Dynamically allocate the buffer used for reading data from the input

[bsd-progress.git] / progress.c

diff --git a/progress.c b/progress.c
index a598ec3632f0d7b7d5c3c82c2824eb80cc5e25f4..5c1eae58294feacee961478146cd710cf2055219 100644 (file)
--- a/progress.c
+++ b/progress.c
@@ -1,4 +1,4 @@
-/*     $NetBSD: progress.c,v 1.12 2006/04/20 23:20:55 hubertf Exp $ */
+/*     $NetBSD: progress.c,v 1.15 2007/06/06 17:49:14 briggs Exp $ */
 
 /*-
  * Copyright (c) 2003 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__RCSID("$NetBSD: progress.c,v 1.12 2006/04/20 23:20:55 hubertf Exp $");
+__RCSID("$NetBSD: progress.c,v 1.15 2007/06/06 17:49:14 briggs Exp $");
 #endif                         /* not lint */
 
 #include <sys/types.h>
@@ -46,12 +46,12 @@ __RCSID("$NetBSD: progress.c,v 1.12 2006/04/20 23:20:55 hubertf Exp $");
 #include <netinet/in.h>
 #include <arpa/ftp.h>
 
-#include <ctype.h>
 #include <err.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <glob.h>
 #include <signal.h>
+#include <inttypes.h>
 #include <limits.h>
 #include <netdb.h>
 #include <stdio.h>
@@ -73,22 +73,24 @@ static void
 usage(void)
 {
        fprintf(stderr,
-           "usage: %s [-ez] [-f file] [-l length] [-p prefix] cmd [args...]\n",
-           getprogname());
-       exit(1);
+           "usage: %s [-ez] [-b buffersize] [-f file] [-l length]\n"
+           "       %*.s [-p prefix] cmd [args...]\n",
+           getprogname(), (int) strlen(getprogname()), "");
+       exit(EXIT_FAILURE);
 }
 
 
 int
 main(int argc, char *argv[])
 {
-       static char fb_buf[BUFSIZ];
+       char *fb_buf;
        char *infile = NULL;
        pid_t pid = 0, gzippid = 0, deadpid;
        int ch, fd, outpipe[2];
        int ws, gzipstat, cmdstat;
        int eflag = 0, lflag = 0, zflag = 0;
        ssize_t nr, nw, off;
+       size_t buffersize;
        struct stat statb;
        struct ttysize ts;
 
@@ -97,10 +99,15 @@ main(int argc, char *argv[])
        /* defaults: Read from stdin, 0 filesize (no completion estimate) */
        fd = STDIN_FILENO;
        filesize = 0;
-       prefix=NULL;
+       buffersize = 64 * 1024;
+       prefix = NULL;
 
-       while ((ch = getopt(argc, argv, "ef:l:p:z")) != -1)
+       while ((ch = getopt(argc, argv, "b:ef:l:p:z")) != -1)
                switch (ch) {
+               case 'b':
+                       buffersize = (size_t) strsuftoll("buffer size", optarg,
+                           0, SIZE_T_MAX);
+                       break;
                case 'e':
                        eflag++;
                        break;
@@ -118,8 +125,8 @@ main(int argc, char *argv[])
                case 'z':
                        zflag++;
                        break;
-               default:
                case '?':
+               default:
                        usage();
                        /* NOTREACHED */
                }
@@ -128,6 +135,7 @@ main(int argc, char *argv[])
 
        if (argc < 1)
                usage();
+
        if (infile && (fd = open(infile, O_RDONLY, 0)) < 0)
                err(1, "%s", infile);
 
@@ -196,11 +204,15 @@ main(int argc, char *argv[])
        progress = 1;
        ttyout = eflag ? stderr : stdout;
 
-       if (ioctl(fileno(ttyout), TIOCGSIZE, &ts) == -1) {
+       if (ioctl(fileno(ttyout), TIOCGSIZE, &ts) == -1)
                ttywidth = 80;
-       } else
+       else
                ttywidth = ts.ts_cols;
 
+       fb_buf = malloc(buffersize);
+       if (fb_buf == NULL)
+               err(1, "malloc for buffersize");
+
        if (pipe(outpipe) < 0)
                err(1, "output pipe");
        pid = fork();
@@ -218,7 +230,7 @@ main(int argc, char *argv[])
        close(outpipe[0]);
 
        progressmeter(-1);
-       while ((nr = read(fd, fb_buf, BUFSIZ)) > 0)
+       while ((nr = read(fd, fb_buf, buffersize)) > 0)
                for (off = 0; nr; nr -= nw, off += nw, bytes += nw)
                        if ((nw = write(outpipe[1], fb_buf + off,
                            (size_t) nr)) < 0)
@@ -254,5 +266,8 @@ main(int argc, char *argv[])
        }
 
        progressmeter(1);
+
+       free(fb_buf);
+
        exit(cmdstat ? cmdstat : gzipstat);
 }