-/* $NetBSD: log.c,v 1.6 1997/10/11 02:01:02 lukem Exp $ */
+/* $NetBSD: log.c,v 1.24 2019/03/19 00:11:34 pgoyette Exp $ */
/*-
* Copyright (c) 1990, 1993
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
- * 3. All advertising materials mentioning features or use of this software
- * must display the following acknowledgement:
- * This product includes software developed by the University of
- * California, Berkeley and its contributors.
- * 4. Neither the name of the University nor the names of its contributors
+ * 3. Neither the name of the University nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
*
#if 0
static char sccsid[] = "@(#)log.c 8.1 (Berkeley) 5/31/93";
#else
-__RCSID("$NetBSD: log.c,v 1.6 1997/10/11 02:01:02 lukem Exp $");
+__RCSID("$NetBSD: log.c,v 1.24 2019/03/19 00:11:34 pgoyette Exp $");
#endif
-#endif not lint
+#endif /* not lint */
+
+#include <sys/types.h>
+#include <sys/utsname.h>
+#include <sys/stat.h> /* for umask(2) */
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <fcntl.h>
+#include <pwd.h>
+#include <err.h>
-#include "include.h"
#include "pathnames.h"
+#include "def.h"
+#include "struct.h"
+#include "extern.h"
+#include "tunable.h"
-int
-compar(va, vb)
- const void *va, *vb;
+static FILE *score_fp;
+
+static int
+compar(const void *va, const void *vb)
{
- SCORE *a, *b;
+ const SCORE *a, *b;
- a = (SCORE *)va;
- b = (SCORE *)vb;
+ a = (const SCORE *)va;
+ b = (const SCORE *)vb;
if (b->planes == a->planes)
return (b->time - a->time);
else
#define MIN(t) (((t) % SECAHOUR) / SECAMIN)
#define SEC(t) ((t) % SECAMIN)
-char *
-timestr(t)
- int t;
+static const char *
+timestr(int t)
{
static char s[80];
if (DAY(t) > 0)
- (void)sprintf(s, "%dd+%02dhrs", DAY(t), HOUR(t));
+ (void)snprintf(s, sizeof(s), "%dd+%02dhrs", DAY(t), HOUR(t));
else if (HOUR(t) > 0)
- (void)sprintf(s, "%d:%02d:%02d", HOUR(t), MIN(t), SEC(t));
+ (void)snprintf(s, sizeof(s), "%d:%02d:%02d", HOUR(t), MIN(t),
+ SEC(t));
else if (MIN(t) > 0)
- (void)sprintf(s, "%d:%02d", MIN(t), SEC(t));
+ (void)snprintf(s, sizeof(s), "%d:%02d", MIN(t), SEC(t));
else if (SEC(t) > 0)
- (void)sprintf(s, ":%02d", SEC(t));
+ (void)snprintf(s, sizeof(s), ":%02d", SEC(t));
else
*s = '\0';
return (s);
}
-int
-log_score(list_em)
- int list_em;
+void
+open_score_file(void)
{
- int i, fd, num_scores = 0, good, changed = 0, found = 0;
- struct passwd *pw;
- FILE *fp;
- char *cp;
- SCORE score[100], thisscore;
- struct utsname name;
+ mode_t old_mask;
+ int score_fd;
+ int flags;
- umask(0);
- fd = open(_PATH_SCORE, O_CREAT|O_RDWR, 0644);
- if (fd < 0) {
+ old_mask = umask(0);
+#if defined(O_NOFOLLOW)
+ score_fd = open(_PATH_SCORE, O_CREAT|O_RDWR|O_NOFOLLOW, 0664);
+#else
+ score_fd = open(_PATH_SCORE, O_CREAT|O_RDWR, 0664);
+#endif
+ (void)umask(old_mask);
+ if (score_fd < 0) {
warn("open %s", _PATH_SCORE);
- return (-1);
+ return;
}
+ if (score_fd < 3)
+ exit(1);
+ /* Set the close-on-exec flag. If this fails for any reason, quit
+ * rather than leave the score file open to tampering. */
+ flags = fcntl(score_fd, F_GETFD);
+ if (flags < 0)
+ err(1, "fcntl F_GETFD");
+ flags |= FD_CLOEXEC;
+ if (fcntl(score_fd, F_SETFD, flags) == -1)
+ err(1, "fcntl F_SETFD");
/*
* This is done to take advantage of stdio, while still
* allowing a O_CREAT during the open(2) of the log file.
*/
- fp = fdopen(fd, "r+");
- if (fp == NULL) {
+ score_fp = fdopen(score_fd, "r+");
+ if (score_fp == NULL) {
warn("fdopen %s", _PATH_SCORE);
+ return;
+ }
+}
+
+int
+log_score(int list_em)
+{
+ int i, num_scores = 0, good, changed = 0, found = 0;
+ struct passwd *pw;
+ char *cp;
+ SCORE score[100], thisscore;
+ struct utsname lname;
+ long offset;
+
+ if (safe_planes == 1)
+ printf("You directed 1 plane safely to its destination.\n\n");
+ else
+ printf("You directed %d planes safely to their destinations.\n\n",
+ safe_planes);
+
+ if (score_fp == NULL) {
+ warnx("no score file available");
return (-1);
}
+
#ifdef BSD
- if (flock(fileno(fp), LOCK_EX) < 0)
+ if (flock(fileno(score_fp), LOCK_EX) < 0)
#endif
#ifdef SYSV
- while (lockf(fileno(fp), F_LOCK, 1) < 0)
+ if (lockf(fileno(score_fp), F_LOCK, 1) < 0)
#endif
{
warn("flock %s", _PATH_SCORE);
return (-1);
}
for (;;) {
- good = fscanf(fp, "%s %s %s %d %d %d",
- score[num_scores].name,
- score[num_scores].host,
- score[num_scores].game,
- &score[num_scores].planes,
- &score[num_scores].time,
- &score[num_scores].real_time);
+ good = fscanf(score_fp, SCORE_SCANF_FMT,
+ score[num_scores].name,
+ score[num_scores].host,
+ score[num_scores].game,
+ &score[num_scores].planes,
+ &score[num_scores].time,
+ &score[num_scores].real_time);
if (good != 6 || ++num_scores >= NUM_SCORES)
break;
}
if (!test_mode && !list_em) {
if ((pw = (struct passwd *) getpwuid(getuid())) == NULL) {
- fprintf(stderr,
+ (void)fprintf(stderr,
"getpwuid failed for uid %d. Who are you?\n",
- getuid());
+ (int)getuid());
return (-1);
}
- strcpy(thisscore.name, pw->pw_name);
- uname(&name);
- strncpy(thisscore.host, name.sysname, sizeof(thisscore.host)-1);
- thisscore.host[sizeof(thisscore.host) - 1] = '\0';
+ (void)strlcpy(thisscore.name, pw->pw_name, SCORE_NAME_LEN);
+ (void)uname(&lname);
+ (void)strlcpy(thisscore.host, lname.nodename,
+ sizeof(thisscore.host));
- cp = strrchr(file, '/');
+ cp = strrchr(filename, '/');
if (cp == NULL) {
- fprintf(stderr, "log: where's the '/' in %s?\n", file);
+ (void)fprintf(stderr, "log: where's the '/' in %s?\n",
+ filename);
return (-1);
}
cp++;
- strcpy(thisscore.game, cp);
+ (void)strlcpy(thisscore.game, cp, SCORE_GAME_LEN);
thisscore.time = clck;
thisscore.planes = safe_planes;
score[i].time = thisscore.time;
score[i].planes = thisscore.planes;
score[i].real_time =
- thisscore.real_time;
+ thisscore.real_time;
changed++;
}
found++;
if (thisscore.time > score[i].time) {
if (num_scores < NUM_SCORES)
num_scores++;
- memcpy(&score[num_scores - 1],
- &score[i],
- sizeof (score[i]));
- memcpy(&score[i], &thisscore,
- sizeof (score[i]));
+ (void)memcpy(&score[num_scores - 1],
+ &score[i], sizeof (score[i]));
+ (void)memcpy(&score[i], &thisscore,
+ sizeof (score[i]));
changed++;
break;
}
}
}
if (!found && !changed && num_scores < NUM_SCORES) {
- memcpy(&score[num_scores], &thisscore,
- sizeof (score[num_scores]));
+ (void)memcpy(&score[num_scores], &thisscore,
+ sizeof (score[num_scores]));
num_scores++;
changed++;
}
if (changed) {
if (found)
- puts("You beat your previous score!");
+ (void)puts("You beat your previous score!");
else
- puts("You made the top players list!");
- qsort(score, num_scores, sizeof (*score), compar);
- rewind(fp);
+ (void)puts("You made the top players list!");
+ qsort(score, (size_t)num_scores, sizeof (*score),
+ compar);
+ rewind(score_fp);
for (i = 0; i < num_scores; i++)
- fprintf(fp, "%s %s %s %d %d %d\n",
- score[i].name, score[i].host,
- score[i].game, score[i].planes,
- score[i].time, score[i].real_time);
+ (void)fprintf(score_fp, "%s %s %s %d %d %d\n",
+ score[i].name, score[i].host,
+ score[i].game, score[i].planes,
+ score[i].time, score[i].real_time);
+ (void)fflush(score_fp);
+ if (ferror(score_fp))
+ warn("error writing %s", _PATH_SCORE);
+ /* It is just possible that updating an entry could
+ * have reduced the length of the file, so we
+ * truncate it. The seeks are required for stream/fd
+ * synchronisation by POSIX.1. */
+ offset = ftell(score_fp);
+ (void)lseek(fileno(score_fp), (off_t)0, SEEK_SET);
+ (void)ftruncate(fileno(score_fp), (off_t)offset);
+ rewind(score_fp);
} else {
if (found)
- puts("You didn't beat your previous score.");
+ (void)puts(
+ "You didn't beat your previous score.");
else
- puts("You didn't make the top players list.");
+ (void)puts(
+ "You didn't make the top players list.");
}
- putchar('\n');
+ (void)putchar('\n');
}
#ifdef BSD
- flock(fileno(fp), LOCK_UN);
+ (void)flock(fileno(score_fp), LOCK_UN);
#endif
#ifdef SYSV
/* lock will evaporate upon close */
#endif
- fclose(fp);
- printf("%2s: %-8s %-8s %-18s %4s %9s %4s\n", "#", "name", "host",
- "game", "time", "real time", "planes safe");
- puts("-------------------------------------------------------------------------------");
+ (void)fclose(score_fp);
+ (void)printf("%2s: %-8s %-8s %-18s %4s %9s %4s\n", "#", "name",
+ "host", "game", "time", "real time", "planes safe");
+ (void)printf("-------------------------------------------------------");
+ (void)printf("-------------------------\n");
for (i = 0; i < num_scores; i++) {
cp = strchr(score[i].host, '.');
if (cp != NULL)
*cp = '\0';
- printf("%2d: %-8s %-8s %-18s %4d %9s %4d\n", i + 1,
- score[i].name, score[i].host, score[i].game,
- score[i].time, timestr(score[i].real_time),
- score[i].planes);
+ (void)printf("%2d: %-8s %-8s %-18s %4d %9s %4d\n", i + 1,
+ score[i].name, score[i].host, score[i].game,
+ score[i].time, timestr(score[i].real_time),
+ score[i].planes);
}
- putchar('\n');
+ (void)putchar('\n');
return (0);
}
+/* ARGSUSED */
void
-log_score_quit(dummy)
- int dummy;
+log_score_quit(int dummy __unused)
{
(void)log_score(0);
exit(0);
git.ckatri.com / bsdgames-darwin.git / blobdiff