From 71a4bdd386813a0bd96c205cf36b3faf3b1ea0e1 Mon Sep 17 00:00:00 2001 From: nia Date: Tue, 21 Jul 2020 03:05:40 +0000 Subject: fortune: arc4random_uniform for better uniform values than random() % ... --- fortune/strfile/strfile.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'fortune/strfile/strfile.c') diff --git a/fortune/strfile/strfile.c b/fortune/strfile/strfile.c index 891c77dd..29298955 100644 --- a/fortune/strfile/strfile.c +++ b/fortune/strfile/strfile.c @@ -1,4 +1,4 @@ -/* $NetBSD: strfile.c,v 1.40 2020/04/30 12:32:26 christos Exp $ */ +/* $NetBSD: strfile.c,v 1.41 2020/07/21 03:05:40 nia Exp $ */ /*- * Copyright (c) 1989, 1993 @@ -47,7 +47,7 @@ __COPYRIGHT("@(#) Copyright (c) 1989, 1993\ #if 0 static char sccsid[] = "@(#)strfile.c 8.1 (Berkeley) 5/31/93"; #else -__RCSID("$NetBSD: strfile.c,v 1.40 2020/04/30 12:32:26 christos Exp $"); +__RCSID("$NetBSD: strfile.c,v 1.41 2020/07/21 03:05:40 nia Exp $"); #endif #endif /* not lint */ #endif /* __NetBSD__ */ @@ -438,8 +438,6 @@ randomize(void) off_t tmp; off_t *sp; - srandom((int)(time(NULL) + getpid())); - Tbl.str_flags |= STR_RANDOM; cnt = Tbl.str_numstr; @@ -448,7 +446,7 @@ randomize(void) */ for (sp = Seekpts; cnt > 0; cnt--, sp++) { - i = random() % cnt; + i = arc4random_uniform(cnt); tmp = sp[0]; sp[0] = sp[i]; sp[i] = tmp; -- cgit v1.2.3