From c2765d33e91be2ea6d9a7dd12d8ea24ff4c62654 Mon Sep 17 00:00:00 2001 From: dholland Date: Sun, 23 Mar 2014 00:17:40 +0000 Subject: Add note cautioning against bothering with WARNS=6 until gcc improves (or -Wconversion is removed from WARNS=6) as it produces loads of false positives. The most entertaining of these that I've seen this afternoon: games/hack/hack.apply.c:143:22: error: conversion to 'unsigned char:1' from 'int' may alter its value [-Werror=conversion] flags.move = multi = 0; ^ --- Makefile.inc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'Makefile.inc') diff --git a/Makefile.inc b/Makefile.inc index 5566c295..48090e05 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -1,4 +1,4 @@ -# $NetBSD: Makefile.inc,v 1.15 2012/06/19 05:46:08 dholland Exp $ +# $NetBSD: Makefile.inc,v 1.16 2014/03/23 00:17:40 dholland Exp $ # @(#)Makefile.inc 8.1 (Berkeley) 5/31/93 MKHIDEGAME?= no @@ -20,4 +20,7 @@ BINGRP= games BINMODE= 2555 .endif .endif +# Note: do not bother with WARNS=6 until -Wconversion is either +# removed from WARNS=6 or rendered useful by improving gcc; as it is +# (with gcc48) it produces buckets of drivel. WARNS?= 5 -- cgit v1.2.3-56-ge451