From f01282b66ee470388fbdfd0bfd5631060888d063 Mon Sep 17 00:00:00 2001
From: jnemeth <jnemeth@NetBSD.org>
Date: Wed, 29 Mar 2006 01:19:51 +0000
Subject: Fix Coverity issues 2366 and 2365 -- REVERSE_INULL. Approved by
 Christos@.

---
 hack/hack.invent.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

(limited to 'hack')

diff --git a/hack/hack.invent.c b/hack/hack.invent.c
index c33d502b..6bc8a173 100644
--- a/hack/hack.invent.c
+++ b/hack/hack.invent.c
@@ -1,4 +1,4 @@
-/*	$NetBSD: hack.invent.c,v 1.9 2004/01/27 20:30:29 jsm Exp $	*/
+/*	$NetBSD: hack.invent.c,v 1.10 2006/03/29 01:19:51 jnemeth Exp $	*/
 
 /*
  * Copyright (c) 1985, Stichting Centrum voor Wiskunde en Informatica,
@@ -63,7 +63,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__RCSID("$NetBSD: hack.invent.c,v 1.9 2004/01/27 20:30:29 jsm Exp $");
+__RCSID("$NetBSD: hack.invent.c,v 1.10 2006/03/29 01:19:51 jnemeth Exp $");
 #endif				/* not lint */
 
 #include <stdlib.h>
@@ -214,9 +214,12 @@ freeobj(obj)
 	if (obj == fobj)
 		fobj = fobj->nobj;
 	else {
-		for (otmp = fobj; otmp->nobj != obj; otmp = otmp->nobj)
-			if (!otmp)
+		otmp = fobj;
+		while (otmp->nobj != obj) {
+			if (otmp->nobj == NULL)
 				panic("error in freeobj");
+			otmp = otmp->nobj;
+		}
 		otmp->nobj = obj->nobj;
 	}
 }
@@ -231,9 +234,12 @@ freegold(gold)
 	if (gold == fgold)
 		fgold = gold->ngold;
 	else {
-		for (gtmp = fgold; gtmp->ngold != gold; gtmp = gtmp->ngold)
-			if (!gtmp)
+		gtmp = fgold;
+		while (gtmp->ngold != gold) {
+			if (gtmp->ngold == NULL)
 				panic("error in freegold");
+			gtmp = gtmp->ngold;
+		}
 		gtmp->ngold = gold->ngold;
 	}
 	free((char *) gold);
-- 
cgit v1.2.3-56-ge451