From 4ddaf6127ab2fdcf268b76c9a33cb08bc276bfbf Mon Sep 17 00:00:00 2001 From: dholland Date: Sun, 30 Mar 2014 05:30:28 +0000 Subject: Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead. Fix two semi-compensating size bugs in wire transmission affecting 64-bit machines. --- hunt/hunt/connect.c | 20 +++++++++++--------- hunt/hunt/hunt.c | 30 +++++++++++++++--------------- hunt/hunt/hunt_private.h | 4 ++-- hunt/hunt/playit.c | 12 ++++++++---- 4 files changed, 36 insertions(+), 30 deletions(-) (limited to 'hunt/hunt') diff --git a/hunt/hunt/connect.c b/hunt/hunt/connect.c index 71729c02..4c2e2f7e 100644 --- a/hunt/hunt/connect.c +++ b/hunt/hunt/connect.c @@ -1,4 +1,4 @@ -/* $NetBSD: connect.c,v 1.10 2014/03/30 05:14:47 dholland Exp $ */ +/* $NetBSD: connect.c,v 1.11 2014/03/30 05:30:28 dholland Exp $ */ /* * Copyright (c) 1983-2003, Regents of the University of California. * All rights reserved. @@ -32,31 +32,33 @@ #include #ifndef lint -__RCSID("$NetBSD: connect.c,v 1.10 2014/03/30 05:14:47 dholland Exp $"); +__RCSID("$NetBSD: connect.c,v 1.11 2014/03/30 05:30:28 dholland Exp $"); #endif /* not lint */ #include #include #include +#include #include "hunt_common.h" #include "hunt_private.h" void -do_connect(char *name, char team, long enter_status) +do_connect(const char *name, size_t namelen, char team, int enter_status) { static int32_t uid; - static int32_t mode; + int32_t mode; + int32_t wire_status = htonl(enter_status); if (uid == 0) uid = htonl(getuid()); - (void) write(huntsocket, &uid, LONGLEN); - (void) write(huntsocket, name, NAMELEN); + (void) write(huntsocket, &uid, sizeof(uid)); + assert(namelen == WIRE_NAMELEN); + (void) write(huntsocket, name, namelen); (void) write(huntsocket, &team, 1); - enter_status = htonl(enter_status); - (void) write(huntsocket, &enter_status, LONGLEN); + (void) write(huntsocket, &wire_status, sizeof(wire_status)); (void) strcpy(Buf, ttyname(fileno(stderr))); - (void) write(huntsocket, Buf, NAMELEN); + (void) write(huntsocket, Buf, WIRE_NAMELEN); #ifdef INTERNET if (Send_message != NULL) mode = C_MESSAGE; diff --git a/hunt/hunt/hunt.c b/hunt/hunt/hunt.c index 4621543b..9396d3f4 100644 --- a/hunt/hunt/hunt.c +++ b/hunt/hunt/hunt.c @@ -1,4 +1,4 @@ -/* $NetBSD: hunt.c,v 1.54 2014/03/30 05:14:47 dholland Exp $ */ +/* $NetBSD: hunt.c,v 1.55 2014/03/30 05:30:28 dholland Exp $ */ /* * Copyright (c) 1983-2003, Regents of the University of California. * All rights reserved. @@ -32,7 +32,7 @@ #include #ifndef lint -__RCSID("$NetBSD: hunt.c,v 1.54 2014/03/30 05:14:47 dholland Exp $"); +__RCSID("$NetBSD: hunt.c,v 1.55 2014/03/30 05:30:28 dholland Exp $"); #endif /* not lint */ #include @@ -94,7 +94,7 @@ SOCKET Daemon; char map_key[256]; /* what to map keys to */ bool no_beep; -static char name[NAMELEN]; +static char name[WIRE_NAMELEN]; static char team = ' '; static int in_visual; @@ -102,7 +102,7 @@ static int in_visual; extern int cur_row, cur_col; static void dump_scores(const struct sockaddr_storage *, socklen_t); -static long env_init(long); +static int env_init(int); static void fill_in_blanks(void); static void fincurs(void); static void rmnl(char *); @@ -138,16 +138,16 @@ main(int ac, char **av) { char *term; int c; - long enter_status; + int enter_status; bool Query_driver = false; bool Show_scores = false; - enter_status = env_init((long) Q_CLOAK); + enter_status = env_init(Q_CLOAK); while ((c = getopt(ac, av, "Sbcfh:l:mn:op:qst:w:")) != -1) { switch (c) { case 'l': /* rsh compatibility */ case 'n': - (void) strncpy(name, optarg, NAMELEN); + (void) strncpy(name, optarg, sizeof(name)); break; case 't': team = *optarg; @@ -268,7 +268,7 @@ main(int ac, char **av) #endif #ifdef OTTO if (Otto_mode) - (void) strncpy(name, "otto", NAMELEN); + (void) strncpy(name, "otto", sizeof(name)); else #endif fill_in_blanks(); @@ -350,7 +350,7 @@ main(int ac, char **av) } #endif - do_connect(name, team, enter_status); + do_connect(name, sizeof(name), team, enter_status); #ifdef INTERNET if (Send_message != NULL) { do_message(); @@ -658,8 +658,8 @@ leavex(int exitval, const char *fmt, ...) va_end(ap); } -static long -env_init(long enter_status) +static int +env_init(int enter_status) { int i; char *envp, *envname, *s; @@ -690,11 +690,11 @@ env_init(long enter_status) envname = s + 1; if ((s = strchr(envp, ',')) == NULL) { *envp = '\0'; - strncpy(name, envname, NAMELEN); + strncpy(name, envname, sizeof(name)); break; } *s = '\0'; - strncpy(name, envname, NAMELEN); + strncpy(name, envname, sizeof(name)); envp = s + 1; } #ifdef INTERNET @@ -759,7 +759,7 @@ env_init(long enter_status) } if (*envp != '\0') { if (envname == NULL) - strncpy(name, envp, NAMELEN); + strncpy(name, envp, sizeof(name)); else printf("unknown option %s\n", envp); } @@ -782,7 +782,7 @@ again: putchar('\n'); } else { printf("Enter your code name: "); - if (fgets(name, NAMELEN, stdin) == NULL) + if (fgets(name, sizeof(name), stdin) == NULL) exit(1); } rmnl(name); diff --git a/hunt/hunt/hunt_private.h b/hunt/hunt/hunt_private.h index 65c15e0e..f4402b57 100644 --- a/hunt/hunt/hunt_private.h +++ b/hunt/hunt/hunt_private.h @@ -1,4 +1,4 @@ -/* $NetBSD: hunt_private.h,v 1.8 2014/03/30 05:14:47 dholland Exp $ */ +/* $NetBSD: hunt_private.h,v 1.9 2014/03/30 05:30:28 dholland Exp $ */ /* * Copyright (c) 1983-2003, Regents of the University of California. @@ -73,7 +73,7 @@ extern SOCKET Daemon; */ /* in connect.c */ -void do_connect(char *, char, long); +void do_connect(const char *, size_t, char, int32_t); /* in hunt.c */ __dead void bad_con(void); diff --git a/hunt/hunt/playit.c b/hunt/hunt/playit.c index 16978bfa..63da5658 100644 --- a/hunt/hunt/playit.c +++ b/hunt/hunt/playit.c @@ -1,4 +1,4 @@ -/* $NetBSD: playit.c,v 1.20 2014/03/30 05:14:47 dholland Exp $ */ +/* $NetBSD: playit.c,v 1.21 2014/03/30 05:30:28 dholland Exp $ */ /* * Copyright (c) 1983-2003, Regents of the University of California. * All rights reserved. @@ -32,7 +32,7 @@ #include #ifndef lint -__RCSID("$NetBSD: playit.c,v 1.20 2014/03/30 05:14:47 dholland Exp $"); +__RCSID("$NetBSD: playit.c,v 1.21 2014/03/30 05:30:28 dholland Exp $"); #endif /* not lint */ #include @@ -93,8 +93,10 @@ playit(void) int ch; int y, x; uint32_t version; + ssize_t result; - if (read(huntsocket, &version, LONGLEN) != LONGLEN) { + result = read(huntsocket, &version, sizeof(version)); + if (result != (ssize_t)sizeof(version)) { bad_con(); /* NOTREACHED */ } @@ -435,8 +437,10 @@ void do_message(void) { uint32_t version; + ssize_t result; - if (read(huntsocket, &version, LONGLEN) != LONGLEN) { + result = read(huntsocket, &version, sizeof(version)); + if (result != (ssize_t)sizeof(version)) { bad_con(); /* NOTREACHED */ } -- cgit v1.2.3-56-ge451