]> git.cameronkatri.com Git - cgit.git/commit
configfile: fix EOF handling
authorJohn Keeping <john@keeping.me.uk>
Sun, 7 Aug 2016 14:54:14 +0000 (15:54 +0100)
committerJohn Keeping <john@keeping.me.uk>
Sat, 1 Oct 2016 10:43:33 +0000 (11:43 +0100)
commit35df710a1fa21b62c5328e2c98f29a68a0312a25
treedb984e301d72179483d6173138f2323b02b98967
parent11695a58fd732689be486edf88d145578a787c89
configfile: fix EOF handling

Currently we can end up passing EOF to isspace(), which is in fact
libgit's sane_isspace which does:

((sane_ctype[(unsigned char)(x)] & (GIT_SPACE)) != 0)

It is very unlikely that EOF cast to "unsigned char" will end up in a
character that has the GIT_SPACE bit set, but the standard only requires
that EOF be a negative integer, so it could access any value in the
sane_ctype array.

If it does end up returning true for isspace() then this loop will never
terminate, so handle EOF as a special value in the same way as the other
loops in this function.

Signed-off-by: John Keeping <john@keeping.me.uk>
configfile.c