Mark several functions/variables static

[cgit.git] / parsing.c

diff --git a/parsing.c b/parsing.c
index c9e43509242d1d3a4e6faf85da7ce46375659ab3..658621d8e76b74336eb8827b3354d59ec9d35320 100644 (file)
--- a/parsing.c
+++ b/parsing.c
@@ -52,17 +52,19 @@ void cgit_parse_url(const char *url)
        }
 }
 
-char *substr(const char *head, const char *tail)
+static char *substr(const char *head, const char *tail)
 {
        char *buf;
 
+       if (tail < head)
+               return xstrdup("");
        buf = xmalloc(tail - head + 1);
        strncpy(buf, head, tail - head);
        buf[tail - head] = '\0';
        return buf;
 }
 
-char *parse_user(char *t, char **name, char **email, unsigned long *date)
+static char *parse_user(char *t, char **name, char **email, unsigned long *date)
 {
        char *p = t;
        int mode = 1;
@@ -99,15 +101,18 @@ char *parse_user(char *t, char **name, char **email, unsigned long *date)
 #ifdef NO_ICONV
 #define reencode(a, b, c)
 #else
-const char *reencode(char **txt, const char *src_enc, const char *dst_enc)
+static const char *reencode(char **txt, const char *src_enc, const char *dst_enc)
 {
        char *tmp;
 
-       if (!txt || !*txt || !src_enc || !dst_enc)
+       if (!txt)
+               return NULL;
+
+       if (!*txt || !src_enc || !dst_enc)
                return *txt;
 
        /* no encoding needed if src_enc equals dst_enc */
-       if(!strcasecmp(src_enc, dst_enc))
+       if (!strcasecmp(src_enc, dst_enc))
                return *txt;
 
        tmp = reencode_string(*txt, dst_enc, src_enc);
@@ -122,7 +127,7 @@ const char *reencode(char **txt, const char *src_enc, const char *dst_enc)
 struct commitinfo *cgit_parse_commit(struct commit *commit)
 {
        struct commitinfo *ret;
-       char *p = commit->buffer, *t = commit->buffer;
+       char *p = commit->buffer, *t;
 
        ret = xmalloc(sizeof(*ret));
        ret->commit = commit;
@@ -165,7 +170,7 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
        }
 
        /* if no special encoding is found, assume UTF-8 */
-       if(!ret->msg_encoding)
+       if (!ret->msg_encoding)
                ret->msg_encoding = xstrdup("UTF-8");
 
        // skip unknown header fields