Always #include corresponding .h in .c files

[cgit.git] / ui-snapshot.c

diff --git a/ui-snapshot.c b/ui-snapshot.c
index 07cc944525c53096b5c429f25fd2b29c68eaa28f..9be5dbef808526b3b0dd9d518163b206ead37b9f 100644 (file)
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
@@ -1,43 +1,71 @@
 /* ui-snapshot.c: generate snapshot of a commit
  *
  * Copyright (C) 2006 Lars Hjemli
+ * Copyright (C) 2012 Jason A. Donenfeld <Jason@zx2c4.com>
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"
+#include "ui-snapshot.h"
 #include "html.h"
 #include "ui-shared.h"
 
-static int write_compressed_tar_archive(struct archiver_args *args,const char *filter)
+static int write_archive_type(const char *format, const char *hex, const char *prefix)
+{
+       struct argv_array argv = ARGV_ARRAY_INIT;
+       argv_array_push(&argv, "snapshot");
+       argv_array_push(&argv, format);
+       if (prefix) {
+               argv_array_push(&argv, "--prefix");
+               argv_array_push(&argv, fmt("%s/", prefix));
+       }
+       argv_array_push(&argv, hex);
+       return write_archive(argv.argc, argv.argv, NULL, 1, NULL, 0);
+}
+
+static int write_tar_archive(const char *hex, const char *prefix)
+{
+       return write_archive_type("--format=tar", hex, prefix);
+}
+
+static int write_zip_archive(const char *hex, const char *prefix)
+{
+       return write_archive_type("--format=zip", hex, prefix);
+}
+
+static int write_compressed_tar_archive(const char *hex,
+                                       const char *prefix,
+                                       char *filter_argv[])
 {
        int rv;
        struct cgit_filter f;
 
-       f.cmd = xstrdup(filter);
-       f.argv = malloc(2 * sizeof(char *));
-       f.argv[0] = f.cmd;
-       f.argv[1] = NULL;
+       f.cmd = filter_argv[0];
+       f.argv = filter_argv;
        cgit_open_filter(&f);
-       rv = write_tar_archive(args);
+       rv = write_tar_archive(hex, prefix);
        cgit_close_filter(&f);
        return rv;
 }
 
-static int write_tar_gzip_archive(struct archiver_args *args)
+static int write_tar_gzip_archive(const char *hex, const char *prefix)
 {
-       return write_compressed_tar_archive(args,"gzip");
+       char *argv[] = { "gzip", "-n", NULL };
+       return write_compressed_tar_archive(hex, prefix, argv);
 }
 
-static int write_tar_bzip2_archive(struct archiver_args *args)
+static int write_tar_bzip2_archive(const char *hex, const char *prefix)
 {
-       return write_compressed_tar_archive(args,"bzip2");
+       char *argv[] = { "bzip2", NULL };
+       return write_compressed_tar_archive(hex, prefix, argv);
 }
 
-static int write_tar_xz_archive(struct archiver_args *args)
+static int write_tar_xz_archive(const char *hex, const char *prefix)
 {
-       return write_compressed_tar_archive(args,"xz");
+       char *argv[] = { "xz", NULL };
+       return write_compressed_tar_archive(hex, prefix, argv);
 }
 
 const struct cgit_snapshot_format cgit_snapshot_formats[] = {
@@ -46,7 +74,7 @@ const struct cgit_snapshot_format cgit_snapshot_formats[] = {
        { ".tar.bz2", "application/x-bzip2", write_tar_bzip2_archive, 0x04 },
        { ".tar", "application/x-tar", write_tar_archive, 0x08 },
        { ".tar.xz", "application/x-xz", write_tar_xz_archive, 0x10 },
-       {}
+       { NULL }
 };
 
 static const struct cgit_snapshot_format *get_format(const char *filename)
@@ -55,7 +83,7 @@ static const struct cgit_snapshot_format *get_format(const char *filename)
        int fl, sl;
 
        fl = strlen(filename);
-       for(fmt = cgit_snapshot_formats; fmt->suffix; fmt++) {
+       for (fmt = cgit_snapshot_formats; fmt->suffix; fmt++) {
                sl = strlen(fmt->suffix);
                if (sl >= fl)
                        continue;
@@ -69,34 +97,20 @@ static int make_snapshot(const struct cgit_snapshot_format *format,
                         const char *hex, const char *prefix,
                         const char *filename)
 {
-       struct archiver_args args;
-       struct commit *commit;
        unsigned char sha1[20];
 
-       if(get_sha1(hex, sha1)) {
+       if (get_sha1(hex, sha1)) {
                cgit_print_error(fmt("Bad object id: %s", hex));
                return 1;
        }
-       commit = lookup_commit_reference(sha1);
-       if(!commit) {
+       if (!lookup_commit_reference(sha1)) {
                cgit_print_error(fmt("Not a commit reference: %s", hex));
                return 1;
        }
-       memset(&args, 0, sizeof(args));
-       if (prefix) {
-               args.base = fmt("%s/", prefix);
-               args.baselen = strlen(prefix) + 1;
-       } else {
-               args.base = "";
-               args.baselen = 0;
-       }
-       args.tree = commit->tree;
-       args.time = commit->date;
-       args.compression_level = Z_DEFAULT_COMPRESSION;
        ctx.page.mimetype = xstrdup(format->mimetype);
        ctx.page.filename = xstrdup(filename);
        cgit_print_http_headers(&ctx);
-       format->write_func(&args);
+       format->write_func(hex, prefix);
        return 0;
 }
 
@@ -140,7 +154,7 @@ static const char *get_ref_from_filename(const char *url, const char *filename,
        return NULL;
 }
 
-void show_error(char *msg)
+static void show_error(char *msg)
 {
        ctx.page.mimetype = "text/html";
        cgit_print_http_headers(&ctx);