Drop return value from parse_user()

[cgit.git] / ui-refs.c

diff --git a/ui-refs.c b/ui-refs.c
index 20c91e3c2401d7da4d6fa3c634623ef60f71e5fe..ac8a6d446e14765afabfcffe0f41f6fb32256b68 100644 (file)
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -11,18 +11,10 @@
 #include "html.h"
 #include "ui-shared.h"
 
-static int cmp_age(int age1, int age2)
+static inline int cmp_age(int age1, int age2)
 {
-       if (age1 != 0 && age2 != 0)
-               return age2 - age1;
-
-       if (age1 == 0 && age2 == 0)
-               return 0;
-
-       if (age1 == 0)
-               return +1;
-
-       return -1;
+       /* age1 and age2 are assumed to be non-negative */
+       return age2 - age1;
 }
 
 static int cmp_ref_name(const void *a, const void *b)
@@ -75,9 +67,11 @@ static int print_branch(struct refinfo *ref)
        html("</td><td>");
 
        if (ref->object->type == OBJ_COMMIT) {
-               cgit_commit_link(info->subject, NULL, NULL, name, NULL, NULL, 0);
+               cgit_commit_link(info->subject, NULL, NULL, name, NULL, NULL);
                html("</td><td>");
+               cgit_open_filter(ctx.repo->email_filter, info->author_email, "refs");
                html_txt(info->author);
+               cgit_close_filter(ctx.repo->email_filter);
                html("</td><td colspan='2'>");
                cgit_print_age(info->commit->date, -1, NULL);
        } else {
@@ -103,11 +97,11 @@ static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
        const char *basename;
        int free_ref = 0;
 
-       if (!ref || strlen(ref) < 2)
+       if (!ref || strlen(ref) < 1)
                return;
 
        basename = cgit_repobasename(repo->url);
-       if (prefixcmp(ref, basename) != 0) {
+       if (!starts_with(ref, basename)) {
                if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1]))
                        ref++;
                if (isdigit(ref[0])) {
@@ -146,7 +140,7 @@ static int print_tag(struct refinfo *ref)
        }
 
        html("<tr><td>");
-       cgit_tag_link(name, NULL, NULL, ctx.qry.head, name);
+       cgit_tag_link(name, NULL, NULL, name);
        html("</td><td>");
        if (ctx.repo->snapshots && (obj->type == OBJ_COMMIT))
                print_tag_downloads(ctx.repo, name);
@@ -154,10 +148,15 @@ static int print_tag(struct refinfo *ref)
                cgit_object_link(obj);
        html("</td><td>");
        if (info) {
-               if (info->tagger)
-                       html(info->tagger);
+               if (info->tagger) {
+                       cgit_open_filter(ctx.repo->email_filter, info->tagger_email, "refs");
+                       html_txt(info->tagger);
+                       cgit_close_filter(ctx.repo->email_filter);
+               }
        } else if (ref->object->type == OBJ_COMMIT) {
-               html(ref->commit->author);
+               cgit_open_filter(ctx.repo->email_filter, ref->commit->author_email, "refs");
+               html_txt(ref->commit->author);
+               cgit_close_filter(ctx.repo->email_filter);
        }
        html("</td><td colspan='2'>");
        if (info) {
@@ -240,9 +239,9 @@ void cgit_print_refs()
 
        html("<table class='list nowrap'>");
 
-       if (ctx.qry.path && !prefixcmp(ctx.qry.path, "heads"))
+       if (ctx.qry.path && starts_with(ctx.qry.path, "heads"))
                cgit_print_branches(0);
-       else if (ctx.qry.path && !prefixcmp(ctx.qry.path, "tags"))
+       else if (ctx.qry.path && starts_with(ctx.qry.path, "tags"))
                cgit_print_tags(0);
        else {
                cgit_print_branches(0);