Handle single-line and empty commit subjects

[cgit.git] / ui-summary.c

diff --git a/ui-summary.c b/ui-summary.c
index 3410e1acff9ed4b155865ce3ea7fbc9221af00c1..15e8aec9b6460ac98e6ea6386dfd718583863d0a 100644 (file)
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -28,12 +28,12 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1,
                html_txt(buf);
                html_link_close();
                html("</td><td>");
-               cgit_print_date(commit->date);
+               cgit_print_age(commit->date, -1, NULL);
                html("</td><td>");
                html_txt(info->author);
                html("</td><td>");
                url = cgit_pageurl(cgit_query_repo, "commit",
-                                  fmt("id=%s", sha1_to_hex(sha1)));
+                                  fmt("h=%s", sha1_to_hex(sha1)));
                html_link_open(url, NULL, NULL);
                html_ntxt(cgit_max_msg_len, info->subject);
                html_link_close();
@@ -52,17 +52,21 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1,
 
 static void cgit_print_object_ref(struct object *obj)
 {
-       char *page, *url;
+       char *page, *arg, *url;
 
-       if (obj->type == OBJ_COMMIT)
+       if (obj->type == OBJ_COMMIT) {
                page = "commit";
-       else if (obj->type == OBJ_TREE)
+               arg = "h";
+       } else if (obj->type == OBJ_TREE) {
                page = "tree";
-       else
+               arg = "id";
+       } else {
                page = "view";
+               arg = "id";
+       }
 
        url = cgit_pageurl(cgit_query_repo, page,
-                          fmt("id=%s", sha1_to_hex(obj->sha1)));
+                          fmt("%s=%s", arg, sha1_to_hex(obj->sha1)));
        html_link_open(url, NULL, NULL);
        htmlf("%s %s", typename(obj->type),
              sha1_to_hex(obj->sha1));
@@ -72,7 +76,7 @@ static void cgit_print_object_ref(struct object *obj)
 static void print_tag_header()
 {
        html("<tr class='nohover'><th class='left'>Tag</th>"
-            "<th class='left'>Created</th>"
+            "<th class='left'>Age</th>"
             "<th class='left'>Author</th>"
             "<th class='left'>Reference</th></tr>\n");
        header = 1;
@@ -104,7 +108,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1,
                html_link_close();
                html("</td><td>");
                if (info->tagger_date > 0)
-                       cgit_print_date(info->tagger_date);
+                       cgit_print_age(info->tagger_date, -1, NULL);
                html("</td><td>");
                if (info->tagger)
                        html(info->tagger);
@@ -130,6 +134,7 @@ static int cgit_print_archive_cb(const char *refname, const unsigned char *sha1,
        struct taginfo *info;
        struct object *obj;
        char buf[256], *url;
+       unsigned char fileid[20];
 
        if (prefixcmp(refname, "refs/archives"))
                return 0;
@@ -141,30 +146,32 @@ static int cgit_print_archive_cb(const char *refname, const unsigned char *sha1,
                tag = lookup_tag(sha1);
                if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag)))
                        return 0;
-               hashcpy(sha1, tag->tagged->sha1);
+               hashcpy(fileid, tag->tagged->sha1);
        } else if (obj->type != OBJ_BLOB) {
                return 0;
+       } else {
+               hashcpy(fileid, sha1);
        }
        if (!header) {
-               html("<table>");
+               html("<table id='downloads'>");
                html("<tr><th>Downloads</th></tr>");
                header = 1;
        }
        html("<tr><td>");
        url = cgit_pageurl(cgit_query_repo, "blob",
-                          fmt("id=%s&path=%s", sha1_to_hex(sha1),
+                          fmt("id=%s&amp;path=%s", sha1_to_hex(fileid),
                               buf));
        html_link_open(url, NULL, NULL);
        html_txt(buf);
        html_link_close();
-       html("</td><tr>");
+       html("</td></tr>");
        return 0;
 }
 
 static void cgit_print_branches()
 {
        html("<tr class='nohover'><th class='left'>Branch</th>"
-            "<th class='left'>Updated</th>"
+            "<th class='left'>Idle</th>"
             "<th class='left'>Author</th>"
             "<th class='left'>Head commit</th></tr>\n");
        for_each_branch_ref(cgit_print_branch_cb, NULL);
@@ -186,16 +193,18 @@ static void cgit_print_archives()
 
 void cgit_print_summary()
 {
-       html("<table class='list nowrap'>");
-       html("<tr class='nohover'><td id='summary' colspan='3'>");
+       html("<div id='summary'>");
+       cgit_print_archives();
        html("<h2>");
        html_txt(cgit_repo->name);
        html(" - ");
        html_txt(cgit_repo->desc);
        html("</h2>");
-       html("</td><td id='archivelist'>");
-       cgit_print_archives();
-       html("</td></tr>");
+       if (cgit_repo->readme)
+               html_include(cgit_repo->readme);
+       html("</div>");
+
+       html("<table class='list nowrap'>");
        cgit_print_branches();
        html("<tr class='nohover'><td colspan='4'>&nbsp;</td></tr>");
        cgit_print_tags();