Remove redundant includes

[cgit.git] / ui-repolist.c

diff --git a/ui-repolist.c b/ui-repolist.c
index 25c36ce39b052bddd62199bf398c5c80ede05cc9..43253ed92c93e3a0597da3c3944b8f77793f9f68 100644 (file)
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -1,36 +1,38 @@
 /* ui-repolist.c: functions for generating the repolist page
  *
 /* ui-repolist.c: functions for generating the repolist page
  *

- * Copyright (C) 2006 Lars Hjemli
+ * Copyright (C) 2006-2014 cgit Development Team <cgit@lists.zx2c4.com>

  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
 #include "cgit.h"

+#include "ui-repolist.h"

 #include "html.h"
 #include "ui-shared.h"
 
 #include "html.h"
 #include "ui-shared.h"
 

-time_t read_agefile(char *path)
+static time_t read_agefile(char *path)

 {
        time_t result;
        size_t size;
        char *buf;
 {
        time_t result;
        size_t size;
        char *buf;

-       static char buf2[64];
+       struct strbuf date_buf = STRBUF_INIT;

 
        if (readfile(path, &buf, &size))
                return -1;
 
 
        if (readfile(path, &buf, &size))
                return -1;
 

-       if (parse_date(buf, buf2, sizeof(buf2)) > 0)
-               result = strtoul(buf2, NULL, 10);
+       if (parse_date(buf, &date_buf) == 0)
+               result = strtoul(date_buf.buf, NULL, 10);

        else
                result = 0;
        free(buf);
        else
                result = 0;
        free(buf);

+       strbuf_release(&date_buf);

        return result;
 }
 
 static int get_repo_modtime(const struct cgit_repo *repo, time_t *mtime)
 {
        return result;
 }
 
 static int get_repo_modtime(const struct cgit_repo *repo, time_t *mtime)
 {

-       char *path;
+       struct strbuf path = STRBUF_INIT;

        struct stat s;
        struct cgit_repo *r = (struct cgit_repo *)repo;
 
        struct stat s;
        struct cgit_repo *r = (struct cgit_repo *)repo;
 


@@ -38,29 +40,36 @@ static int get_repo_modtime(const struct cgit_repo *repo, time_t *mtime)
                *mtime = repo->mtime;
                return 1;
        }
                *mtime = repo->mtime;
                return 1;
        }

-       path = fmt("%s/%s", repo->path, ctx.cfg.agefile);
-       if (stat(path, &s) == 0) {
-               *mtime = read_agefile(path);
-               r->mtime = *mtime;
-               return 1;
+       strbuf_addf(&path, "%s/%s", repo->path, ctx.cfg.agefile);
+       if (stat(path.buf, &s) == 0) {
+               *mtime = read_agefile(path.buf);
+               if (*mtime) {
+                       r->mtime = *mtime;
+                       goto end;
+               }

        }
 
        }
 

-       path = fmt("%s/refs/heads/%s", repo->path, repo->defbranch);
-       if (stat(path, &s) == 0) {
+       strbuf_reset(&path);
+       strbuf_addf(&path, "%s/refs/heads/%s", repo->path,
+                   repo->defbranch ? repo->defbranch : "master");
+       if (stat(path.buf, &s) == 0) {

                *mtime = s.st_mtime;
                r->mtime = *mtime;
                *mtime = s.st_mtime;
                r->mtime = *mtime;

-               return 1;
+               goto end;

        }
 
        }
 

-       path = fmt("%s/%s", repo->path, "packed-refs");
-       if (stat(path, &s) == 0) {
+       strbuf_reset(&path);
+       strbuf_addf(&path, "%s/%s", repo->path, "packed-refs");
+       if (stat(path.buf, &s) == 0) {

                *mtime = s.st_mtime;
                r->mtime = *mtime;
                *mtime = s.st_mtime;
                r->mtime = *mtime;

-               return 1;
+               goto end;

        }
 
        *mtime = 0;
        r->mtime = *mtime;
        }
 
        *mtime = 0;
        r->mtime = *mtime;

+end:
+       strbuf_release(&path);

        return (r->mtime != 0);
 }
 
        return (r->mtime != 0);
 }
 


@@ -71,7 +80,7 @@ static void print_modtime(struct cgit_repo *repo)
                cgit_print_age(t, -1, NULL);
 }
 
                cgit_print_age(t, -1, NULL);
 }
 

-int is_match(struct cgit_repo *repo)
+static int is_match(struct cgit_repo *repo)

 {
        if (!ctx.qry.search)
                return 1;
 {
        if (!ctx.qry.search)
                return 1;


@@ -86,31 +95,34 @@ int is_match(struct cgit_repo *repo)
        return 0;
 }
 
        return 0;
 }
 

-int is_in_url(struct cgit_repo *repo)
+static int is_in_url(struct cgit_repo *repo)

 {
        if (!ctx.qry.url)
                return 1;
 {
        if (!ctx.qry.url)
                return 1;

-       if (repo->url && !prefixcmp(repo->url, ctx.qry.url))
+       if (repo->url && starts_with(repo->url, ctx.qry.url))

                return 1;
        return 0;
 }
 
                return 1;
        return 0;
 }
 

-void print_sort_header(const char *title, const char *sort)
+static void print_sort_header(const char *title, const char *sort)

 {
 {

-       htmlf("<th class='left'><a href='%s?s=%s", cgit_rooturl(), sort);
+       html("<th class='left'><a href='");
+       html_attr(cgit_currenturl());
+       htmlf("?s=%s", sort);

        if (ctx.qry.search) {
        if (ctx.qry.search) {

-               html("&q=");
+               html("&amp;q=");

                html_url_arg(ctx.qry.search);
        }
        htmlf("'>%s</a></th>", title);
 }
 
                html_url_arg(ctx.qry.search);
        }
        htmlf("'>%s</a></th>", title);
 }
 

-void print_header(int columns)
+static void print_header(void)

 {
        html("<tr class='nohover'>");
        print_sort_header("Name", "name");
        print_sort_header("Description", "desc");
 {
        html("<tr class='nohover'>");
        print_sort_header("Name", "name");
        print_sort_header("Description", "desc");

-       print_sort_header("Owner", "owner");
+       if (ctx.cfg.enable_index_owner)
+               print_sort_header("Owner", "owner");

        print_sort_header("Idle", "idle");
        if (ctx.cfg.enable_index_links)
                html("<th class='left'>Links</th>");
        print_sort_header("Idle", "idle");
        if (ctx.cfg.enable_index_links)
                html("<th class='left'>Links</th>");


@@ -118,20 +130,29 @@ void print_header(int columns)
 }
 
 
 }
 
 

-void print_pager(int items, int pagelen, char *search)
+static void print_pager(int items, int pagelen, char *search, char *sort)

 {
 {

-       int i;
-       html("<div class='pager'>");
-       for(i = 0; i * pagelen < items; i++)
-               cgit_index_link(fmt("[%d]", i+1), fmt("Page %d", i+1), NULL,
-                               search, i * pagelen);
-       html("</div>");
+       int i, ofs;
+       char *class = NULL;
+       html("<ul class='pager'>");
+       for (i = 0, ofs = 0; ofs < items; i++, ofs = i * pagelen) {
+               class = (ctx.qry.ofs == ofs) ? "current" : NULL;
+               html("<li>");
+               cgit_index_link(fmt("[%d]", i + 1), fmt("Page %d", i + 1),
+                               class, search, sort, ofs, 0);
+               html("</li>");
+       }
+       html("</ul>");

 }
 
 static int cmp(const char *s1, const char *s2)
 {
 }
 
 static int cmp(const char *s1, const char *s2)
 {

-       if (s1 && s2)
-               return strcmp(s1, s2);
+       if (s1 && s2) {
+               if (ctx.cfg.case_sensitive_sort)
+                       return strcmp(s1, s2);
+               else
+                       return strcasecmp(s1, s2);
+       }

        if (s1 && !s2)
                return -1;
        if (s2 && !s1)
        if (s1 && !s2)
                return -1;
        if (s2 && !s1)


@@ -144,10 +165,19 @@ static int sort_section(const void *a, const void *b)
        const struct cgit_repo *r1 = a;
        const struct cgit_repo *r2 = b;
        int result;
        const struct cgit_repo *r1 = a;
        const struct cgit_repo *r2 = b;
        int result;

+       time_t t;

 
        result = cmp(r1->section, r2->section);
 
        result = cmp(r1->section, r2->section);

-       if (!result)
-               result = cmp(r1->name, r2->name);
+       if (!result) {
+               if (!strcmp(ctx.cfg.repository_sort, "age")) {
+                       // get_repo_modtime caches the value in r->mtime, so we don't
+                       // have to worry about inefficiencies here.
+                       if (get_repo_modtime(r1, &t) && get_repo_modtime(r2, &t))
+                               result = r2->mtime - r1->mtime;
+               }
+               if (!result)
+                       result = cmp(r1->name, r2->name);
+       }

        return result;
 }
 
        return result;
 }
 


@@ -192,7 +222,7 @@ struct sortcolumn {
        int (*fn)(const void *a, const void *b);
 };
 
        int (*fn)(const void *a, const void *b);
 };
 

-struct sortcolumn sortcolumn[] = {
+static const struct sortcolumn sortcolumn[] = {

        {"section", sort_section},
        {"name", sort_name},
        {"desc", sort_desc},
        {"section", sort_section},
        {"name", sort_name},
        {"desc", sort_desc},


@@ -201,9 +231,9 @@ struct sortcolumn sortcolumn[] = {
        {NULL, NULL}
 };
 
        {NULL, NULL}
 };
 

-int sort_repolist(char *field)
+static int sort_repolist(char *field)

 {
 {

-       struct sortcolumn *column;
+       const struct sortcolumn *column;

 
        for (column = &sortcolumn[0]; column->name; column++) {
                if (strcmp(field, column->name))
 
        for (column = &sortcolumn[0]; column->name; column++) {
                if (strcmp(field, column->name))


@@ -216,32 +246,36 @@ int sort_repolist(char *field)
 }
 
 
 }
 
 

-void cgit_print_repolist()
+void cgit_print_repolist(void)

 {
 {

-       int i, columns = 4, hits = 0, header = 0;
+       int i, columns = 3, hits = 0, header = 0;

        char *last_section = NULL;
        char *section;
        int sorted = 0;
 
        if (ctx.cfg.enable_index_links)
        char *last_section = NULL;
        char *section;
        int sorted = 0;
 
        if (ctx.cfg.enable_index_links)

-               columns++;
+               ++columns;
+       if (ctx.cfg.enable_index_owner)
+               ++columns;

 
        ctx.page.title = ctx.cfg.root_title;
 
        ctx.page.title = ctx.cfg.root_title;

-       cgit_print_http_headers(&ctx);
-       cgit_print_docstart(&ctx);
-       cgit_print_pageheader(&ctx);
+       cgit_print_http_headers();
+       cgit_print_docstart();
+       cgit_print_pageheader();

 
        if (ctx.cfg.index_header)
                html_include(ctx.cfg.index_header);
 
 
        if (ctx.cfg.index_header)
                html_include(ctx.cfg.index_header);
 

-       if(ctx.qry.sort)
+       if (ctx.qry.sort)

                sorted = sort_repolist(ctx.qry.sort);
                sorted = sort_repolist(ctx.qry.sort);

-       else
+       else if (ctx.cfg.section_sort)

                sort_repolist("section");
 
        html("<table summary='repository list' class='list nowrap'>");
                sort_repolist("section");
 
        html("<table summary='repository list' class='list nowrap'>");

-       for (i=0; i<cgit_repolist.count; i++) {
+       for (i = 0; i < cgit_repolist.count; i++) {

                ctx.repo = &cgit_repolist.repos[i];
                ctx.repo = &cgit_repolist.repos[i];

+               if (ctx.repo->hide || ctx.repo->ignore)
+                       continue;

                if (!(is_match(ctx.repo) && is_in_url(ctx.repo)))
                        continue;
                hits++;
                if (!(is_match(ctx.repo) && is_in_url(ctx.repo)))
                        continue;
                hits++;


@@ -250,7 +284,7 @@ void cgit_print_repolist()
                if (hits > ctx.qry.ofs + ctx.cfg.max_repo_count)
                        continue;
                if (!header++)
                if (hits > ctx.qry.ofs + ctx.cfg.max_repo_count)
                        continue;
                if (!header++)

-                       print_header(columns);
+                       print_header();

                section = ctx.repo->section;
                if (section && !strcmp(section, ""))
                        section = NULL;
                section = ctx.repo->section;
                if (section && !strcmp(section, ""))
                        section = NULL;


@@ -273,15 +307,29 @@ void cgit_print_repolist()
                html_ntxt(ctx.cfg.max_repodesc_len, ctx.repo->desc);
                html_link_close();
                html("</td><td>");
                html_ntxt(ctx.cfg.max_repodesc_len, ctx.repo->desc);
                html_link_close();
                html("</td><td>");

-               html_txt(ctx.repo->owner);
-               html("</td><td>");
+               if (ctx.cfg.enable_index_owner) {
+                       if (ctx.repo->owner_filter) {
+                               cgit_open_filter(ctx.repo->owner_filter);
+                               html_txt(ctx.repo->owner);
+                               cgit_close_filter(ctx.repo->owner_filter);
+                       } else {
+                               html("<a href='");
+                               html_attr(cgit_currenturl());
+                               html("?q=");
+                               html_url_arg(ctx.repo->owner);
+                               html("'>");
+                               html_txt(ctx.repo->owner);
+                               html("</a>");
+                       }
+                       html("</td><td>");
+               }

                print_modtime(ctx.repo);
                html("</td>");
                if (ctx.cfg.enable_index_links) {
                        html("<td>");
                        cgit_summary_link("summary", NULL, "button", NULL);
                        cgit_log_link("log", NULL, "button", NULL, NULL, NULL,
                print_modtime(ctx.repo);
                html("</td>");
                if (ctx.cfg.enable_index_links) {
                        html("<td>");
                        cgit_summary_link("summary", NULL, "button", NULL);
                        cgit_log_link("log", NULL, "button", NULL, NULL, NULL,

-                                     0, NULL, NULL, ctx.qry.showmsg);
+                                     0, NULL, NULL, ctx.qry.showmsg, 0);

                        cgit_tree_link("tree", NULL, "button", NULL, NULL, NULL);
                        html("</td>");
                }
                        cgit_tree_link("tree", NULL, "button", NULL, NULL, NULL);
                        html("</td>");
                }


@@ -291,17 +339,15 @@ void cgit_print_repolist()
        if (!hits)
                cgit_print_error("No repositories found");
        else if (hits > ctx.cfg.max_repo_count)
        if (!hits)
                cgit_print_error("No repositories found");
        else if (hits > ctx.cfg.max_repo_count)

-               print_pager(hits, ctx.cfg.max_repo_count, ctx.qry.search);
+               print_pager(hits, ctx.cfg.max_repo_count, ctx.qry.search, ctx.qry.sort);

        cgit_print_docend();
 }
 
        cgit_print_docend();
 }
 

-void cgit_print_site_readme()
+void cgit_print_site_readme(void)

 {
        if (!ctx.cfg.root_readme)
                return;
 {
        if (!ctx.cfg.root_readme)
                return;

-       if (ctx.cfg.about_filter)
-               cgit_open_filter(ctx.cfg.about_filter);
+       cgit_open_filter(ctx.cfg.about_filter, ctx.cfg.root_readme);

        html_include(ctx.cfg.root_readme);
        html_include(ctx.cfg.root_readme);

-       if (ctx.cfg.about_filter)
-               cgit_close_filter(ctx.cfg.about_filter);
+       cgit_close_filter(ctx.cfg.about_filter);

 }
 }