ui-log: ban strcpy()

[cgit.git] / ui-repolist.c

diff --git a/ui-repolist.c b/ui-repolist.c
index 7158bf7cf643b3b90c47cfab040796ff013ad2ea..41424c0881dee009816a3effc75ef1d116f06955 100644 (file)
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -184,27 +184,6 @@ static int cmp(const char *s1, const char *s2)
        return 0;
 }
 
-static int sort_section(const void *a, const void *b)
-{
-       const struct cgit_repo *r1 = a;
-       const struct cgit_repo *r2 = b;
-       int result;
-       time_t t;
-
-       result = cmp(r1->section, r2->section);
-       if (!result) {
-               if (!strcmp(ctx.cfg.repository_sort, "age")) {
-                       // get_repo_modtime caches the value in r->mtime, so we don't
-                       // have to worry about inefficiencies here.
-                       if (get_repo_modtime(r1, &t) && get_repo_modtime(r2, &t))
-                               result = r2->mtime - r1->mtime;
-               }
-               if (!result)
-                       result = cmp(r1->name, r2->name);
-       }
-       return result;
-}
-
 static int sort_name(const void *a, const void *b)
 {
        const struct cgit_repo *r1 = a;
@@ -241,6 +220,22 @@ static int sort_idle(const void *a, const void *b)
        return t2 - t1;
 }
 
+static int sort_section(const void *a, const void *b)
+{
+       const struct cgit_repo *r1 = a;
+       const struct cgit_repo *r2 = b;
+       int result;
+
+       result = cmp(r1->section, r2->section);
+       if (!result) {
+               if (!strcmp(ctx.cfg.repository_sort, "age"))
+                       result = sort_idle(r1, r2);
+               if (!result)
+                       result = cmp(r1->name, r2->name);
+       }
+       return result;
+}
+
 struct sortcolumn {
        const char *name;
        int (*fn)(const void *a, const void *b);
@@ -293,9 +288,6 @@ void cgit_print_repolist(void)
        cgit_print_docstart();
        cgit_print_pageheader();
 
-       if (ctx.cfg.index_header)
-               html_include(ctx.cfg.index_header);
-
        if (ctx.qry.sort)
                sorted = sort_repolist(ctx.qry.sort);
        else if (ctx.cfg.section_sort)
@@ -321,7 +313,7 @@ void cgit_print_repolist(void)
                    (last_section != NULL && section == NULL) ||
                    (last_section != NULL && section != NULL &&
                     strcmp(section, last_section)))) {
-                       htmlf("<tr class='nohover'><td colspan='%d' class='reposection'>",
+                       htmlf("<tr class='nohover-highlight'><td colspan='%d' class='reposection'>",
                              columns);
                        html_txt(section);
                        html("</td></tr>");
@@ -334,7 +326,8 @@ void cgit_print_repolist(void)
                repourl = cgit_repourl(ctx.repo->url);
                html_link_open(repourl, NULL, NULL);
                free(repourl);
-               html_ntxt(ctx.cfg.max_repodesc_len, ctx.repo->desc);
+               if (html_ntxt(ctx.repo->desc, ctx.cfg.max_repodesc_len) < 0)
+                       html("...");
                html_link_close();
                html("</td><td>");
                if (ctx.cfg.enable_index_owner) {