ui-diff,ui-tag: don't use htmlf with non-formatted strings

[cgit.git] / ui-diff.c

diff --git a/ui-diff.c b/ui-diff.c
index c7fb49b0c9b79d337c0e62ce0e197e3838c21b9d..c60aefd1d629826e081329713324b7b35b6dff8e 100644 (file)
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -82,7 +82,7 @@ static void print_fileinfo(struct fileinfo *info)
        }
 
        html("<tr>");
-       htmlf("<td class='mode'>");
+       html("<td class='mode'>");
        if (is_null_oid(info->new_oid)) {
                cgit_print_filemode(info->old_mode);
        } else {
@@ -258,8 +258,8 @@ static void header(const struct object_id *oid1, char *path1, int mode1,
                htmlf("<br/>deleted file mode %.6o", mode1);
 
        if (!subproject) {
-               abbrev1 = xstrdup(find_unique_abbrev(oid1->hash, DEFAULT_ABBREV));
-               abbrev2 = xstrdup(find_unique_abbrev(oid2->hash, DEFAULT_ABBREV));
+               abbrev1 = xstrdup(find_unique_abbrev(oid1, DEFAULT_ABBREV));
+               abbrev2 = xstrdup(find_unique_abbrev(oid2, DEFAULT_ABBREV));
                htmlf("<br/>index %s..%s", abbrev1, abbrev2);
                free(abbrev1);
                free(abbrev2);
@@ -407,13 +407,13 @@ void cgit_print_diff(const char *new_rev, const char *old_rev,
                        "Bad object name: %s", new_rev);
                return;
        }
-       commit = lookup_commit_reference(new_rev_oid);
+       commit = lookup_commit_reference(the_repository, new_rev_oid);
        if (!commit || parse_commit(commit)) {
                cgit_print_error_page(404, "Not found",
                        "Bad commit: %s", oid_to_hex(new_rev_oid));
                return;
        }
-       new_tree_oid = &commit->tree->object.oid;
+       new_tree_oid = &commit->maybe_tree->object.oid;
 
        if (old_rev) {
                if (get_oid(old_rev, old_rev_oid)) {
@@ -428,13 +428,13 @@ void cgit_print_diff(const char *new_rev, const char *old_rev,
        }
 
        if (!is_null_oid(old_rev_oid)) {
-               commit2 = lookup_commit_reference(old_rev_oid);
+               commit2 = lookup_commit_reference(the_repository, old_rev_oid);
                if (!commit2 || parse_commit(commit2)) {
                        cgit_print_error_page(404, "Not found",
                                "Bad commit: %s", oid_to_hex(old_rev_oid));
                        return;
                }
-               old_tree_oid = &commit2->tree->object.oid;
+               old_tree_oid = &commit2->maybe_tree->object.oid;
        } else {
                old_tree_oid = NULL;
        }
@@ -444,7 +444,7 @@ void cgit_print_diff(const char *new_rev, const char *old_rev,
 
                diff_setup(&diffopt);
                diffopt.output_format = DIFF_FORMAT_PATCH;
-               DIFF_OPT_SET(&diffopt, RECURSIVE);
+               diffopt.flags.recursive = 1;
                diff_setup_done(&diffopt);
 
                ctx.page.mimetype = "text/plain";