ui-summary: Pass filename to about-filter

[cgit.git] / ui-tag.c

diff --git a/ui-tag.c b/ui-tag.c
index cd353c2e34ff5742036ad4746e350c09b1690fab..aea795879dfe595f851efe4908e8d31fb2976837 100644 (file)
--- a/ui-tag.c
+++ b/ui-tag.c
@@ -7,6 +7,7 @@
  */
 
 #include "cgit.h"
+#include "ui-tag.h"
 #include "html.h"
 #include "ui-shared.h"
 
@@ -30,7 +31,7 @@ static void print_tag_content(char *buf)
        }
 }
 
-void print_download_links(char *revname)
+static void print_download_links(char *revname)
 {
        html("<tr><th>download</th><td class='sha1'>");
        cgit_print_snapshot_links(ctx.qry.repo, ctx.qry.head,
@@ -40,6 +41,7 @@ void print_download_links(char *revname)
 
 void cgit_print_tag(char *revname)
 {
+       struct strbuf fullref = STRBUF_INIT;
        unsigned char sha1[20];
        struct object *obj;
        struct tag *tag;
@@ -48,32 +50,33 @@ void cgit_print_tag(char *revname)
        if (!revname)
                revname = ctx.qry.head;
 
-       if (get_sha1(fmt("refs/tags/%s", revname), sha1)) {
-               cgit_print_error(fmt("Bad tag reference: %s", revname));
-               return;
+       strbuf_addf(&fullref, "refs/tags/%s", revname);
+       if (get_sha1(fullref.buf, sha1)) {
+               cgit_print_error("Bad tag reference: %s", revname);
+               goto cleanup;
        }
        obj = parse_object(sha1);
        if (!obj) {
-               cgit_print_error(fmt("Bad object id: %s", sha1_to_hex(sha1)));
-               return;
+               cgit_print_error("Bad object id: %s", sha1_to_hex(sha1));
+               goto cleanup;
        }
        if (obj->type == OBJ_TAG) {
                tag = lookup_tag(sha1);
                if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag))) {
-                       cgit_print_error(fmt("Bad tag object: %s", revname));
-                       return;
+                       cgit_print_error("Bad tag object: %s", revname);
+                       goto cleanup;
                }
                html("<table class='commit-info'>\n");
-               htmlf("<tr><td>Tag name</td><td>");
+               htmlf("<tr><td>tag name</td><td>");
                html_txt(revname);
                htmlf(" (%s)</td></tr>\n", sha1_to_hex(sha1));
                if (info->tagger_date > 0) {
-                       html("<tr><td>Tag date</td><td>");
+                       html("<tr><td>tag date</td><td>");
                        cgit_print_date(info->tagger_date, FMT_LONGDATE, ctx.cfg.local_time);
                        html("</td></tr>\n");
                }
                if (info->tagger) {
-                       html("<tr><td>Tagged by</td><td>");
+                       html("<tr><td>tagged by</td><td>");
                        html_txt(info->tagger);
                        if (info->tagger_email && !ctx.cfg.noplainemail) {
                                html(" ");
@@ -81,7 +84,7 @@ void cgit_print_tag(char *revname)
                        }
                        html("</td></tr>\n");
                }
-               html("<tr><td>Tagged object</td><td>");
+               html("<tr><td>tagged object</td><td class='sha1'>");
                cgit_object_link(tag->tagged);
                html("</td></tr>\n");
                if (ctx.repo->snapshots)
@@ -90,15 +93,17 @@ void cgit_print_tag(char *revname)
                print_tag_content(info->msg);
        } else {
                html("<table class='commit-info'>\n");
-               htmlf("<tr><td>Tag name</td><td>");
+               htmlf("<tr><td>tag name</td><td>");
                html_txt(revname);
                html("</td></tr>\n");
-               html("<tr><td>Tagged object</td><td>");
+               html("<tr><td>Tagged object</td><td class='sha1'>");
                cgit_object_link(obj);
                html("</td></tr>\n");
                if (ctx.repo->snapshots)
                        print_download_links(revname);
                html("</table>\n");
-        }
-       return;
+       }
+
+cleanup:
+       strbuf_release(&fullref);
 }