doc: use consistent id's when generating html files

[cgit.git] / ui-ssdiff.c

diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index cbe60bd6da0709b53a355d6d775b9ced0e1cd968..7f261ed53a0077fa3fd4a8dab3db1fcdcf247a8c 100644 (file)
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -18,7 +18,7 @@ struct deferred_lines {
 static struct deferred_lines *deferred_old, *deferred_old_last;
 static struct deferred_lines *deferred_new, *deferred_new_last;
 
-static void create_or_reset_lcs_table()
+static void create_or_reset_lcs_table(void)
 {
        int i;
 
@@ -92,7 +92,7 @@ static char *longest_common_subsequence(char *A, char *B)
 static int line_from_hunk(char *line, char type)
 {
        char *buf1, *buf2;
-       int len;
+       int len, res;
 
        buf1 = strchr(line, type);
        if (buf1 == NULL)
@@ -105,7 +105,7 @@ static int line_from_hunk(char *line, char type)
        buf2 = xmalloc(len + 1);
        strncpy(buf2, buf1, len);
        buf2[len] = '\0';
-       int res = atoi(buf2);
+       res = atoi(buf2);
        free(buf2);
        return res;
 }
@@ -229,12 +229,14 @@ static void print_ssdiff_line(char *class,
        if (old_line_no > 0) {
                struct diff_filespec *old_file = cgit_get_current_old_file();
                char *lineno_str = fmt("n%d", old_line_no);
-               char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str);
-               html("<td class='lineno'><a class='no' href='");
-               html(cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str));
-               htmlf("' id='%s' name='%s'>%s</a>", lineno_str, lineno_str, lineno_str + 1);
+               char *id_str = fmt("id=%s#%s", is_null_oid(&old_file->oid)?"HEAD":oid_to_hex(old_rev_oid), lineno_str);
+               char *fileurl = cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str);
+               html("<td class='lineno'><a href='");
+               html(fileurl);
+               htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1);
                html("</td>");
                htmlf("<td class='%s'>", class);
+               free(fileurl);
        } else if (old_line)
                htmlf("<td class='lineno'></td><td class='%s'>", class);
        else
@@ -250,12 +252,14 @@ static void print_ssdiff_line(char *class,
        if (new_line_no > 0) {
                struct diff_filespec *new_file = cgit_get_current_new_file();
                char *lineno_str = fmt("n%d", new_line_no);
-               char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str);
-               html("<td class='lineno'><a class='no' href='");
-               html(cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str));
-               htmlf("' id='%s' name='%s'>%s</a>", lineno_str, lineno_str, lineno_str + 1);
+               char *id_str = fmt("id=%s#%s", is_null_oid(&new_file->oid)?"HEAD":oid_to_hex(new_rev_oid), lineno_str);
+               char *fileurl = cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str);
+               html("<td class='lineno'><a href='");
+               html(fileurl);
+               htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1);
                html("</td>");
                htmlf("<td class='%s'>", class);
+               free(fileurl);
        } else if (new_line)
                htmlf("<td class='lineno'></td><td class='%s'>", class);
        else
@@ -276,7 +280,7 @@ static void print_ssdiff_line(char *class,
                free(old_line);
 }
 
-static void print_deferred_old_lines()
+static void print_deferred_old_lines(void)
 {
        struct deferred_lines *iter_old, *tmp;
        iter_old = deferred_old;
@@ -289,7 +293,7 @@ static void print_deferred_old_lines()
        }
 }
 
-static void print_deferred_new_lines()
+static void print_deferred_new_lines(void)
 {
        struct deferred_lines *iter_new, *tmp;
        iter_new = deferred_new;
@@ -302,7 +306,7 @@ static void print_deferred_new_lines()
        }
 }
 
-static void print_deferred_changed_lines()
+static void print_deferred_changed_lines(void)
 {
        struct deferred_lines *iter_old, *iter_new, *tmp;
        int n_old_lines = calc_deferred_lines(deferred_old);
@@ -337,7 +341,7 @@ static void print_deferred_changed_lines()
        }
 }
 
-void cgit_ssdiff_print_deferred_lines()
+void cgit_ssdiff_print_deferred_lines(void)
 {
        if (!deferred_old && !deferred_new)
                return;
@@ -388,7 +392,7 @@ void cgit_ssdiff_line_cb(char *line, int len)
        line[len - 1] = c;
 }
 
-void cgit_ssdiff_header_begin()
+void cgit_ssdiff_header_begin(void)
 {
        current_old_line = -1;
        current_new_line = -1;
@@ -396,12 +400,12 @@ void cgit_ssdiff_header_begin()
        html("<tr><td class='head' colspan='4'>");
 }
 
-void cgit_ssdiff_header_end()
+void cgit_ssdiff_header_end(void)
 {
        html("</td><tr>");
 }
 
-void cgit_ssdiff_footer()
+void cgit_ssdiff_footer(void)
 {
        if (deferred_old || deferred_new)
                cgit_ssdiff_print_deferred_lines();