ui-tree: free read_sha1_file() buffer after use

[cgit.git] / ui-refs.c

diff --git a/ui-refs.c b/ui-refs.c
index d125459f81264230a6a4422a22321b3375aff518..75f2789fc1653b76509f2ff3f8a9120051dd30e6 100644 (file)
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -11,18 +11,10 @@
 #include "html.h"
 #include "ui-shared.h"
 
 #include "html.h"
 #include "ui-shared.h"
 

-static int cmp_age(int age1, int age2)
+static inline int cmp_age(int age1, int age2)

 {
 {

-       if (age1 != 0 && age2 != 0)
-               return age2 - age1;
-
-       if (age1 == 0 && age2 == 0)
-               return 0;
-
-       if (age1 == 0)
-               return +1;
-
-       return -1;
+       /* age1 and age2 are assumed to be non-negative */
+       return age2 - age1;

 }
 
 static int cmp_ref_name(const void *a, const void *b)
 }
 
 static int cmp_ref_name(const void *a, const void *b)


@@ -71,17 +63,17 @@ static int print_branch(struct refinfo *ref)
                return 1;
        html("<tr><td>");
        cgit_log_link(name, NULL, NULL, name, NULL, NULL, 0, NULL, NULL,
                return 1;
        html("<tr><td>");
        cgit_log_link(name, NULL, NULL, name, NULL, NULL, 0, NULL, NULL,

-                     ctx.qry.showmsg);
+                     ctx.qry.showmsg, 0);

        html("</td><td>");
 
        if (ref->object->type == OBJ_COMMIT) {
        html("</td><td>");
 
        if (ref->object->type == OBJ_COMMIT) {

-               cgit_commit_link(info->subject, NULL, NULL, name, NULL, NULL, 0);
+               cgit_commit_link(info->subject, NULL, NULL, name, NULL, NULL);

                html("</td><td>");
                html("</td><td>");

-               cgit_open_filter(ctx.repo->email_filter, info->author_email);
+               cgit_open_filter(ctx.repo->email_filter, info->author_email, "refs");

                html_txt(info->author);
                cgit_close_filter(ctx.repo->email_filter);
                html("</td><td colspan='2'>");
                html_txt(info->author);
                cgit_close_filter(ctx.repo->email_filter);
                html("</td><td colspan='2'>");

-               cgit_print_age(info->commit->date, -1, NULL);
+               cgit_print_age(info->committer_date, info->committer_tz, -1);

        } else {
                html("</td><td></td><td>");
                cgit_object_link(ref->object);
        } else {
                html("</td><td></td><td>");
                cgit_object_link(ref->object);


@@ -90,7 +82,7 @@ static int print_branch(struct refinfo *ref)
        return 0;
 }
 
        return 0;
 }
 

-static void print_tag_header()
+static void print_tag_header(void)

 {
        html("<tr class='nohover'><th class='left'>Tag</th>"
             "<th class='left'>Download</th>"
 {
        html("<tr class='nohover'><th class='left'>Tag</th>"
             "<th class='left'>Download</th>"


@@ -101,34 +93,28 @@ static void print_tag_header()
 static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
 {
        const struct cgit_snapshot_format* f;
 static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
 {
        const struct cgit_snapshot_format* f;

-       struct strbuf filename = STRBUF_INIT;

        const char *basename;
        const char *basename;

-       int free_ref = 0;
+       struct strbuf filename = STRBUF_INIT;
+       size_t prefixlen;

 
 

-       if (!ref || strlen(ref) < 2)
+       if (!ref || strlen(ref) < 1)

                return;
 
        basename = cgit_repobasename(repo->url);
                return;
 
        basename = cgit_repobasename(repo->url);

-       if (prefixcmp(ref, basename) != 0) {
-               if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1]))
-                       ref++;
-               if (isdigit(ref[0])) {
-                       ref = fmtalloc("%s-%s", basename, ref);
-                       free_ref = 1;
-               }
-       }
-
+       if (starts_with(ref, basename))
+               strbuf_addstr(&filename, ref);
+       else
+               cgit_compose_snapshot_prefix(&filename, basename, ref);
+       prefixlen = filename.len;

        for (f = cgit_snapshot_formats; f->suffix; f++) {
                if (!(repo->snapshots & f->bit))
                        continue;
        for (f = cgit_snapshot_formats; f->suffix; f++) {
                if (!(repo->snapshots & f->bit))
                        continue;

-               strbuf_reset(&filename);
-               strbuf_addf(&filename, "%s%s", ref, f->suffix);
+               strbuf_setlen(&filename, prefixlen);
+               strbuf_addstr(&filename, f->suffix);

                cgit_snapshot_link(filename.buf, NULL, NULL, NULL, NULL, filename.buf);
                html("&nbsp;&nbsp;");
        }
 
                cgit_snapshot_link(filename.buf, NULL, NULL, NULL, NULL, filename.buf);
                html("&nbsp;&nbsp;");
        }
 

-       if (free_ref)
-               free((char *)ref);

        strbuf_release(&filename);
 }
 
        strbuf_release(&filename);
 }
 


@@ -143,12 +129,12 @@ static int print_tag(struct refinfo *ref)
                tag = (struct tag *)obj;
                obj = tag->tagged;
                info = ref->tag;
                tag = (struct tag *)obj;
                obj = tag->tagged;
                info = ref->tag;

-               if (!tag || !info)
+               if (!info)

                        return 1;
        }
 
        html("<tr><td>");
                        return 1;
        }
 
        html("<tr><td>");

-       cgit_tag_link(name, NULL, NULL, ctx.qry.head, name);
+       cgit_tag_link(name, NULL, NULL, name);

        html("</td><td>");
        if (ctx.repo->snapshots && (obj->type == OBJ_COMMIT))
                print_tag_downloads(ctx.repo, name);
        html("</td><td>");
        if (ctx.repo->snapshots && (obj->type == OBJ_COMMIT))
                print_tag_downloads(ctx.repo, name);


@@ -157,21 +143,21 @@ static int print_tag(struct refinfo *ref)
        html("</td><td>");
        if (info) {
                if (info->tagger) {
        html("</td><td>");
        if (info) {
                if (info->tagger) {

-                       cgit_open_filter(ctx.repo->email_filter, info->tagger_email);
+                       cgit_open_filter(ctx.repo->email_filter, info->tagger_email, "refs");

                        html_txt(info->tagger);
                        cgit_close_filter(ctx.repo->email_filter);
                }
        } else if (ref->object->type == OBJ_COMMIT) {
                        html_txt(info->tagger);
                        cgit_close_filter(ctx.repo->email_filter);
                }
        } else if (ref->object->type == OBJ_COMMIT) {

-               cgit_open_filter(ctx.repo->email_filter, ref->commit->author_email);
+               cgit_open_filter(ctx.repo->email_filter, ref->commit->author_email, "refs");

                html_txt(ref->commit->author);
                cgit_close_filter(ctx.repo->email_filter);
        }
        html("</td><td colspan='2'>");
        if (info) {
                if (info->tagger_date > 0)
                html_txt(ref->commit->author);
                cgit_close_filter(ctx.repo->email_filter);
        }
        html("</td><td colspan='2'>");
        if (info) {
                if (info->tagger_date > 0)

-                       cgit_print_age(info->tagger_date, -1, NULL);
+                       cgit_print_age(info->tagger_date, info->tagger_tz, -1);

        } else if (ref->object->type == OBJ_COMMIT) {
        } else if (ref->object->type == OBJ_COMMIT) {

-               cgit_print_age(ref->commit->commit->date, -1, NULL);
+               cgit_print_age(ref->commit->commit->date, 0, -1);

        }
        html("</td></tr>\n");
 
        }
        html("</td></tr>\n");
 


@@ -242,14 +228,14 @@ void cgit_print_tags(int maxcount)
        cgit_free_reflist_inner(&list);
 }
 
        cgit_free_reflist_inner(&list);
 }
 

-void cgit_print_refs()
+void cgit_print_refs(void)

 {
 {

-
+       cgit_print_layout_start();

        html("<table class='list nowrap'>");
 
        html("<table class='list nowrap'>");
 

-       if (ctx.qry.path && !prefixcmp(ctx.qry.path, "heads"))
+       if (ctx.qry.path && starts_with(ctx.qry.path, "heads"))

                cgit_print_branches(0);
                cgit_print_branches(0);

-       else if (ctx.qry.path && !prefixcmp(ctx.qry.path, "tags"))
+       else if (ctx.qry.path && starts_with(ctx.qry.path, "tags"))

                cgit_print_tags(0);
        else {
                cgit_print_branches(0);
                cgit_print_tags(0);
        else {
                cgit_print_branches(0);


@@ -257,4 +243,5 @@ void cgit_print_refs()
                cgit_print_tags(0);
        }
        html("</table>");
                cgit_print_tags(0);
        }
        html("</table>");

+       cgit_print_layout_end();

 }
 }