filter: make exit status local

[cgit.git] / shared.c

diff --git a/shared.c b/shared.c
index 0a0e22e7255b0db8b9446c496fa85b58d46e24aa..6259d75d8841c26756aaf00d266940672b6162f3 100644 (file)
--- a/shared.c
+++ b/shared.c
@@ -1,6 +1,6 @@
 /* shared.c: global vars + some callback functions
  *
 /* shared.c: global vars + some callback functions
  *

- * Copyright (C) 2006 Lars Hjemli
+ * Copyright (C) 2006-2014 cgit Development Team <cgit@lists.zx2c4.com>

  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)


@@ -15,24 +15,25 @@ struct cgit_context ctx;
 int chk_zero(int result, char *msg)
 {
        if (result != 0)
 int chk_zero(int result, char *msg)
 {
        if (result != 0)

-               die("%s: %s", msg, strerror(errno));
+               die_errno("%s", msg);

        return result;
 }
 
 int chk_positive(int result, char *msg)
 {
        if (result <= 0)
        return result;
 }
 
 int chk_positive(int result, char *msg)
 {
        if (result <= 0)

-               die("%s: %s", msg, strerror(errno));
+               die_errno("%s", msg);

        return result;
 }
 
 int chk_non_negative(int result, char *msg)
 {
        return result;
 }
 
 int chk_non_negative(int result, char *msg)
 {

-       if (result < 0)
-               die("%s: %s",msg, strerror(errno));
+       if (result < 0)
+               die_errno("%s", msg);

        return result;
 }
 
        return result;
 }
 

+char *cgit_default_repo_desc = "[no description]";

 struct cgit_repo *cgit_add_repo(const char *url)
 {
        struct cgit_repo *ret;
 struct cgit_repo *cgit_add_repo(const char *url)
 {
        struct cgit_repo *ret;


@@ -52,7 +53,7 @@ struct cgit_repo *cgit_add_repo(const char *url)
        ret->url = trim_end(url, '/');
        ret->name = ret->url;
        ret->path = NULL;
        ret->url = trim_end(url, '/');
        ret->name = ret->url;
        ret->path = NULL;

-       ret->desc = "[no description]";
+       ret->desc = cgit_default_repo_desc;

        ret->owner = NULL;
        ret->section = ctx.cfg.section;
        ret->snapshots = ctx.cfg.snapshots;
        ret->owner = NULL;
        ret->section = ctx.cfg.section;
        ret->snapshots = ctx.cfg.snapshots;


@@ -62,6 +63,8 @@ struct cgit_repo *cgit_add_repo(const char *url)
        ret->enable_remote_branches = ctx.cfg.enable_remote_branches;
        ret->enable_subject_links = ctx.cfg.enable_subject_links;
        ret->max_stats = ctx.cfg.max_stats;
        ret->enable_remote_branches = ctx.cfg.enable_remote_branches;
        ret->enable_subject_links = ctx.cfg.enable_subject_links;
        ret->max_stats = ctx.cfg.max_stats;

+       ret->branch_sort = ctx.cfg.branch_sort;
+       ret->commit_sort = ctx.cfg.commit_sort;

        ret->module_link = ctx.cfg.module_link;
        ret->readme = ctx.cfg.readme;
        ret->mtime = -1;
        ret->module_link = ctx.cfg.module_link;
        ret->readme = ctx.cfg.readme;
        ret->mtime = -1;


@@ -78,7 +81,7 @@ struct cgit_repo *cgit_get_repoinfo(const char *url)
        int i;
        struct cgit_repo *repo;
 
        int i;
        struct cgit_repo *repo;
 

-       for (i=0; i<cgit_repolist.count; i++) {
+       for (i = 0; i < cgit_repolist.count; i++) {

                repo = &cgit_repolist.repos[i];
                if (!strcmp(repo->url, url))
                        return repo;
                repo = &cgit_repolist.repos[i];
                if (!strcmp(repo->url, url))
                        return repo;


@@ -106,13 +109,34 @@ char *trim_end(const char *str, char c)
        if (str == NULL)
                return NULL;
        len = strlen(str);
        if (str == NULL)
                return NULL;
        len = strlen(str);

-       while(len > 0 && str[len - 1] == c)
+       while (len > 0 && str[len - 1] == c)

                len--;
        if (len == 0)
                return NULL;
        return xstrndup(str, len);
 }
 
                len--;
        if (len == 0)
                return NULL;
        return xstrndup(str, len);
 }
 

+char *ensure_end(const char *str, char c)
+{
+       size_t len = strlen(str);
+       char *result;
+
+       if (len && str[len - 1] == c)
+               return xstrndup(str, len);
+
+       result = xmalloc(len + 2);
+       memcpy(result, str, len);
+       result[len] = '/';
+       result[len + 1] = '\0';
+       return result;
+}
+
+void strbuf_ensure_end(struct strbuf *sb, char c)
+{
+       if (!sb->len || sb->buf[sb->len - 1] != c)
+               strbuf_addch(sb, c);
+}
+

 char *strlpart(char *txt, int maxlen)
 {
        char *result;
 char *strlpart(char *txt, int maxlen)
 {
        char *result;


@@ -156,7 +180,7 @@ void cgit_add_ref(struct reflist *list, struct refinfo *ref)
        list->refs[list->count++] = ref;
 }
 
        list->refs[list->count++] = ref;
 }
 

-struct refinfo *cgit_mk_refinfo(const char *refname, const unsigned char *sha1)
+static struct refinfo *cgit_mk_refinfo(const char *refname, const unsigned char *sha1)

 {
        struct refinfo *ref;
 
 {
        struct refinfo *ref;
 


@@ -174,6 +198,42 @@ struct refinfo *cgit_mk_refinfo(const char *refname, const unsigned char *sha1)
        return ref;
 }
 
        return ref;
 }
 

+static void cgit_free_taginfo(struct taginfo *tag)
+{
+       if (tag->tagger)
+               free(tag->tagger);
+       if (tag->tagger_email)
+               free(tag->tagger_email);
+       if (tag->msg)
+               free(tag->msg);
+       free(tag);
+}
+
+static void cgit_free_refinfo(struct refinfo *ref)
+{
+       if (ref->refname)
+               free((char *)ref->refname);
+       switch (ref->object->type) {
+       case OBJ_TAG:
+               cgit_free_taginfo(ref->tag);
+               break;
+       case OBJ_COMMIT:
+               cgit_free_commitinfo(ref->commit);
+               break;
+       }
+       free(ref);
+}
+
+void cgit_free_reflist_inner(struct reflist *list)
+{
+       int i;
+
+       for (i = 0; i < list->count; i++) {
+               cgit_free_refinfo(list->refs[i]);
+       }
+       free(list->refs);
+}
+

 int cgit_refs_cb(const char *refname, const unsigned char *sha1, int flags,
                  void *cb_data)
 {
 int cgit_refs_cb(const char *refname, const unsigned char *sha1, int flags,
                  void *cb_data)
 {


@@ -185,8 +245,8 @@ int cgit_refs_cb(const char *refname, const unsigned char *sha1, int flags,
        return 0;
 }
 
        return 0;
 }
 

-void cgit_diff_tree_cb(struct diff_queue_struct *q,
-                      struct diff_options *options, void *data)
+static void cgit_diff_tree_cb(struct diff_queue_struct *q,
+                             struct diff_options *options, void *data)

 {
        int i;
 
 {
        int i;
 


@@ -205,7 +265,7 @@ static int load_mmfile(mmfile_t *file, const unsigned char *sha1)
                file->ptr = (char *)"";
                file->size = 0;
        } else {
                file->ptr = (char *)"";
                file->size = 0;
        } else {

-               file->ptr = read_sha1_file(sha1, &type, 
+               file->ptr = read_sha1_file(sha1, &type,

                                           (unsigned long *)&file->size);
        }
        return 1;
                                           (unsigned long *)&file->size);
        }
        return 1;


@@ -222,7 +282,7 @@ static int load_mmfile(mmfile_t *file, const unsigned char *sha1)
 char *diffbuf = NULL;
 int buflen = 0;
 
 char *diffbuf = NULL;
 int buflen = 0;
 

-int filediff_cb(void *priv, mmbuffer_t *mb, int nbuf)
+static int filediff_cb(void *priv, mmbuffer_t *mb, int nbuf)

 {
        int i;
 
 {
        int i;
 


@@ -305,7 +365,7 @@ void cgit_diff_tree(const unsigned char *old_sha1,
                    filepair_fn fn, const char *prefix, int ignorews)
 {
        struct diff_options opt;
                    filepair_fn fn, const char *prefix, int ignorews)
 {
        struct diff_options opt;

-       int prefixlen;
+       struct pathspec_item item;

 
        diff_setup(&opt);
        opt.output_format = DIFF_FORMAT_CALLBACK;
 
        diff_setup(&opt);
        opt.output_format = DIFF_FORMAT_CALLBACK;


@@ -317,10 +377,10 @@ void cgit_diff_tree(const unsigned char *old_sha1,
        opt.format_callback = cgit_diff_tree_cb;
        opt.format_callback_data = fn;
        if (prefix) {
        opt.format_callback = cgit_diff_tree_cb;
        opt.format_callback_data = fn;
        if (prefix) {

-               opt.nr_paths = 1;
-               opt.paths = &prefix;
-               prefixlen = strlen(prefix);
-               opt.pathlens = &prefixlen;
+               item.match = prefix;
+               item.len = strlen(prefix);
+               opt.pathspec.nr = 1;
+               opt.pathspec.items = &item;

        }
        diff_setup_done(&opt);
 
        }
        diff_setup_done(&opt);
 


@@ -344,28 +404,29 @@ void cgit_diff_commit(struct commit *commit, filepair_fn fn, const char *prefix)
 
 int cgit_parse_snapshots_mask(const char *str)
 {
 
 int cgit_parse_snapshots_mask(const char *str)
 {

+       struct string_list tokens = STRING_LIST_INIT_DUP;
+       struct string_list_item *item;

        const struct cgit_snapshot_format *f;
        const struct cgit_snapshot_format *f;

-       static const char *delim = " \t,:/|;";
-       int tl, sl, rv = 0;
+       int rv = 0;

 
        /* favor legacy setting */
 
        /* favor legacy setting */

-       if(atoi(str))
+       if (atoi(str))

                return 1;
                return 1;

-       for(;;) {
-               str += strspn(str,delim);
-               tl = strcspn(str,delim);
-               if (!tl)
-                       break;
+
+       string_list_split(&tokens, str, ' ', -1);
+       string_list_remove_empty_items(&tokens, 0);
+
+       for_each_string_list_item(item, &tokens) {

                for (f = cgit_snapshot_formats; f->suffix; f++) {
                for (f = cgit_snapshot_formats; f->suffix; f++) {

-                       sl = strlen(f->suffix);
-                       if((tl == sl && !strncmp(f->suffix, str, tl)) ||
-                          (tl == sl-1 && !strncmp(f->suffix+1, str, tl-1))) {
+                       if (!strcmp(item->string, f->suffix) ||
+                           !strcmp(item->string, f->suffix + 1)) {

                                rv |= f->bit;
                                break;
                        }
                }
                                rv |= f->bit;
                                break;
                        }
                }

-               str += tl;

        }
        }

+
+       string_list_clear(&tokens, 0);

        return rv;
 }
 
        return rv;
 }
 


@@ -398,7 +459,6 @@ void cgit_prepare_repo_env(struct cgit_repo * repo)
 
 int cgit_open_filter(struct cgit_filter *filter)
 {
 
 int cgit_open_filter(struct cgit_filter *filter)
 {

-

        filter->old_stdout = chk_positive(dup(STDOUT_FILENO),
                "Unable to duplicate STDOUT");
        chk_zero(pipe(filter->pipe_fh), "Unable to create pipe to subprocess");
        filter->old_stdout = chk_positive(dup(STDOUT_FILENO),
                "Unable to duplicate STDOUT");
        chk_zero(pipe(filter->pipe_fh), "Unable to create pipe to subprocess");


@@ -408,8 +468,7 @@ int cgit_open_filter(struct cgit_filter *filter)
                chk_non_negative(dup2(filter->pipe_fh[0], STDIN_FILENO),
                        "Unable to use pipe as STDIN");
                execvp(filter->cmd, filter->argv);
                chk_non_negative(dup2(filter->pipe_fh[0], STDIN_FILENO),
                        "Unable to use pipe as STDIN");
                execvp(filter->cmd, filter->argv);

-               die("Unable to exec subprocess %s: %s (%d)", filter->cmd,
-                       strerror(errno), errno);
+               die_errno("Unable to exec subprocess %s", filter->cmd);

        }
        close(filter->pipe_fh[0]);
        chk_non_negative(dup2(filter->pipe_fh[1], STDOUT_FILENO),
        }
        close(filter->pipe_fh[0]);
        chk_non_negative(dup2(filter->pipe_fh[1], STDOUT_FILENO),


@@ -420,13 +479,15 @@ int cgit_open_filter(struct cgit_filter *filter)
 
 int cgit_close_filter(struct cgit_filter *filter)
 {
 
 int cgit_close_filter(struct cgit_filter *filter)
 {

+       int exit_status;
+

        chk_non_negative(dup2(filter->old_stdout, STDOUT_FILENO),
                "Unable to restore STDOUT");
        close(filter->old_stdout);
        if (filter->pid < 0)
                return 0;
        chk_non_negative(dup2(filter->old_stdout, STDOUT_FILENO),
                "Unable to restore STDOUT");
        close(filter->old_stdout);
        if (filter->pid < 0)
                return 0;

-       waitpid(filter->pid, &filter->exitstatus, 0);
-       if (WIFEXITED(filter->exitstatus) && !WEXITSTATUS(filter->exitstatus))
+       waitpid(filter->pid, &exit_status, 0);
+       if (WIFEXITED(exit_status) && !WEXITSTATUS(exit_status))

                return 0;
        die("Subprocess %s exited abnormally", filter->cmd);
 }
                return 0;
        die("Subprocess %s exited abnormally", filter->cmd);
 }


@@ -459,14 +520,14 @@ int readfile(const char *path, char **buf, size_t *size)
        return (*size == st.st_size ? 0 : e);
 }
 
        return (*size == st.st_size ? 0 : e);
 }
 

-int is_token_char(char c)
+static int is_token_char(char c)

 {
        return isalnum(c) || c == '_';
 }
 
 /* Replace name with getenv(name), return pointer to zero-terminating char
  */
 {
        return isalnum(c) || c == '_';
 }
 
 /* Replace name with getenv(name), return pointer to zero-terminating char
  */

-char *expand_macro(char *name, int maxlength)
+static char *expand_macro(char *name, int maxlength)

 {
        char *value;
        int len;
 {
        char *value;
        int len;