ui-stats: cast pointer before checking for zero

[cgit.git] / ui-ssdiff.c

diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 71087799f5759bf48a0f45aea7ad8606c073c07a..d183d40501a2393a1db0c1a565c759bfdbc3ba06 100644 (file)
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -1,8 +1,8 @@
 #include "cgit.h"
+#include "ui-ssdiff.h"
 #include "html.h"
 #include "ui-shared.h"
 #include "ui-diff.h"
-#include "ui-ssdiff.h"
 
 extern int use_ssdiff;
 
@@ -18,7 +18,7 @@ struct deferred_lines {
 static struct deferred_lines *deferred_old, *deferred_old_last;
 static struct deferred_lines *deferred_new, *deferred_new_last;
 
-static void create_or_reset_lcs_table()
+static void create_or_reset_lcs_table(void)
 {
        int i;
 
@@ -138,9 +138,8 @@ static char *replace_tabs(char *line)
                        strcat(result, prev_buf);
                        break;
                } else {
-                       strcat(result, " ");
-                       strncat(result, spaces, 8 - (strlen(result) % 8));
                        strncat(result, prev_buf, cur_buf - prev_buf);
+                       strncat(result, spaces, 8 - (strlen(result) % 8));
                }
                prev_buf = cur_buf + 1;
        }
@@ -231,11 +230,13 @@ static void print_ssdiff_line(char *class,
                struct diff_filespec *old_file = cgit_get_current_old_file();
                char *lineno_str = fmt("n%d", old_line_no);
                char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str);
-               html("<td class='lineno'><a class='no' href='");
-               html(cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str));
-               htmlf("' id='%s' name='%s'>%s</a>", lineno_str, lineno_str, lineno_str + 1);
+               char *fileurl = cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str);
+               html("<td class='lineno'><a href='");
+               html(fileurl);
+               htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1);
                html("</td>");
                htmlf("<td class='%s'>", class);
+               free(fileurl);
        } else if (old_line)
                htmlf("<td class='lineno'></td><td class='%s'>", class);
        else
@@ -252,11 +253,13 @@ static void print_ssdiff_line(char *class,
                struct diff_filespec *new_file = cgit_get_current_new_file();
                char *lineno_str = fmt("n%d", new_line_no);
                char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str);
-               html("<td class='lineno'><a class='no' href='");
-               html(cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str));
-               htmlf("' id='%s' name='%s'>%s</a>", lineno_str, lineno_str, lineno_str + 1);
+               char *fileurl = cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str);
+               html("<td class='lineno'><a href='");
+               html(fileurl);
+               htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1);
                html("</td>");
                htmlf("<td class='%s'>", class);
+               free(fileurl);
        } else if (new_line)
                htmlf("<td class='lineno'></td><td class='%s'>", class);
        else
@@ -277,7 +280,7 @@ static void print_ssdiff_line(char *class,
                free(old_line);
 }
 
-static void print_deferred_old_lines()
+static void print_deferred_old_lines(void)
 {
        struct deferred_lines *iter_old, *tmp;
        iter_old = deferred_old;
@@ -290,7 +293,7 @@ static void print_deferred_old_lines()
        }
 }
 
-static void print_deferred_new_lines()
+static void print_deferred_new_lines(void)
 {
        struct deferred_lines *iter_new, *tmp;
        iter_new = deferred_new;
@@ -303,7 +306,7 @@ static void print_deferred_new_lines()
        }
 }
 
-static void print_deferred_changed_lines()
+static void print_deferred_changed_lines(void)
 {
        struct deferred_lines *iter_old, *iter_new, *tmp;
        int n_old_lines = calc_deferred_lines(deferred_old);
@@ -338,7 +341,7 @@ static void print_deferred_changed_lines()
        }
 }
 
-void cgit_ssdiff_print_deferred_lines()
+void cgit_ssdiff_print_deferred_lines(void)
 {
        if (!deferred_old && !deferred_new)
                return;
@@ -389,7 +392,7 @@ void cgit_ssdiff_line_cb(char *line, int len)
        line[len - 1] = c;
 }
 
-void cgit_ssdiff_header_begin()
+void cgit_ssdiff_header_begin(void)
 {
        current_old_line = -1;
        current_new_line = -1;
@@ -397,12 +400,12 @@ void cgit_ssdiff_header_begin()
        html("<tr><td class='head' colspan='4'>");
 }
 
-void cgit_ssdiff_header_end()
+void cgit_ssdiff_header_end(void)
 {
        html("</td><tr>");
 }
 
-void cgit_ssdiff_footer()
+void cgit_ssdiff_footer(void)
 {
        if (deferred_old || deferred_new)
                cgit_ssdiff_print_deferred_lines();