Merge branch 'lh/clone'

[cgit.git] / cache.c

diff --git a/cache.c b/cache.c
index a99610982999fef1cf1c116353912ad2d08b854f..57068a11faa727f339777ec0ed0bc0e4d3b7a684 100644 (file)
--- a/cache.c
+++ b/cache.c
@@ -81,16 +81,19 @@ static int close_slot(struct cache_slot *slot)
 /* Print the content of the active cache slot (but skip the key). */
 static int print_slot(struct cache_slot *slot)
 {
-       ssize_t i;
+       ssize_t i, j;
 
        i = lseek(slot->cache_fd, slot->keylen + 1, SEEK_SET);
        if (i != slot->keylen + 1)
                return errno;
 
-       while((i = xread(slot->cache_fd, slot->buf, sizeof(slot->buf))) > 0)
-               i = xwrite(STDOUT_FILENO, slot->buf, i);
+       do {
+               i = j = xread(slot->cache_fd, slot->buf, sizeof(slot->buf));
+               if (i > 0)
+                       j = xwrite(STDOUT_FILENO, slot->buf, i);
+       } while (i > 0 && j == i);
 
-       if (i < 0)
+       if (i < 0 || j != i)
                return errno;
        else
                return 0;
@@ -252,9 +255,14 @@ static int process_slot(struct cache_slot *slot)
                                }
                        }
                }
-               print_slot(slot);
+               if ((err = print_slot(slot)) != 0) {
+                       cache_log("[cgit] error printing cache %s: %s (%d)\n",
+                                 slot->cache_name,
+                                 strerror(err),
+                                 err);
+               }
                close_slot(slot);
-               return 0;
+               return err;
        }
 
        /* If the cache slot does not exist (or its key doesn't match the
@@ -289,7 +297,12 @@ static int process_slot(struct cache_slot *slot)
        // the lock file.
        slot->cache_fd = slot->lock_fd;
        unlock_slot(slot, 1);
-       err = print_slot(slot);
+       if ((err = print_slot(slot)) != 0) {
+               cache_log("[cgit] error printing cache %s: %s (%d)\n",
+                         slot->cache_name,
+                         strerror(err),
+                         err);
+       }
        close_slot(slot);
        return err;
 }
@@ -403,7 +416,7 @@ int cache_ls(const char *path)
                                  fullname, strerror(err), err);
                        continue;
                }
-               printf("%s %s %10lld %s\n",
+               printf("%s %s %10zd %s\n",
                       name,
                       sprintftime("%Y-%m-%d %H:%M:%S",
                                   slot.cache_st.st_mtime),