ui-shared: do not allow negative minutes

[cgit.git] / ui-summary.c

diff --git a/ui-summary.c b/ui-summary.c
index f965b320b4033a01aca83adac5f3b6f91dfeab7a..ddd8f1b3392a329013cb7ee7d8c652e2847f4d22 100644 (file)
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -1,7 +1,6 @@
 /* ui-summary.c: functions for generating repo summary page
  *
- * Copyright (C) 2006 Lars Hjemli
- * Copyright (C) 2010 Jason A. Donenfeld <Jason@zx2c4.com>
+ * Copyright (C) 2006-2014 cgit Development Team <cgit@lists.zx2c4.com>
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
@@ -13,6 +12,7 @@
 #include "ui-log.h"
 #include "ui-refs.h"
 #include "ui-blob.h"
+#include <libgen.h>
 
 static void print_url(char *base, char *suffix)
 {
@@ -95,57 +95,70 @@ void cgit_print_summary()
        html("</table>");
 }
 
-void cgit_print_repo_readme(char *path)
+/* The caller must free the return value. */
+static char* append_readme_path(const char *filename, const char *ref, const char *path)
 {
-       char *slash, *tmp, *colon, *ref;
+       char *file, *base_dir, *full_path, *resolved_base = NULL, *resolved_full = NULL;
+       /* If a subpath is specified for the about page, make it relative
+        * to the directory containing the configured readme. */
+
+       file = xstrdup(filename);
+       base_dir = dirname(file);
+       if (!strcmp(base_dir, ".") || !strcmp(base_dir, "..")) {
+               if (!ref) {
+                       free(file);
+                       return NULL;
+               }
+               full_path = xstrdup(path);
+       } else
+               full_path = fmtalloc("%s/%s", base_dir, path);
+       
+       if (!ref) {
+               resolved_base = realpath(base_dir, NULL);
+               resolved_full = realpath(full_path, NULL);
+               if (!resolved_base || !resolved_full || prefixcmp(resolved_full, resolved_base)) {
+                       free(full_path);
+                       full_path = NULL;
+               }
+       }
 
-       if (!ctx.repo->readme || !(*ctx.repo->readme))
-               return;
+       free(file);
+       free(resolved_base);
+       free(resolved_full);
 
-       ref = NULL;
+       return full_path;
+}
 
-       /* Check if the readme is tracked in the git repo. */
-       colon = strchr(ctx.repo->readme, ':');
-       if (colon && strlen(colon) > 1) {
-               *colon = '\0';
-               ref = ctx.repo->readme;
-               ctx.repo->readme = colon + 1;
-               if (!(*ctx.repo->readme))
-                       return;
-       }
+void cgit_print_repo_readme(char *path)
+{
+       char *filename, *ref;
+       int free_filename = 0;
 
-       /* Prepend repo path to relative readme path unless tracked. */
-       if (!ref && *ctx.repo->readme != '/')
-               ctx.repo->readme = fmtalloc("%s/%s", ctx.repo->path,
-                                               ctx.repo->readme);
+       if (ctx.repo->readme.nr == 0)
+               return;
+       
+       filename = ctx.repo->readme.items[0].string;
+       ref = ctx.repo->readme.items[0].util;
 
-       /* If a subpath is specified for the about page, make it relative
-        * to the directory containing the configured readme.
-        */
        if (path) {
-               slash = strrchr(ctx.repo->readme, '/');
-               if (!slash) {
-                       if (!colon)
-                               return;
-                       slash = colon;
-               }
-               tmp = xmalloc(slash - ctx.repo->readme + 1 + strlen(path) + 1);
-               strncpy(tmp, ctx.repo->readme, slash - ctx.repo->readme + 1);
-               strcpy(tmp + (slash - ctx.repo->readme + 1), path);
-       } else
-               tmp = ctx.repo->readme;
+               free_filename = 1;
+               filename = append_readme_path(filename, ref, path);
+               if (!filename)
+                       return;
+       }
 
        /* Print the calculated readme, either from the git repo or from the
         * filesystem, while applying the about-filter.
         */
        html("<div id='summary'>");
-       if (ctx.repo->about_filter)
-               cgit_open_filter(ctx.repo->about_filter);
+       cgit_open_filter(ctx.repo->about_filter, filename);
        if (ref)
-               cgit_print_file(tmp, ref);
+               cgit_print_file(filename, ref, 1);
        else
-               html_include(tmp);
-       if (ctx.repo->about_filter)
-               cgit_close_filter(ctx.repo->about_filter);
+               html_include(filename);
+       cgit_close_filter(ctx.repo->about_filter);
+
        html("</div>");
+       if (free_filename)
+               free(filename);
 }