]> git.cameronkatri.com Git - cgit.git/commit
global: use proper accessors for maybe_tree
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 13 Mar 2020 02:52:35 +0000 (20:52 -0600)
committerJason A. Donenfeld <Jason@zx2c4.com>
Fri, 13 Mar 2020 23:48:34 +0000 (17:48 -0600)
commit6a8d6d4b5021af6c90ca0da806691987df449469
treedb4984608a96ce279e25c580895d4084d2b1e24f
parent892ba8c3cc0617d2087a2337d8c6e71524d7b49c
global: use proper accessors for maybe_tree

A previous commit changed ->tree to ->maybe_tree throughout, which may
have worked at the time, but wasn't safe, because maybe_tree is loaded
lazily. This manifested itself in crashes when using the "follow" log
feature. The proper fix is to use the correct contextual accessors
everytime we want access to maybe_tree. Thankfully, the commit.cocci
script takes care of creating mostly-correct patches that we could then
fix up, resulting in this commit here.

Fixes: 255b78f ("git: update to v2.18.0")
Reviewed-by: Christian Hesse <mail@eworm.de>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
ui-blame.c
ui-blob.c
ui-commit.c
ui-diff.c
ui-log.c
ui-plain.c
ui-tree.c