From: Christian Hesse Date: Tue, 28 Aug 2018 16:22:26 +0000 (+0200) Subject: ui-ssdiff: ban strncpy() X-Git-Tag: v1.2.2~24 X-Git-Url: https://git.cameronkatri.com/cgit.git/commitdiff_plain/0899eb644fab415e9a3b304f53da9da50aaf91aa ui-ssdiff: ban strncpy() Git upstream bans strncpy() with commit: banned.h: mark strncpy() as banned e488b7aba743d23b830d239dcc33d9ca0745a9ad Signed-off-by: Christian Hesse --- diff --git a/ui-ssdiff.c b/ui-ssdiff.c index 68c2044..a3dd059 100644 --- a/ui-ssdiff.c +++ b/ui-ssdiff.c @@ -103,8 +103,7 @@ static int line_from_hunk(char *line, char type) return 0; len = buf2 - buf1; buf2 = xmalloc(len + 1); - strncpy(buf2, buf1, len); - buf2[len] = '\0'; + strlcpy(buf2, buf1, len + 1); res = atoi(buf2); free(buf2); return res;