From: John Keeping <john@keeping.me.uk>
Date: Sun, 8 Mar 2015 16:32:17 +0000 (+0000)
Subject: Avoid signed bitfields
X-Git-Tag: v0.11.2~15
X-Git-Url: https://git.cameronkatri.com/cgit.git/commitdiff_plain/12d3d4c3edfcf177c56ca97e5a4b0c8301ca46aa?hp=e3d3fffdd447cdb4551549faae65bae5353a2cab

Avoid signed bitfields

Bitfields are only defined for unsigned types.

Detected by sparse.

Signed-off-by: John Keeping <john@keeping.me.uk>
---

diff --git a/ui-blob.c b/ui-blob.c
index a025bca..388a017 100644
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -14,8 +14,8 @@
 struct walk_tree_context {
 	const char *match_path;
 	unsigned char *matched_sha1;
-	int found_path:1;
-	int file_only:1;
+	unsigned int found_path:1;
+	unsigned int file_only:1;
 };
 
 static int walk_tree(const unsigned char *sha1, struct strbuf *base,
diff --git a/ui-diff.c b/ui-diff.c
index 8eff178..1cf2ce0 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -31,7 +31,7 @@ static struct fileinfo {
 	unsigned int removed;
 	unsigned long old_size;
 	unsigned long new_size;
-	int binary:1;
+	unsigned int binary:1;
 } *items;
 
 static int use_ssdiff = 0;