]> git.cameronkatri.com Git - mandoc.git/blobdiff - roff.c
Cleanup, no functional change:
[mandoc.git] / roff.c
diff --git a/roff.c b/roff.c
index ce481526e3b86996b8f4d3b9b75af4d244fed73e..d7b24d61a6f62a5f59e9d44fe1e84d4e2b8b08ad 100644 (file)
--- a/roff.c
+++ b/roff.c
@@ -1,7 +1,7 @@
-/*     $Id: roff.c,v 1.313 2017/06/17 22:43:14 schwarze Exp $ */
+/*     $Id: roff.c,v 1.346 2018/12/13 02:06:07 schwarze Exp $ */
 /*
  * Copyright (c) 2008-2012, 2014 Kristaps Dzonsons <kristaps@bsd.lv>
- * Copyright (c) 2010-2015, 2017 Ingo Schwarze <schwarze@openbsd.org>
+ * Copyright (c) 2010-2015, 2017, 2018 Ingo Schwarze <schwarze@openbsd.org>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
 #include <stdlib.h>
 #include <string.h>
 
-#include "mandoc.h"
 #include "mandoc_aux.h"
 #include "mandoc_ohash.h"
+#include "mandoc.h"
 #include "roff.h"
 #include "libmandoc.h"
 #include "roff_int.h"
 #include "libroff.h"
+#include "tbl_parse.h"
 
 /* Maximum number of string expansions per line, to break infinite loops. */
 #define        EXPAND_LIMIT    1000
 
+/* Types of definitions of macros and strings. */
+#define        ROFFDEF_USER    (1 << 1)  /* User-defined. */
+#define        ROFFDEF_PRE     (1 << 2)  /* Predefined. */
+#define        ROFFDEF_REN     (1 << 3)  /* Renamed standard macro. */
+#define        ROFFDEF_STD     (1 << 4)  /* mdoc(7) or man(7) macro. */
+#define        ROFFDEF_ANY     (ROFFDEF_USER | ROFFDEF_PRE | \
+                        ROFFDEF_REN | ROFFDEF_STD)
+#define        ROFFDEF_UNDEF   (1 << 5)  /* Completely undefined. */
+
 /* --- data types --------------------------------------------------------- */
 
 /*
@@ -64,6 +74,7 @@ struct        roffkv {
 struct roffreg {
        struct roffstr   key;
        int              val;
+       int              step;
        struct roffreg  *next;
 };
 
@@ -75,10 +86,21 @@ struct      roffreq {
        char             name[];
 };
 
+/*
+ * A macro processing context.
+ * More than one is needed when macro calls are nested.
+ */
+struct mctx {
+       char            **argv;
+       int              argc;
+       int              argsz;
+};
+
 struct roff {
        struct mparse   *parse; /* parse point */
        struct roff_man *man; /* mdoc or man parser */
        struct roffnode *last; /* leaf of stack */
+       struct mctx     *mstack; /* stack of macro contexts */
        int             *rstack; /* stack of inverted `ie' values */
        struct ohash    *reqtab; /* request lookup table */
        struct roffreg  *regtab; /* number registers */
@@ -90,15 +112,15 @@ struct     roff {
        struct tbl_node *first_tbl; /* first table parsed */
        struct tbl_node *last_tbl; /* last table parsed */
        struct tbl_node *tbl; /* current table being parsed */
-       struct eqn_node *last_eqn; /* last equation parsed */
-       struct eqn_node *first_eqn; /* first equation parsed */
-       struct eqn_node *eqn; /* current equation being parsed */
+       struct eqn_node *last_eqn; /* equation parser */
+       struct eqn_node *eqn; /* active equation parser */
        int              eqn_inline; /* current equation is inline */
        int              options; /* parse options */
+       int              mstacksz; /* current size of mstack */
+       int              mstackpos; /* position in mstack */
        int              rstacksz; /* current size limit of rstack */
        int              rstackpos; /* position in rstack */
        int              format; /* current file in mdoc or man format */
-       int              argc; /* number of args of the last macro */
        char             control; /* control character */
        char             escape; /* escape character */
 };
@@ -122,7 +144,7 @@ struct      roffnode {
                         int pos, /* current pos in buffer */ \
                         int *offs /* reset offset of buffer data */
 
-typedef        enum rofferr (*roffproc)(ROFF_ARGS);
+typedef        int (*roffproc)(ROFF_ARGS);
 
 struct roffmac {
        roffproc         proc; /* process new macro */
@@ -142,25 +164,27 @@ struct    predef {
 
 /* --- function prototypes ------------------------------------------------ */
 
-static void             roffnode_cleanscope(struct roff *);
-static void             roffnode_pop(struct roff *);
+static int              roffnode_cleanscope(struct roff *);
+static int              roffnode_pop(struct roff *);
 static void             roffnode_push(struct roff *, enum roff_tok,
                                const char *, int, int);
-static enum rofferr     roff_als(ROFF_ARGS);
-static enum rofferr     roff_block(ROFF_ARGS);
-static enum rofferr     roff_block_text(ROFF_ARGS);
-static enum rofferr     roff_block_sub(ROFF_ARGS);
-static enum rofferr     roff_br(ROFF_ARGS);
-static enum rofferr     roff_cblock(ROFF_ARGS);
-static enum rofferr     roff_cc(ROFF_ARGS);
-static void             roff_ccond(struct roff *, int, int);
-static enum rofferr     roff_cond(ROFF_ARGS);
-static enum rofferr     roff_cond_text(ROFF_ARGS);
-static enum rofferr     roff_cond_sub(ROFF_ARGS);
-static enum rofferr     roff_ds(ROFF_ARGS);
-static enum rofferr     roff_ec(ROFF_ARGS);
-static enum rofferr     roff_eo(ROFF_ARGS);
-static enum rofferr     roff_eqndelim(struct roff *, struct buf *, int);
+static void             roff_addtbl(struct roff_man *, int, struct tbl_node *);
+static int              roff_als(ROFF_ARGS);
+static int              roff_block(ROFF_ARGS);
+static int              roff_block_text(ROFF_ARGS);
+static int              roff_block_sub(ROFF_ARGS);
+static int              roff_br(ROFF_ARGS);
+static int              roff_cblock(ROFF_ARGS);
+static int              roff_cc(ROFF_ARGS);
+static int              roff_ccond(struct roff *, int, int);
+static int              roff_char(ROFF_ARGS);
+static int              roff_cond(ROFF_ARGS);
+static int              roff_cond_text(ROFF_ARGS);
+static int              roff_cond_sub(ROFF_ARGS);
+static int              roff_ds(ROFF_ARGS);
+static int              roff_ec(ROFF_ARGS);
+static int              roff_eo(ROFF_ARGS);
+static int              roff_eqndelim(struct roff *, struct buf *, int);
 static int              roff_evalcond(struct roff *r, int, char *, int *);
 static int              roff_evalnum(struct roff *, int,
                                const char *, int *, int *, int);
@@ -173,48 +197,50 @@ static    void             roff_freestr(struct roffkv *);
 static size_t           roff_getname(struct roff *, char **, int, int);
 static int              roff_getnum(const char *, int *, int *, int);
 static int              roff_getop(const char *, int *, char *);
-static int              roff_getregn(const struct roff *,
-                               const char *, size_t);
+static int              roff_getregn(struct roff *,
+                               const char *, size_t, char);
 static int              roff_getregro(const struct roff *,
                                const char *name);
-static const char      *roff_getrenn(const struct roff *,
-                               const char *, size_t);
-static const char      *roff_getstrn(const struct roff *,
-                               const char *, size_t);
+static const char      *roff_getstrn(struct roff *,
+                               const char *, size_t, int *);
 static int              roff_hasregn(const struct roff *,
                                const char *, size_t);
-static enum rofferr     roff_insec(ROFF_ARGS);
-static enum rofferr     roff_it(ROFF_ARGS);
-static enum rofferr     roff_line_ignore(ROFF_ARGS);
+static int              roff_insec(ROFF_ARGS);
+static int              roff_it(ROFF_ARGS);
+static int              roff_line_ignore(ROFF_ARGS);
 static void             roff_man_alloc1(struct roff_man *);
 static void             roff_man_free1(struct roff_man *);
-static enum rofferr     roff_manyarg(ROFF_ARGS);
-static enum rofferr     roff_nr(ROFF_ARGS);
-static enum rofferr     roff_onearg(ROFF_ARGS);
+static int              roff_manyarg(ROFF_ARGS);
+static int              roff_nop(ROFF_ARGS);
+static int              roff_nr(ROFF_ARGS);
+static int              roff_onearg(ROFF_ARGS);
 static enum roff_tok    roff_parse(struct roff *, char *, int *,
                                int, int);
-static enum rofferr     roff_parsetext(struct roff *, struct buf *,
+static int              roff_parsetext(struct roff *, struct buf *,
                                int, int *);
-static enum rofferr     roff_renamed(ROFF_ARGS);
-static enum rofferr     roff_res(struct roff *, struct buf *, int, int);
-static enum rofferr     roff_rm(ROFF_ARGS);
-static enum rofferr     roff_rn(ROFF_ARGS);
-static enum rofferr     roff_rr(ROFF_ARGS);
+static int              roff_renamed(ROFF_ARGS);
+static int              roff_res(struct roff *, struct buf *, int, int);
+static int              roff_return(ROFF_ARGS);
+static int              roff_rm(ROFF_ARGS);
+static int              roff_rn(ROFF_ARGS);
+static int              roff_rr(ROFF_ARGS);
+static void             roff_setregn(struct roff *, const char *,
+                               size_t, int, char, int);
 static void             roff_setstr(struct roff *,
                                const char *, const char *, int);
 static void             roff_setstrn(struct roffkv **, const char *,
                                size_t, const char *, size_t, int);
-static enum rofferr     roff_so(ROFF_ARGS);
-static enum rofferr     roff_tr(ROFF_ARGS);
-static enum rofferr     roff_Dd(ROFF_ARGS);
-static enum rofferr     roff_TH(ROFF_ARGS);
-static enum rofferr     roff_TE(ROFF_ARGS);
-static enum rofferr     roff_TS(ROFF_ARGS);
-static enum rofferr     roff_EQ(ROFF_ARGS);
-static enum rofferr     roff_EN(ROFF_ARGS);
-static enum rofferr     roff_T_(ROFF_ARGS);
-static enum rofferr     roff_unsupp(ROFF_ARGS);
-static enum rofferr     roff_userdef(ROFF_ARGS);
+static int              roff_shift(ROFF_ARGS);
+static int              roff_so(ROFF_ARGS);
+static int              roff_tr(ROFF_ARGS);
+static int              roff_Dd(ROFF_ARGS);
+static int              roff_TE(ROFF_ARGS);
+static int              roff_TS(ROFF_ARGS);
+static int              roff_EQ(ROFF_ARGS);
+static int              roff_EN(ROFF_ARGS);
+static int              roff_T_(ROFF_ARGS);
+static int              roff_unsupp(ROFF_ARGS);
+static int              roff_userdef(ROFF_ARGS);
 
 /* --- constant data ------------------------------------------------------ */
 
@@ -317,6 +343,7 @@ const char *__roff_name[MAN_MAX + 1] = {
        "Dx",           "%Q",           "%U",           "Ta",
        NULL,
        "TH",           "SH",           "SS",           "TP",
+       "TQ",
        "LP",           "PP",           "P",            "IP",
        "HP",           "SM",           "SB",           "BI",
        "IB",           "BR",           "RB",           "R",
@@ -324,8 +351,9 @@ const char *__roff_name[MAN_MAX + 1] = {
        "nf",           "fi",
        "RE",           "RS",           "DT",           "UC",
        "PD",           "AT",           "in",
-       "OP",           "EX",           "EE",           "UR",
-       "UE",           NULL
+       "SY",           "YS",           "OP",
+       "EX",           "EE",           "UR",
+       "UE",           "MT",           "ME",           NULL
 };
 const  char *const *roff_name = __roff_name;
 
@@ -371,7 +399,7 @@ static      struct roffmac   roffs[TOKEN_NONE] = {
        { roff_insec, NULL, NULL, 0 },  /* cf */
        { roff_line_ignore, NULL, NULL, 0 },  /* cflags */
        { roff_line_ignore, NULL, NULL, 0 },  /* ch */
-       { roff_unsupp, NULL, NULL, 0 },  /* char */
+       { roff_char, NULL, NULL, 0 },  /* char */
        { roff_unsupp, NULL, NULL, 0 },  /* chop */
        { roff_line_ignore, NULL, NULL, 0 },  /* class */
        { roff_insec, NULL, NULL, 0 },  /* close */
@@ -481,7 +509,7 @@ static      struct roffmac   roffs[TOKEN_NONE] = {
        { roff_line_ignore, NULL, NULL, 0 },  /* nhychar */
        { roff_unsupp, NULL, NULL, 0 },  /* nm */
        { roff_unsupp, NULL, NULL, 0 },  /* nn */
-       { roff_unsupp, NULL, NULL, 0 },  /* nop */
+       { roff_nop, NULL, NULL, 0 },  /* nop */
        { roff_nr, NULL, NULL, 0 },  /* nr */
        { roff_unsupp, NULL, NULL, 0 },  /* nrf */
        { roff_line_ignore, NULL, NULL, 0 },  /* nroff */
@@ -510,7 +538,7 @@ static      struct roffmac   roffs[TOKEN_NONE] = {
        { roff_unsupp, NULL, NULL, 0 },  /* rchar */
        { roff_line_ignore, NULL, NULL, 0 },  /* rd */
        { roff_line_ignore, NULL, NULL, 0 },  /* recursionlimit */
-       { roff_unsupp, NULL, NULL, 0 },  /* return */
+       { roff_return, NULL, NULL, 0 },  /* return */
        { roff_unsupp, NULL, NULL, 0 },  /* rfschar */
        { roff_line_ignore, NULL, NULL, 0 },  /* rhang */
        { roff_rm, NULL, NULL, 0 },  /* rm */
@@ -522,7 +550,7 @@ static      struct roffmac   roffs[TOKEN_NONE] = {
        { roff_unsupp, NULL, NULL, 0 },  /* schar */
        { roff_line_ignore, NULL, NULL, 0 },  /* sentchar */
        { roff_line_ignore, NULL, NULL, 0 },  /* shc */
-       { roff_unsupp, NULL, NULL, 0 },  /* shift */
+       { roff_shift, NULL, NULL, 0 },  /* shift */
        { roff_line_ignore, NULL, NULL, 0 },  /* sizes */
        { roff_so, NULL, NULL, 0 },  /* so */
        { roff_line_ignore, NULL, NULL, 0 },  /* spacewidth */
@@ -536,7 +564,7 @@ static      struct roffmac   roffs[TOKEN_NONE] = {
        { roff_T_, NULL, NULL, 0 },  /* T& */
        { roff_unsupp, NULL, NULL, 0 },  /* tc */
        { roff_TE, NULL, NULL, 0 },  /* TE */
-       { roff_TH, NULL, NULL, 0 },  /* TH */
+       { roff_Dd, NULL, NULL, 0 },  /* TH */
        { roff_line_ignore, NULL, NULL, 0 },  /* tkf */
        { roff_unsupp, NULL, NULL, 0 },  /* tl */
        { roff_line_ignore, NULL, NULL, 0 },  /* tm */
@@ -564,7 +592,7 @@ static      struct roffmac   roffs[TOKEN_NONE] = {
        { roff_line_ignore, NULL, NULL, 0 },  /* watchlength */
        { roff_line_ignore, NULL, NULL, 0 },  /* watchn */
        { roff_unsupp, NULL, NULL, 0 },  /* wh */
-       { roff_unsupp, NULL, NULL, 0 },  /* while */
+       { roff_cond, roff_cond_text, roff_cond_sub, ROFFMAC_STRUCT }, /*while*/
        { roff_insec, NULL, NULL, 0 },  /* write */
        { roff_insec, NULL, NULL, 0 },  /* writec */
        { roff_insec, NULL, NULL, 0 },  /* writem */
@@ -574,39 +602,6 @@ static     struct roffmac   roffs[TOKEN_NONE] = {
        { roff_userdef, NULL, NULL, 0 }
 };
 
-/* not currently implemented: Ds em Eq LP Me PP pp Or Rd Sf SH */
-const  char *const __mdoc_reserved[] = {
-       "Ac", "Ad", "An", "Ao", "Ap", "Aq", "Ar", "At",
-       "Bc", "Bd", "Bf", "Bk", "Bl", "Bo", "Bq",
-       "Brc", "Bro", "Brq", "Bsx", "Bt", "Bx",
-       "Cd", "Cm", "Db", "Dc", "Dd", "Dl", "Do", "Dq",
-       "Dt", "Dv", "Dx", "D1",
-       "Ec", "Ed", "Ef", "Ek", "El", "Em",
-       "En", "Eo", "Er", "Es", "Ev", "Ex",
-       "Fa", "Fc", "Fd", "Fl", "Fn", "Fo", "Fr", "Ft", "Fx",
-       "Hf", "Ic", "In", "It", "Lb", "Li", "Lk", "Lp",
-       "Ms", "Mt", "Nd", "Nm", "No", "Ns", "Nx",
-       "Oc", "Oo", "Op", "Os", "Ot", "Ox",
-       "Pa", "Pc", "Pf", "Po", "Pp", "Pq",
-       "Qc", "Ql", "Qo", "Qq", "Re", "Rs", "Rv",
-       "Sc", "Sh", "Sm", "So", "Sq",
-       "Ss", "St", "Sx", "Sy",
-       "Ta", "Tn", "Ud", "Ux", "Va", "Vt", "Xc", "Xo", "Xr",
-       "%A", "%B", "%C", "%D", "%I", "%J", "%N", "%O",
-       "%P", "%Q", "%R", "%T", "%U", "%V",
-       NULL
-};
-
-/* not currently implemented: BT DE DS ME MT PT SY TQ YS */
-const  char *const __man_reserved[] = {
-       "AT", "B", "BI", "BR", "DT",
-       "EE", "EN", "EQ", "EX", "HP", "I", "IB", "IP", "IR",
-       "LP", "OP", "P", "PD", "PP",
-       "R", "RB", "RE", "RI", "RS", "SB", "SH", "SM", "SS",
-       "TE", "TH", "TP", "TS", "T&", "UC", "UE", "UR",
-       NULL
-};
-
 /* Array of injected predefined strings. */
 #define        PREDEFS_MAX      38
 static const struct predef predefs[PREDEFS_MAX] = {
@@ -681,18 +676,19 @@ roffhash_find(struct ohash *htab, const char *name, size_t sz)
  * Pop the current node off of the stack of roff instructions currently
  * pending.
  */
-static void
+static int
 roffnode_pop(struct roff *r)
 {
        struct roffnode *p;
+       int              inloop;
 
-       assert(r->last);
        p = r->last;
-
-       r->last = r->last->parent;
+       inloop = p->tok == ROFF_while;
+       r->last = p->parent;
        free(p->name);
        free(p->end);
        free(p);
+       return inloop;
 }
 
 /*
@@ -722,21 +718,17 @@ roffnode_push(struct roff *r, enum roff_tok tok, const char *name,
 static void
 roff_free1(struct roff *r)
 {
-       struct tbl_node *tbl;
-       struct eqn_node *e;
        int              i;
 
-       while (NULL != (tbl = r->first_tbl)) {
-               r->first_tbl = tbl->next;
-               tbl_free(tbl);
-       }
+       tbl_free(r->first_tbl);
        r->first_tbl = r->last_tbl = r->tbl = NULL;
 
-       while (NULL != (e = r->first_eqn)) {
-               r->first_eqn = e->next;
-               eqn_free(e);
-       }
-       r->first_eqn = r->last_eqn = r->eqn = NULL;
+       if (r->last_eqn != NULL)
+               eqn_free(r->last_eqn);
+       r->last_eqn = r->eqn = NULL;
+
+       while (r->mstackpos >= 0)
+               roff_userret(r);
 
        while (r->last)
                roffnode_pop(r);
@@ -777,7 +769,12 @@ roff_reset(struct roff *r)
 void
 roff_free(struct roff *r)
 {
+       int              i;
+
        roff_free1(r);
+       for (i = 0; i < r->mstacksz; i++)
+               free(r->mstack[i].argv);
+       free(r->mstack);
        roffhash_free(r->reqtab);
        free(r);
 }
@@ -789,9 +786,10 @@ roff_alloc(struct mparse *parse, int options)
 
        r = mandoc_calloc(1, sizeof(struct roff));
        r->parse = parse;
-       r->reqtab = roffhash_alloc(0, ROFF_USERDEF);
+       r->reqtab = roffhash_alloc(0, ROFF_RENAMED);
        r->options = options;
        r->format = options & (MPARSE_MDOC | MPARSE_MAN);
+       r->mstackpos = -1;
        r->rstackpos = -1;
        r->escape = '\\';
        return r;
@@ -847,14 +845,14 @@ roff_man_free(struct roff_man *man)
 
 struct roff_man *
 roff_man_alloc(struct roff *roff, struct mparse *parse,
-       const char *defos, int quick)
+       const char *os_s, int quick)
 {
        struct roff_man *man;
 
        man = mandoc_calloc(1, sizeof(*man));
        man->parse = parse;
        man->roff = roff;
-       man->defos = defos;
+       man->os_s = os_s;
        man->quick = quick;
        roff_man_alloc1(man);
        roff->man = man;
@@ -1011,31 +1009,21 @@ roff_body_alloc(struct roff_man *man, int line, int pos, int tok)
        return n;
 }
 
-void
-roff_addeqn(struct roff_man *man, const struct eqn *eqn)
-{
-       struct roff_node        *n;
-
-       n = roff_node_alloc(man, eqn->ln, eqn->pos, ROFFT_EQN, TOKEN_NONE);
-       n->eqn = eqn;
-       if (eqn->ln > man->last->line)
-               n->flags |= NODE_LINE;
-       roff_node_append(man, n);
-       man->next = ROFF_NEXT_SIBLING;
-}
-
-void
-roff_addtbl(struct roff_man *man, const struct tbl_span *tbl)
+static void
+roff_addtbl(struct roff_man *man, int line, struct tbl_node *tbl)
 {
        struct roff_node        *n;
+       struct tbl_span         *span;
 
        if (man->macroset == MACROSET_MAN)
                man_breakscope(man, ROFF_TS);
-       n = roff_node_alloc(man, tbl->line, 0, ROFFT_TBL, TOKEN_NONE);
-       n->span = tbl;
-       roff_node_append(man, n);
-       n->flags |= NODE_VALID | NODE_ENDED;
-       man->next = ROFF_NEXT_SIBLING;
+       while ((span = tbl_span(tbl)) != NULL) {
+               n = roff_node_alloc(man, line, 0, ROFFT_TBL, TOKEN_NONE);
+               n->span = span;
+               roff_node_append(man, n);
+               n->flags |= NODE_VALID | NODE_ENDED;
+               man->next = ROFF_NEXT_SIBLING;
+       }
 }
 
 void
@@ -1075,6 +1063,14 @@ roff_node_unlink(struct roff_man *man, struct roff_node *n)
                man->first = NULL;
 }
 
+void
+roff_node_relink(struct roff_man *man, struct roff_node *n)
+{
+       roff_node_unlink(man, n);
+       n->prev = n->next = NULL;
+       roff_node_append(man, n);
+}
+
 void
 roff_node_free(struct roff_node *n)
 {
@@ -1083,6 +1079,8 @@ roff_node_free(struct roff_node *n)
                mdoc_argv_free(n->args);
        if (n->type == ROFFT_BLOCK || n->type == ROFFT_ELEM)
                free(n->norm);
+       if (n->eqn != NULL)
+               eqn_box_free(n->eqn);
        free(n->string);
        free(n);
 }
@@ -1153,25 +1151,33 @@ deroff(char **dest, const struct roff_node *n)
  * used in numerical expressions and conditional requests.
  * Also check the syntax of the remaining escape sequences.
  */
-static enum rofferr
+static int
 roff_res(struct roff *r, struct buf *buf, int ln, int pos)
 {
+       struct mctx     *ctx;   /* current macro call context */
        char             ubuf[24]; /* buffer to print the number */
+       struct roff_node *n;    /* used for header comments */
        const char      *start; /* start of the string to process */
        char            *stesc; /* start of an escape sequence ('\\') */
+       char            *ep;    /* end of comment string */
        const char      *stnam; /* start of the name, after "[(*" */
        const char      *cp;    /* end of the name, e.g. before ']' */
        const char      *res;   /* the string to be substituted */
        char            *nbuf;  /* new buffer to copy buf->buf to */
        size_t           maxl;  /* expected length of the escape name */
        size_t           naml;  /* actual length of the escape name */
+       size_t           asz;   /* length of the replacement */
+       size_t           rsz;   /* length of the rest of the string */
        enum mandoc_esc  esc;   /* type of the escape sequence */
-       enum mdoc_os     os_e;  /* kind of RCS id seen */
        int              inaml; /* length returned from mandoc_escape() */
        int              expand_count;  /* to avoid infinite loops */
        int              npos;  /* position in numeric expression */
        int              arg_complete; /* argument not interrupted by eol */
+       int              quote_args; /* true for \\$@, false for \\$* */
        int              done;  /* no more input available */
+       int              deftype; /* type of definition to paste */
+       int              rcsid; /* kind of RCS id seen */
+       char             sign;  /* increment number register */
        char             term;  /* character terminating the escape */
 
        /* Search forward for comments. */
@@ -1187,29 +1193,63 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
 
                /* Comment found, look for RCS id. */
 
+               rcsid = 0;
                if ((cp = strstr(stesc, "$" "OpenBSD")) != NULL) {
-                       os_e = MDOC_OS_OPENBSD;
+                       rcsid = 1 << MANDOC_OS_OPENBSD;
                        cp += 8;
                } else if ((cp = strstr(stesc, "$" "NetBSD")) != NULL) {
-                       os_e = MDOC_OS_NETBSD;
+                       rcsid = 1 << MANDOC_OS_NETBSD;
                        cp += 7;
                }
                if (cp != NULL &&
                    isalnum((unsigned char)*cp) == 0 &&
-                   strchr(cp, '$') != NULL)
-                       r->man->meta.rcsids |= 1 << os_e;
+                   strchr(cp, '$') != NULL) {
+                       if (r->man->meta.rcsids & rcsid)
+                               mandoc_msg(MANDOCERR_RCS_REP, r->parse,
+                                   ln, stesc + 1 - buf->buf, stesc + 1);
+                       r->man->meta.rcsids |= rcsid;
+               }
 
                /* Handle trailing whitespace. */
 
-               cp = strchr(stesc--, '\0') - 1;
-               if (*cp == '\n') {
+               ep = strchr(stesc--, '\0') - 1;
+               if (*ep == '\n') {
                        done = 1;
-                       cp--;
+                       ep--;
                }
-               if (*cp == ' ' || *cp == '\t')
+               if (*ep == ' ' || *ep == '\t')
                        mandoc_msg(MANDOCERR_SPACE_EOL, r->parse,
-                           ln, cp - buf->buf, NULL);
-               while (stesc > start && stesc[-1] == ' ')
+                           ln, ep - buf->buf, NULL);
+
+               /*
+                * Save comments preceding the title macro
+                * in the syntax tree.
+                */
+
+               if (r->format == 0) {
+                       while (*ep == ' ' || *ep == '\t')
+                               ep--;
+                       ep[1] = '\0';
+                       n = roff_node_alloc(r->man,
+                           ln, stesc + 1 - buf->buf,
+                           ROFFT_COMMENT, TOKEN_NONE);
+                       n->string = mandoc_strdup(stesc + 2);
+                       roff_node_append(r->man, n);
+                       n->flags |= NODE_VALID | NODE_ENDED;
+                       r->man->next = ROFF_NEXT_SIBLING;
+               }
+
+               /* Line continuation with comment. */
+
+               if (stesc[1] == '#') {
+                       *stesc = '\0';
+                       return ROFF_IGN | ROFF_APPEND;
+               }
+
+               /* Discard normal comments. */
+
+               while (stesc > start && stesc[-1] == ' ' &&
+                   (stesc == start + 1 || stesc[-2] != '\\'))
                        stesc--;
                *stesc = '\0';
                break;
@@ -1261,7 +1301,7 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
                        if (done)
                                continue;
                        else
-                               return ROFF_APPEND;
+                               return ROFF_IGN | ROFF_APPEND;
                }
 
                /* Decide whether to expand or to check only. */
@@ -1270,6 +1310,7 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
                cp = stesc + 1;
                switch (*cp) {
                case '*':
+               case '$':
                        res = NULL;
                        break;
                case 'B':
@@ -1277,6 +1318,9 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
                        term = cp[1];
                        /* FALLTHROUGH */
                case 'n':
+                       sign = cp[1];
+                       if (sign == '+' || sign == '-')
+                               cp++;
                        res = ubuf;
                        break;
                default:
@@ -1365,9 +1409,80 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
 
                switch (stesc[1]) {
                case '*':
-                       if (arg_complete)
-                               res = roff_getstrn(r, stnam, naml);
+                       if (arg_complete) {
+                               deftype = ROFFDEF_USER | ROFFDEF_PRE;
+                               res = roff_getstrn(r, stnam, naml, &deftype);
+
+                               /*
+                                * If not overriden, let \*(.T
+                                * through to the formatters.
+                                */
+
+                               if (res == NULL && naml == 2 &&
+                                   stnam[0] == '.' && stnam[1] == 'T') {
+                                       roff_setstrn(&r->strtab,
+                                           ".T", 2, NULL, 0, 0);
+                                       stesc--;
+                                       continue;
+                               }
+                       }
                        break;
+               case '$':
+                       if (r->mstackpos < 0) {
+                               mandoc_vmsg(MANDOCERR_ARG_UNDEF,
+                                   r->parse, ln, (int)(stesc - buf->buf),
+                                   "%.3s", stesc);
+                               break;
+                       }
+                       ctx = r->mstack + r->mstackpos;
+                       npos = stesc[2] - '1';
+                       if (npos >= 0 && npos <= 8) {
+                               res = npos < ctx->argc ?
+                                   ctx->argv[npos] : "";
+                               break;
+                       }
+                       if (stesc[2] == '*')
+                               quote_args = 0;
+                       else if (stesc[2] == '@')
+                               quote_args = 1;
+                       else {
+                               mandoc_vmsg(MANDOCERR_ARG_NONUM,
+                                   r->parse, ln, (int)(stesc - buf->buf),
+                                   "%.3s", stesc);
+                               break;
+                       }
+                       asz = 0;
+                       for (npos = 0; npos < ctx->argc; npos++) {
+                               if (npos)
+                                       asz++;  /* blank */
+                               if (quote_args)
+                                       asz += 2;  /* quotes */
+                               asz += strlen(ctx->argv[npos]);
+                       }
+                       if (asz != 3) {
+                               rsz = buf->sz - (stesc - buf->buf) - 3;
+                               if (asz < 3)
+                                       memmove(stesc + asz, stesc + 3, rsz);
+                               buf->sz += asz - 3;
+                               nbuf = mandoc_realloc(buf->buf, buf->sz);
+                               start = nbuf + pos;
+                               stesc = nbuf + (stesc - buf->buf);
+                               buf->buf = nbuf;
+                               if (asz > 3)
+                                       memmove(stesc + asz, stesc + 3, rsz);
+                       }
+                       for (npos = 0; npos < ctx->argc; npos++) {
+                               if (npos)
+                                       *stesc++ = ' ';
+                               if (quote_args)
+                                       *stesc++ = '"';
+                               cp = ctx->argv[npos];
+                               while (*cp != '\0')
+                                       *stesc++ = *cp++;
+                               if (quote_args)
+                                       *stesc++ = '"';
+                       }
+                       continue;
                case 'B':
                        npos = 0;
                        ubuf[0] = arg_complete &&
@@ -1379,7 +1494,7 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
                case 'n':
                        if (arg_complete)
                                (void)snprintf(ubuf, sizeof(ubuf), "%d",
-                                   roff_getregn(r, stnam, naml));
+                                   roff_getregn(r, stnam, naml, sign));
                        else
                                ubuf[0] = '\0';
                        break;
@@ -1391,9 +1506,10 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
                }
 
                if (res == NULL) {
-                       mandoc_vmsg(MANDOCERR_STR_UNDEF,
-                           r->parse, ln, (int)(stesc - buf->buf),
-                           "%.*s", (int)naml, stnam);
+                       if (stesc[1] == '*')
+                               mandoc_vmsg(MANDOCERR_STR_UNDEF,
+                                   r->parse, ln, (int)(stesc - buf->buf),
+                                   "%.*s", (int)naml, stnam);
                        res = "";
                } else if (buf->sz + strlen(res) > SHRT_MAX) {
                        mandoc_msg(MANDOCERR_ROFFLOOP, r->parse,
@@ -1420,7 +1536,7 @@ roff_res(struct roff *r, struct buf *buf, int ln, int pos)
 /*
  * Process text streams.
  */
-static enum rofferr
+static int
 roff_parsetext(struct roff *r, struct buf *buf, int pos, int *offs)
 {
        size_t           sz;
@@ -1486,11 +1602,11 @@ roff_parsetext(struct roff *r, struct buf *buf, int pos, int *offs)
        return ROFF_CONT;
 }
 
-enum rofferr
+int
 roff_parseln(struct roff *r, int ln, struct buf *buf, int *offs)
 {
        enum roff_tok    t;
-       enum rofferr     e;
+       int              e;
        int              pos;   /* parse point */
        int              spos;  /* saved parse point for messages */
        int              ppos;  /* original offset in buf->buf */
@@ -1512,7 +1628,7 @@ roff_parseln(struct roff *r, int ln, struct buf *buf, int *offs)
        /* Expand some escape sequences. */
 
        e = roff_res(r, buf, ln, pos);
-       if (e == ROFF_IGN || e == ROFF_APPEND)
+       if ((e & ROFF_MASK) == ROFF_IGN)
                return e;
        assert(e == ROFF_CONT);
 
@@ -1529,16 +1645,22 @@ roff_parseln(struct roff *r, int ln, struct buf *buf, int *offs)
        if (r->last != NULL && ! ctl) {
                t = r->last->tok;
                e = (*roffs[t].text)(r, t, buf, ln, pos, pos, offs);
-               if (e == ROFF_IGN)
+               if ((e & ROFF_MASK) == ROFF_IGN)
                        return e;
-               assert(e == ROFF_CONT);
+               e &= ~ROFF_MASK;
+       } else
+               e = ROFF_IGN;
+       if (r->eqn != NULL && strncmp(buf->buf + ppos, ".EN", 3)) {
+               eqn_read(r->eqn, buf->buf + ppos);
+               return e;
+       }
+       if (r->tbl != NULL && (ctl == 0 || buf->buf[pos] == '\0')) {
+               tbl_read(r->tbl, ln, buf->buf, ppos);
+               roff_addtbl(r->man, ln, r->tbl);
+               return e;
        }
-       if (r->eqn != NULL)
-               return eqn_read(&r->eqn, ln, buf->buf, ppos, offs);
-       if (r->tbl != NULL && ( ! ctl || buf->buf[pos] == '\0'))
-               return tbl_read(r->tbl, ln, buf->buf, ppos);
        if ( ! ctl)
-               return roff_parsetext(r, buf, pos, offs);
+               return roff_parsetext(r, buf, pos, offs) | e;
 
        /* Skip empty request lines. */
 
@@ -1577,13 +1699,16 @@ roff_parseln(struct roff *r, int ln, struct buf *buf, int *offs)
                        pos++;
                while (buf->buf[pos] == ' ')
                        pos++;
-               return tbl_read(r->tbl, ln, buf->buf, pos);
+               tbl_read(r->tbl, ln, buf->buf, pos);
+               roff_addtbl(r->man, ln, r->tbl);
+               return ROFF_IGN;
        }
 
        /* For now, let high level macros abort .ce mode. */
 
        if (ctl && roffce_node != NULL &&
-           (t == TOKEN_NONE || t == ROFF_EQ || t == ROFF_TS)) {
+           (t == TOKEN_NONE || t == ROFF_Dd || t == ROFF_EQ ||
+            t == ROFF_TH || t == ROFF_TS)) {
                r->man->last = roffce_node;
                r->man->next = ROFF_NEXT_SIBLING;
                roffce_lines = 0;
@@ -1603,25 +1728,43 @@ roff_parseln(struct roff *r, int ln, struct buf *buf, int *offs)
        return (*roffs[t].proc)(r, t, buf, ln, spos, pos, offs);
 }
 
+/*
+ * Internal interface function to tell the roff parser that execution
+ * of the current macro ended.  This is required because macro
+ * definitions usually do not end with a .return request.
+ */
 void
-roff_endparse(struct roff *r)
+roff_userret(struct roff *r)
 {
+       struct mctx     *ctx;
+       int              i;
+
+       assert(r->mstackpos >= 0);
+       ctx = r->mstack + r->mstackpos;
+       for (i = 0; i < ctx->argc; i++)
+               free(ctx->argv[i]);
+       ctx->argc = 0;
+       r->mstackpos--;
+}
 
-       if (r->last)
+void
+roff_endparse(struct roff *r)
+{
+       if (r->last != NULL)
                mandoc_msg(MANDOCERR_BLK_NOEND, r->parse,
                    r->last->line, r->last->col,
                    roff_name[r->last->tok]);
 
-       if (r->eqn) {
+       if (r->eqn != NULL) {
                mandoc_msg(MANDOCERR_BLK_NOEND, r->parse,
-                   r->eqn->eqn.ln, r->eqn->eqn.pos, "EQ");
-               eqn_end(&r->eqn);
+                   r->eqn->node->line, r->eqn->node->pos, "EQ");
+               eqn_parse(r->eqn);
+               r->eqn = NULL;
        }
 
-       if (r->tbl) {
-               mandoc_msg(MANDOCERR_BLK_NOEND, r->parse,
-                   r->tbl->line, r->tbl->pos, "TS");
-               tbl_end(&r->tbl);
+       if (r->tbl != NULL) {
+               tbl_end(r->tbl, 1);
+               r->tbl = NULL;
        }
 }
 
@@ -1635,6 +1778,7 @@ roff_parse(struct roff *r, char *buf, int *pos, int ln, int ppos)
        char            *cp;
        const char      *mac;
        size_t           maclen;
+       int              deftype;
        enum roff_tok    t;
 
        cp = buf + *pos;
@@ -1645,20 +1789,32 @@ roff_parse(struct roff *r, char *buf, int *pos, int ln, int ppos)
        mac = cp;
        maclen = roff_getname(r, &cp, ln, ppos);
 
-       t = (r->current_string = roff_getstrn(r, mac, maclen)) ?
-           ROFF_USERDEF :
-           (r->current_string = roff_getrenn(r, mac, maclen)) ?
-           ROFF_RENAMED : roffhash_find(r->reqtab, mac, maclen);
-
+       deftype = ROFFDEF_USER | ROFFDEF_REN;
+       r->current_string = roff_getstrn(r, mac, maclen, &deftype);
+       switch (deftype) {
+       case ROFFDEF_USER:
+               t = ROFF_USERDEF;
+               break;
+       case ROFFDEF_REN:
+               t = ROFF_RENAMED;
+               break;
+       default:
+               t = roffhash_find(r->reqtab, mac, maclen);
+               break;
+       }
        if (t != TOKEN_NONE)
                *pos = cp - buf;
-
+       else if (deftype == ROFFDEF_UNDEF) {
+               /* Using an undefined macro defines it to be empty. */
+               roff_setstrn(&r->strtab, mac, maclen, "", 0, 0);
+               roff_setstrn(&r->rentab, mac, maclen, NULL, 0, 0);
+       }
        return t;
 }
 
 /* --- handling of request blocks ----------------------------------------- */
 
-static enum rofferr
+static int
 roff_cblock(ROFF_ARGS)
 {
 
@@ -1698,55 +1854,57 @@ roff_cblock(ROFF_ARGS)
 
 }
 
-static void
+static int
 roffnode_cleanscope(struct roff *r)
 {
+       int inloop;
 
-       while (r->last) {
+       inloop = 0;
+       while (r->last != NULL) {
                if (--r->last->endspan != 0)
                        break;
-               roffnode_pop(r);
+               inloop += roffnode_pop(r);
        }
+       return inloop;
 }
 
-static void
+static int
 roff_ccond(struct roff *r, int ln, int ppos)
 {
-
        if (NULL == r->last) {
                mandoc_msg(MANDOCERR_BLK_NOTOPEN, r->parse,
                    ln, ppos, "\\}");
-               return;
+               return 0;
        }
 
        switch (r->last->tok) {
        case ROFF_el:
        case ROFF_ie:
        case ROFF_if:
+       case ROFF_while:
                break;
        default:
                mandoc_msg(MANDOCERR_BLK_NOTOPEN, r->parse,
                    ln, ppos, "\\}");
-               return;
+               return 0;
        }
 
        if (r->last->endspan > -1) {
                mandoc_msg(MANDOCERR_BLK_NOTOPEN, r->parse,
                    ln, ppos, "\\}");
-               return;
+               return 0;
        }
 
-       roffnode_pop(r);
-       roffnode_cleanscope(r);
-       return;
+       return roffnode_pop(r) + roffnode_cleanscope(r);
 }
 
-static enum rofferr
+static int
 roff_block(ROFF_ARGS)
 {
-       const char      *name;
-       char            *iname, *cp;
-       size_t           namesz;
+       const char      *name, *value;
+       char            *call, *cp, *iname, *rname;
+       size_t           csz, namesz, rsz;
+       int              deftype;
 
        /* Ignore groff compatibility mode for now. */
 
@@ -1774,7 +1932,9 @@ roff_block(ROFF_ARGS)
        /* Resolve the macro name argument if it is indirect. */
 
        if (namesz && (tok == ROFF_dei || tok == ROFF_ami)) {
-               if ((name = roff_getstrn(r, iname, namesz)) == NULL) {
+               deftype = ROFFDEF_USER;
+               name = roff_getstrn(r, iname, namesz, &deftype);
+               if (name == NULL) {
                        mandoc_vmsg(MANDOCERR_STR_UNDEF,
                            r->parse, ln, (int)(iname - buf->buf),
                            "%.*s", (int)namesz, iname);
@@ -1801,6 +1961,33 @@ roff_block(ROFF_ARGS)
        if (tok == ROFF_de || tok == ROFF_dei) {
                roff_setstrn(&r->strtab, name, namesz, "", 0, 0);
                roff_setstrn(&r->rentab, name, namesz, NULL, 0, 0);
+       } else if (tok == ROFF_am || tok == ROFF_ami) {
+               deftype = ROFFDEF_ANY;
+               value = roff_getstrn(r, iname, namesz, &deftype);
+               switch (deftype) {  /* Before appending, ... */
+               case ROFFDEF_PRE: /* copy predefined to user-defined. */
+                       roff_setstrn(&r->strtab, name, namesz,
+                           value, strlen(value), 0);
+                       break;
+               case ROFFDEF_REN: /* call original standard macro. */
+                       csz = mandoc_asprintf(&call, ".%.*s \\$* \\\"\n",
+                           (int)strlen(value), value);
+                       roff_setstrn(&r->strtab, name, namesz, call, csz, 0);
+                       roff_setstrn(&r->rentab, name, namesz, NULL, 0, 0);
+                       free(call);
+                       break;
+               case ROFFDEF_STD:  /* rename and call standard macro. */
+                       rsz = mandoc_asprintf(&rname, "__%s_renamed", name);
+                       roff_setstrn(&r->rentab, rname, rsz, name, namesz, 0);
+                       csz = mandoc_asprintf(&call, ".%.*s \\$* \\\"\n",
+                           (int)rsz, rname);
+                       roff_setstrn(&r->strtab, name, namesz, call, csz, 0);
+                       free(call);
+                       free(rname);
+                       break;
+               default:
+                       break;
+               }
        }
 
        if (*cp == '\0')
@@ -1814,7 +2001,9 @@ roff_block(ROFF_ARGS)
        /* Resolve the end marker if it is indirect. */
 
        if (namesz && (tok == ROFF_dei || tok == ROFF_ami)) {
-               if ((name = roff_getstrn(r, iname, namesz)) == NULL) {
+               deftype = ROFFDEF_USER;
+               name = roff_getstrn(r, iname, namesz, &deftype);
+               if (name == NULL) {
                        mandoc_vmsg(MANDOCERR_STR_UNDEF,
                            r->parse, ln, (int)(iname - buf->buf),
                            "%.*s", (int)namesz, iname);
@@ -1834,7 +2023,7 @@ roff_block(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_block_sub(ROFF_ARGS)
 {
        enum roff_tok   t;
@@ -1888,7 +2077,7 @@ roff_block_sub(ROFF_ARGS)
        return (*roffs[t].proc)(r, t, buf, ln, ppos, pos, offs);
 }
 
-static enum rofferr
+static int
 roff_block_text(ROFF_ARGS)
 {
 
@@ -1898,24 +2087,19 @@ roff_block_text(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_cond_sub(ROFF_ARGS)
 {
-       enum roff_tok    t;
        char            *ep;
-       int              rr;
+       int              endloop, irc, rr;
+       enum roff_tok    t;
 
+       irc = ROFF_IGN;
        rr = r->last->rule;
-       roffnode_cleanscope(r);
-       t = roff_parse(r, buf->buf, &pos, ln, ppos);
-
-       /*
-        * Fully handle known macros when they are structurally
-        * required or when the conditional evaluated to true.
-        */
-
-       if (t != TOKEN_NONE && (rr || roffs[t].flags & ROFFMAC_STRUCT))
-               return (*roffs[t].proc)(r, t, buf, ln, ppos, pos, offs);
+       endloop = tok != ROFF_while ? ROFF_IGN :
+           rr ? ROFF_LOOPCONT : ROFF_LOOPEXIT;
+       if (roffnode_cleanscope(r))
+               irc |= endloop;
 
        /*
         * If `\}' occurs on a macro line without a preceding macro,
@@ -1926,38 +2110,84 @@ roff_cond_sub(ROFF_ARGS)
        if (ep[0] == '\\' && ep[1] == '}')
                rr = 0;
 
-       /* Always check for the closing delimiter `\}'. */
+       /*
+        * The closing delimiter `\}' rewinds the conditional scope
+        * but is otherwise ignored when interpreting the line.
+        */
 
        while ((ep = strchr(ep, '\\')) != NULL) {
-               if (*(++ep) == '}') {
-                       *ep = '&';
-                       roff_ccond(r, ln, ep - buf->buf - 1);
-               }
-               if (*ep != '\0')
+               switch (ep[1]) {
+               case '}':
+                       memmove(ep, ep + 2, strlen(ep + 2) + 1);
+                       if (roff_ccond(r, ln, ep - buf->buf))
+                               irc |= endloop;
+                       break;
+               case '\0':
                        ++ep;
+                       break;
+               default:
+                       ep += 2;
+                       break;
+               }
        }
-       return rr ? ROFF_CONT : ROFF_IGN;
+
+       /*
+        * Fully handle known macros when they are structurally
+        * required or when the conditional evaluated to true.
+        */
+
+       t = roff_parse(r, buf->buf, &pos, ln, ppos);
+       irc |= t != TOKEN_NONE && (rr || roffs[t].flags & ROFFMAC_STRUCT) ?
+           (*roffs[t].proc)(r, t, buf, ln, ppos, pos, offs) :
+           rr ? ROFF_CONT : ROFF_IGN;
+       return irc;
 }
 
-static enum rofferr
+static int
 roff_cond_text(ROFF_ARGS)
 {
        char            *ep;
-       int              rr;
+       int              endloop, irc, rr;
 
+       irc = ROFF_IGN;
        rr = r->last->rule;
-       roffnode_cleanscope(r);
+       endloop = tok != ROFF_while ? ROFF_IGN :
+           rr ? ROFF_LOOPCONT : ROFF_LOOPEXIT;
+       if (roffnode_cleanscope(r))
+               irc |= endloop;
+
+       /*
+        * If `\}' occurs on a text line with neither preceding
+        * nor following characters, drop the line completely.
+        */
 
        ep = buf->buf + pos;
+       if (strcmp(ep, "\\}") == 0)
+               rr = 0;
+
+       /*
+        * The closing delimiter `\}' rewinds the conditional scope
+        * but is otherwise ignored when interpreting the line.
+        */
+
        while ((ep = strchr(ep, '\\')) != NULL) {
-               if (*(++ep) == '}') {
-                       *ep = '&';
-                       roff_ccond(r, ln, ep - buf->buf - 1);
-               }
-               if (*ep != '\0')
+               switch (ep[1]) {
+               case '}':
+                       memmove(ep, ep + 2, strlen(ep + 2) + 1);
+                       if (roff_ccond(r, ln, ep - buf->buf))
+                               irc |= endloop;
+                       break;
+               case '\0':
                        ++ep;
+                       break;
+               default:
+                       ep += 2;
+                       break;
+               }
        }
-       return rr ? ROFF_CONT : ROFF_IGN;
+       if (rr)
+               irc |= ROFF_CONT;
+       return irc;
 }
 
 /* --- handling of numeric and conditional expressions -------------------- */
@@ -2084,9 +2314,10 @@ out:
 static int
 roff_evalcond(struct roff *r, int ln, char *v, int *pos)
 {
-       char    *cp, *name;
-       size_t   sz;
-       int      number, savepos, istrue, wanttrue;
+       const char      *start, *end;
+       char            *cp, *name;
+       size_t           sz;
+       int              deftype, len, number, savepos, istrue, wanttrue;
 
        if ('!' == v[*pos]) {
                wanttrue = 0;
@@ -2101,12 +2332,50 @@ roff_evalcond(struct roff *r, int ln, char *v, int *pos)
        case 'o':
                (*pos)++;
                return wanttrue;
-       case 'c':
        case 'e':
        case 't':
        case 'v':
                (*pos)++;
                return !wanttrue;
+       case 'c':
+               do {
+                       (*pos)++;
+               } while (v[*pos] == ' ');
+
+               /*
+                * Quirk for groff compatibility:
+                * The horizontal tab is neither available nor unavailable.
+                */
+
+               if (v[*pos] == '\t') {
+                       (*pos)++;
+                       return 0;
+               }
+
+               /* Printable ASCII characters are available. */
+
+               if (v[*pos] != '\\') {
+                       (*pos)++;
+                       return wanttrue;
+               }
+
+               end = v + ++*pos;
+               switch (mandoc_escape(&end, &start, &len)) {
+               case ESCAPE_SPECIAL:
+                       istrue = mchars_spec2cp(start, len) != -1;
+                       break;
+               case ESCAPE_UNICODE:
+                       istrue = 1;
+                       break;
+               case ESCAPE_NUMBERED:
+                       istrue = mchars_num2char(start, len) != -1;
+                       break;
+               default:
+                       istrue = !wanttrue;
+                       break;
+               }
+               *pos = end - v;
+               return istrue == wanttrue;
        case 'd':
        case 'r':
                cp = v + *pos + 1;
@@ -2114,9 +2383,15 @@ roff_evalcond(struct roff *r, int ln, char *v, int *pos)
                        cp++;
                name = cp;
                sz = roff_getname(r, &cp, ln, cp - v);
-               istrue = sz && (v[*pos] == 'r' ? roff_hasregn(r, name, sz) :
-                   (roff_getstrn(r, name, sz) != NULL ||
-                    roff_getrenn(r, name, sz) != NULL));
+               if (sz == 0)
+                       istrue = 0;
+               else if (v[*pos] == 'r')
+                       istrue = roff_hasregn(r, name, sz);
+               else {
+                       deftype = ROFFDEF_ANY;
+                       roff_getstrn(r, name, sz, &deftype);
+                       istrue = !!deftype;
+               }
                *pos = cp - v;
                return istrue == wanttrue;
        default:
@@ -2132,14 +2407,14 @@ roff_evalcond(struct roff *r, int ln, char *v, int *pos)
                return 0;
 }
 
-static enum rofferr
+static int
 roff_line_ignore(ROFF_ARGS)
 {
 
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_insec(ROFF_ARGS)
 {
 
@@ -2148,7 +2423,7 @@ roff_insec(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_unsupp(ROFF_ARGS)
 {
 
@@ -2157,9 +2432,10 @@ roff_unsupp(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_cond(ROFF_ARGS)
 {
+       int      irc;
 
        roffnode_push(r, tok, NULL, ln, ppos);
 
@@ -2198,9 +2474,10 @@ roff_cond(ROFF_ARGS)
         * Determine scope.
         * If there is nothing on the line after the conditional,
         * not even whitespace, use next-line scope.
+        * Except that .while does not support next-line scope.
         */
 
-       if (buf->buf[pos] == '\0') {
+       if (buf->buf[pos] == '\0' && tok != ROFF_while) {
                r->last->endspan = 2;
                goto out;
        }
@@ -2232,10 +2509,13 @@ roff_cond(ROFF_ARGS)
 
 out:
        *offs = pos;
-       return ROFF_RERUN;
+       irc = ROFF_RERUN;
+       if (tok == ROFF_while)
+               irc |= ROFF_WHILE;
+       return irc;
 }
 
-static enum rofferr
+static int
 roff_ds(ROFF_ARGS)
 {
        char            *string;
@@ -2484,21 +2764,30 @@ roff_evalnum(struct roff *r, int ln, const char *v,
 
 void
 roff_setreg(struct roff *r, const char *name, int val, char sign)
+{
+       roff_setregn(r, name, strlen(name), val, sign, INT_MIN);
+}
+
+static void
+roff_setregn(struct roff *r, const char *name, size_t len,
+    int val, char sign, int step)
 {
        struct roffreg  *reg;
 
        /* Search for an existing register with the same name. */
        reg = r->regtab;
 
-       while (reg && strcmp(name, reg->key.p))
+       while (reg != NULL && (reg->key.sz != len ||
+           strncmp(reg->key.p, name, len) != 0))
                reg = reg->next;
 
        if (NULL == reg) {
                /* Create a new register. */
                reg = mandoc_malloc(sizeof(struct roffreg));
-               reg->key.p = mandoc_strdup(name);
-               reg->key.sz = strlen(name);
+               reg->key.p = mandoc_strndup(name, len);
+               reg->key.sz = len;
                reg->val = 0;
+               reg->step = 0;
                reg->next = r->regtab;
                r->regtab = reg;
        }
@@ -2509,6 +2798,8 @@ roff_setreg(struct roff *r, const char *name, int val, char sign)
                reg->val -= val;
        else
                reg->val = val;
+       if (step != INT_MIN)
+               reg->step = step;
 }
 
 /*
@@ -2523,7 +2814,7 @@ roff_getregro(const struct roff *r, const char *name)
 
        switch (*name) {
        case '$':  /* Number of arguments of the last macro evaluated. */
-               return r->argc;
+               return r->mstackpos < 0 ? 0 : r->mstack[r->mstackpos].argc;
        case 'A':  /* ASCII approximation mode is always off. */
                return 0;
        case 'g':  /* Groff compatibility mode is always on. */
@@ -2542,26 +2833,13 @@ roff_getregro(const struct roff *r, const char *name)
 }
 
 int
-roff_getreg(const struct roff *r, const char *name)
+roff_getreg(struct roff *r, const char *name)
 {
-       struct roffreg  *reg;
-       int              val;
-
-       if ('.' == name[0] && '\0' != name[1] && '\0' == name[2]) {
-               val = roff_getregro(r, name + 1);
-               if (-1 != val)
-                       return val;
-       }
-
-       for (reg = r->regtab; reg; reg = reg->next)
-               if (0 == strcmp(name, reg->key.p))
-                       return reg->val;
-
-       return 0;
+       return roff_getregn(r, name, strlen(name), '\0');
 }
 
 static int
-roff_getregn(const struct roff *r, const char *name, size_t len)
+roff_getregn(struct roff *r, const char *name, size_t len, char sign)
 {
        struct roffreg  *reg;
        int              val;
@@ -2572,11 +2850,24 @@ roff_getregn(const struct roff *r, const char *name, size_t len)
                        return val;
        }
 
-       for (reg = r->regtab; reg; reg = reg->next)
+       for (reg = r->regtab; reg; reg = reg->next) {
                if (len == reg->key.sz &&
-                   0 == strncmp(name, reg->key.p, len))
+                   0 == strncmp(name, reg->key.p, len)) {
+                       switch (sign) {
+                       case '+':
+                               reg->val += reg->step;
+                               break;
+                       case '-':
+                               reg->val -= reg->step;
+                               break;
+                       default:
+                               break;
+                       }
                        return reg->val;
+               }
+       }
 
+       roff_setregn(r, name, len, 0, '\0', INT_MIN);
        return 0;
 }
 
@@ -2613,12 +2904,12 @@ roff_freereg(struct roffreg *reg)
        }
 }
 
-static enum rofferr
+static int
 roff_nr(ROFF_ARGS)
 {
-       char            *key, *val;
+       char            *key, *val, *step;
        size_t           keysz;
-       int              iv;
+       int              iv, is, len;
        char             sign;
 
        key = val = buf->buf + pos;
@@ -2628,19 +2919,26 @@ roff_nr(ROFF_ARGS)
        keysz = roff_getname(r, &val, ln, pos);
        if (key[keysz] == '\\')
                return ROFF_IGN;
-       key[keysz] = '\0';
 
        sign = *val;
        if (sign == '+' || sign == '-')
                val++;
 
-       if (roff_evalnum(r, ln, val, NULL, &iv, ROFFNUM_SCALE))
-               roff_setreg(r, key, iv, sign);
+       len = 0;
+       if (roff_evalnum(r, ln, val, &len, &iv, ROFFNUM_SCALE) == 0)
+               return ROFF_IGN;
 
+       step = val + len;
+       while (isspace((unsigned char)*step))
+               step++;
+       if (roff_evalnum(r, ln, step, NULL, &is, 0) == 0)
+               is = INT_MIN;
+
+       roff_setregn(r, key, keysz, iv, sign, is);
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_rr(ROFF_ARGS)
 {
        struct roffreg  *reg, **prev;
@@ -2670,7 +2968,7 @@ roff_rr(ROFF_ARGS)
 
 /* --- handler functions for roff requests -------------------------------- */
 
-static enum rofferr
+static int
 roff_rm(ROFF_ARGS)
 {
        const char       *name;
@@ -2689,7 +2987,7 @@ roff_rm(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_it(ROFF_ARGS)
 {
        int              iv;
@@ -2718,53 +3016,57 @@ roff_it(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_Dd(ROFF_ARGS)
 {
-       const char *const       *cp;
-
-       if ((r->options & (MPARSE_MDOC | MPARSE_QUICK)) == 0)
-               for (cp = __mdoc_reserved; *cp; cp++)
-                       roff_setstr(r, *cp, NULL, 0);
-
-       if (r->format == 0)
-               r->format = MPARSE_MDOC;
-
-       return ROFF_CONT;
-}
-
-static enum rofferr
-roff_TH(ROFF_ARGS)
-{
-       const char *const       *cp;
-
-       if ((r->options & MPARSE_QUICK) == 0)
-               for (cp = __man_reserved; *cp; cp++)
-                       roff_setstr(r, *cp, NULL, 0);
-
-       if (r->format == 0)
-               r->format = MPARSE_MAN;
+       int              mask;
+       enum roff_tok    t, te;
 
+       switch (tok) {
+       case ROFF_Dd:
+               tok = MDOC_Dd;
+               te = MDOC_MAX;
+               if (r->format == 0)
+                       r->format = MPARSE_MDOC;
+               mask = MPARSE_MDOC | MPARSE_QUICK;
+               break;
+       case ROFF_TH:
+               tok = MAN_TH;
+               te = MAN_MAX;
+               if (r->format == 0)
+                       r->format = MPARSE_MAN;
+               mask = MPARSE_QUICK;
+               break;
+       default:
+               abort();
+       }
+       if ((r->options & mask) == 0)
+               for (t = tok; t < te; t++)
+                       roff_setstr(r, roff_name[t], NULL, 0);
        return ROFF_CONT;
 }
 
-static enum rofferr
+static int
 roff_TE(ROFF_ARGS)
 {
-
-       if (NULL == r->tbl)
+       if (r->tbl == NULL) {
                mandoc_msg(MANDOCERR_BLK_NOTOPEN, r->parse,
                    ln, ppos, "TE");
-       else if ( ! tbl_end(&r->tbl)) {
+               return ROFF_IGN;
+       }
+       if (tbl_end(r->tbl, 0) == 0) {
+               r->tbl = NULL;
                free(buf->buf);
                buf->buf = mandoc_strdup(".sp");
                buf->sz = 4;
+               *offs = 0;
                return ROFF_REPARSE;
        }
+       r->tbl = NULL;
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_T_(ROFF_ARGS)
 {
 
@@ -2780,7 +3082,7 @@ roff_T_(ROFF_ARGS)
 /*
  * Handle in-line equation delimiters.
  */
-static enum rofferr
+static int
 roff_eqndelim(struct roff *r, struct buf *buf, int pos)
 {
        char            *cp1, *cp2;
@@ -2843,23 +3145,28 @@ roff_eqndelim(struct roff *r, struct buf *buf, int pos)
        return ROFF_REPARSE;
 }
 
-static enum rofferr
+static int
 roff_EQ(ROFF_ARGS)
 {
-       struct eqn_node *e;
-
-       assert(r->eqn == NULL);
-       e = eqn_alloc(ppos, ln, r->parse);
+       struct roff_node        *n;
 
-       if (r->last_eqn) {
-               r->last_eqn->next = e;
-               e->delim = r->last_eqn->delim;
-               e->odelim = r->last_eqn->odelim;
-               e->cdelim = r->last_eqn->cdelim;
-       } else
-               r->first_eqn = r->last_eqn = e;
+       if (r->man->macroset == MACROSET_MAN)
+               man_breakscope(r->man, ROFF_EQ);
+       n = roff_node_alloc(r->man, ln, ppos, ROFFT_EQN, TOKEN_NONE);
+       if (ln > r->man->last->line)
+               n->flags |= NODE_LINE;
+       n->eqn = mandoc_calloc(1, sizeof(*n->eqn));
+       n->eqn->expectargs = UINT_MAX;
+       roff_node_append(r->man, n);
+       r->man->next = ROFF_NEXT_SIBLING;
 
-       r->eqn = r->last_eqn = e;
+       assert(r->eqn == NULL);
+       if (r->last_eqn == NULL)
+               r->last_eqn = eqn_alloc(r->parse);
+       else
+               eqn_reset(r->last_eqn);
+       r->eqn = r->last_eqn;
+       r->eqn->node = n;
 
        if (buf->buf[pos] != '\0')
                mandoc_vmsg(MANDOCERR_ARG_SKIP, r->parse, ln, pos,
@@ -2868,37 +3175,36 @@ roff_EQ(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_EN(ROFF_ARGS)
 {
-
-       mandoc_msg(MANDOCERR_BLK_NOTOPEN, r->parse, ln, ppos, "EN");
+       if (r->eqn != NULL) {
+               eqn_parse(r->eqn);
+               r->eqn = NULL;
+       } else
+               mandoc_msg(MANDOCERR_BLK_NOTOPEN, r->parse, ln, ppos, "EN");
+       if (buf->buf[pos] != '\0')
+               mandoc_vmsg(MANDOCERR_ARG_SKIP, r->parse, ln, pos,
+                   "EN %s", buf->buf + pos);
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_TS(ROFF_ARGS)
 {
-       struct tbl_node *tbl;
-
-       if (r->tbl) {
+       if (r->tbl != NULL) {
                mandoc_msg(MANDOCERR_BLK_BROKEN, r->parse,
                    ln, ppos, "TS breaks TS");
-               tbl_end(&r->tbl);
+               tbl_end(r->tbl, 0);
        }
-
-       tbl = tbl_alloc(ppos, ln, r->parse);
-
-       if (r->last_tbl)
-               r->last_tbl->next = tbl;
-       else
-               r->first_tbl = r->last_tbl = tbl;
-
-       r->tbl = r->last_tbl = tbl;
+       r->tbl = tbl_alloc(ppos, ln, r->parse, r->last_tbl);
+       if (r->last_tbl == NULL)
+               r->first_tbl = r->tbl;
+       r->last_tbl = r->tbl;
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_onearg(ROFF_ARGS)
 {
        struct roff_node        *n;
@@ -2906,7 +3212,8 @@ roff_onearg(ROFF_ARGS)
        int                      npos;
 
        if (r->man->flags & (MAN_BLINE | MAN_ELINE) &&
-           (tok == ROFF_sp || tok == ROFF_ti))
+           (tok == ROFF_ce || tok == ROFF_rj || tok == ROFF_sp ||
+            tok == ROFF_ti))
                man_breakscope(r->man, tok);
 
        if (roffce_node != NULL && (tok == ROFF_ce || tok == ROFF_rj)) {
@@ -2957,7 +3264,7 @@ roff_onearg(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_manyarg(ROFF_ARGS)
 {
        struct roff_node        *n;
@@ -2980,7 +3287,7 @@ roff_manyarg(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_als(ROFF_ARGS)
 {
        char            *oldn, *newn, *end, *value;
@@ -2999,14 +3306,15 @@ roff_als(ROFF_ARGS)
        if (oldsz == 0)
                return ROFF_IGN;
 
-       valsz = mandoc_asprintf(&value, ".%.*s \\$*\n", (int)oldsz, oldn);
+       valsz = mandoc_asprintf(&value, ".%.*s \\$@\\\"\n",
+           (int)oldsz, oldn);
        roff_setstrn(&r->strtab, newn, newsz, value, valsz, 0);
        roff_setstrn(&r->rentab, newn, newsz, NULL, 0, 0);
        free(value);
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_br(ROFF_ARGS)
 {
        if (r->man->flags & (MAN_BLINE | MAN_ELINE))
@@ -3020,7 +3328,7 @@ roff_br(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_cc(ROFF_ARGS)
 {
        const char      *p;
@@ -3037,7 +3345,78 @@ roff_cc(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
+roff_char(ROFF_ARGS)
+{
+       const char      *p, *kp, *vp;
+       size_t           ksz, vsz;
+       int              font;
+
+       /* Parse the character to be replaced. */
+
+       kp = buf->buf + pos;
+       p = kp + 1;
+       if (*kp == '\0' || (*kp == '\\' &&
+            mandoc_escape(&p, NULL, NULL) != ESCAPE_SPECIAL) ||
+           (*p != ' ' && *p != '\0')) {
+               mandoc_vmsg(MANDOCERR_CHAR_ARG, r->parse,
+                   ln, pos, "char %s", kp);
+               return ROFF_IGN;
+       }
+       ksz = p - kp;
+       while (*p == ' ')
+               p++;
+
+       /*
+        * If the replacement string contains a font escape sequence,
+        * we have to restore the font at the end.
+        */
+
+       vp = p;
+       vsz = strlen(p);
+       font = 0;
+       while (*p != '\0') {
+               if (*p++ != '\\')
+                       continue;
+               switch (mandoc_escape(&p, NULL, NULL)) {
+               case ESCAPE_FONT:
+               case ESCAPE_FONTROMAN:
+               case ESCAPE_FONTITALIC:
+               case ESCAPE_FONTBOLD:
+               case ESCAPE_FONTBI:
+               case ESCAPE_FONTCW:
+               case ESCAPE_FONTPREV:
+                       font++;
+                       break;
+               default:
+                       break;
+               }
+       }
+       if (font > 1)
+               mandoc_msg(MANDOCERR_CHAR_FONT, r->parse,
+                   ln, vp - buf->buf, vp);
+
+       /*
+        * Approximate the effect of .char using the .tr tables.
+        * XXX In groff, .char and .tr interact differently.
+        */
+
+       if (ksz == 1) {
+               if (r->xtab == NULL)
+                       r->xtab = mandoc_calloc(128, sizeof(*r->xtab));
+               assert((unsigned int)*kp < 128);
+               free(r->xtab[(int)*kp].p);
+               r->xtab[(int)*kp].sz = mandoc_asprintf(&r->xtab[(int)*kp].p,
+                   "%s%s", vp, font ? "\fP" : "");
+       } else {
+               roff_setstrn(&r->xmbtab, kp, ksz, vp, vsz, 0);
+               if (font)
+                       roff_setstrn(&r->xmbtab, kp, ksz, "\\fP", 3, 1);
+       }
+       return ROFF_IGN;
+}
+
+static int
 roff_ec(ROFF_ARGS)
 {
        const char      *p;
@@ -3054,7 +3433,7 @@ roff_ec(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
 roff_eo(ROFF_ARGS)
 {
        r->escape = '\0';
@@ -3064,7 +3443,16 @@ roff_eo(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
+roff_nop(ROFF_ARGS)
+{
+       while (buf->buf[pos] == ' ')
+               pos++;
+       *offs = pos;
+       return ROFF_RERUN;
+}
+
+static int
 roff_tr(ROFF_ARGS)
 {
        const char      *p, *first, *second;
@@ -3126,12 +3514,29 @@ roff_tr(ROFF_ARGS)
        return ROFF_IGN;
 }
 
-static enum rofferr
+/*
+ * Implementation of the .return request.
+ * There is no need to call roff_userret() from here.
+ * The read module will call that after rewinding the reader stack
+ * to the place from where the current macro was called.
+ */
+static int
+roff_return(ROFF_ARGS)
+{
+       if (r->mstackpos >= 0)
+               return ROFF_IGN | ROFF_USERRET;
+
+       mandoc_msg(MANDOCERR_REQ_NOMAC, r->parse, ln, ppos, "return");
+       return ROFF_IGN;
+}
+
+static int
 roff_rn(ROFF_ARGS)
 {
        const char      *value;
        char            *oldn, *newn, *end;
        size_t           oldsz, newsz;
+       int              deftype;
 
        oldn = newn = buf->buf + pos;
        if (*oldn == '\0')
@@ -3146,37 +3551,69 @@ roff_rn(ROFF_ARGS)
        if (newsz == 0)
                return ROFF_IGN;
 
-       /*
-        * Rename a user-defined macro bearing the old name,
-        * overriding an existing renamed high-level macro
-        * bearing the new name, if that exists.
-        */
-
-       if ((value = roff_getstrn(r, oldn, oldsz)) != NULL) {
+       deftype = ROFFDEF_ANY;
+       value = roff_getstrn(r, oldn, oldsz, &deftype);
+       switch (deftype) {
+       case ROFFDEF_USER:
                roff_setstrn(&r->strtab, newn, newsz, value, strlen(value), 0);
                roff_setstrn(&r->strtab, oldn, oldsz, NULL, 0, 0);
                roff_setstrn(&r->rentab, newn, newsz, NULL, 0, 0);
-               return ROFF_IGN;
-       }
-
-       /*
-        * Rename a high-level macro bearing the old name,
-        * either renaming it a second time if it was already
-        * renamed before, or renaming it for the first time.
-        * In both cases, override an existing user-defined
-        * macro bearing the new name, if that exists.
-        */
-
-       if ((value = roff_getrenn(r, oldn, oldsz)) != NULL) {
+               break;
+       case ROFFDEF_PRE:
+               roff_setstrn(&r->strtab, newn, newsz, value, strlen(value), 0);
+               roff_setstrn(&r->rentab, newn, newsz, NULL, 0, 0);
+               break;
+       case ROFFDEF_REN:
                roff_setstrn(&r->rentab, newn, newsz, value, strlen(value), 0);
                roff_setstrn(&r->rentab, oldn, oldsz, NULL, 0, 0);
-       } else
+               roff_setstrn(&r->strtab, newn, newsz, NULL, 0, 0);
+               break;
+       case ROFFDEF_STD:
                roff_setstrn(&r->rentab, newn, newsz, oldn, oldsz, 0);
-       roff_setstrn(&r->strtab, newn, newsz, NULL, 0, 0);
+               roff_setstrn(&r->strtab, newn, newsz, NULL, 0, 0);
+               break;
+       default:
+               roff_setstrn(&r->strtab, newn, newsz, NULL, 0, 0);
+               roff_setstrn(&r->rentab, newn, newsz, NULL, 0, 0);
+               break;
+       }
        return ROFF_IGN;
 }
 
-static enum rofferr
+static int
+roff_shift(ROFF_ARGS)
+{
+       struct mctx     *ctx;
+       int              levels, i;
+
+       levels = 1;
+       if (buf->buf[pos] != '\0' &&
+           roff_evalnum(r, ln, buf->buf, &pos, &levels, 0) == 0) {
+               mandoc_vmsg(MANDOCERR_CE_NONUM, r->parse,
+                   ln, pos, "shift %s", buf->buf + pos);
+               levels = 1;
+       }
+       if (r->mstackpos < 0) {
+               mandoc_msg(MANDOCERR_REQ_NOMAC, r->parse, ln, ppos, "shift");
+               return ROFF_IGN;
+       }
+       ctx = r->mstack + r->mstackpos;
+       if (levels > ctx->argc) {
+               mandoc_vmsg(MANDOCERR_SHIFT, r->parse,
+                   ln, pos, "%d, but max is %d", levels, ctx->argc);
+               levels = ctx->argc;
+       }
+       if (levels == 0)
+               return ROFF_IGN;
+       for (i = 0; i < levels; i++)
+               free(ctx->argv[i]);
+       ctx->argc -= levels;
+       for (i = 0; i < ctx->argc; i++)
+               ctx->argv[i] = ctx->argv[i + levels];
+       return ROFF_IGN;
+}
+
+static int
 roff_so(ROFF_ARGS)
 {
        char *name, *cp;
@@ -3208,161 +3645,77 @@ roff_so(ROFF_ARGS)
 
 /* --- user defined strings and macros ------------------------------------ */
 
-static enum rofferr
+static int
 roff_userdef(ROFF_ARGS)
 {
-       const char       *arg[16], *ap;
-       char             *cp, *n1, *n2;
-       int               expand_count, i, ib, ie;
-       size_t            asz, rsz;
+       struct mctx      *ctx;
+       char             *arg, *ap, *dst, *src;
+       size_t            sz;
 
-       /*
-        * Collect pointers to macro argument strings
-        * and NUL-terminate them.
-        */
+       /* Initialize a new macro stack context. */
 
-       r->argc = 0;
-       cp = buf->buf + pos;
-       for (i = 0; i < 16; i++) {
-               if (*cp == '\0')
-                       arg[i] = "";
-               else {
-                       arg[i] = mandoc_getarg(r->parse, &cp, ln, &pos);
-                       r->argc = i + 1;
-               }
+       if (++r->mstackpos == r->mstacksz) {
+               r->mstack = mandoc_recallocarray(r->mstack,
+                   r->mstacksz, r->mstacksz + 8, sizeof(*r->mstack));
+               r->mstacksz += 8;
        }
+       ctx = r->mstack + r->mstackpos;
+       ctx->argsz = 0;
+       ctx->argc = 0;
+       ctx->argv = NULL;
 
        /*
-        * Expand macro arguments.
+        * Collect pointers to macro argument strings,
+        * NUL-terminating them and escaping quotes.
         */
 
-       buf->sz = strlen(r->current_string) + 1;
-       n1 = n2 = cp = mandoc_malloc(buf->sz);
-       memcpy(n1, r->current_string, buf->sz);
-       expand_count = 0;
-       while (*cp != '\0') {
-
-               /* Scan ahead for the next argument invocation. */
-
-               if (*cp++ != '\\')
-                       continue;
-               if (*cp++ != '$')
-                       continue;
-               if (*cp == '*') {  /* \\$* inserts all arguments */
-                       ib = 0;
-                       ie = r->argc - 1;
-               } else {  /* \\$1 .. \\$9 insert one argument */
-                       ib = ie = *cp - '1';
-                       if (ib < 0 || ib > 8)
-                               continue;
-               }
-               cp -= 2;
-
-               /*
-                * Prevent infinite recursion.
-                */
-
-               if (cp >= n2)
-                       expand_count = 1;
-               else if (++expand_count > EXPAND_LIMIT) {
-                       mandoc_msg(MANDOCERR_ROFFLOOP, r->parse,
-                           ln, (int)(cp - n1), NULL);
-                       free(buf->buf);
-                       buf->buf = n1;
-                       return ROFF_IGN;
-               }
-
-               /*
-                * Determine the size of the expanded argument,
-                * taking escaping of quotes into account.
-                */
-
-               asz = ie > ib ? ie - ib : 0;  /* for blanks */
-               for (i = ib; i <= ie; i++) {
-                       for (ap = arg[i]; *ap != '\0'; ap++) {
-                               asz++;
-                               if (*ap == '"')
-                                       asz += 3;
-                       }
-               }
-               if (asz != 3) {
-
-                       /*
-                        * Determine the size of the rest of the
-                        * unexpanded macro, including the NUL.
-                        */
-
-                       rsz = buf->sz - (cp - n1) - 3;
-
-                       /*
-                        * When shrinking, move before
-                        * releasing the storage.
-                        */
-
-                       if (asz < 3)
-                               memmove(cp + asz, cp + 3, rsz);
-
-                       /*
-                        * Resize the storage for the macro
-                        * and readjust the parse pointer.
-                        */
-
-                       buf->sz += asz - 3;
-                       n2 = mandoc_realloc(n1, buf->sz);
-                       cp = n2 + (cp - n1);
-                       n1 = n2;
-
-                       /*
-                        * When growing, make room
-                        * for the expanded argument.
-                        */
-
-                       if (asz > 3)
-                               memmove(cp + asz, cp + 3, rsz);
+       src = buf->buf + pos;
+       while (*src != '\0') {
+               if (ctx->argc == ctx->argsz) {
+                       ctx->argsz += 8;
+                       ctx->argv = mandoc_reallocarray(ctx->argv,
+                           ctx->argsz, sizeof(*ctx->argv));
                }
-
-               /* Copy the expanded argument, escaping quotes. */
-
-               n2 = cp;
-               for (i = ib; i <= ie; i++) {
-                       for (ap = arg[i]; *ap != '\0'; ap++) {
-                               if (*ap == '"') {
-                                       memcpy(n2, "\\(dq", 4);
-                                       n2 += 4;
-                               } else
-                                       *n2++ = *ap;
-                       }
-                       if (i < ie)
-                               *n2++ = ' ';
+               arg = mandoc_getarg(r->parse, &src, ln, &pos);
+               sz = 1;  /* For the terminating NUL. */
+               for (ap = arg; *ap != '\0'; ap++)
+                       sz += *ap == '"' ? 4 : 1;
+               ctx->argv[ctx->argc++] = dst = mandoc_malloc(sz);
+               for (ap = arg; *ap != '\0'; ap++) {
+                       if (*ap == '"') {
+                               memcpy(dst, "\\(dq", 4);
+                               dst += 4;
+                       } else
+                               *dst++ = *ap;
                }
+               *dst = '\0';
        }
 
-       /*
-        * Replace the macro invocation
-        * by the expanded macro.
-        */
+       /* Replace the macro invocation by the macro definition. */
 
        free(buf->buf);
-       buf->buf = n1;
+       buf->buf = mandoc_strdup(r->current_string);
+       buf->sz = strlen(buf->buf) + 1;
        *offs = 0;
 
        return buf->sz > 1 && buf->buf[buf->sz - 2] == '\n' ?
-          ROFF_REPARSE : ROFF_APPEND;
+           ROFF_REPARSE | ROFF_USERCALL : ROFF_IGN | ROFF_APPEND;
 }
 
 /*
  * Calling a high-level macro that was renamed with .rn.
  * r->current_string has already been set up by roff_parse().
  */
-static enum rofferr
+static int
 roff_renamed(ROFF_ARGS)
 {
        char    *nbuf;
 
-       buf->sz = mandoc_asprintf(&nbuf, ".%s %s", r->current_string,
-           buf->buf + pos) + 1;
+       buf->sz = mandoc_asprintf(&nbuf, ".%s%s%s", r->current_string,
+           buf->buf[pos] == '\0' ? "" : " ", buf->buf + pos) + 1;
        free(buf->buf);
        buf->buf = nbuf;
+       *offs = 0;
        return ROFF_CONT;
 }
 
@@ -3415,9 +3768,12 @@ static void
 roff_setstr(struct roff *r, const char *name, const char *string,
        int append)
 {
+       size_t   namesz;
 
-       roff_setstrn(&r->strtab, name, strlen(name), string,
+       namesz = strlen(name);
+       roff_setstrn(&r->strtab, name, namesz, string,
            string ? strlen(string) : 0, append);
+       roff_setstrn(&r->rentab, name, namesz, NULL, 0, 0);
 }
 
 static void
@@ -3493,38 +3849,96 @@ roff_setstrn(struct roffkv **r, const char *name, size_t namesz,
 }
 
 static const char *
-roff_getstrn(const struct roff *r, const char *name, size_t len)
+roff_getstrn(struct roff *r, const char *name, size_t len,
+    int *deftype)
 {
-       const struct roffkv *n;
-       int i;
+       const struct roffkv     *n;
+       int                      found, i;
+       enum roff_tok            tok;
 
-       for (n = r->strtab; n; n = n->next)
-               if (0 == strncmp(name, n->key.p, len) &&
-                   '\0' == n->key.p[(int)len])
+       found = 0;
+       for (n = r->strtab; n != NULL; n = n->next) {
+               if (strncmp(name, n->key.p, len) != 0 ||
+                   n->key.p[len] != '\0' || n->val.p == NULL)
+                       continue;
+               if (*deftype & ROFFDEF_USER) {
+                       *deftype = ROFFDEF_USER;
                        return n->val.p;
-
-       for (i = 0; i < PREDEFS_MAX; i++)
-               if (0 == strncmp(name, predefs[i].name, len) &&
-                               '\0' == predefs[i].name[(int)len])
+               } else {
+                       found = 1;
+                       break;
+               }
+       }
+       for (n = r->rentab; n != NULL; n = n->next) {
+               if (strncmp(name, n->key.p, len) != 0 ||
+                   n->key.p[len] != '\0' || n->val.p == NULL)
+                       continue;
+               if (*deftype & ROFFDEF_REN) {
+                       *deftype = ROFFDEF_REN;
+                       return n->val.p;
+               } else {
+                       found = 1;
+                       break;
+               }
+       }
+       for (i = 0; i < PREDEFS_MAX; i++) {
+               if (strncmp(name, predefs[i].name, len) != 0 ||
+                   predefs[i].name[len] != '\0')
+                       continue;
+               if (*deftype & ROFFDEF_PRE) {
+                       *deftype = ROFFDEF_PRE;
                        return predefs[i].str;
+               } else {
+                       found = 1;
+                       break;
+               }
+       }
+       if (r->man->macroset != MACROSET_MAN) {
+               for (tok = MDOC_Dd; tok < MDOC_MAX; tok++) {
+                       if (strncmp(name, roff_name[tok], len) != 0 ||
+                           roff_name[tok][len] != '\0')
+                               continue;
+                       if (*deftype & ROFFDEF_STD) {
+                               *deftype = ROFFDEF_STD;
+                               return NULL;
+                       } else {
+                               found = 1;
+                               break;
+                       }
+               }
+       }
+       if (r->man->macroset != MACROSET_MDOC) {
+               for (tok = MAN_TH; tok < MAN_MAX; tok++) {
+                       if (strncmp(name, roff_name[tok], len) != 0 ||
+                           roff_name[tok][len] != '\0')
+                               continue;
+                       if (*deftype & ROFFDEF_STD) {
+                               *deftype = ROFFDEF_STD;
+                               return NULL;
+                       } else {
+                               found = 1;
+                               break;
+                       }
+               }
+       }
 
-       return NULL;
-}
+       if (found == 0 && *deftype != ROFFDEF_ANY) {
+               if (*deftype & ROFFDEF_REN) {
+                       /*
+                        * This might still be a request,
+                        * so do not treat it as undefined yet.
+                        */
+                       *deftype = ROFFDEF_UNDEF;
+                       return NULL;
+               }
 
-/*
- * Check whether *name is the renamed name of a high-level macro.
- * Return the standard name, or NULL if it is not.
- */
-static const char *
-roff_getrenn(const struct roff *r, const char *name, size_t len)
-{
-       const struct roffkv *n;
+               /* Using an undefined string defines it to be empty. */
 
-       for (n = r->rentab; n; n = n->next)
-               if (0 == strncmp(name, n->key.p, len) &&
-                   '\0' == n->key.p[(int)len])
-                       return n->val.p;
+               roff_setstrn(&r->strtab, name, len, "", 0, 0);
+               roff_setstrn(&r->rentab, name, len, NULL, 0, 0);
+       }
 
+       *deftype = 0;
        return NULL;
 }
 
@@ -3543,20 +3957,6 @@ roff_freestr(struct roffkv *r)
 
 /* --- accessors and utility functions ------------------------------------ */
 
-const struct tbl_span *
-roff_span(const struct roff *r)
-{
-
-       return r->tbl ? tbl_span(r->tbl) : NULL;
-}
-
-const struct eqn *
-roff_eqn(const struct roff *r)
-{
-
-       return r->last_eqn ? &r->last_eqn->eqn : NULL;
-}
-
 /*
  * Duplicate an input string, making the appropriate character
  * conversations (as stipulated by `tr') along the way.