Fix a regression caused by the insertion of two new tokens,

[mandoc.git] / tbl_data.c

diff --git a/tbl_data.c b/tbl_data.c
index 687d2d305455af56ccb33335db1d77d09b863f47..93198484ebc46daa997a995b5ee50e8e2b2828d8 100644 (file)
--- a/tbl_data.c
+++ b/tbl_data.c
@@ -1,7 +1,7 @@
-/*     $Id: tbl_data.c,v 1.50 2018/12/14 01:18:26 schwarze Exp $ */
+/*     $Id: tbl_data.c,v 1.53 2020/01/11 20:48:18 schwarze Exp $ */
 /*
  * Copyright (c) 2009, 2010, 2011 Kristaps Dzonsons <kristaps@bsd.lv>
- * Copyright (c) 2011, 2015, 2017, 2018 Ingo Schwarze <schwarze@openbsd.org>
+ * Copyright (c) 2011,2015,2017,2018,2019 Ingo Schwarze <schwarze@openbsd.org>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -21,6 +21,7 @@
 
 #include <assert.h>
 #include <ctype.h>
+#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -73,12 +74,13 @@ getdata(struct tbl_node *tbl, struct tbl_span *dp,
                if (dp->layout->last->col + 1 < dp->opts->cols) {
                        cp = mandoc_calloc(1, sizeof(*cp));
                        cp->pos = TBL_CELL_LEFT;
+                       cp->spacing = SIZE_MAX;
                        dp->layout->last->next = cp;
                        cp->col = dp->layout->last->col + 1;
                        dp->layout->last = cp;
                } else {
-                       mandoc_msg(MANDOCERR_TBLDATA_EXTRA, tbl->parse,
-                           ln, sv, p + sv);
+                       mandoc_msg(MANDOCERR_TBLDATA_EXTRA,
+                           ln, sv, "%s", p + sv);
                        while (p[*pos] != '\0')
                                (*pos)++;
                        return;
@@ -171,7 +173,7 @@ getdata(struct tbl_node *tbl, struct tbl_span *dp,
            dat->layout->pos == TBL_CELL_DOWN) &&
            dat->pos == TBL_DATA_DATA && *dat->string != '\0')
                mandoc_msg(MANDOCERR_TBLDATA_SPAN,
-                   tbl->parse, ln, sv, dat->string);
+                   ln, sv, "%s", dat->string);
 }
 
 void
@@ -210,8 +212,8 @@ tbl_cdata(struct tbl_node *tbl, int ln, const char *p, int pos)
                dat->string = mandoc_strdup(p + pos);
 
        if (dat->layout->pos == TBL_CELL_DOWN)
-               mandoc_msg(MANDOCERR_TBLDATA_SPAN, tbl->parse,
-                   ln, pos, dat->string);
+               mandoc_msg(MANDOCERR_TBLDATA_SPAN,
+                   ln, pos, "%s", dat->string);
 }
 
 static struct tbl_span *
@@ -248,14 +250,27 @@ tbl_data(struct tbl_node *tbl, int ln, const char *p, int pos)
 
        assert(rp != NULL);
 
-       if ( ! strcmp(p, "_")) {
-               sp = newspan(tbl, ln, rp);
-               sp->pos = TBL_SPAN_HORIZ;
-               return;
-       } else if ( ! strcmp(p, "=")) {
-               sp = newspan(tbl, ln, rp);
-               sp->pos = TBL_SPAN_DHORIZ;
-               return;
+       if (p[1] == '\0') {
+               switch (p[0]) {
+               case '.':
+                       /*
+                        * Empty request lines must be handled here
+                        * and cannot be discarded in roff_parseln()
+                        * because in the layout section, they
+                        * are significant and end the layout.
+                        */
+                       return;
+               case '_':
+                       sp = newspan(tbl, ln, rp);
+                       sp->pos = TBL_SPAN_HORIZ;
+                       return;
+               case '=':
+                       sp = newspan(tbl, ln, rp);
+                       sp->pos = TBL_SPAN_DHORIZ;
+                       return;
+               default:
+                       break;
+               }
        }
 
        /*