do not use the echo(1) -n option, it is not portable;

[mandoc.git] / roff_validate.c

diff --git a/roff_validate.c b/roff_validate.c
index 05df6cb62ef44577632628a354020212cb1be8f8..74eedafb958108116e8725c27ed9b2a59c817c69 100644 (file)
--- a/roff_validate.c
+++ b/roff_validate.c
@@ -1,6 +1,6 @@
-/*     $OpenBSD: roff_html.c,v 1.1 2017/05/04 22:07:44 schwarze Exp $ */
+/* $Id: roff_validate.c,v 1.20 2020/06/22 19:20:40 schwarze Exp $ */
 /*
- * Copyright (c) 2010, 2017 Ingo Schwarze <schwarze@openbsd.org>
+ * Copyright (c) 2010, 2017, 2018, 2020 Ingo Schwarze <schwarze@openbsd.org>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -14,10 +14,13 @@
  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
+#include "config.h"
+
 #include <sys/types.h>
 
 #include <assert.h>
-#include <stddef.h>
+#include <stdio.h>
+#include <string.h>
 
 #include "mandoc.h"
 #include "roff.h"
@@ -28,14 +31,25 @@
 
 typedef        void    (*roff_valid_fp)(ROFF_VALID_ARGS);
 
+static void      roff_valid_br(ROFF_VALID_ARGS);
+static void      roff_valid_fi(ROFF_VALID_ARGS);
 static void      roff_valid_ft(ROFF_VALID_ARGS);
+static void      roff_valid_nf(ROFF_VALID_ARGS);
+static void      roff_valid_sp(ROFF_VALID_ARGS);
 
 static const roff_valid_fp roff_valids[ROFF_MAX] = {
-       NULL,  /* br */
+       roff_valid_br,  /* br */
+       NULL,  /* ce */
+       roff_valid_fi,  /* fi */
        roff_valid_ft,  /* ft */
        NULL,  /* ll */
-       NULL,  /* sp */
+       NULL,  /* mc */
+       roff_valid_nf,  /* nf */
+       NULL,  /* po */
+       NULL,  /* rj */
+       roff_valid_sp,  /* sp */
        NULL,  /* ta */
+       NULL,  /* ti */
 };
 
 
@@ -50,10 +64,46 @@ roff_validate(struct roff_man *man)
                (*roff_valids[n->tok])(man, n);
 }
 
+static void
+roff_valid_br(ROFF_VALID_ARGS)
+{
+       struct roff_node        *np;
+
+       if (n->next != NULL && n->next->type == ROFFT_TEXT &&
+           *n->next->string == ' ') {
+               mandoc_msg(MANDOCERR_PAR_SKIP, n->line, n->pos,
+                   "br before text line with leading blank");
+               roff_node_delete(man, n);
+               return;
+       }
+
+       if ((np = roff_node_prev(n)) == NULL)
+               return;
+
+       switch (np->tok) {
+       case ROFF_br:
+       case ROFF_sp:
+       case MDOC_Pp:
+               mandoc_msg(MANDOCERR_PAR_SKIP,
+                   n->line, n->pos, "br after %s", roff_name[np->tok]);
+               roff_node_delete(man, n);
+               break;
+       default:
+               break;
+       }
+}
+
+static void
+roff_valid_fi(ROFF_VALID_ARGS)
+{
+       if ((n->flags & NODE_NOFILL) == 0)
+               mandoc_msg(MANDOCERR_FI_SKIP, n->line, n->pos, "fi");
+}
+
 static void
 roff_valid_ft(ROFF_VALID_ARGS)
 {
-       char    *cp;
+       const char              *cp;
 
        if (n->child == NULL) {
                man->next = ROFF_NEXT_CHILD;
@@ -63,30 +113,39 @@ roff_valid_ft(ROFF_VALID_ARGS)
        }
 
        cp = n->child->string;
-       switch (*cp) {
-       case '1':
-       case '2':
-       case '3':
-       case '4':
-       case 'I':
-       case 'P':
-       case 'R':
-               if (cp[1] == '\0')
-                       return;
-               break;
-       case 'B':
-               if (cp[1] == '\0' || (cp[1] == 'I' && cp[2] == '\0'))
-                       return;
+       if (mandoc_font(cp, (int)strlen(cp)) != ESCAPE_ERROR)
+               return;
+       mandoc_msg(MANDOCERR_FT_BAD, n->line, n->pos, "ft %s", cp);
+       roff_node_delete(man, n);
+}
+
+static void
+roff_valid_nf(ROFF_VALID_ARGS)
+{
+       if (n->flags & NODE_NOFILL)
+               mandoc_msg(MANDOCERR_NF_SKIP, n->line, n->pos, "nf");
+}
+
+static void
+roff_valid_sp(ROFF_VALID_ARGS)
+{
+       struct roff_node        *np;
+
+       if ((np = roff_node_prev(n)) == NULL)
+               return;
+
+       switch (np->tok) {
+       case ROFF_br:
+               mandoc_msg(MANDOCERR_PAR_SKIP,
+                   np->line, np->pos, "br before sp");
+               roff_node_delete(man, np);
                break;
-       case 'C':
-               if (cp[1] == 'W' && cp[2] == '\0')
-                       return;
+       case MDOC_Pp:
+               mandoc_msg(MANDOCERR_PAR_SKIP,
+                   n->line, n->pos, "sp after Pp");
+               roff_node_delete(man, n);
                break;
        default:
                break;
        }
-
-       mandoc_vmsg(MANDOCERR_FT_BAD, man->parse,
-           n->line, n->pos, "ft %s", cp);
-       roff_node_delete(man, n);
 }