clarify the meaning of a complicated mixed signed/unsigned expression;

[mandoc.git] / mdoc_argv.c

diff --git a/mdoc_argv.c b/mdoc_argv.c
index 8689ab86fb3a77b9809e99a290362c8ac2c7d11e..1bfd336b7a972cf81c202ec38b8c92363f37203d 100644 (file)
--- a/mdoc_argv.c
+++ b/mdoc_argv.c
@@ -1,7 +1,7 @@
-/*     $Id: mdoc_argv.c,v 1.114 2017/05/05 15:17:32 schwarze Exp $ */
+/*     $Id: mdoc_argv.c,v 1.120 2019/07/11 17:06:17 schwarze Exp $ */
 /*
  * Copyright (c) 2008, 2009, 2010, 2011 Kristaps Dzonsons <kristaps@bsd.lv>
- * Copyright (c) 2012, 2014-2017 Ingo Schwarze <schwarze@openbsd.org>
+ * Copyright (c) 2012, 2014-2019 Ingo Schwarze <schwarze@openbsd.org>
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -144,7 +144,7 @@ static      const enum mdocargt args_Bl[] = {
        MDOC_ARG_MAX
 };
 
-static const struct mdocarg __mdocargs[MDOC_MAX - MDOC_Dd] = {
+static const struct mdocarg mdocargs[MDOC_MAX - MDOC_Dd] = {
        { ARGSFL_NONE, NULL }, /* Dd */
        { ARGSFL_NONE, NULL }, /* Dt */
        { ARGSFL_NONE, NULL }, /* Os */
@@ -266,7 +266,6 @@ static      const struct mdocarg __mdocargs[MDOC_MAX - MDOC_Dd] = {
        { ARGSFL_NONE, NULL }, /* %U */
        { ARGSFL_NONE, NULL }, /* Ta */
 };
-static const struct mdocarg *const mdocargs = __mdocargs - MDOC_Dd;
 
 
 /*
@@ -290,7 +289,7 @@ mdoc_argv(struct roff_man *mdoc, int line, enum roff_tok tok,
        /* Which flags does this macro support? */
 
        assert(tok >= MDOC_Dd && tok < MDOC_MAX);
-       argtable = mdocargs[tok].argvs;
+       argtable = mdocargs[tok - MDOC_Dd].argvs;
        if (argtable == NULL)
                return;
 
@@ -368,7 +367,7 @@ mdoc_argv(struct roff_man *mdoc, int line, enum roff_tok tok,
                /* Prepare for parsing the next flag. */
 
                *pos = ipos;
-               argtable = mdocargs[tok].argvs;
+               argtable = mdocargs[tok - MDOC_Dd].argvs;
        }
 }
 
@@ -417,12 +416,9 @@ mdoc_args(struct roff_man *mdoc, int line, int *pos,
        char *buf, enum roff_tok tok, char **v)
 {
        struct roff_node *n;
-       char             *v_local;
        enum argsflag     fl;
 
-       if (v == NULL)
-               v = &v_local;
-       fl = tok == TOKEN_NONE ? ARGSFL_NONE : mdocargs[tok].flags;
+       fl = tok == TOKEN_NONE ? ARGSFL_NONE : mdocargs[tok - MDOC_Dd].flags;
 
        /*
         * We know that we're in an `It', so it's reasonable to expect
@@ -449,18 +445,21 @@ args(struct roff_man *mdoc, int line, int *pos,
                char *buf, enum argsflag fl, char **v)
 {
        char            *p;
+       char            *v_local;
        int              pairs;
 
        if (buf[*pos] == '\0') {
                if (mdoc->flags & MDOC_PHRASELIT &&
                    ! (mdoc->flags & MDOC_PHRASE)) {
-                       mandoc_msg(MANDOCERR_ARG_QUOTE,
-                           mdoc->parse, line, *pos, NULL);
+                       mandoc_msg(MANDOCERR_ARG_QUOTE, line, *pos, NULL);
                        mdoc->flags &= ~MDOC_PHRASELIT;
                }
+               mdoc->flags &= ~MDOC_PHRASEQL;
                return ARGS_EOLN;
        }
 
+       if (v == NULL)
+               v = &v_local;
        *v = buf + *pos;
 
        if (fl == ARGSFL_DELIM && args_checkpunct(buf, *pos))
@@ -506,7 +505,7 @@ args(struct roff_man *mdoc, int line, int *pos,
                        p = strchr(*v, '\0');
                        if (p[-1] == ' ')
                                mandoc_msg(MANDOCERR_SPACE_EOL,
-                                   mdoc->parse, line, *pos, NULL);
+                                   line, *pos, NULL);
                        *pos += (int)(p - *v);
                }
 
@@ -527,13 +526,12 @@ args(struct roff_man *mdoc, int line, int *pos,
         * Whitespace is NOT involved in literal termination.
         */
 
-       if (mdoc->flags & MDOC_PHRASELIT || buf[*pos] == '\"') {
-               if ( ! (mdoc->flags & MDOC_PHRASELIT))
+       if (mdoc->flags & MDOC_PHRASELIT ||
+           (mdoc->flags & MDOC_PHRASE && buf[*pos] == '\"')) {
+               if ((mdoc->flags & MDOC_PHRASELIT) == 0) {
                        *v = &buf[++(*pos)];
-
-               if (mdoc->flags & MDOC_PHRASE)
                        mdoc->flags |= MDOC_PHRASELIT;
-
+               }
                pairs = 0;
                for ( ; buf[*pos]; (*pos)++) {
                        /* Move following text left after quoted quotes. */
@@ -554,28 +552,29 @@ args(struct roff_man *mdoc, int line, int *pos,
                if (buf[*pos] == '\0') {
                        if ( ! (mdoc->flags & MDOC_PHRASE))
                                mandoc_msg(MANDOCERR_ARG_QUOTE,
-                                   mdoc->parse, line, *pos, NULL);
-                       return ARGS_QWORD;
+                                   line, *pos, NULL);
+                       return ARGS_WORD;
                }
 
                mdoc->flags &= ~MDOC_PHRASELIT;
                buf[(*pos)++] = '\0';
 
                if ('\0' == buf[*pos])
-                       return ARGS_QWORD;
+                       return ARGS_WORD;
 
                while (' ' == buf[*pos])
                        (*pos)++;
 
                if ('\0' == buf[*pos])
-                       mandoc_msg(MANDOCERR_SPACE_EOL, mdoc->parse,
-                           line, *pos, NULL);
+                       mandoc_msg(MANDOCERR_SPACE_EOL, line, *pos, NULL);
 
-               return ARGS_QWORD;
+               return ARGS_WORD;
        }
 
        p = &buf[*pos];
-       *v = mandoc_getarg(mdoc->parse, &p, line, pos);
+       *v = roff_getarg(mdoc->roff, &p, line, pos);
+       if (v == &v_local)
+               free(*v);
 
        /*
         * After parsing the last word in this phrase,
@@ -586,7 +585,7 @@ args(struct roff_man *mdoc, int line, int *pos,
                mdoc->flags &= ~MDOC_PHRASEQL;
                mdoc->flags |= MDOC_PHRASEQF;
        }
-       return ARGS_WORD;
+       return ARGS_ALLOC;
 }
 
 /*
@@ -657,7 +656,9 @@ argv_multi(struct roff_man *mdoc, int line,
                        v->value = mandoc_reallocarray(v->value,
                            v->sz + MULTI_STEP, sizeof(char *));
 
-               v->value[(int)v->sz] = mandoc_strdup(p);
+               if (ac != ARGS_ALLOC)
+                       p = mandoc_strdup(p);
+               v->value[(int)v->sz] = p;
        }
 }
 
@@ -672,7 +673,10 @@ argv_single(struct roff_man *mdoc, int line,
        if (ac == ARGS_EOLN)
                return;
 
+       if (ac != ARGS_ALLOC)
+               p = mandoc_strdup(p);
+
        v->sz = 1;
        v->value = mandoc_malloc(sizeof(char *));
-       v->value[0] = mandoc_strdup(p);
+       v->value[0] = p;
 }