If man(7) next-line scope is open and the line ends with \c,

[mandoc.git] / eqn.c

diff --git a/eqn.c b/eqn.c
index 79466093c6b98b4b8cf12028b56aa54dbdb40a4c..01601a7137343a576964eccf402f2a17c502930a 100644 (file)
--- a/eqn.c
+++ b/eqn.c
@@ -1,4 +1,4 @@
-/*     $Id: eqn.c,v 1.70 2017/06/26 11:04:47 schwarze Exp $ */
+/*     $Id: eqn.c,v 1.78 2017/07/15 16:26:17 schwarze Exp $ */

 /*
  * Copyright (c) 2011, 2014 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2014, 2015, 2017 Ingo Schwarze <schwarze@openbsd.org>
 /*
  * Copyright (c) 2011, 2014 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2014, 2015, 2017 Ingo Schwarze <schwarze@openbsd.org>


@@ -27,8 +27,9 @@
 #include <string.h>
 #include <time.h>
 
 #include <string.h>
 #include <time.h>
 

-#include "mandoc.h"

 #include "mandoc_aux.h"
 #include "mandoc_aux.h"

+#include "mandoc.h"
+#include "roff.h"

 #include "libmandoc.h"
 #include "libroff.h"
 
 #include "libmandoc.h"
 #include "libroff.h"
 


@@ -145,7 +146,7 @@ static      const char *const eqn_func[] = {
 };
 
 enum   eqn_symt {
 };
 
 enum   eqn_symt {

-       EQNSYM_alpha,
+       EQNSYM_alpha = 0,

        EQNSYM_beta,
        EQNSYM_chi,
        EQNSYM_delta,
        EQNSYM_beta,
        EQNSYM_chi,
        EQNSYM_delta,


@@ -276,275 +277,195 @@ static  const struct eqnsym eqnsyms[EQNSYM__MAX] = {
        { "-", "mi" }, /* EQNSYM_minus */
 };
 
        { "-", "mi" }, /* EQNSYM_minus */
 };
 

+enum   parse_mode {
+       MODE_QUOTED,
+       MODE_NOSUB,
+       MODE_SUB,
+       MODE_TOK
+};
+

 static struct eqn_box  *eqn_box_alloc(struct eqn_node *, struct eqn_box *);
 static struct eqn_box  *eqn_box_alloc(struct eqn_node *, struct eqn_box *);

-static void             eqn_box_free(struct eqn_box *);

 static struct eqn_box  *eqn_box_makebinary(struct eqn_node *,
 static struct eqn_box  *eqn_box_makebinary(struct eqn_node *,

-                               enum eqn_post, struct eqn_box *);
+                               struct eqn_box *);

 static void             eqn_def(struct eqn_node *);
 static void             eqn_def(struct eqn_node *);

-static struct eqn_def  *eqn_def_find(struct eqn_node *, const char *, size_t);
+static struct eqn_def  *eqn_def_find(struct eqn_node *);

 static void             eqn_delim(struct eqn_node *);
 static void             eqn_delim(struct eqn_node *);

-static const char      *eqn_next(struct eqn_node *, char, size_t *, int);
-static const char      *eqn_nextrawtok(struct eqn_node *, size_t *);
-static const char      *eqn_nexttok(struct eqn_node *, size_t *);
-static enum rofferr     eqn_parse(struct eqn_node *, struct eqn_box *);
-static enum eqn_tok     eqn_tok_parse(struct eqn_node *, char **);
+static enum eqn_tok     eqn_next(struct eqn_node *, enum parse_mode);

 static void             eqn_undef(struct eqn_node *);
 
 
 static void             eqn_undef(struct eqn_node *);
 
 

-enum rofferr
-eqn_read(struct eqn_node **epp, int ln,
-               const char *p, int pos, int *offs)
+struct eqn_node *
+eqn_alloc(struct mparse *parse)

 {
 {

-       size_t           sz;
-       struct eqn_node *ep;
-       enum rofferr     er;
-
-       ep = *epp;
-
-       /*
-        * If we're the terminating mark, unset our equation status and
-        * validate the full equation.
-        */
-
-       if (0 == strncmp(p, ".EN", 3)) {
-               er = eqn_end(epp);
-               p += 3;
-               while (' ' == *p || '\t' == *p)
-                       p++;
-               if ('\0' == *p)
-                       return er;
-               mandoc_vmsg(MANDOCERR_ARG_SKIP, ep->parse,
-                   ln, pos, "EN %s", p);
-               return er;
-       }
-
-       /*
-        * Build up the full string, replacing all newlines with regular
-        * whitespace.
-        */
-
-       sz = strlen(p + pos) + 1;
-       ep->data = mandoc_realloc(ep->data, ep->sz + sz + 1);
-
-       /* First invocation: nil terminate the string. */
+       struct eqn_node *ep;

 
 

-       if (0 == ep->sz)
-               *ep->data = '\0';
-
-       ep->sz += sz;
-       strlcat(ep->data, p + pos, ep->sz + 1);
-       strlcat(ep->data, " ", ep->sz + 1);
-       return ROFF_IGN;
+       ep = mandoc_calloc(1, sizeof(*ep));
+       ep->parse = parse;
+       ep->gsize = EQN_DEFSIZE;
+       return ep;

 }
 
 }
 

-struct eqn_node *
-eqn_alloc(int pos, int line, struct mparse *parse)
+void
+eqn_reset(struct eqn_node *ep)

 {
 {

-       struct eqn_node *p;
-
-       p = mandoc_calloc(1, sizeof(struct eqn_node));
+       free(ep->data);
+       ep->data = ep->start = ep->end = NULL;
+       ep->sz = ep->toksz = 0;
+}

 
 

-       p->parse = parse;
-       p->eqn.ln = line;
-       p->eqn.pos = pos;
-       p->gsize = EQN_DEFSIZE;
+void
+eqn_read(struct eqn_node *ep, const char *p)
+{
+       char            *cp;

 
 

-       return p;
+       if (ep->data == NULL) {
+               ep->sz = strlen(p);
+               ep->data = mandoc_strdup(p);
+       } else {
+               ep->sz = mandoc_asprintf(&cp, "%s %s", ep->data, p);
+               free(ep->data);
+               ep->data = cp;
+       }
+       ep->sz += 1;

 }
 
 /*
  * Find the key "key" of the give size within our eqn-defined values.
  */
 static struct eqn_def *
 }
 
 /*
  * Find the key "key" of the give size within our eqn-defined values.
  */
 static struct eqn_def *

-eqn_def_find(struct eqn_node *ep, const char *key, size_t sz)
+eqn_def_find(struct eqn_node *ep)

 {
        int              i;
 
        for (i = 0; i < (int)ep->defsz; i++)
                if (ep->defs[i].keysz && STRNEQ(ep->defs[i].key,
 {
        int              i;
 
        for (i = 0; i < (int)ep->defsz; i++)
                if (ep->defs[i].keysz && STRNEQ(ep->defs[i].key,

-                   ep->defs[i].keysz, key, sz))
+                   ep->defs[i].keysz, ep->start, ep->toksz))

                        return &ep->defs[i];
 
        return NULL;
 }
 
 /*
                        return &ep->defs[i];
 
        return NULL;
 }
 
 /*

- * Get the next token from the input stream using the given quote
- * character.
- * Optionally make any replacements.
+ * Parse a token from the input text.  The modes are:
+ * MODE_QUOTED: Use *ep->start as the delimiter; the token ends
+ *   before its next occurence.  Do not interpret the token in any
+ *   way and return EQN_TOK_QUOTED.  All other modes behave like
+ *   MODE_QUOTED when *ep->start is '"'.
+ * MODE_NOSUB: If *ep->start is a curly brace, the token ends after it;
+ *   otherwise, it ends before the next whitespace or brace.
+ *   Do not interpret the token and return EQN_TOK__MAX.
+ * MODE_SUB: Like MODE_NOSUB, but try to interpret the token as an
+ *   alias created with define.  If it is an alias, replace it with
+ *   its string value and reparse.
+ * MODE_TOK: Like MODE_SUB, but also check the token against the list
+ *   of tokens, and if there is a match, return that token.  Otherwise,
+ *   if the token matches a symbol, return EQN_TOK_SYM; if it matches
+ *   a function name, EQN_TOK_FUNC, or else EQN_TOK__MAX.  Except for
+ *   a token match, *ep->start is set to an allocated string that the
+ *   caller is expected to free.
+ * All modes skip whitespace following the end of the token.

  */
  */

-static const char *
-eqn_next(struct eqn_node *ep, char quote, size_t *sz, int repl)
+static enum eqn_tok
+eqn_next(struct eqn_node *ep, enum parse_mode mode)

 {
 {

-       static size_t    last_len;
-       static int       lim;
+       static int       last_len, lim;

 
 

-       char            *start, *next;
-       int              q, diff;
-       size_t           ssz, dummy;

        struct eqn_def  *def;
        struct eqn_def  *def;

+       size_t           start;
+       int              diff, i, quoted;
+       enum eqn_tok     tok;

 
 

-       if (NULL == sz)
-               sz = &dummy;
-
-       if (ep->cur >= last_len)
+       /*
+        * Reset the recursion counter after advancing
+        * beyond the end of the previous substitution.
+        */
+       if (ep->end - ep->data >= last_len)

                lim = 0;
                lim = 0;

-       ep->rew = ep->cur;
-again:
-       /* Prevent self-definitions. */
-
-       if (lim >= EQN_NEST_MAX) {
-               mandoc_msg(MANDOCERR_ROFFLOOP, ep->parse,
-                   ep->eqn.ln, ep->eqn.pos, NULL);
-               return NULL;
-       }
-
-       ep->cur = ep->rew;
-       start = &ep->data[(int)ep->cur];
-       q = 0;

 
 

-       if ('\0' == *start)
-               return NULL;
-
-       if (quote == *start) {
-               ep->cur++;
-               q = 1;
-       }
-
-       start = &ep->data[(int)ep->cur];
-
-       if ( ! q) {
-               if ('{' == *start || '}' == *start)
-                       ssz = 1;
-               else
-                       ssz = strcspn(start + 1, " ^~\"{}\t") + 1;
-               next = start + (int)ssz;
-               if ('\0' == *next)
-                       next = NULL;
-       } else
-               next = strchr(start, quote);
-
-       if (NULL != next) {
-               *sz = (size_t)(next - start);
-               ep->cur += *sz;
-               if (q)
-                       ep->cur++;
-               while (' ' == ep->data[(int)ep->cur] ||
-                   '\t' == ep->data[(int)ep->cur] ||
-                   '^' == ep->data[(int)ep->cur] ||
-                   '~' == ep->data[(int)ep->cur])
-                       ep->cur++;
-       } else {
-               if (q)
-                       mandoc_msg(MANDOCERR_ARG_QUOTE, ep->parse,
-                           ep->eqn.ln, ep->eqn.pos, NULL);
-               next = strchr(start, '\0');
-               *sz = (size_t)(next - start);
-               ep->cur += *sz;
-       }
-
-       /* Quotes aren't expanded for values. */
-
-       if (q || ! repl)
-               return start;
-
-       if (NULL != (def = eqn_def_find(ep, start, *sz))) {
-               diff = def->valsz - *sz;
+       ep->start = ep->end;
+       quoted = mode == MODE_QUOTED;
+       for (;;) {
+               switch (*ep->start) {
+               case '\0':
+                       ep->toksz = 0;
+                       return EQN_TOK_EOF;
+               case '"':
+                       quoted = 1;
+                       break;
+               default:
+                       break;
+               }
+               if (quoted) {
+                       ep->end = strchr(ep->start + 1, *ep->start);
+                       ep->start++;  /* Skip opening quote. */
+                       if (ep->end == NULL) {
+                               mandoc_msg(MANDOCERR_ARG_QUOTE, ep->parse,
+                                   ep->node->line, ep->node->pos, NULL);
+                               ep->end = strchr(ep->start, '\0');
+                       }
+               } else {
+                       ep->end = ep->start + 1;
+                       if (*ep->start != '{' && *ep->start != '}')
+                               ep->end += strcspn(ep->end, " ^~\"{}\t");
+               }
+               ep->toksz = ep->end - ep->start;
+               if (quoted && *ep->end != '\0')
+                       ep->end++;  /* Skip closing quote. */
+               while (*ep->end != '\0' && strchr(" \t^~", *ep->end) != NULL)
+                       ep->end++;
+               if (quoted)  /* Cannot return, may have to strndup. */
+                       break;
+               if (mode == MODE_NOSUB)
+                       return EQN_TOK__MAX;
+               if ((def = eqn_def_find(ep)) == NULL)
+                       break;
+               if (++lim > EQN_NEST_MAX) {
+                       mandoc_msg(MANDOCERR_ROFFLOOP, ep->parse,
+                           ep->node->line, ep->node->pos, NULL);
+                       return EQN_TOK_EOF;
+               }

 
 

-               if (def->valsz > *sz) {
+               /* Replace a defined name with its string value. */
+               if ((diff = def->valsz - ep->toksz) > 0) {
+                       start = ep->start - ep->data;

                        ep->sz += diff;
                        ep->data = mandoc_realloc(ep->data, ep->sz + 1);
                        ep->sz += diff;
                        ep->data = mandoc_realloc(ep->data, ep->sz + 1);

-                       ep->data[ep->sz] = '\0';
-                       start = &ep->data[(int)ep->rew];
+                       ep->start = ep->data + start;

                }
                }

-
-               diff = def->valsz - *sz;
-               memmove(start + *sz + diff, start + *sz,
-                   (strlen(start) - *sz) + 1);
-               memcpy(start, def->val, def->valsz);
-               last_len = start - ep->data + def->valsz;
-               lim++;
-               goto again;
+               if (diff)
+                       memmove(ep->start + def->valsz, ep->start + ep->toksz,
+                           strlen(ep->start + ep->toksz) + 1);
+               memcpy(ep->start, def->val, def->valsz);
+               last_len = ep->start - ep->data + def->valsz;

        }
        }

-
-       return start;
-}
-
-/*
- * Get the next delimited token using the default current quote
- * character.
- */
-static const char *
-eqn_nexttok(struct eqn_node *ep, size_t *sz)
-{
-
-       return eqn_next(ep, '"', sz, 1);
-}
-
-/*
- * Get next token without replacement.
- */
-static const char *
-eqn_nextrawtok(struct eqn_node *ep, size_t *sz)
-{
-
-       return eqn_next(ep, '"', sz, 0);
-}
-
-/*
- * Parse a token from the stream of text.
- * A token consists of one of the recognised eqn(7) strings.
- * Strings are separated by delimiting marks.
- * This returns EQN_TOK_EOF when there are no more tokens.
- * If the token is an unrecognised string literal, then it returns
- * EQN_TOK__MAX and sets the "p" pointer to an allocated, nil-terminated
- * string.
- * This must be later freed with free(3).
- */
-static enum eqn_tok
-eqn_tok_parse(struct eqn_node *ep, char **p)
-{
-       const char      *start;
-       size_t           i, sz;
-       int              quoted;
-
-       if (p != NULL)
-               *p = NULL;
-
-       quoted = ep->data[ep->cur] == '"';
-
-       if ((start = eqn_nexttok(ep, &sz)) == NULL)
-               return EQN_TOK_EOF;
-
+       if (mode != MODE_TOK)
+               return quoted ? EQN_TOK_QUOTED : EQN_TOK__MAX;

        if (quoted) {
        if (quoted) {

-               if (p != NULL)
-                       *p = mandoc_strndup(start, sz);
+               ep->start = mandoc_strndup(ep->start, ep->toksz);

                return EQN_TOK_QUOTED;
        }
                return EQN_TOK_QUOTED;
        }

-
-       for (i = 0; i < EQN_TOK__MAX; i++)
-               if (STRNEQ(start, sz, eqn_toks[i], strlen(eqn_toks[i])))
-                       return i;
+       for (tok = 0; tok < EQN_TOK__MAX; tok++)
+               if (STRNEQ(ep->start, ep->toksz,
+                   eqn_toks[tok], strlen(eqn_toks[tok])))
+                       return tok;

 
        for (i = 0; i < EQNSYM__MAX; i++) {
 
        for (i = 0; i < EQNSYM__MAX; i++) {

-               if (STRNEQ(start, sz,
+               if (STRNEQ(ep->start, ep->toksz,

                    eqnsyms[i].str, strlen(eqnsyms[i].str))) {
                    eqnsyms[i].str, strlen(eqnsyms[i].str))) {

-                       mandoc_asprintf(p, "\\[%s]", eqnsyms[i].sym);
+                       mandoc_asprintf(&ep->start,
+                           "\\[%s]", eqnsyms[i].sym);

                        return EQN_TOK_SYM;
                }
        }
                        return EQN_TOK_SYM;
                }
        }

-
-       if (p != NULL)
-               *p = mandoc_strndup(start, sz);
-
-       for (i = 0; i < sizeof(eqn_func)/sizeof(*eqn_func); i++)
-               if (STRNEQ(start, sz, eqn_func[i], strlen(eqn_func[i])))
+       ep->start = mandoc_strndup(ep->start, ep->toksz);
+       for (i = 0; i < (int)(sizeof(eqn_func)/sizeof(*eqn_func)); i++)
+               if (STRNEQ(ep->start, ep->toksz,
+                   eqn_func[i], strlen(eqn_func[i])))

                        return EQN_TOK_FUNC;
                        return EQN_TOK_FUNC;

-

        return EQN_TOK__MAX;
 }
 
        return EQN_TOK__MAX;
 }
 

-static void
+void

 eqn_box_free(struct eqn_box *bp)
 {
 
 eqn_box_free(struct eqn_box *bp)
 {
 


@@ -593,8 +514,7 @@ eqn_box_alloc(struct eqn_node *ep, struct eqn_box *parent)
  * The new EQN_SUBEXPR will have a two-child limit.
  */
 static struct eqn_box *
  * The new EQN_SUBEXPR will have a two-child limit.
  */
 static struct eqn_box *

-eqn_box_makebinary(struct eqn_node *ep,
-       enum eqn_post pos, struct eqn_box *parent)
+eqn_box_makebinary(struct eqn_node *ep, struct eqn_box *parent)

 {
        struct eqn_box  *b, *newb;
 
 {
        struct eqn_box  *b, *newb;
 


@@ -606,7 +526,6 @@ eqn_box_makebinary(struct eqn_node *ep,
        parent->last = b->prev;
        b->prev = NULL;
        newb = eqn_box_alloc(ep, parent);
        parent->last = b->prev;
        b->prev = NULL;
        newb = eqn_box_alloc(ep, parent);

-       newb->pos = pos;

        newb->type = EQN_SUBEXPR;
        newb->expectargs = 2;
        newb->args = 1;
        newb->type = EQN_SUBEXPR;
        newb->expectargs = 2;
        newb->args = 1;


@@ -622,20 +541,21 @@ eqn_box_makebinary(struct eqn_node *ep,
 static void
 eqn_delim(struct eqn_node *ep)
 {
 static void
 eqn_delim(struct eqn_node *ep)
 {

-       const char      *start;
-       size_t           sz;
-
-       if ((start = eqn_nextrawtok(ep, &sz)) == NULL)
+       if (ep->end[0] == '\0' || ep->end[1] == '\0') {

                mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                   ep->eqn.ln, ep->eqn.pos, "delim");
-       else if (strncmp(start, "off", 3) == 0)
+                   ep->node->line, ep->node->pos, "delim");
+               if (ep->end[0] != '\0')
+                       ep->end++;
+       } else if (strncmp(ep->end, "off", 3) == 0) {

                ep->delim = 0;
                ep->delim = 0;

-       else if (strncmp(start, "on", 2) == 0) {
+               ep->end += 3;
+       } else if (strncmp(ep->end, "on", 2) == 0) {

                if (ep->odelim && ep->cdelim)
                        ep->delim = 1;
                if (ep->odelim && ep->cdelim)
                        ep->delim = 1;

-       } else if (start[1] != '\0') {
-               ep->odelim = start[0];
-               ep->cdelim = start[1];
+               ep->end += 2;
+       } else {
+               ep->odelim = *ep->end++;
+               ep->cdelim = *ep->end++;

                ep->delim = 1;
        }
 }
                ep->delim = 1;
        }
 }


@@ -646,16 +566,14 @@ eqn_delim(struct eqn_node *ep)
 static void
 eqn_undef(struct eqn_node *ep)
 {
 static void
 eqn_undef(struct eqn_node *ep)
 {

-       const char      *start;

        struct eqn_def  *def;
        struct eqn_def  *def;

-       size_t           sz;

 
 

-       if ((start = eqn_nextrawtok(ep, &sz)) == NULL) {
+       if (eqn_next(ep, MODE_NOSUB) == EQN_TOK_EOF) {

                mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                   ep->eqn.ln, ep->eqn.pos, "undef");
+                   ep->node->line, ep->node->pos, "undef");

                return;
        }
                return;
        }

-       if ((def = eqn_def_find(ep, start, sz)) == NULL)
+       if ((def = eqn_def_find(ep)) == NULL)

                return;
        free(def->key);
        free(def->val);
                return;
        free(def->key);
        free(def->val);


@@ -666,14 +584,12 @@ eqn_undef(struct eqn_node *ep)
 static void
 eqn_def(struct eqn_node *ep)
 {
 static void
 eqn_def(struct eqn_node *ep)
 {

-       const char      *start;
-       size_t           sz;

        struct eqn_def  *def;
        int              i;
 
        struct eqn_def  *def;
        int              i;
 

-       if ((start = eqn_nextrawtok(ep, &sz)) == NULL) {
+       if (eqn_next(ep, MODE_NOSUB) == EQN_TOK_EOF) {

                mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                   ep->eqn.ln, ep->eqn.pos, "define");
+                   ep->node->line, ep->node->pos, "define");

                return;
        }
 
                return;
        }
 


@@ -681,7 +597,7 @@ eqn_def(struct eqn_node *ep)
         * Search for a key that already exists.
         * Create a new key if none is found.
         */
         * Search for a key that already exists.
         * Create a new key if none is found.
         */

-       if (NULL == (def = eqn_def_find(ep, start, sz))) {
+       if ((def = eqn_def_find(ep)) == NULL) {

                /* Find holes in string array. */
                for (i = 0; i < (int)ep->defsz; i++)
                        if (0 == ep->defs[i].keysz)
                /* Find holes in string array. */
                for (i = 0; i < (int)ep->defsz; i++)
                        if (0 == ep->defs[i].keysz)


@@ -696,14 +612,13 @@ eqn_def(struct eqn_node *ep)
 
                def = ep->defs + i;
                free(def->key);
 
                def = ep->defs + i;
                free(def->key);

-               def->key = mandoc_strndup(start, sz);
-               def->keysz = sz;
+               def->key = mandoc_strndup(ep->start, ep->toksz);
+               def->keysz = ep->toksz;

        }
 
        }
 

-       start = eqn_next(ep, ep->data[(int)ep->cur], &sz, 0);
-       if (start == NULL) {
+       if (eqn_next(ep, MODE_QUOTED) == EQN_TOK_EOF) {

                mandoc_vmsg(MANDOCERR_REQ_EMPTY, ep->parse,
                mandoc_vmsg(MANDOCERR_REQ_EMPTY, ep->parse,

-                   ep->eqn.ln, ep->eqn.pos, "define %s", def->key);
+                   ep->node->line, ep->node->pos, "define %s", def->key);

                free(def->key);
                free(def->val);
                def->key = def->val = NULL;
                free(def->key);
                free(def->val);
                def->key = def->val = NULL;


@@ -711,26 +626,21 @@ eqn_def(struct eqn_node *ep)
                return;
        }
        free(def->val);
                return;
        }
        free(def->val);

-       def->val = mandoc_strndup(start, sz);
-       def->valsz = sz;
+       def->val = mandoc_strndup(ep->start, ep->toksz);
+       def->valsz = ep->toksz;

 }
 
 }
 

-/*
- * Recursively parse an eqn(7) expression.
- */
-static enum rofferr
-eqn_parse(struct eqn_node *ep, struct eqn_box *parent)
+void
+eqn_parse(struct eqn_node *ep)

 {
 {

-       char             sym[64];
-       struct eqn_box  *cur, *nbox, *split;
-       const char      *cp, *cpn, *start;
+       struct eqn_box  *cur, *nbox, *parent, *split;
+       const char      *cp, *cpn;

        char            *p;
        char            *p;

-       size_t           sz;
-       enum eqn_tok     tok, subtok;
-       enum eqn_post    pos;
+       enum eqn_tok     tok;

        enum { CCL_LET, CCL_DIG, CCL_PUN } ccl, ccln;
        int              size;
 
        enum { CCL_LET, CCL_DIG, CCL_PUN } ccl, ccln;
        int              size;
 

+       parent = ep->node->eqn;

        assert(parent != NULL);
 
        /*
        assert(parent != NULL);
 
        /*


@@ -739,12 +649,12 @@ eqn_parse(struct eqn_node *ep, struct eqn_box *parent)
         */
 
        if (ep->data == NULL)
         */
 
        if (ep->data == NULL)

-               return ROFF_IGN;
+               return;

 
 

-next_tok:
-       tok = eqn_tok_parse(ep, &p);
+       ep->start = ep->end = ep->data + strspn(ep->data, " ^~");

 
 

-this_tok:
+next_tok:
+       tok = eqn_next(ep, MODE_TOK);

        switch (tok) {
        case EQN_TOK_UNDEF:
                eqn_undef(ep);
        switch (tok) {
        case EQN_TOK_UNDEF:
                eqn_undef(ep);


@@ -754,18 +664,18 @@ this_tok:
                eqn_def(ep);
                break;
        case EQN_TOK_TDEFINE:
                eqn_def(ep);
                break;
        case EQN_TOK_TDEFINE:

-               if (eqn_nextrawtok(ep, NULL) == NULL ||
-                   eqn_next(ep, ep->data[(int)ep->cur], NULL, 0) == NULL)
+               if (eqn_next(ep, MODE_NOSUB) == EQN_TOK_EOF ||
+                   eqn_next(ep, MODE_QUOTED) == EQN_TOK_EOF)

                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, "tdefine");
+                           ep->node->line, ep->node->pos, "tdefine");

                break;
        case EQN_TOK_DELIM:
                eqn_delim(ep);
                break;
        case EQN_TOK_GFONT:
                break;
        case EQN_TOK_DELIM:
                eqn_delim(ep);
                break;
        case EQN_TOK_GFONT:

-               if (eqn_nextrawtok(ep, NULL) == NULL)
+               if (eqn_next(ep, MODE_SUB) == EQN_TOK_EOF)

                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                break;
        case EQN_TOK_MARK:
        case EQN_TOK_LINEUP:
                break;
        case EQN_TOK_MARK:
        case EQN_TOK_LINEUP:


@@ -781,56 +691,39 @@ this_tok:
        case EQN_TOK_DOTDOT:
                if (parent->last == NULL) {
                        mandoc_msg(MANDOCERR_EQN_NOBOX, ep->parse,
        case EQN_TOK_DOTDOT:
                if (parent->last == NULL) {
                        mandoc_msg(MANDOCERR_EQN_NOBOX, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        cur = eqn_box_alloc(ep, parent);
                        cur->type = EQN_TEXT;
                        cur->text = mandoc_strdup("");
                }
                        cur = eqn_box_alloc(ep, parent);
                        cur->type = EQN_TEXT;
                        cur->text = mandoc_strdup("");
                }

-               parent = eqn_box_makebinary(ep, EQNPOS_NONE, parent);
-               parent->type = EQN_LISTONE;
+               parent = eqn_box_makebinary(ep, parent);
+               parent->type = EQN_LIST;

                parent->expectargs = 1;
                parent->font = EQNFONT_ROMAN;
                switch (tok) {
                case EQN_TOK_DOTDOT:
                parent->expectargs = 1;
                parent->font = EQNFONT_ROMAN;
                switch (tok) {
                case EQN_TOK_DOTDOT:

-                       strlcpy(sym, "\\[ad]", sizeof(sym));
+                       parent->top = mandoc_strdup("\\[ad]");

                        break;
                case EQN_TOK_VEC:
                        break;
                case EQN_TOK_VEC:

-                       strlcpy(sym, "\\[->]", sizeof(sym));
+                       parent->top = mandoc_strdup("\\[->]");

                        break;
                case EQN_TOK_DYAD:
                        break;
                case EQN_TOK_DYAD:

-                       strlcpy(sym, "\\[<>]", sizeof(sym));
+                       parent->top = mandoc_strdup("\\[<>]");

                        break;
                case EQN_TOK_TILDE:
                        break;
                case EQN_TOK_TILDE:

-                       strlcpy(sym, "\\[a~]", sizeof(sym));
+                       parent->top = mandoc_strdup("\\[a~]");

                        break;
                case EQN_TOK_UNDER:
                        break;
                case EQN_TOK_UNDER:

-                       strlcpy(sym, "\\[ul]", sizeof(sym));
+                       parent->bottom = mandoc_strdup("\\[ul]");

                        break;
                case EQN_TOK_BAR:
                        break;
                case EQN_TOK_BAR:

-                       strlcpy(sym, "\\[rl]", sizeof(sym));
+                       parent->top = mandoc_strdup("\\[rn]");

                        break;
                case EQN_TOK_DOT:
                        break;
                case EQN_TOK_DOT:

-                       strlcpy(sym, "\\[a.]", sizeof(sym));
-                       break;
-               case EQN_TOK_HAT:
-                       strlcpy(sym, "\\[ha]", sizeof(sym));
+                       parent->top = mandoc_strdup("\\[a.]");

                        break;
                        break;

-               default:
-                       abort();
-               }
-
-               switch (tok) {
-               case EQN_TOK_DOTDOT:
-               case EQN_TOK_VEC:
-               case EQN_TOK_DYAD:
-               case EQN_TOK_TILDE:
-               case EQN_TOK_BAR:
-               case EQN_TOK_DOT:

                case EQN_TOK_HAT:
                case EQN_TOK_HAT:

-                       parent->top = mandoc_strdup(sym);
-                       break;
-               case EQN_TOK_UNDER:
-                       parent->bottom = mandoc_strdup(sym);
+                       parent->top = mandoc_strdup("\\[ha]");

                        break;
                default:
                        abort();
                        break;
                default:
                        abort();


@@ -841,13 +734,9 @@ this_tok:
        case EQN_TOK_BACK:
        case EQN_TOK_DOWN:
        case EQN_TOK_UP:
        case EQN_TOK_BACK:
        case EQN_TOK_DOWN:
        case EQN_TOK_UP:

-               subtok = eqn_tok_parse(ep, NULL);
-               if (subtok != EQN_TOK__MAX) {
+               if (eqn_next(ep, MODE_SUB) == EQN_TOK_EOF)

                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
-                       tok = subtok;
-                       goto this_tok;
-               }
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                break;
        case EQN_TOK_FAT:
        case EQN_TOK_ROMAN:
                break;
        case EQN_TOK_FAT:
        case EQN_TOK_ROMAN:


@@ -861,7 +750,7 @@ this_tok:
                 * exactly one of those.
                 */
                parent = eqn_box_alloc(ep, parent);
                 * exactly one of those.
                 */
                parent = eqn_box_alloc(ep, parent);

-               parent->type = EQN_LISTONE;
+               parent->type = EQN_LIST;

                parent->expectargs = 1;
                switch (tok) {
                case EQN_TOK_FAT:
                parent->expectargs = 1;
                switch (tok) {
                case EQN_TOK_FAT:


@@ -883,23 +772,25 @@ this_tok:
        case EQN_TOK_SIZE:
        case EQN_TOK_GSIZE:
                /* Accept two values: integral size and a single. */
        case EQN_TOK_SIZE:
        case EQN_TOK_GSIZE:
                /* Accept two values: integral size and a single. */

-               if (NULL == (start = eqn_nexttok(ep, &sz))) {
+               if (eqn_next(ep, MODE_SUB) == EQN_TOK_EOF) {

                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        break;
                }
                        break;
                }

-               size = mandoc_strntoi(start, sz, 10);
+               size = mandoc_strntoi(ep->start, ep->toksz, 10);

                if (-1 == size) {
                        mandoc_msg(MANDOCERR_IT_NONUM, ep->parse,
                if (-1 == size) {
                        mandoc_msg(MANDOCERR_IT_NONUM, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        break;
                }
                if (EQN_TOK_GSIZE == tok) {
                        ep->gsize = size;
                        break;
                }
                        break;
                }
                if (EQN_TOK_GSIZE == tok) {
                        ep->gsize = size;
                        break;
                }

+               while (parent->args == parent->expectargs)
+                       parent = parent->parent;

                parent = eqn_box_alloc(ep, parent);
                parent = eqn_box_alloc(ep, parent);

-               parent->type = EQN_LISTONE;
+               parent->type = EQN_LIST;

                parent->expectargs = 1;
                parent->size = size;
                break;
                parent->expectargs = 1;
                parent->size = size;
                break;


@@ -914,39 +805,51 @@ this_tok:
                 */
                if (parent->last == NULL) {
                        mandoc_msg(MANDOCERR_EQN_NOBOX, ep->parse,
                 */
                if (parent->last == NULL) {
                        mandoc_msg(MANDOCERR_EQN_NOBOX, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        cur = eqn_box_alloc(ep, parent);
                        cur->type = EQN_TEXT;
                        cur->text = mandoc_strdup("");
                }
                        cur = eqn_box_alloc(ep, parent);
                        cur->type = EQN_TEXT;
                        cur->text = mandoc_strdup("");
                }

-               /* Handle the "subsup" and "fromto" positions. */
-               if (EQN_TOK_SUP == tok && parent->pos == EQNPOS_SUB) {
+               while (parent->expectargs == 1 && parent->args == 1)
+                       parent = parent->parent;
+               if (tok == EQN_TOK_FROM || tok == EQN_TOK_TO)  {
+                       for (cur = parent; cur != NULL; cur = cur->parent)
+                               if (cur->pos == EQNPOS_SUB ||
+                                   cur->pos == EQNPOS_SUP ||
+                                   cur->pos == EQNPOS_SUBSUP ||
+                                   cur->pos == EQNPOS_SQRT ||
+                                   cur->pos == EQNPOS_OVER)
+                                       break;
+                       if (cur != NULL)
+                               parent = cur->parent;
+               }
+               if (tok == EQN_TOK_SUP && parent->pos == EQNPOS_SUB) {

                        parent->expectargs = 3;
                        parent->pos = EQNPOS_SUBSUP;
                        break;
                }
                        parent->expectargs = 3;
                        parent->pos = EQNPOS_SUBSUP;
                        break;
                }

-               if (EQN_TOK_TO == tok && parent->pos == EQNPOS_FROM) {
+               if (tok == EQN_TOK_TO && parent->pos == EQNPOS_FROM) {

                        parent->expectargs = 3;
                        parent->pos = EQNPOS_FROMTO;
                        break;
                }
                        parent->expectargs = 3;
                        parent->pos = EQNPOS_FROMTO;
                        break;
                }

+               parent = eqn_box_makebinary(ep, parent);

                switch (tok) {
                case EQN_TOK_FROM:
                switch (tok) {
                case EQN_TOK_FROM:

-                       pos = EQNPOS_FROM;
+                       parent->pos = EQNPOS_FROM;

                        break;
                case EQN_TOK_TO:
                        break;
                case EQN_TOK_TO:

-                       pos = EQNPOS_TO;
+                       parent->pos = EQNPOS_TO;

                        break;
                case EQN_TOK_SUP:
                        break;
                case EQN_TOK_SUP:

-                       pos = EQNPOS_SUP;
+                       parent->pos = EQNPOS_SUP;

                        break;
                case EQN_TOK_SUB:
                        break;
                case EQN_TOK_SUB:

-                       pos = EQNPOS_SUB;
+                       parent->pos = EQNPOS_SUB;

                        break;
                default:
                        abort();
                }
                        break;
                default:
                        abort();
                }

-               parent = eqn_box_makebinary(ep, pos, parent);

                break;
        case EQN_TOK_SQRT:
                while (parent->args == parent->expectargs)
                break;
        case EQN_TOK_SQRT:
                while (parent->args == parent->expectargs)


@@ -969,14 +872,17 @@ this_tok:
                 */
                if (parent->last == NULL) {
                        mandoc_msg(MANDOCERR_EQN_NOBOX, ep->parse,
                 */
                if (parent->last == NULL) {
                        mandoc_msg(MANDOCERR_EQN_NOBOX, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        cur = eqn_box_alloc(ep, parent);
                        cur->type = EQN_TEXT;
                        cur->text = mandoc_strdup("");
                }
                        cur = eqn_box_alloc(ep, parent);
                        cur->type = EQN_TEXT;
                        cur->text = mandoc_strdup("");
                }

+               while (parent->args == parent->expectargs)
+                       parent = parent->parent;

                while (EQN_SUBEXPR == parent->type)
                        parent = parent->parent;
                while (EQN_SUBEXPR == parent->type)
                        parent = parent->parent;

-               parent = eqn_box_makebinary(ep, EQNPOS_OVER, parent);
+               parent = eqn_box_makebinary(ep, parent);
+               parent->pos = EQNPOS_OVER;

                break;
        case EQN_TOK_RIGHT:
        case EQN_TOK_BRACE_CLOSE:
                break;
        case EQN_TOK_RIGHT:
        case EQN_TOK_BRACE_CLOSE:


@@ -987,31 +893,31 @@ this_tok:
                 */
                for (cur = parent; cur != NULL; cur = cur->parent)
                        if (cur->type == EQN_LIST &&
                 */
                for (cur = parent; cur != NULL; cur = cur->parent)
                        if (cur->type == EQN_LIST &&

+                           cur->expectargs > 1 &&

                            (tok == EQN_TOK_BRACE_CLOSE ||
                             cur->left != NULL))
                                break;
                if (cur == NULL) {
                        mandoc_msg(MANDOCERR_BLK_NOTOPEN, ep->parse,
                            (tok == EQN_TOK_BRACE_CLOSE ||
                             cur->left != NULL))
                                break;
                if (cur == NULL) {
                        mandoc_msg(MANDOCERR_BLK_NOTOPEN, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        break;
                }
                parent = cur;
                if (EQN_TOK_RIGHT == tok) {
                        break;
                }
                parent = cur;
                if (EQN_TOK_RIGHT == tok) {

-                       if (NULL == (start = eqn_nexttok(ep, &sz))) {
+                       if (eqn_next(ep, MODE_SUB) == EQN_TOK_EOF) {

                                mandoc_msg(MANDOCERR_REQ_EMPTY,
                                mandoc_msg(MANDOCERR_REQ_EMPTY,

-                                   ep->parse, ep->eqn.ln,
-                                   ep->eqn.pos, eqn_toks[tok]);
+                                   ep->parse, ep->node->line,
+                                   ep->node->pos, eqn_toks[tok]);

                                break;
                        }
                        /* Handling depends on right/left. */
                                break;
                        }
                        /* Handling depends on right/left. */

-                       if (STRNEQ(start, sz, "ceiling", 7)) {
-                               strlcpy(sym, "\\[rc]", sizeof(sym));
-                               parent->right = mandoc_strdup(sym);
-                       } else if (STRNEQ(start, sz, "floor", 5)) {
-                               strlcpy(sym, "\\[rf]", sizeof(sym));
-                               parent->right = mandoc_strdup(sym);
-                       } else
-                               parent->right = mandoc_strndup(start, sz);
+                       if (STRNEQ(ep->start, ep->toksz, "ceiling", 7))
+                               parent->right = mandoc_strdup("\\[rc]");
+                       else if (STRNEQ(ep->start, ep->toksz, "floor", 5))
+                               parent->right = mandoc_strdup("\\[rf]");
+                       else
+                               parent->right =
+                                   mandoc_strndup(ep->start, ep->toksz);

                }
                parent = parent->parent;
                if (tok == EQN_TOK_BRACE_CLOSE &&
                }
                parent = parent->parent;
                if (tok == EQN_TOK_BRACE_CLOSE &&


@@ -1019,8 +925,9 @@ this_tok:
                     parent->type == EQN_MATRIX))
                        parent = parent->parent;
                /* Close out any "singleton" lists. */
                     parent->type == EQN_MATRIX))
                        parent = parent->parent;
                /* Close out any "singleton" lists. */

-               while (parent->type == EQN_LISTONE &&
-                   parent->args == parent->expectargs)
+               while (parent->type == EQN_LIST &&
+                   parent->expectargs == 1 &&
+                   parent->args == 1)

                        parent = parent->parent;
                break;
        case EQN_TOK_BRACE_OPEN:
                        parent = parent->parent;
                break;
        case EQN_TOK_BRACE_OPEN:


@@ -1033,22 +940,21 @@ this_tok:
                while (parent->args == parent->expectargs)
                        parent = parent->parent;
                if (EQN_TOK_LEFT == tok &&
                while (parent->args == parent->expectargs)
                        parent = parent->parent;
                if (EQN_TOK_LEFT == tok &&

-                   (start = eqn_nexttok(ep, &sz)) == NULL) {
+                   eqn_next(ep, MODE_SUB) == EQN_TOK_EOF) {

                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,
                        mandoc_msg(MANDOCERR_REQ_EMPTY, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        break;
                }
                parent = eqn_box_alloc(ep, parent);
                parent->type = EQN_LIST;
                if (EQN_TOK_LEFT == tok) {
                        break;
                }
                parent = eqn_box_alloc(ep, parent);
                parent->type = EQN_LIST;
                if (EQN_TOK_LEFT == tok) {

-                       if (STRNEQ(start, sz, "ceiling", 7)) {
-                               strlcpy(sym, "\\[lc]", sizeof(sym));
-                               parent->left = mandoc_strdup(sym);
-                       } else if (STRNEQ(start, sz, "floor", 5)) {
-                               strlcpy(sym, "\\[lf]", sizeof(sym));
-                               parent->left = mandoc_strdup(sym);
-                       } else
-                               parent->left = mandoc_strndup(start, sz);
+                       if (STRNEQ(ep->start, ep->toksz, "ceiling", 7))
+                               parent->left = mandoc_strdup("\\[lc]");
+                       else if (STRNEQ(ep->start, ep->toksz, "floor", 5))
+                               parent->left = mandoc_strdup("\\[lf]");
+                       else
+                               parent->left =
+                                   mandoc_strndup(ep->start, ep->toksz);

                }
                break;
        case EQN_TOK_PILE:
                }
                break;
        case EQN_TOK_PILE:


@@ -1070,7 +976,7 @@ this_tok:
                                break;
                if (cur == NULL) {
                        mandoc_msg(MANDOCERR_IT_STRAY, ep->parse,
                                break;
                if (cur == NULL) {
                        mandoc_msg(MANDOCERR_IT_STRAY, ep->parse,

-                           ep->eqn.ln, ep->eqn.pos, eqn_toks[tok]);
+                           ep->node->line, ep->node->pos, eqn_toks[tok]);

                        break;
                }
                parent = eqn_box_alloc(ep, cur);
                        break;
                }
                parent = eqn_box_alloc(ep, cur);


@@ -1084,15 +990,12 @@ this_tok:
                parent->expectargs = 1;
                break;
        case EQN_TOK_EOF:
                parent->expectargs = 1;
                break;
        case EQN_TOK_EOF:

-               /*
-                * End of file!
-                * TODO: make sure we're not in an open subexpression.
-                */
-               return ROFF_EQN;
+               return;

        case EQN_TOK__MAX:
        case EQN_TOK_FUNC:
        case EQN_TOK_QUOTED:
        case EQN_TOK_SYM:
        case EQN_TOK__MAX:
        case EQN_TOK_FUNC:
        case EQN_TOK_QUOTED:
        case EQN_TOK_SYM:

+               p = ep->start;

                assert(p != NULL);
                /*
                 * If we already have something in the stack and we're
                assert(p != NULL);
                /*
                 * If we already have something in the stack and we're


@@ -1138,7 +1041,7 @@ this_tok:
                                /* No boundary after last character. */
                                if (*cpn == '\0')
                                        break;
                                /* No boundary after last character. */
                                if (*cpn == '\0')
                                        break;

-                               if (ccln == ccl)
+                               if (ccln == ccl && *cp != ',' && *cpn != ',')

                                        continue;
                                /* Boundary found, split the text. */
                                if (parent->args == parent->expectargs) {
                                        continue;
                                /* Boundary found, split the text. */
                                if (parent->args == parent->expectargs) {


@@ -1177,12 +1080,6 @@ this_tok:
                                parent = split->parent;
                        break;
                }
                                parent = split->parent;
                        break;
                }

-               /*
-                * Post-process list status.
-                */
-               while (parent->type == EQN_LISTONE &&
-                   parent->args == parent->expectargs)
-                       parent = parent->parent;

                break;
        default:
                abort();
                break;
        default:
                abort();


@@ -1190,26 +1087,11 @@ this_tok:
        goto next_tok;
 }
 
        goto next_tok;
 }
 

-enum rofferr
-eqn_end(struct eqn_node **epp)
-{
-       struct eqn_node *ep;
-
-       ep = *epp;
-       *epp = NULL;
-
-       ep->eqn.root = mandoc_calloc(1, sizeof(struct eqn_box));
-       ep->eqn.root->expectargs = UINT_MAX;
-       return eqn_parse(ep, ep->eqn.root);
-}
-

 void
 eqn_free(struct eqn_node *p)
 {
        int              i;
 
 void
 eqn_free(struct eqn_node *p)
 {
        int              i;
 

-       eqn_box_free(p->eqn.root);
-

        for (i = 0; i < (int)p->defsz; i++) {
                free(p->defs[i].key);
                free(p->defs[i].val);
        for (i = 0; i < (int)p->defsz; i++) {
                free(p->defs[i].key);
                free(p->defs[i].val);