Simplify handling of system errors: just exit(3).

[mandoc.git] / man.c

diff --git a/man.c b/man.c
index d500f1d1ea3190c5b4eb0e3245207519e2790c30..766272d92c5862f4f3b13132fe78229b411d637d 100644 (file)
--- a/man.c
+++ b/man.c
@@ -1,4 +1,4 @@
-/*     $Id: man.c,v 1.136 2014/08/01 17:27:44 schwarze Exp $ */
+/*     $Id: man.c,v 1.146 2014/12/28 14:42:27 schwarze Exp $ */

 /*
  * Copyright (c) 2008, 2009, 2010, 2011 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2013, 2014 Ingo Schwarze <schwarze@openbsd.org>
 /*
  * Copyright (c) 2008, 2009, 2010, 2011 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2013, 2014 Ingo Schwarze <schwarze@openbsd.org>


@@ -16,9 +16,7 @@
  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */

-#ifdef HAVE_CONFIG_H

 #include "config.h"
 #include "config.h"

-#endif

 
 #include <sys/types.h>
 
 
 #include <sys/types.h>
 


@@ -52,8 +50,7 @@ const char * const *man_macronames = __man_macronames;
 
 static struct man_node *man_node_alloc(struct man *, int, int,
                                enum man_type, enum mant);
 
 static struct man_node *man_node_alloc(struct man *, int, int,
                                enum man_type, enum mant);

-static int              man_node_append(struct man *,
-                               struct man_node *);
+static void             man_node_append(struct man *, struct man_node *);

 static void             man_node_free(struct man_node *);
 static void             man_node_unlink(struct man *,
                                struct man_node *);
 static void             man_node_free(struct man_node *);
 static void             man_node_unlink(struct man *,
                                struct man_node *);


@@ -61,7 +58,7 @@ static        int              man_ptext(struct man *, int, char *, int);
 static int              man_pmacro(struct man *, int, char *, int);
 static void             man_free1(struct man *);
 static void             man_alloc1(struct man *);
 static int              man_pmacro(struct man *, int, char *, int);
 static void             man_free1(struct man *);
 static void             man_alloc1(struct man *);

-static int              man_descope(struct man *, int, int);
+static void             man_descope(struct man *, int, int);

 
 
 const struct man_node *
 
 
 const struct man_node *


@@ -95,7 +92,8 @@ man_free(struct man *man)
 }
 
 struct man *
 }
 
 struct man *

-man_alloc(struct roff *roff, struct mparse *parse, int quick)
+man_alloc(struct roff *roff, struct mparse *parse,
+       const char *defos, int quick)

 {
        struct man      *p;
 
 {
        struct man      *p;
 


@@ -103,6 +101,7 @@ man_alloc(struct roff *roff, struct mparse *parse, int quick)
 
        man_hash_init();
        p->parse = parse;
 
        man_hash_init();
        p->parse = parse;

+       p->defos = defos;

        p->quick = quick;
        p->roff = roff;
 
        p->quick = quick;
        p->roff = roff;
 


@@ -114,14 +113,16 @@ int
 man_endparse(struct man *man)
 {
 
 man_endparse(struct man *man)
 {
 

-       return(man_macroend(man));
+       man_macroend(man);
+       return(1);

 }
 
 int
 man_parseln(struct man *man, int ln, char *buf, int offs)
 {
 
 }
 
 int
 man_parseln(struct man *man, int ln, char *buf, int offs)
 {
 

-       man->flags |= MAN_NEWLINE;
+       if (man->last->type != MAN_EQN || ln > man->last->line)
+               man->flags |= MAN_NEWLINE;

 
        return (roff_getcontrol(man->roff, buf, &offs) ?
            man_pmacro(man, ln, buf, offs) :
 
        return (roff_getcontrol(man->roff, buf, &offs) ?
            man_pmacro(man, ln, buf, offs) :


@@ -134,16 +135,11 @@ man_free1(struct man *man)
 
        if (man->first)
                man_node_delete(man, man->first);
 
        if (man->first)
                man_node_delete(man, man->first);

-       if (man->meta.title)
-               free(man->meta.title);
-       if (man->meta.source)
-               free(man->meta.source);
-       if (man->meta.date)
-               free(man->meta.date);
-       if (man->meta.vol)
-               free(man->meta.vol);
-       if (man->meta.msec)
-               free(man->meta.msec);
+       free(man->meta.title);
+       free(man->meta.source);
+       free(man->meta.date);
+       free(man->meta.vol);
+       free(man->meta.msec);

 }
 
 static void
 }
 
 static void


@@ -160,13 +156,13 @@ man_alloc1(struct man *man)
 }
 
 
 }
 
 

-static int
+static void

 man_node_append(struct man *man, struct man_node *p)
 {
 
        assert(man->last);
        assert(man->first);
 man_node_append(struct man *man, struct man_node *p)
 {
 
        assert(man->last);
        assert(man->first);

-       assert(MAN_ROOT != p->type);
+       assert(p->type != MAN_ROOT);

 
        switch (man->next) {
        case MAN_NEXT_SIBLING:
 
        switch (man->next) {
        case MAN_NEXT_SIBLING:


@@ -186,20 +182,17 @@ man_node_append(struct man *man, struct man_node *p)
        assert(p->parent);
        p->parent->nchild++;
 
        assert(p->parent);
        p->parent->nchild++;
 

-       if ( ! man_valid_pre(man, p))
-               return(0);
-

        switch (p->type) {
        switch (p->type) {

+       case MAN_BLOCK:
+               if (p->tok == MAN_SH || p->tok == MAN_SS)
+                       man->flags &= ~MAN_LITERAL;
+               break;

        case MAN_HEAD:
        case MAN_HEAD:

-               assert(MAN_BLOCK == p->parent->type);
+               assert(p->parent->type == MAN_BLOCK);

                p->parent->head = p;
                break;
                p->parent->head = p;
                break;

-       case MAN_TAIL:
-               assert(MAN_BLOCK == p->parent->type);
-               p->parent->tail = p;
-               break;

        case MAN_BODY:
        case MAN_BODY:

-               assert(MAN_BLOCK == p->parent->type);
+               assert(p->parent->type == MAN_BLOCK);

                p->parent->body = p;
                break;
        default:
                p->parent->body = p;
                break;
        default:


@@ -212,14 +205,11 @@ man_node_append(struct man *man, struct man_node *p)
        case MAN_TBL:
                /* FALLTHROUGH */
        case MAN_TEXT:
        case MAN_TBL:
                /* FALLTHROUGH */
        case MAN_TEXT:

-               if ( ! man_valid_post(man))
-                       return(0);
+               man_valid_post(man);

                break;
        default:
                break;
        }
                break;
        default:
                break;
        }

-
-       return(1);

 }
 
 static struct man_node *
 }
 
 static struct man_node *


@@ -234,85 +224,76 @@ man_node_alloc(struct man *man, int line, int pos,
        p->type = type;
        p->tok = tok;
 
        p->type = type;
        p->tok = tok;
 

-       if (MAN_NEWLINE & man->flags)
+       if (man->flags & MAN_NEWLINE)

                p->flags |= MAN_LINE;
        man->flags &= ~MAN_NEWLINE;
        return(p);
 }
 
                p->flags |= MAN_LINE;
        man->flags &= ~MAN_NEWLINE;
        return(p);
 }
 

-int
+void

 man_elem_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_ELEM, tok);
 man_elem_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_ELEM, tok);

-       if ( ! man_node_append(man, p))
-               return(0);
+       man_node_append(man, p);

        man->next = MAN_NEXT_CHILD;
        man->next = MAN_NEXT_CHILD;

-       return(1);

 }
 
 }
 

-int
-man_tail_alloc(struct man *man, int line, int pos, enum mant tok)
-{
-       struct man_node *p;
-
-       p = man_node_alloc(man, line, pos, MAN_TAIL, tok);
-       if ( ! man_node_append(man, p))
-               return(0);
-       man->next = MAN_NEXT_CHILD;
-       return(1);
-}
-
-int
+void

 man_head_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_HEAD, tok);
 man_head_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_HEAD, tok);

-       if ( ! man_node_append(man, p))
-               return(0);
+       man_node_append(man, p);

        man->next = MAN_NEXT_CHILD;
        man->next = MAN_NEXT_CHILD;

-       return(1);

 }
 
 }
 

-int
+void

 man_body_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_BODY, tok);
 man_body_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_BODY, tok);

-       if ( ! man_node_append(man, p))
-               return(0);
+       man_node_append(man, p);

        man->next = MAN_NEXT_CHILD;
        man->next = MAN_NEXT_CHILD;

-       return(1);

 }
 
 }
 

-int
+void

 man_block_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_BLOCK, tok);
 man_block_alloc(struct man *man, int line, int pos, enum mant tok)
 {
        struct man_node *p;
 
        p = man_node_alloc(man, line, pos, MAN_BLOCK, tok);

-       if ( ! man_node_append(man, p))
-               return(0);
+       man_node_append(man, p);

        man->next = MAN_NEXT_CHILD;
        man->next = MAN_NEXT_CHILD;

-       return(1);

 }
 
 }
 

-int
+void

 man_word_alloc(struct man *man, int line, int pos, const char *word)
 {
        struct man_node *n;
 
        n = man_node_alloc(man, line, pos, MAN_TEXT, MAN_MAX);
        n->string = roff_strdup(man->roff, word);
 man_word_alloc(struct man *man, int line, int pos, const char *word)
 {
        struct man_node *n;
 
        n = man_node_alloc(man, line, pos, MAN_TEXT, MAN_MAX);
        n->string = roff_strdup(man->roff, word);

+       man_node_append(man, n);
+       man->next = MAN_NEXT_SIBLING;
+}

 
 

-       if ( ! man_node_append(man, n))
-               return(0);
-
+void
+man_word_append(struct man *man, const char *word)
+{
+       struct man_node *n;
+       char            *addstr, *newstr;
+
+       n = man->last;
+       addstr = roff_strdup(man->roff, word);
+       mandoc_asprintf(&newstr, "%s %s", n->string, addstr);
+       free(addstr);
+       free(n->string);
+       n->string = newstr;

        man->next = MAN_NEXT_SIBLING;
        man->next = MAN_NEXT_SIBLING;

-       return(1);

 }
 
 /*
 }
 
 /*


@@ -323,8 +304,7 @@ static void
 man_node_free(struct man_node *p)
 {
 
 man_node_free(struct man_node *p)
 {
 

-       if (p->string)
-               free(p->string);
+       free(p->string);

        free(p);
 }
 
        free(p);
 }
 


@@ -339,37 +319,33 @@ man_node_delete(struct man *man, struct man_node *p)
        man_node_free(p);
 }
 
        man_node_free(p);
 }
 

-int
+void

 man_addeqn(struct man *man, const struct eqn *ep)
 {
        struct man_node *n;
 
        n = man_node_alloc(man, ep->ln, ep->pos, MAN_EQN, MAN_MAX);
        n->eqn = ep;
 man_addeqn(struct man *man, const struct eqn *ep)
 {
        struct man_node *n;
 
        n = man_node_alloc(man, ep->ln, ep->pos, MAN_EQN, MAN_MAX);
        n->eqn = ep;

-
-       if ( ! man_node_append(man, n))
-               return(0);
-
+       if (ep->ln > man->last->line)
+               n->flags |= MAN_LINE;
+       man_node_append(man, n);

        man->next = MAN_NEXT_SIBLING;
        man->next = MAN_NEXT_SIBLING;

-       return(man_descope(man, ep->ln, ep->pos));
+       man_descope(man, ep->ln, ep->pos);

 }
 
 }
 

-int
+void

 man_addspan(struct man *man, const struct tbl_span *sp)
 {
        struct man_node *n;
 
        n = man_node_alloc(man, sp->line, 0, MAN_TBL, MAN_MAX);
        n->span = sp;
 man_addspan(struct man *man, const struct tbl_span *sp)
 {
        struct man_node *n;
 
        n = man_node_alloc(man, sp->line, 0, MAN_TBL, MAN_MAX);
        n->span = sp;

-
-       if ( ! man_node_append(man, n))
-               return(0);
-
+       man_node_append(man, n);

        man->next = MAN_NEXT_SIBLING;
        man->next = MAN_NEXT_SIBLING;

-       return(man_descope(man, sp->line, 0));
+       man_descope(man, sp->line, 0);

 }
 
 }
 

-static int
+static void

 man_descope(struct man *man, int line, int offs)
 {
        /*
 man_descope(struct man *man, int line, int offs)
 {
        /*


@@ -378,19 +354,15 @@ man_descope(struct man *man, int line, int offs)
         * out the block scope (also if applicable).
         */
 
         * out the block scope (also if applicable).
         */
 

-       if (MAN_ELINE & man->flags) {
+       if (man->flags & MAN_ELINE) {

                man->flags &= ~MAN_ELINE;
                man->flags &= ~MAN_ELINE;

-               if ( ! man_unscope(man, man->last->parent))
-                       return(0);
+               man_unscope(man, man->last->parent);

        }
        }

-
-       if ( ! (MAN_BLINE & man->flags))
-               return(1);
+       if ( ! (man->flags & MAN_BLINE))
+               return;

        man->flags &= ~MAN_BLINE;
        man->flags &= ~MAN_BLINE;

-
-       if ( ! man_unscope(man, man->last->parent))
-               return(0);
-       return(man_body_alloc(man, line, offs, man->last->tok));
+       man_unscope(man, man->last->parent);
+       man_body_alloc(man, line, offs, man->last->tok);

 }
 
 static int
 }
 
 static int


@@ -400,13 +372,13 @@ man_ptext(struct man *man, int line, char *buf, int offs)
 
        /* Literal free-form text whitespace is preserved. */
 
 
        /* Literal free-form text whitespace is preserved. */
 

-       if (MAN_LITERAL & man->flags) {
-               if ( ! man_word_alloc(man, line, offs, buf + offs))
-                       return(0);
-               return(man_descope(man, line, offs));
+       if (man->flags & MAN_LITERAL) {
+               man_word_alloc(man, line, offs, buf + offs);
+               man_descope(man, line, offs);
+               return(1);

        }
 
        }
 

-       for (i = offs; ' ' == buf[i]; i++)
+       for (i = offs; buf[i] == ' '; i++)

                /* Skip leading whitespace. */ ;
 
        /*
                /* Skip leading whitespace. */ ;
 
        /*


@@ -414,12 +386,11 @@ man_ptext(struct man *man, int line, char *buf, int offs)
         * but add a single vertical space elsewhere.
         */
 
         * but add a single vertical space elsewhere.
         */
 

-       if ('\0' == buf[i]) {
+       if (buf[i] == '\0') {

                /* Allocate a blank entry. */
                /* Allocate a blank entry. */

-               if (MAN_SH != man->last->tok &&
-                   MAN_SS != man->last->tok) {
-                       if ( ! man_elem_alloc(man, line, offs, MAN_sp))
-                               return(0);
+               if (man->last->tok != MAN_SH &&
+                   man->last->tok != MAN_SS) {
+                       man_elem_alloc(man, line, offs, MAN_sp);

                        man->next = MAN_NEXT_SIBLING;
                }
                return(1);
                        man->next = MAN_NEXT_SIBLING;
                }
                return(1);


@@ -446,9 +417,7 @@ man_ptext(struct man *man, int line, char *buf, int offs)
 
                buf[i] = '\0';
        }
 
                buf[i] = '\0';
        }

-
-       if ( ! man_word_alloc(man, line, offs, buf + offs))
-               return(0);
+       man_word_alloc(man, line, offs, buf + offs);

 
        /*
         * End-of-sentence check.  If the last character is an unescaped
 
        /*
         * End-of-sentence check.  If the last character is an unescaped


@@ -460,50 +429,59 @@ man_ptext(struct man *man, int line, char *buf, int offs)
        if (mandoc_eos(buf, (size_t)i))
                man->last->flags |= MAN_EOS;
 
        if (mandoc_eos(buf, (size_t)i))
                man->last->flags |= MAN_EOS;
 

-       return(man_descope(man, line, offs));
+       man_descope(man, line, offs);
+       return(1);

 }
 
 static int
 man_pmacro(struct man *man, int ln, char *buf, int offs)
 {
 }
 
 static int
 man_pmacro(struct man *man, int ln, char *buf, int offs)
 {

-       char             mac[5];

        struct man_node *n;
        struct man_node *n;

+       const char      *cp;

        enum mant        tok;
        int              i, ppos;
        int              bline;
        enum mant        tok;
        int              i, ppos;
        int              bline;

-
-       if ('"' == buf[offs]) {
-               mandoc_msg(MANDOCERR_COMMENT_BAD, man->parse,
-                   ln, offs, NULL);
-               return(1);
-       } else if ('\0' == buf[offs])
-               return(1);
+       char             mac[5];

 
        ppos = offs;
 
        /*
         * Copy the first word into a nil-terminated buffer.
 
        ppos = offs;
 
        /*
         * Copy the first word into a nil-terminated buffer.

-        * Stop copying when a tab, space, or eoln is encountered.
+        * Stop when a space, tab, escape, or eoln is encountered.

         */
 
        i = 0;
         */
 
        i = 0;

-       while (i < 4 && '\0' != buf[offs] && ' ' != buf[offs] &&
-           '\t' != buf[offs])
+       while (i < 4 && strchr(" \t\\", buf[offs]) == NULL)

                mac[i++] = buf[offs++];
 
        mac[i] = '\0';
 
        tok = (i > 0 && i < 4) ? man_hash_find(mac) : MAN_MAX;
 
                mac[i++] = buf[offs++];
 
        mac[i] = '\0';
 
        tok = (i > 0 && i < 4) ? man_hash_find(mac) : MAN_MAX;
 

-       if (MAN_MAX == tok) {
+       if (tok == MAN_MAX) {

                mandoc_msg(MANDOCERR_MACRO, man->parse,
                    ln, ppos, buf + ppos - 1);
                return(1);
        }
 
                mandoc_msg(MANDOCERR_MACRO, man->parse,
                    ln, ppos, buf + ppos - 1);
                return(1);
        }
 

-       /* The macro is sane.  Jump to the next word. */
+       /* Skip a leading escape sequence or tab. */

 
 

-       while (buf[offs] && ' ' == buf[offs])
+       switch (buf[offs]) {
+       case '\\':
+               cp = buf + offs + 1;
+               mandoc_escape(&cp, NULL, NULL);
+               offs = cp - buf;
+               break;
+       case '\t':
+               offs++;
+               break;
+       default:
+               break;
+       }
+
+       /* Jump to the next non-whitespace word. */
+
+       while (buf[offs] && buf[offs] == ' ')

                offs++;
 
        /*
                offs++;
 
        /*


@@ -511,7 +489,7 @@ man_pmacro(struct man *man, int ln, char *buf, int offs)
         * into the parser as "text", so we only warn about spaces here.
         */
 
         * into the parser as "text", so we only warn about spaces here.
         */
 

-       if ('\0' == buf[offs] && ' ' == buf[offs - 1])
+       if (buf[offs] == '\0' && buf[offs - 1] == ' ')

                mandoc_msg(MANDOCERR_SPACE_EOL, man->parse,
                    ln, offs - 1, NULL);
 
                mandoc_msg(MANDOCERR_SPACE_EOL, man->parse,
                    ln, offs - 1, NULL);
 


@@ -521,14 +499,14 @@ man_pmacro(struct man *man, int ln, char *buf, int offs)
         * macros---they don't print text---so we let those slip by.
         */
 
         * macros---they don't print text---so we let those slip by.
         */
 

-       if ( ! (MAN_NSCOPED & man_macros[tok].flags) &&
+       if ( ! (man_macros[tok].flags & MAN_NSCOPED) &&

                        man->flags & MAN_ELINE) {
                n = man->last;
                assert(MAN_TEXT != n->type);
 
                /* Remove repeated NSCOPED macros causing ELINE. */
 
                        man->flags & MAN_ELINE) {
                n = man->last;
                assert(MAN_TEXT != n->type);
 
                /* Remove repeated NSCOPED macros causing ELINE. */
 

-               if (MAN_NSCOPED & man_macros[n->tok].flags)
+               if (man_macros[n->tok].flags & MAN_NSCOPED)

                        n = n->parent;
 
                mandoc_vmsg(MANDOCERR_BLK_LINE, man->parse, n->line,
                        n = n->parent;
 
                mandoc_vmsg(MANDOCERR_BLK_LINE, man->parse, n->line,


@@ -543,24 +521,24 @@ man_pmacro(struct man *man, int ln, char *buf, int offs)
         * Remove prior BLINE macro that is being clobbered.
         */
        if ((man->flags & MAN_BLINE) &&
         * Remove prior BLINE macro that is being clobbered.
         */
        if ((man->flags & MAN_BLINE) &&

-           (MAN_BSCOPE & man_macros[tok].flags)) {
+           (man_macros[tok].flags & MAN_BSCOPE)) {

                n = man->last;
 
                /* Might be a text node like 8 in
                 * .TP 8
                 * .SH foo
                 */
                n = man->last;
 
                /* Might be a text node like 8 in
                 * .TP 8
                 * .SH foo
                 */

-               if (MAN_TEXT == n->type)
+               if (n->type == MAN_TEXT)

                        n = n->parent;
 
                /* Remove element that didn't end BLINE, if any. */
                        n = n->parent;
 
                /* Remove element that didn't end BLINE, if any. */

-               if ( ! (MAN_BSCOPE & man_macros[n->tok].flags))
+               if ( ! (man_macros[n->tok].flags & MAN_BSCOPE))

                        n = n->parent;
 
                        n = n->parent;
 

-               assert(MAN_HEAD == n->type);
+               assert(n->type == MAN_HEAD);

                n = n->parent;
                n = n->parent;

-               assert(MAN_BLOCK == n->type);
-               assert(MAN_SCOPED & man_macros[n->tok].flags);
+               assert(n->type == MAN_BLOCK);
+               assert(man_macros[n->tok].flags & MAN_SCOPED);

 
                mandoc_vmsg(MANDOCERR_BLK_LINE, man->parse, n->line,
                    n->pos, "%s breaks %s", man_macronames[tok],
 
                mandoc_vmsg(MANDOCERR_BLK_LINE, man->parse, n->line,
                    n->pos, "%s breaks %s", man_macronames[tok],


@@ -577,14 +555,13 @@ man_pmacro(struct man *man, int ln, char *buf, int offs)
        /* Call to handler... */
 
        assert(man_macros[tok].fp);
        /* Call to handler... */
 
        assert(man_macros[tok].fp);

-       if ( ! (*man_macros[tok].fp)(man, tok, ln, ppos, &offs, buf))
-               return(0);
+       (*man_macros[tok].fp)(man, tok, ln, ppos, &offs, buf);

 
        /* In quick mode (for mandocdb), abort after the NAME section. */
 
 
        /* In quick mode (for mandocdb), abort after the NAME section. */
 

-       if (man->quick && MAN_SH == tok) {
+       if (man->quick && tok == MAN_SH) {

                n = man->last;
                n = man->last;

-               if (MAN_BODY == n->type &&
+               if (n->type == MAN_BODY &&

                    strcmp(n->prev->child->string, "NAME"))
                        return(2);
        }
                    strcmp(n->prev->child->string, "NAME"))
                        return(2);
        }


@@ -599,12 +576,12 @@ man_pmacro(struct man *man, int ln, char *buf, int offs)
            man_macros[tok].flags & MAN_NSCOPED)
                return(1);
 
            man_macros[tok].flags & MAN_NSCOPED)
                return(1);
 

-       assert(MAN_BLINE & man->flags);
+       assert(man->flags & MAN_BLINE);

        man->flags &= ~MAN_BLINE;
 
        man->flags &= ~MAN_BLINE;
 

-       if ( ! man_unscope(man, man->last->parent))
-               return(0);
-       return(man_body_alloc(man, ln, ppos, man->last->tok));
+       man_unscope(man, man->last->parent);
+       man_body_alloc(man, ln, ppos, man->last->tok);
+       return(1);

 }
 
 /*
 }
 
 /*


@@ -662,7 +639,7 @@ man_deroff(char **dest, const struct man_node *n)
        char    *cp;
        size_t   sz;
 
        char    *cp;
        size_t   sz;
 

-       if (MAN_TEXT != n->type) {
+       if (n->type != MAN_TEXT) {

                for (n = n->child; n; n = n->next)
                        man_deroff(dest, n);
                return;
                for (n = n->child; n; n = n->next)
                        man_deroff(dest, n);
                return;