Correctly print `Lk' arguments in -Tascii. Issue raised by Aldis Berzoja.

[mandoc.git] / mdoc_validate.c

diff --git a/mdoc_validate.c b/mdoc_validate.c
index 85f6474381c743ade4a45d8567948303b39e1b54..d90107dbbcb18e69c6026d51749e68dc75cebadf 100644 (file)
--- a/mdoc_validate.c
+++ b/mdoc_validate.c
@@ -1,6 +1,6 @@
-/*     $Id: mdoc_validate.c,v 1.91 2010/06/03 13:44:36 kristaps Exp $ */
+/*     $Id: mdoc_validate.c,v 1.114 2010/07/26 13:45:49 kristaps Exp $ */

 /*
 /*

- * Copyright (c) 2008, 2009 Kristaps Dzonsons <kristaps@bsd.lv>
+ * Copyright (c) 2008, 2009, 2010 Kristaps Dzonsons <kristaps@bsd.lv>

  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above


@@ -32,7 +32,6 @@
 #include "libmandoc.h"
 
 /* FIXME: .Bl -diag can't have non-text children in HEAD. */
 #include "libmandoc.h"
 
 /* FIXME: .Bl -diag can't have non-text children in HEAD. */

-/* TODO: ignoring Pp (it's superfluous in some invocations). */

 
 #define        PRE_ARGS  struct mdoc *mdoc, struct mdoc_node *n
 #define        POST_ARGS struct mdoc *mdoc
 
 #define        PRE_ARGS  struct mdoc *mdoc, struct mdoc_node *n
 #define        POST_ARGS struct mdoc *mdoc


@@ -47,12 +46,10 @@ struct      valids {
 
 static int      check_parent(PRE_ARGS, enum mdoct, enum mdoc_type);
 static int      check_stdarg(PRE_ARGS);
 
 static int      check_parent(PRE_ARGS, enum mdoct, enum mdoc_type);
 static int      check_stdarg(PRE_ARGS);

-static int      check_text(struct mdoc *, int, int, const char *);
+static int      check_text(struct mdoc *, int, int, char *);

 static int      check_argv(struct mdoc *, 
 static int      check_argv(struct mdoc *, 

-                       const struct mdoc_node *,
-                       const struct mdoc_argv *);
-static int      check_args(struct mdoc *, 
-                       const struct mdoc_node *);
+                       struct mdoc_node *, struct mdoc_argv *);
+static int      check_args(struct mdoc *, struct mdoc_node *);

 static int      err_child_lt(struct mdoc *, const char *, int);
 static int      warn_child_lt(struct mdoc *, const char *, int);
 static int      err_child_gt(struct mdoc *, const char *, int);
 static int      err_child_lt(struct mdoc *, const char *, int);
 static int      warn_child_lt(struct mdoc *, const char *, int);
 static int      err_child_gt(struct mdoc *, const char *, int);


@@ -109,7 +106,7 @@ static      int      pre_ss(PRE_ARGS);
 
 static v_post   posts_an[] = { post_an, NULL };
 static v_post   posts_at[] = { post_at, NULL };
 
 static v_post   posts_an[] = { post_an, NULL };
 static v_post   posts_at[] = { post_at, NULL };

-static v_post   posts_bd[] = { hwarn_eq0, bwarn_ge1, NULL };
+static v_post   posts_bd_bk[] = { hwarn_eq0, bwarn_ge1, NULL };

 static v_post   posts_bf[] = { hwarn_le1, post_bf, NULL };
 static v_post   posts_bl[] = { bwarn_ge1, post_bl, NULL };
 static v_post   posts_bool[] = { eerr_eq1, ebool, NULL };
 static v_post   posts_bf[] = { hwarn_le1, post_bf, NULL };
 static v_post   posts_bl[] = { bwarn_ge1, post_bl, NULL };
 static v_post   posts_bool[] = { eerr_eq1, ebool, NULL };


@@ -148,7 +145,7 @@ static      v_pre    pres_ss[] = { pre_ss, NULL };
 
 const  struct valids mdoc_valids[MDOC_MAX] = {
        { NULL, NULL },                         /* Ap */
 
 const  struct valids mdoc_valids[MDOC_MAX] = {
        { NULL, NULL },                         /* Ap */

-       { pres_dd, posts_text },                /* Dd */
+       { pres_dd, posts_wtext },               /* Dd */

        { pres_dt, posts_dt },                  /* Dt */
        { pres_os, NULL },                      /* Os */
        { pres_sh, posts_sh },                  /* Sh */ 
        { pres_dt, posts_dt },                  /* Dt */
        { pres_os, NULL },                      /* Os */
        { pres_sh, posts_sh },                  /* Sh */ 


@@ -156,7 +153,7 @@ const       struct valids mdoc_valids[MDOC_MAX] = {
        { NULL, posts_notext },                 /* Pp */ 
        { pres_d1, posts_wline },               /* D1 */
        { pres_d1, posts_wline },               /* Dl */
        { NULL, posts_notext },                 /* Pp */ 
        { pres_d1, posts_wline },               /* D1 */
        { pres_d1, posts_wline },               /* Dl */

-       { pres_bd, posts_bd },                  /* Bd */
+       { pres_bd, posts_bd_bk },               /* Bd */

        { NULL, NULL },                         /* Ed */
        { pres_bl, posts_bl },                  /* Bl */ 
        { NULL, NULL },                         /* El */
        { NULL, NULL },                         /* Ed */
        { pres_bl, posts_bl },                  /* Bl */ 
        { NULL, NULL },                         /* El */


@@ -247,7 +244,7 @@ const       struct valids mdoc_valids[MDOC_MAX] = {
        { NULL, NULL },                         /* Fc */ 
        { NULL, NULL },                         /* Oo */
        { NULL, NULL },                         /* Oc */
        { NULL, NULL },                         /* Fc */ 
        { NULL, NULL },                         /* Oo */
        { NULL, NULL },                         /* Oc */

-       { NULL, posts_wline },                  /* Bk */
+       { NULL, posts_bd_bk },                  /* Bk */

        { NULL, NULL },                         /* Ek */
        { NULL, posts_eoln },                   /* Bt */
        { NULL, NULL },                         /* Hf */
        { NULL, NULL },                         /* Ek */
        { NULL, posts_eoln },                   /* Bt */
        { NULL, NULL },                         /* Hf */


@@ -277,7 +274,7 @@ mdoc_valid_pre(struct mdoc *mdoc, struct mdoc_node *n)
 {
        v_pre           *p;
        int              line, pos;
 {
        v_pre           *p;
        int              line, pos;

-       const char      *tp;
+       char            *tp;

 
        if (MDOC_TEXT == n->type) {
                tp = n->string;
 
        if (MDOC_TEXT == n->type) {
                tp = n->string;


@@ -419,7 +416,7 @@ check_stdarg(PRE_ARGS)
 
 
 static int
 
 
 static int

-check_args(struct mdoc *m, const struct mdoc_node *n)
+check_args(struct mdoc *m, struct mdoc_node *n)

 {
        int              i;
 
 {
        int              i;
 


@@ -436,8 +433,7 @@ check_args(struct mdoc *m, const struct mdoc_node *n)
 
 
 static int
 
 
 static int

-check_argv(struct mdoc *m, const struct mdoc_node *n, 
-               const struct mdoc_argv *v)
+check_argv(struct mdoc *m, struct mdoc_node *n, struct mdoc_argv *v)

 {
        int              i;
 
 {
        int              i;
 


@@ -457,21 +453,29 @@ check_argv(struct mdoc *m, const struct mdoc_node *n,
 
 
 static int
 
 
 static int

-check_text(struct mdoc *mdoc, int line, int pos, const char *p)
+check_text(struct mdoc *m, int ln, int pos, char *p)

 {
        int              c;
 {
        int              c;

+       size_t           sz;

 
        for ( ; *p; p++, pos++) {
 
        for ( ; *p; p++, pos++) {

+               sz = strcspn(p, "\t\\");
+               p += (int)sz;
+
+               if ('\0' == *p)
+                       break;
+
+               pos += (int)sz;
+

                if ('\t' == *p) {
                if ('\t' == *p) {

-                       if ( ! (MDOC_LITERAL & mdoc->flags))
-                               if ( ! mdoc_pmsg(mdoc, line, pos, MANDOCERR_BADCHAR))
-                                       return(0);
-               } else if ( ! isprint((u_char)*p) && ASCII_HYPH != *p)
-                       if ( ! mdoc_pmsg(mdoc, line, pos, MANDOCERR_BADCHAR))
-                               return(0);
+                       if (MDOC_LITERAL & m->flags)
+                               continue;
+                       if (mdoc_pmsg(m, ln, pos, MANDOCERR_BADTAB))
+                               continue;
+                       return(0);
+               }

 
 

-               if ('\\' != *p)
-                       continue;
+               /* Check the special character. */

 
                c = mandoc_special(p);
                if (c) {
 
                c = mandoc_special(p);
                if (c) {


@@ -480,8 +484,8 @@ check_text(struct mdoc *mdoc, int line, int pos, const char *p)
                        continue;
                }
 
                        continue;
                }
 

-               c = mdoc_pmsg(mdoc, line, pos, MANDOCERR_BADESCAPE);
-               if ( ! (MDOC_IGN_ESCAPE & mdoc->pflags) && ! c)
+               c = mdoc_pmsg(m, ln, pos, MANDOCERR_BADESCAPE);
+               if ( ! (MDOC_IGN_ESCAPE & m->pflags) && ! c)

                        return(c);
        }
 
                        return(c);
        }
 


@@ -489,8 +493,6 @@ check_text(struct mdoc *mdoc, int line, int pos, const char *p)
 }
 
 
 }
 
 

-
-

 static int
 check_parent(PRE_ARGS, enum mdoct tok, enum mdoc_type t)
 {
 static int
 check_parent(PRE_ARGS, enum mdoct tok, enum mdoc_type t)
 {


@@ -508,7 +510,6 @@ check_parent(PRE_ARGS, enum mdoct tok, enum mdoc_type t)
 }
 
 
 }
 
 

-

 static int
 pre_display(PRE_ARGS)
 {
 static int
 pre_display(PRE_ARGS)
 {


@@ -535,15 +536,23 @@ pre_display(PRE_ARGS)
 static int
 pre_bl(PRE_ARGS)
 {
 static int
 pre_bl(PRE_ARGS)
 {

-       int              i, width, offs, cmpt, dupl;
-       enum mdoc_list   lt;
+       int               i, comp, dup;
+       const char       *offs, *width;
+       enum mdoc_list    lt;
+       struct mdoc_node *np;

 
        if (MDOC_BLOCK != n->type) {
 
        if (MDOC_BLOCK != n->type) {

-               assert(n->parent);
-               assert(MDOC_BLOCK == n->parent->type);
-               assert(MDOC_Bl == n->parent->tok);
-               assert(LIST__NONE != n->parent->data.list);
-               n->data.list = n->parent->data.list;
+               if (ENDBODY_NOT != n->end) {
+                       assert(n->pending);
+                       np = n->pending->parent;
+               } else
+                       np = n->parent;
+
+               assert(np);
+               assert(MDOC_BLOCK == np->type);
+               assert(MDOC_Bl == np->tok);
+               assert(np->data.Bl);
+               n->data.Bl = np->data.Bl;

                return(1);
        }
 
                return(1);
        }
 


@@ -553,13 +562,14 @@ pre_bl(PRE_ARGS)
         * ones.  If we find no list type, we default to LIST_item.
         */
 
         * ones.  If we find no list type, we default to LIST_item.
         */
 

-       assert(LIST__NONE == n->data.list);
-       offs = width = cmpt = -1;
+       assert(NULL == n->data.Bl);
+       n->data.Bl = mandoc_calloc(1, sizeof(struct mdoc_bl));

 
        /* LINTED */
        for (i = 0; n->args && i < (int)n->args->argc; i++) {
                lt = LIST__NONE;
 
        /* LINTED */
        for (i = 0; n->args && i < (int)n->args->argc; i++) {
                lt = LIST__NONE;

-               dupl = 0;
+               dup = comp = 0;
+               width = offs = NULL;

                switch (n->args->argv[i].arg) {
                /* Set list types. */
                case (MDOC_Bullet):
                switch (n->args->argv[i].arg) {
                /* Set list types. */
                case (MDOC_Bullet):


@@ -597,43 +607,64 @@ pre_bl(PRE_ARGS)
                        break;
                /* Set list arguments. */
                case (MDOC_Compact):
                        break;
                /* Set list arguments. */
                case (MDOC_Compact):

-                       if (cmpt >= 0) 
-                               dupl++;
-                       cmpt = i;
+                       dup = n->data.Bl->comp;
+                       comp = 1;

                        break;
                case (MDOC_Width):
                        break;
                case (MDOC_Width):

-                       if (width >= 0)
-                               dupl++;
-                       width = i;
+                       dup = (NULL != n->data.Bl->width);
+                       width = n->args->argv[i].value[0];

                        break;
                case (MDOC_Offset):
                        break;
                case (MDOC_Offset):

-                       if (offs >= 0)
-                               dupl++;
-                       offs = i;
+                       /* NB: this can be empty! */
+                       if (n->args->argv[i].sz) {
+                               offs = n->args->argv[i].value[0];
+                               dup = (NULL != n->data.Bl->offs);
+                               break;
+                       }
+                       if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_IGNARGV))
+                               return(0);

                        break;
                        break;

+               default:
+                       continue;

                }
 
                /* Check: duplicate auxiliary arguments. */
 
                }
 
                /* Check: duplicate auxiliary arguments. */
 

-               if (dupl)
-                       if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_ARGVREP))
-                               return(0);
+               if (dup && ! mdoc_nmsg(mdoc, n, MANDOCERR_ARGVREP))
+                       return(0);
+
+               if (comp && ! dup)
+                       n->data.Bl->comp = comp;
+               if (offs && ! dup)
+                       n->data.Bl->offs = offs;
+               if (width && ! dup)
+                       n->data.Bl->width = width;

 
                /* Check: multiple list types. */
 
 
                /* Check: multiple list types. */
 

-               if (LIST__NONE != lt && n->data.list != LIST__NONE)
+               if (LIST__NONE != lt && n->data.Bl->type != LIST__NONE)

                        if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_LISTREP))
                                return(0);
 
                /* Assign list type. */
 
                        if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_LISTREP))
                                return(0);
 
                /* Assign list type. */
 

-               if (LIST__NONE != lt && n->data.list == LIST__NONE)
-                       n->data.list = lt;
+               if (LIST__NONE != lt && n->data.Bl->type == LIST__NONE) {
+                       n->data.Bl->type = lt;
+                       /* Set column information, too. */
+                       if (LIST_column == lt) {
+                               n->data.Bl->ncols = 
+                                       n->args->argv[i].sz;
+                               n->data.Bl->cols = (const char **)
+                                       n->args->argv[i].value;
+                       }
+               }

 
                /* The list type should come first. */
 
 
                /* The list type should come first. */
 

-               if (n->data.list == LIST__NONE)
-                       if (width >= 0 || offs >= 0 || cmpt >= 0)
+               if (n->data.Bl->type == LIST__NONE)
+                       if (n->data.Bl->width || 
+                                       n->data.Bl->offs || 
+                                       n->data.Bl->comp)

                                if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_LISTFIRST))
                                        return(0);
 
                                if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_LISTFIRST))
                                        return(0);
 


@@ -642,10 +673,10 @@ pre_bl(PRE_ARGS)
 
        /* Allow lists to default to LIST_item. */
 
 
        /* Allow lists to default to LIST_item. */
 

-       if (LIST__NONE == n->data.list) {
+       if (LIST__NONE == n->data.Bl->type) {

                if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_LISTTYPE))
                        return(0);
                if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_LISTTYPE))
                        return(0);

-               n->data.list = LIST_item;
+               n->data.Bl->type = LIST_item;

        }
 
        /* 
        }
 
        /* 


@@ -654,9 +685,9 @@ pre_bl(PRE_ARGS)
         * and must also be warned.
         */
 
         * and must also be warned.
         */
 

-       switch (n->data.list) {
+       switch (n->data.Bl->type) {

        case (LIST_tag):
        case (LIST_tag):

-               if (width >= 0)
+               if (n->data.Bl->width)

                        break;
                if (mdoc_nmsg(mdoc, n, MANDOCERR_NOWIDTHARG))
                        break;
                        break;
                if (mdoc_nmsg(mdoc, n, MANDOCERR_NOWIDTHARG))
                        break;


@@ -670,7 +701,7 @@ pre_bl(PRE_ARGS)
        case (LIST_inset):
                /* FALLTHROUGH */
        case (LIST_item):
        case (LIST_inset):
                /* FALLTHROUGH */
        case (LIST_item):

-               if (width < 0)
+               if (NULL == n->data.Bl->width)

                        break;
                if (mdoc_nmsg(mdoc, n, MANDOCERR_WIDTHARG))
                        break;
                        break;
                if (mdoc_nmsg(mdoc, n, MANDOCERR_WIDTHARG))
                        break;


@@ -686,43 +717,104 @@ pre_bl(PRE_ARGS)
 static int
 pre_bd(PRE_ARGS)
 {
 static int
 pre_bd(PRE_ARGS)
 {

-       int              i, type, err;
+       int               i, dup, comp;
+       enum mdoc_disp    dt;
+       const char       *offs;
+       struct mdoc_node *np;

 
 

-       if (MDOC_BLOCK != n->type)
+       if (MDOC_BLOCK != n->type) {
+               if (ENDBODY_NOT != n->end) {
+                       assert(n->pending);
+                       np = n->pending->parent;
+               } else
+                       np = n->parent;
+
+               assert(np);
+               assert(MDOC_BLOCK == np->type);
+               assert(MDOC_Bd == np->tok);
+               assert(np->data.Bd);
+               n->data.Bd = np->data.Bd;

                return(1);
                return(1);

-       if (NULL == n->args) {
-               mdoc_nmsg(mdoc, n, MANDOCERR_DISPTYPE);
-               return(0);

        }
 
        }
 

-       /* Make sure that only one type of display is specified.  */
+       assert(NULL == n->data.Bd);
+       n->data.Bd = mandoc_calloc(1, sizeof(struct mdoc_bd));

 
        /* LINTED */
 
        /* LINTED */

-       for (i = 0, err = type = 0; ! err && 
-                       i < (int)n->args->argc; i++)
+       for (i = 0; n->args && i < (int)n->args->argc; i++) {
+               dt = DISP__NONE;
+               dup = comp = 0;
+               offs = NULL;
+

                switch (n->args->argv[i].arg) {
                case (MDOC_Centred):
                switch (n->args->argv[i].arg) {
                case (MDOC_Centred):

-                       /* FALLTHROUGH */
+                       dt = DISP_centred;
+                       break;

                case (MDOC_Ragged):
                case (MDOC_Ragged):

-                       /* FALLTHROUGH */
+                       dt = DISP_ragged;
+                       break;

                case (MDOC_Unfilled):
                case (MDOC_Unfilled):

-                       /* FALLTHROUGH */
+                       dt = DISP_unfilled;
+                       break;

                case (MDOC_Filled):
                case (MDOC_Filled):

-                       /* FALLTHROUGH */
+                       dt = DISP_filled;
+                       break;

                case (MDOC_Literal):
                case (MDOC_Literal):

-                       if (0 == type++) 
+                       dt = DISP_literal;
+                       break;
+               case (MDOC_File):
+                       mdoc_nmsg(mdoc, n, MANDOCERR_BADDISP);
+                       return(0);
+               case (MDOC_Offset):
+                       /* NB: this can be empty! */
+                       if (n->args->argv[i].sz) {
+                               offs = n->args->argv[i].value[0];
+                               dup = (NULL != n->data.Bd->offs);

                                break;
                                break;

-                       if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_DISPREP))
+                       }
+                       if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_IGNARGV))

                                return(0);
                        break;
                                return(0);
                        break;

-               default:
+               case (MDOC_Compact):
+                       comp = 1;
+                       dup = n->data.Bd->comp;

                        break;
                        break;

+               default:
+                       abort();
+                       /* NOTREACHED */

                }
 
                }
 

-       if (type)
-               return(1);
-       mdoc_nmsg(mdoc, n, MANDOCERR_DISPTYPE);
-       return(0);
+               /* Check whether we have duplicates. */
+
+               if (dup && ! mdoc_nmsg(mdoc, n, MANDOCERR_ARGVREP))
+                       return(0);
+
+               /* Make our auxiliary assignments. */
+
+               if (offs && ! dup)
+                       n->data.Bd->offs = offs;
+               if (comp && ! dup)
+                       n->data.Bd->comp = comp;
+
+               /* Check whether a type has already been assigned. */
+
+               if (DISP__NONE != dt && n->data.Bd->type != DISP__NONE)
+                       if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_DISPREP))
+                               return(0);
+
+               /* Make our type assignment. */
+
+               if (DISP__NONE != dt && n->data.Bd->type == DISP__NONE)
+                       n->data.Bd->type = dt;
+       }
+
+       if (DISP__NONE == n->data.Bd->type) {
+               if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_DISPTYPE))
+                       return(0);
+               n->data.Bd->type = DISP_ragged;
+       }
+
+       return(1);

 }
 
 
 }
 
 


@@ -742,6 +834,8 @@ pre_sh(PRE_ARGS)
 
        if (MDOC_BLOCK != n->type)
                return(1);
 
        if (MDOC_BLOCK != n->type)
                return(1);

+
+       mdoc->regs->regs[(int)REG_nS].set = 0;

        return(check_parent(mdoc, n, MDOC_MAX, MDOC_ROOT));
 }
 
        return(check_parent(mdoc, n, MDOC_MAX, MDOC_ROOT));
 }
 


@@ -764,13 +858,20 @@ static int
 pre_an(PRE_ARGS)
 {
 
 pre_an(PRE_ARGS)
 {
 

-       if (NULL == n->args || 1 == n->args->argc)
+       if (NULL == n->args)

                return(1);
                return(1);

-       mdoc_vmsg(mdoc, MANDOCERR_SYNTARGCOUNT, 
-                               n->line, n->pos,
-                               "line arguments == 1 (have %d)",
-                               n->args->argc);
-       return(0);
+       if (n->args->argc > 1)
+               if ( ! mdoc_nmsg(mdoc, n, MANDOCERR_ARGCOUNT))
+                       return(0);
+
+       if (MDOC_Split == n->args->argv[0].arg)
+               n->data.An.auth = AUTH_split;
+       else if (MDOC_Nosplit == n->args->argv[0].arg)
+               n->data.An.auth = AUTH_nosplit;
+       else
+               abort();
+
+       return(1);

 }
 
 
 }
 
 


@@ -846,38 +947,74 @@ pre_dd(PRE_ARGS)
 static int
 post_bf(POST_ARGS)
 {
 static int
 post_bf(POST_ARGS)
 {

-       char             *p;
-       struct mdoc_node *head;
+       struct mdoc_node *np;
+       enum mdocargt     arg;

 
 

-       if (MDOC_BLOCK != mdoc->last->type)
+       /*
+        * Unlike other data pointers, these are "housed" by the HEAD
+        * element, which contains the goods.
+        */
+
+       if (MDOC_HEAD != mdoc->last->type) {
+               if (ENDBODY_NOT != mdoc->last->end) {
+                       assert(mdoc->last->pending);
+                       np = mdoc->last->pending->parent->head;
+               } else if (MDOC_BLOCK != mdoc->last->type) {
+                       np = mdoc->last->parent->head;
+               } else 
+                       np = mdoc->last->head;
+
+               assert(np);
+               assert(MDOC_HEAD == np->type);
+               assert(MDOC_Bf == np->tok);
+               assert(np->data.Bf);
+               mdoc->last->data.Bf = np->data.Bf;

                return(1);
                return(1);

+       }

 
 

-       head = mdoc->last->head;
+       np = mdoc->last;
+       assert(MDOC_BLOCK == np->parent->type);
+       assert(MDOC_Bf == np->parent->tok);
+       np->data.Bf = mandoc_calloc(1, sizeof(struct mdoc_bf));

 
 

-       if (mdoc->last->args && head->child) {
-               /* FIXME: this should provide a default. */
-               mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_SYNTARGVCOUNT);
-               return(0);
-       } else if (mdoc->last->args)
-               return(1);
+       /* 
+        * Cannot have both argument and parameter.
+        * If neither is specified, let it through with a warning. 
+        */

 
 

-       if (NULL == head->child || MDOC_TEXT != head->child->type) {
-               /* FIXME: this should provide a default. */
-               mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_SYNTARGVCOUNT);
+       if (np->parent->args && np->child) {
+               mdoc_nmsg(mdoc, np, MANDOCERR_SYNTARGVCOUNT);

                return(0);
                return(0);

+       } else if (NULL == np->parent->args && NULL == np->child)
+               return(mdoc_nmsg(mdoc, np, MANDOCERR_FONTTYPE));
+
+       /* Extract argument into data. */
+       
+       if (np->parent->args) {
+               arg = np->parent->args->argv[0].arg;
+               if (MDOC_Emphasis == arg)
+                       np->data.Bf->font = FONT_Em;
+               else if (MDOC_Literal == arg)
+                       np->data.Bf->font = FONT_Li;
+               else if (MDOC_Symbolic == arg)
+                       np->data.Bf->font = FONT_Sy;
+               else
+                       abort();
+               return(1);

        }
 
        }
 

-       p = head->child->string;
+       /* Extract parameter into data. */

 
 

-       if (0 == strcmp(p, "Em"))
-               return(1);
-       else if (0 == strcmp(p, "Li"))
-               return(1);
-       else if (0 == strcmp(p, "Sy"))
-               return(1);
+       if (0 == strcmp(np->child->string, "Em"))
+               np->data.Bf->font = FONT_Em;
+       else if (0 == strcmp(np->child->string, "Li"))
+               np->data.Bf->font = FONT_Li;
+       else if (0 == strcmp(np->child->string, "Sy"))
+               np->data.Bf->font = FONT_Sy;
+       else if ( ! mdoc_nmsg(mdoc, np, MANDOCERR_FONTTYPE))
+               return(0);

 
 

-       mdoc_nmsg(mdoc, head, MANDOCERR_FONTTYPE);
-       return(0);
+       return(1);

 }
 
 
 }
 
 


@@ -955,16 +1092,14 @@ post_at(POST_ARGS)
 static int
 post_an(POST_ARGS)
 {
 static int
 post_an(POST_ARGS)
 {

+       struct mdoc_node *np;

 
 

-       if (mdoc->last->args) {
-               if (NULL == mdoc->last->child)
-                       return(1);
-               return(mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_ARGCOUNT));
-       }
-
-       if (mdoc->last->child)
+       np = mdoc->last;
+       if (AUTH__NONE != np->data.An.auth && np->child)
+               return(mdoc_nmsg(mdoc, np, MANDOCERR_ARGCOUNT));
+       if (AUTH__NONE != np->data.An.auth || np->child)

                return(1);
                return(1);

-       return(mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_NOARGS));
+       return(mdoc_nmsg(mdoc, np, MANDOCERR_NOARGS));

 }
 
 
 }
 
 


@@ -980,7 +1115,8 @@ post_it(POST_ARGS)
                return(1);
 
        n = mdoc->last->parent->parent;
                return(1);
 
        n = mdoc->last->parent->parent;

-       lt = n->data.list;
+       assert(n->data.Bl);
+       lt = n->data.Bl->type;

 
        if (LIST__NONE == lt) {
                mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_LISTTYPE);
 
        if (LIST__NONE == lt) {
                mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_LISTTYPE);


@@ -1005,9 +1141,6 @@ post_it(POST_ARGS)
                if (NULL == mdoc->last->head->child)
                        if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_NOARGS))
                                return(0);
                if (NULL == mdoc->last->head->child)
                        if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_NOARGS))
                                return(0);

-               if (NULL == mdoc->last->body->child)
-                       if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_NOBODY))
-                               return(0);

                break;
        case (LIST_bullet):
                /* FALLTHROUGH */
                break;
        case (LIST_bullet):
                /* FALLTHROUGH */


@@ -1016,24 +1149,18 @@ post_it(POST_ARGS)
        case (LIST_enum):
                /* FALLTHROUGH */
        case (LIST_hyphen):
        case (LIST_enum):
                /* FALLTHROUGH */
        case (LIST_hyphen):

+               if (NULL == mdoc->last->body->child)
+                       if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_NOBODY))
+                               return(0);

                /* FALLTHROUGH */
        case (LIST_item):
                if (mdoc->last->head->child)
                        if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_ARGSLOST))
                                return(0);
                /* FALLTHROUGH */
        case (LIST_item):
                if (mdoc->last->head->child)
                        if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_ARGSLOST))
                                return(0);

-               if (NULL == mdoc->last->body->child)
-                       if ( ! mdoc_nmsg(mdoc, mdoc->last, MANDOCERR_NOBODY))
-                               return(0);

                break;
        case (LIST_column):
                break;
        case (LIST_column):

-               cols = -1;
-               for (i = 0; i < (int)n->args->argc; i++)
-                       if (MDOC_Column == n->args->argv[i].arg) {
-                               cols = (int)n->args->argv[i].sz;
-                               break;
-                       }
+               cols = (int)n->data.Bl->ncols;

 
 

-               assert(-1 != cols);

                assert(NULL == mdoc->last->head->child);
 
                if (NULL == mdoc->last->body->child)
                assert(NULL == mdoc->last->head->child);
 
                if (NULL == mdoc->last->body->child)


@@ -1072,13 +1199,8 @@ post_bl_head(POST_ARGS)
        assert(mdoc->last->parent);
        n = mdoc->last->parent;
 
        assert(mdoc->last->parent);
        n = mdoc->last->parent;
 

-       if (LIST_column == n->data.list) {
-               for (i = 0; i < (int)n->args->argc; i++)
-                       if (MDOC_Column == n->args->argv[i].arg)
-                               break;
-               assert(i < (int)n->args->argc);
-
-               if (n->args->argv[i].sz && mdoc->last->nchild) {
+       if (LIST_column == n->data.Bl->type) {
+               if (n->data.Bl->ncols && mdoc->last->nchild) {

                        mdoc_nmsg(mdoc, n, MANDOCERR_COLUMNS);
                        return(0);
                }
                        mdoc_nmsg(mdoc, n, MANDOCERR_COLUMNS);
                        return(0);
                }