No need to populate the TYPE_arch and TYPE_sec bits, the information

[mandoc.git] / cgi.c

diff --git a/cgi.c b/cgi.c
index e20ad2011ad19c5bc6c6fcab6632781dad5a9c15..f8497b588d954aeb19c50ef4123545ff7f344ea8 100644 (file)
--- a/cgi.c
+++ b/cgi.c
@@ -1,102 +1,131 @@
-/*     $Id: cgi.c,v 1.60 2014/07/09 17:03:07 schwarze Exp $ */
+/*     $Id: cgi.c,v 1.135 2016/07/11 22:48:37 schwarze Exp $ */

 /*
  * Copyright (c) 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv>
 /*
  * Copyright (c) 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv>

- * Copyright (c) 2014 Ingo Schwarze <schwarze@usta.de>
+ * Copyright (c) 2014, 2015, 2016 Ingo Schwarze <schwarze@usta.de>

  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
  * copyright notice and this permission notice appear in all copies.
  *
  *
  * Permission to use, copy, modify, and distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
  * copyright notice and this permission notice appear in all copies.
  *

- * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHORS DISCLAIM ALL WARRANTIES

  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF

- * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR

  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */

-#ifdef HAVE_CONFIG_H

 #include "config.h"
 #include "config.h"

-#endif
+
+#include <sys/types.h>
+#include <sys/time.h>

 
 #include <ctype.h>
 
 #include <ctype.h>

+#include <err.h>

 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>

+#include <stdint.h>

 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
 

-#include "mandoc.h"

 #include "mandoc_aux.h"
 #include "mandoc_aux.h"

+#include "mandoc.h"
+#include "roff.h"
+#include "mdoc.h"
+#include "man.h"

 #include "main.h"
 #include "main.h"

-#include "manpath.h"
+#include "manconf.h"

 #include "mansearch.h"
 #include "mansearch.h"

-
-enum   page {
-       PAGE_INDEX,
-       PAGE_SEARCH,
-       PAGE_SHOW,
-       PAGE__MAX
-};
+#include "cgi.h"

 
 /*
  * A query as passed to the search function.
  */
 struct query {
 
 /*
  * A query as passed to the search function.
  */
 struct query {

-       const char      *manpath; /* desired manual directory */
-       const char      *arch; /* architecture */
-       const char      *sec; /* manual section */
-       const char      *expr; /* unparsed expression string */
-       int              legacy; /* whether legacy mode */
+       char            *manpath; /* desired manual directory */
+       char            *arch; /* architecture */
+       char            *sec; /* manual section */
+       char            *query; /* unparsed query expression */
+       int              equal; /* match whole names, not substrings */

 };
 
 struct req {
        struct query      q;
        char            **p; /* array of available manpaths */
        size_t            psz; /* number of available manpaths */
 };
 
 struct req {
        struct query      q;
        char            **p; /* array of available manpaths */
        size_t            psz; /* number of available manpaths */

-       enum page         page;
+       int               isquery; /* QUERY_STRING used, not PATH_INFO */
+};
+
+enum   focus {
+       FOCUS_NONE = 0,
+       FOCUS_QUERY

 };
 
 };
 

-static void             catman(const struct req *, const char *);
-static int              cmp(const void *, const void *);
-static void             format(const struct req *, const char *);

 static void             html_print(const char *);
 static void             html_print(const char *);

-static void             html_printquery(const struct req *);

 static void             html_putchar(char);
 static void             html_putchar(char);

-static int              http_decode(char *);
-static void             http_parse(struct req *, char *);
-static void             http_print(const char *);
-static void             http_putchar(char);
-static void             http_printquery(const struct req *);
-static void             pathgen(struct req *);
-static void             pg_index(const struct req *, char *);
-static void             pg_search(const struct req *, char *);
-static void             pg_show(const struct req *, char *);
+static int              http_decode(char *);
+static void             parse_manpath_conf(struct req *);
+static void             parse_path_info(struct req *req, const char *path);
+static void             parse_query_string(struct req *, const char *);
+static void             pg_error_badrequest(const char *);
+static void             pg_error_internal(void);
+static void             pg_index(const struct req *);
+static void             pg_noresult(const struct req *, const char *);
+static void             pg_search(const struct req *);
+static void             pg_searchres(const struct req *,
+                               struct manpage *, size_t);
+static void             pg_show(struct req *, const char *);

 static void             resp_begin_html(int, const char *);
 static void             resp_begin_http(int, const char *);
 static void             resp_begin_html(int, const char *);
 static void             resp_begin_http(int, const char *);

+static void             resp_catman(const struct req *, const char *);
+static void             resp_copy(const char *);

 static void             resp_end_html(void);
 static void             resp_end_html(void);

-static void             resp_error_badrequest(const char *);
-static void             resp_error_internal(void);
-static void             resp_error_notfound(const char *);
-static void             resp_index(const struct req *);
-static void             resp_noresult(const struct req *,
-                               const char *);
-static void             resp_search(const struct req *,
-                               struct manpage *, size_t);
-static void             resp_searchform(const struct req *);
-
-static const char       *scriptname; /* CGI script name */
-static const char       *mandir; /* contains all manpath directories */
-static const char       *cssdir; /* css directory */
-static const char       *httphost; /* hostname used in the URIs */
-
-static const char * const pages[PAGE__MAX] = {
-       "index", /* PAGE_INDEX */ 
-       "search", /* PAGE_SEARCH */
-       "show", /* PAGE_SHOW */
+static void             resp_format(const struct req *, const char *);
+static void             resp_searchform(const struct req *, enum focus);
+static void             resp_show(const struct req *, const char *);
+static void             set_query_attr(char **, char **);
+static int              validate_filename(const char *);
+static int              validate_manpath(const struct req *, const char *);
+static int              validate_urifrag(const char *);
+
+static const char       *scriptname = SCRIPT_NAME;
+
+static const int sec_prios[] = {1, 4, 5, 8, 6, 3, 7, 2, 9};
+static const char *const sec_numbers[] = {
+    "0", "1", "2", "3", "3p", "4", "5", "6", "7", "8", "9"

 };
 };

+static const char *const sec_names[] = {
+    "All Sections",
+    "1 - General Commands",
+    "2 - System Calls",
+    "3 - Library Functions",
+    "3p - Perl Library",
+    "4 - Device Drivers",
+    "5 - File Formats",
+    "6 - Games",
+    "7 - Miscellaneous Information",
+    "8 - System Manager\'s Manual",
+    "9 - Kernel Developer\'s Manual"
+};
+static const int sec_MAX = sizeof(sec_names) / sizeof(char *);
+
+static const char *const arch_names[] = {
+    "amd64",       "alpha",       "armish",      "armv7",
+    "hppa",        "hppa64",      "i386",        "landisk",
+    "loongson",    "luna88k",     "macppc",      "mips64",
+    "octeon",      "sgi",         "socppc",      "sparc",
+    "sparc64",     "zaurus",
+    "amiga",       "arc",         "arm32",       "atari",
+    "aviion",      "beagle",      "cats",        "hp300",       
+    "ia64",        "mac68k",      "mvme68k",     "mvme88k",
+    "mvmeppc",     "palm",        "pc532",       "pegasos",
+    "pmax",        "powerpc",     "solbourne",   "sun3",
+    "vax",         "wgrisc",      "x68k"
+};
+static const int arch_MAX = sizeof(arch_names) / sizeof(char *);

 
 /*
  * Print a character, escaping HTML along the way.
 
 /*
  * Print a character, escaping HTML along the way.


@@ -125,154 +154,125 @@ html_putchar(char c)
        }
 }
 
        }
 }
 

+/*
+ * Call through to html_putchar().
+ * Accepts NULL strings.
+ */

 static void
 static void

-http_printquery(const struct req *req)
-{
-
-       if (NULL != req->q.manpath) {
-               printf("&manpath=");
-               http_print(req->q.manpath);
-       }
-       if (NULL != req->q.sec) {
-               printf("&sec=");
-               http_print(req->q.sec);
-       }
-       if (NULL != req->q.arch) {
-               printf("&arch=");
-               http_print(req->q.arch);
-       }
-       if (NULL != req->q.expr) {
-               printf("&expr=");
-               http_print(req->q.expr ? req->q.expr : "");
-       }
-}
-
-static void
-html_printquery(const struct req *req)
-{
-
-       if (NULL != req->q.manpath) {
-               printf("&amp;manpath=");
-               html_print(req->q.manpath);
-       }
-       if (NULL != req->q.sec) {
-               printf("&amp;sec=");
-               html_print(req->q.sec);
-       }
-       if (NULL != req->q.arch) {
-               printf("&amp;arch=");
-               html_print(req->q.arch);
-       }
-       if (NULL != req->q.expr) {
-               printf("&amp;expr=");
-               html_print(req->q.expr ? req->q.expr : "");
-       }
-}
-
-static void
-http_print(const char *p)
+html_print(const char *p)

 {
 
        if (NULL == p)
                return;
        while ('\0' != *p)
 {
 
        if (NULL == p)
                return;
        while ('\0' != *p)

-               http_putchar(*p++);
+               html_putchar(*p++);

 }
 
 /*
 }
 
 /*

- * Call through to html_putchar().
- * Accepts NULL strings.
+ * Transfer the responsibility for the allocated string *val
+ * to the query structure.

  */
 static void
  */
 static void

-html_print(const char *p)
+set_query_attr(char **attr, char **val)

 {
 {

-       
-       if (NULL == p)
-               return;
-       while ('\0' != *p)
-               html_putchar(*p++);
+
+       free(*attr);
+       if (**val == '\0') {
+               *attr = NULL;
+               free(*val);
+       } else
+               *attr = *val;
+       *val = NULL;

 }
 
 /*
 }
 
 /*

- * Parse out key-value pairs from an HTTP request variable.
- * This can be either a cookie or a POST/GET string, although man.cgi
- * uses only GET for simplicity.
+ * Parse the QUERY_STRING for key-value pairs
+ * and store the values into the query structure.

  */
 static void
  */
 static void

-http_parse(struct req *req, char *p)
+parse_query_string(struct req *req, const char *qs)

 {
 {

-       char            *key, *val;
-       int              legacy;
+       char            *key, *val;
+       size_t           keysz, valsz;

 
 

-       memset(&req->q, 0, sizeof(struct query));
-       req->q.manpath = req->p[0];
+       req->isquery    = 1;
+       req->q.manpath  = NULL;
+       req->q.arch     = NULL;
+       req->q.sec      = NULL;
+       req->q.query    = NULL;
+       req->q.equal    = 1;

 
 

-       legacy = -1;
-       while ('\0' != *p) {
-               key = p;
-               val = NULL;
+       key = val = NULL;
+       while (*qs != '\0') {

 
 

-               p += (int)strcspn(p, ";&");
-               if ('\0' != *p)
-                       *p++ = '\0';
-               if (NULL != (val = strchr(key, '=')))
-                       *val++ = '\0';
+               /* Parse one key. */

 
 

-               if ('\0' == *key || NULL == val || '\0' == *val)
-                       continue;
+               keysz = strcspn(qs, "=;&");
+               key = mandoc_strndup(qs, keysz);
+               qs += keysz;
+               if (*qs != '=')
+                       goto next;

 
 

-               /* Just abort handling. */
+               /* Parse one value. */

 
 

-               if ( ! http_decode(key))
-                       break;
-               if (NULL != val && ! http_decode(val))
-                       break;
+               valsz = strcspn(++qs, ";&");
+               val = mandoc_strndup(qs, valsz);
+               qs += valsz;

 
 

-               if (0 == strcmp(key, "expr"))
-                       req->q.expr = val;
-               else if (0 == strcmp(key, "query"))
-                       req->q.expr = val;
-               else if (0 == strcmp(key, "sec"))
-                       req->q.sec = val;
-               else if (0 == strcmp(key, "sektion"))
-                       req->q.sec = val;
-               else if (0 == strcmp(key, "arch"))
-                       req->q.arch = val;
-               else if (0 == strcmp(key, "manpath"))
-                       req->q.manpath = val;
-               else if (0 == strcmp(key, "apropos"))
-                       legacy = 0 == strcmp(val, "0");
-       }
-
-       /* Test for old man.cgi compatibility mode. */
-
-       req->q.legacy = legacy > 0;
-
-       /* 
-        * Section "0" means no section when in legacy mode.
-        * For some man.cgi scripts, "default" arch is none.
-        */
+               /* Decode and catch encoding errors. */

 
 

-       if (req->q.legacy && NULL != req->q.sec)
-               if (0 == strcmp(req->q.sec, "0"))
-                       req->q.sec = NULL;
-       if (req->q.legacy && NULL != req->q.arch)
-               if (0 == strcmp(req->q.arch, "default"))
-                       req->q.arch = NULL;
-}
+               if ( ! (http_decode(key) && http_decode(val)))
+                       goto next;

 
 

-static void
-http_putchar(char c)
-{
+               /* Handle key-value pairs. */

 
 

-       if (isalnum((unsigned char)c)) {
-               putchar((unsigned char)c);
-               return;
-       } else if (' ' == c) {
-               putchar('+');
-               return;
+               if ( ! strcmp(key, "query"))
+                       set_query_attr(&req->q.query, &val);
+
+               else if ( ! strcmp(key, "apropos"))
+                       req->q.equal = !strcmp(val, "0");
+
+               else if ( ! strcmp(key, "manpath")) {
+#ifdef COMPAT_OLDURI
+                       if ( ! strncmp(val, "OpenBSD ", 8)) {
+                               val[7] = '-';
+                               if ('C' == val[8])
+                                       val[8] = 'c';
+                       }
+#endif
+                       set_query_attr(&req->q.manpath, &val);
+               }
+
+               else if ( ! (strcmp(key, "sec")
+#ifdef COMPAT_OLDURI
+                   && strcmp(key, "sektion")
+#endif
+                   )) {
+                       if ( ! strcmp(val, "0"))
+                               *val = '\0';
+                       set_query_attr(&req->q.sec, &val);
+               }
+
+               else if ( ! strcmp(key, "arch")) {
+                       if ( ! strcmp(val, "default"))
+                               *val = '\0';
+                       set_query_attr(&req->q.arch, &val);
+               }
+
+               /*
+                * The key must be freed in any case.
+                * The val may have been handed over to the query
+                * structure, in which case it is now NULL.
+                */
+next:
+               free(key);
+               key = NULL;
+               free(val);
+               val = NULL;
+
+               if (*qs != '\0')
+                       qs++;

        }
        }

-       printf("%%%.2x", c);

 }
 
 /*
 }
 
 /*


@@ -284,29 +284,31 @@ static int
 http_decode(char *p)
 {
        char             hex[3];
 http_decode(char *p)
 {
        char             hex[3];

+       char            *q;

        int              c;
 
        hex[2] = '\0';
 
        int              c;
 
        hex[2] = '\0';
 

-       for ( ; '\0' != *p; p++) {
+       q = p;
+       for ( ; '\0' != *p; p++, q++) {

                if ('%' == *p) {
                        if ('\0' == (hex[0] = *(p + 1)))
                if ('%' == *p) {
                        if ('\0' == (hex[0] = *(p + 1)))

-                               return(0);
+                               return 0;

                        if ('\0' == (hex[1] = *(p + 2)))
                        if ('\0' == (hex[1] = *(p + 2)))

-                               return(0);
+                               return 0;

                        if (1 != sscanf(hex, "%x", &c))
                        if (1 != sscanf(hex, "%x", &c))

-                               return(0);
+                               return 0;

                        if ('\0' == c)
                        if ('\0' == c)

-                               return(0);
+                               return 0;

 
 

-                       *p = (char)c;
-                       memmove(p + 1, p + 3, strlen(p + 3) + 1);
+                       *q = (char)c;
+                       p += 2;

                } else
                } else

-                       *p = '+' == *p ? ' ' : *p;
+                       *q = '+' == *p ? ' ' : *p;

        }
 
        }
 

-       *p = '\0';
-       return(1);
+       *q = '\0';
+       return 1;

 }
 
 static void
 }
 
 static void


@@ -314,242 +316,362 @@ resp_begin_http(int code, const char *msg)
 {
 
        if (200 != code)
 {
 
        if (200 != code)

-               printf("Status: %d %s\n", code, msg);
+               printf("Status: %d %s\r\n", code, msg);

 
 

-       puts("Content-Type: text/html; charset=utf-8\n"
-            "Cache-Control: no-cache\n"
-            "Pragma: no-cache\n"
-            "");
+       printf("Content-Type: text/html; charset=utf-8\r\n"
+            "Cache-Control: no-cache\r\n"
+            "Pragma: no-cache\r\n"
+            "\r\n");

 
        fflush(stdout);
 }
 
 
        fflush(stdout);
 }
 

+static void
+resp_copy(const char *filename)
+{
+       char     buf[4096];
+       ssize_t  sz;
+       int      fd;
+
+       if ((fd = open(filename, O_RDONLY)) != -1) {
+               fflush(stdout);
+               while ((sz = read(fd, buf, sizeof(buf))) > 0)
+                       write(STDOUT_FILENO, buf, sz);
+       }
+}
+

 static void
 resp_begin_html(int code, const char *msg)
 {
 
        resp_begin_http(code, msg);
 
 static void
 resp_begin_html(int code, const char *msg)
 {
 
        resp_begin_http(code, msg);
 

-       printf("<!DOCTYPE HTML PUBLIC "
-              " \"-//W3C//DTD HTML 4.01//EN\""
-              " \"http://www.w3.org/TR/html4/strict.dtd\">\n"
-              "<HTML>\n"
-              "<HEAD>\n"
-              "<META HTTP-EQUIV=\"Content-Type\""
-              " CONTENT=\"text/html; charset=utf-8\">\n"
-              "<LINK REL=\"stylesheet\" HREF=\"%s/man-cgi.css\""
-              " TYPE=\"text/css\" media=\"all\">\n"
-              "<LINK REL=\"stylesheet\" HREF=\"%s/man.css\""
-              " TYPE=\"text/css\" media=\"all\">\n"
-              "<TITLE>System Manpage Reference</TITLE>\n"
-              "</HEAD>\n"
-              "<BODY>\n"
+       printf("<!DOCTYPE html>\n"
+              "<html>\n"
+              "<head>\n"
+              "<meta charset=\"UTF-8\"/>\n"
+              "<link rel=\"stylesheet\" href=\"%s/mandoc.css\""
+              " type=\"text/css\" media=\"all\">\n"
+              "<title>%s</title>\n"
+              "</head>\n"
+              "<body>\n"

               "<!-- Begin page content. //-->\n",
               "<!-- Begin page content. //-->\n",

-              cssdir, cssdir);
+              CSS_DIR, CUSTOMIZE_TITLE);
+
+       resp_copy(MAN_DIR "/header.html");

 }
 
 static void
 resp_end_html(void)
 {
 
 }
 
 static void
 resp_end_html(void)
 {
 

-       puts("</BODY>\n"
-            "</HTML>");
+       resp_copy(MAN_DIR "/footer.html");
+
+       puts("</body>\n"
+            "</html>");

 }
 
 static void
 }
 
 static void

-resp_searchform(const struct req *req)
+resp_searchform(const struct req *req, enum focus focus)

 {
        int              i;
 
        puts("<!-- Begin search form. //-->");
 {
        int              i;
 
        puts("<!-- Begin search form. //-->");

-       printf("<DIV ID=\"mancgi\">\n"
-              "<FORM ACTION=\"%s/search\" METHOD=\"get\">\n"
-              "<FIELDSET>\n"
-              "<LEGEND>Search Parameters</LEGEND>\n"
-              "<INPUT TYPE=\"submit\" "
-              " VALUE=\"Search\"> for manuals satisfying \n"
-              "<INPUT TYPE=\"text\" NAME=\"expr\" VALUE=\"",
+       printf("<div id=\"mancgi\">\n"
+              "<form action=\"/%s\" method=\"get\">\n"
+              "<fieldset>\n"
+              "<legend>Manual Page Search Parameters</legend>\n",

               scriptname);
               scriptname);

-       html_print(req->q.expr ? req->q.expr : "");
-       printf("\">, section "
-              "<INPUT TYPE=\"text\""
-              " SIZE=\"4\" NAME=\"sec\" VALUE=\"");
-       html_print(req->q.sec ? req->q.sec : "");
-       printf("\">, arch "
-              "<INPUT TYPE=\"text\""
-              " SIZE=\"8\" NAME=\"arch\" VALUE=\"");
-       html_print(req->q.arch ? req->q.arch : "");
-       printf("\">");
+
+       /* Write query input box. */
+
+       printf("<input type=\"text\" name=\"query\" value=\"");
+       if (req->q.query != NULL)
+               html_print(req->q.query);
+       printf( "\" size=\"40\"");
+       if (focus == FOCUS_QUERY)
+               printf(" autofocus");
+       puts(">");
+
+       /* Write submission buttons. */
+
+       printf( "<button type=\"submit\" name=\"apropos\" value=\"0\">"
+               "man</button>\n"
+               "<button type=\"submit\" name=\"apropos\" value=\"1\">"
+               "apropos</button>\n<br/>\n");
+
+       /* Write section selector. */
+
+       puts("<select name=\"sec\">");
+       for (i = 0; i < sec_MAX; i++) {
+               printf("<option value=\"%s\"", sec_numbers[i]);
+               if (NULL != req->q.sec &&
+                   0 == strcmp(sec_numbers[i], req->q.sec))
+                       printf(" selected=\"selected\"");
+               printf(">%s</option>\n", sec_names[i]);
+       }
+       puts("</select>");
+
+       /* Write architecture selector. */
+
+       printf( "<select name=\"arch\">\n"
+               "<option value=\"default\"");
+       if (NULL == req->q.arch)
+               printf(" selected=\"selected\"");
+       puts(">All Architectures</option>");
+       for (i = 0; i < arch_MAX; i++) {
+               printf("<option value=\"%s\"", arch_names[i]);
+               if (NULL != req->q.arch &&
+                   0 == strcmp(arch_names[i], req->q.arch))
+                       printf(" selected=\"selected\"");
+               printf(">%s</option>\n", arch_names[i]);
+       }
+       puts("</select>");
+
+       /* Write manpath selector. */
+

        if (req->psz > 1) {
        if (req->psz > 1) {

-               puts(", in <SELECT NAME=\"manpath\">");
+               puts("<select name=\"manpath\">");

                for (i = 0; i < (int)req->psz; i++) {
                for (i = 0; i < (int)req->psz; i++) {

-                       printf("<OPTION ");
-                       if (NULL == req->q.manpath ? 0 == i :
-                           0 == strcmp(req->q.manpath, req->p[i]))
-                               printf("SELECTED=\"selected\" ");
-                       printf("VALUE=\"");
+                       printf("<option ");
+                       if (strcmp(req->q.manpath, req->p[i]) == 0)
+                               printf("selected=\"selected\" ");
+                       printf("value=\"");

                        html_print(req->p[i]);
                        printf("\">");
                        html_print(req->p[i]);
                        html_print(req->p[i]);
                        printf("\">");
                        html_print(req->p[i]);

-                       puts("</OPTION>");
+                       puts("</option>");

                }
                }

-               puts("</SELECT>");
+               puts("</select>");

        }
        }

-       puts("&mdash;\n"
-            "<INPUT TYPE=\"reset\" VALUE=\"Reset\">\n"
-            "</FIELDSET>\n"
-            "</FORM>\n"
-            "</DIV>");
+
+       puts("</fieldset>\n"
+            "</form>\n"
+            "</div>");

        puts("<!-- End search form. //-->");
 }
 
        puts("<!-- End search form. //-->");
 }
 

+static int
+validate_urifrag(const char *frag)
+{
+
+       while ('\0' != *frag) {
+               if ( ! (isalnum((unsigned char)*frag) ||
+                   '-' == *frag || '.' == *frag ||
+                   '/' == *frag || '_' == *frag))
+                       return 0;
+               frag++;
+       }
+       return 1;
+}
+
+static int
+validate_manpath(const struct req *req, const char* manpath)
+{
+       size_t   i;
+
+       for (i = 0; i < req->psz; i++)
+               if ( ! strcmp(manpath, req->p[i]))
+                       return 1;
+
+       return 0;
+}
+
+static int
+validate_filename(const char *file)
+{
+
+       if ('.' == file[0] && '/' == file[1])
+               file += 2;
+
+       return ! (strstr(file, "../") || strstr(file, "/..") ||
+           (strncmp(file, "man", 3) && strncmp(file, "cat", 3)));
+}
+

 static void
 static void

-resp_index(const struct req *req)
+pg_index(const struct req *req)

 {
 
        resp_begin_html(200, NULL);
 {
 
        resp_begin_html(200, NULL);

-       puts("<H1>\n"
-            "Online manuals with "
-            "<A HREF=\"http://mdocml.bsd.lv/\">mandoc</A>\n"
-            "</H1>");
-       resp_searchform(req);
-       puts("<P>\n"
-            "The <A HREF=\"search?expr=Nm~^apropos$&amp;sec=1\">"
-            "apropos</A> manual explains the query syntax.\n"
-            "</P>");
+       resp_searchform(req, FOCUS_QUERY);
+       printf("<p>\n"
+              "This web interface is documented in the\n"
+              "<a href=\"/%s%sman.cgi.8\">man.cgi(8)</a>\n"
+              "manual, and the\n"
+              "<a href=\"/%s%sapropos.1\">apropos(1)</a>\n"
+              "manual explains the query syntax.\n"
+              "</p>\n",
+              scriptname, *scriptname == '\0' ? "" : "/",
+              scriptname, *scriptname == '\0' ? "" : "/");

        resp_end_html();
 }
 
 static void
        resp_end_html();
 }
 
 static void

-resp_noresult(const struct req *req, const char *msg)
+pg_noresult(const struct req *req, const char *msg)

 {
        resp_begin_html(200, NULL);
 {
        resp_begin_html(200, NULL);

-       resp_searchform(req);
-       puts("<P>");
+       resp_searchform(req, FOCUS_QUERY);
+       puts("<p>");

        puts(msg);
        puts(msg);

-       puts("</P>");
+       puts("</p>");

        resp_end_html();
 }
 
 static void
        resp_end_html();
 }
 
 static void

-resp_error_badrequest(const char *msg)
+pg_error_badrequest(const char *msg)

 {
 
        resp_begin_html(400, "Bad Request");
 {
 
        resp_begin_html(400, "Bad Request");

-       puts("<H1>Bad Request</H1>\n"
-            "<P>\n");
+       puts("<h1>Bad Request</h1>\n"
+            "<p>\n");

        puts(msg);
        printf("Try again from the\n"
        puts(msg);
        printf("Try again from the\n"

-              "<A HREF=\"%s\">main page</A>.\n"
-              "</P>", scriptname);
+              "<a href=\"/%s\">main page</a>.\n"
+              "</p>", scriptname);

        resp_end_html();
 }
 
 static void
        resp_end_html();
 }
 
 static void

-resp_error_notfound(const char *page)
-{
-
-       resp_begin_html(404, "Not Found");
-       puts("<H1>Page Not Found</H1>\n"
-            "<P>\n"
-            "The page you're looking for, ");
-       printf("<B>");
-       html_print(page);
-       printf("</B>,\n"
-              "could not be found.\n"
-              "Try searching from the\n"
-              "<A HREF=\"%s\">main page</A>.\n"
-              "</P>", scriptname);
-       resp_end_html();
-}
-
-static void
-resp_error_internal(void)
+pg_error_internal(void)

 {
        resp_begin_html(500, "Internal Server Error");
 {
        resp_begin_html(500, "Internal Server Error");

-       puts("<P>Internal Server Error</P>");
+       puts("<p>Internal Server Error</p>");

        resp_end_html();
 }
 
 static void
        resp_end_html();
 }
 
 static void

-resp_search(const struct req *req, struct manpage *r, size_t sz)
+pg_searchres(const struct req *req, struct manpage *r, size_t sz)

 {
 {

-       size_t           i;
+       char            *arch, *archend;
+       const char      *sec;
+       size_t           i, iuse;
+       int              archprio, archpriouse;
+       int              prio, priouse;
+
+       for (i = 0; i < sz; i++) {
+               if (validate_filename(r[i].file))
+                       continue;
+               warnx("invalid filename %s in %s database",
+                   r[i].file, req->q.manpath);
+               pg_error_internal();
+               return;
+       }

 
 

-       if (1 == sz) {
+       if (req->isquery && sz == 1) {

                /*
                 * If we have just one result, then jump there now
                 * without any delay.
                 */
                /*
                 * If we have just one result, then jump there now
                 * without any delay.
                 */

-               puts("Status: 303 See Other");
-               printf("Location: http://%s%s/show/%s/%s?",
-                   httphost, scriptname, req->q.manpath, r[0].file);
-               http_printquery(req);
-               puts("\n"
-                    "Content-Type: text/html; charset=utf-8\n");
+               printf("Status: 303 See Other\r\n");
+               printf("Location: http://%s/%s%s%s/%s",
+                   HTTP_HOST, scriptname,
+                   *scriptname == '\0' ? "" : "/",
+                   req->q.manpath, r[0].file);
+               printf("\r\n"
+                    "Content-Type: text/html; charset=utf-8\r\n"
+                    "\r\n");

                return;
        }
 
                return;
        }
 

-       qsort(r, sz, sizeof(struct manpage), cmp);
-

        resp_begin_html(200, NULL);
        resp_begin_html(200, NULL);

-       resp_searchform(req);
-       puts("<DIV CLASS=\"results\">");
-       puts("<TABLE>");
+       resp_searchform(req,
+           req->q.equal || sz == 1 ? FOCUS_NONE : FOCUS_QUERY);
+
+       if (sz > 1) {
+               puts("<div class=\"results\">");
+               puts("<table>");
+
+               for (i = 0; i < sz; i++) {
+                       printf("<tr>\n"
+                              "<td class=\"title\">\n"
+                              "<a href=\"/%s%s%s/%s",
+                           scriptname, *scriptname == '\0' ? "" : "/",
+                           req->q.manpath, r[i].file);
+                       printf("\">");
+                       html_print(r[i].names);
+                       printf("</a>\n"
+                              "</td>\n"
+                              "<td class=\"desc\">");
+                       html_print(r[i].output);
+                       puts("</td>\n"
+                            "</tr>");
+               }

 
 

-       for (i = 0; i < sz; i++) {
-               printf("<TR>\n"
-                      "<TD CLASS=\"title\">\n"
-                      "<A HREF=\"%s/show/%s/%s?", 
-                   scriptname, req->q.manpath, r[i].file);
-               html_printquery(req);
-               printf("\">");
-               html_print(r[i].names);
-               printf("</A>\n"
-                      "</TD>\n"
-                      "<TD CLASS=\"desc\">");
-               html_print(r[i].output);
-               puts("</TD>\n"
-                    "</TR>");
-       }
-
-       puts("</TABLE>\n"
-            "</DIV>");
-       resp_end_html();
-}
+               puts("</table>\n"
+                    "</div>");
+       }

 
 

-/* ARGSUSED */
-static void
-pg_index(const struct req *req, char *path)
-{
+       /*
+        * In man(1) mode, show one of the pages
+        * even if more than one is found.
+        */
+
+       if (req->q.equal || sz == 1) {
+               puts("<hr>");
+               iuse = 0;
+               priouse = 20;
+               archpriouse = 3;
+               for (i = 0; i < sz; i++) {
+                       sec = r[i].file;
+                       sec += strcspn(sec, "123456789");
+                       if (sec[0] == '\0')
+                               continue;
+                       prio = sec_prios[sec[0] - '1'];
+                       if (sec[1] != '/')
+                               prio += 10;
+                       if (req->q.arch == NULL) {
+                               archprio =
+                                   ((arch = strchr(sec + 1, '/'))
+                                       == NULL) ? 3 :
+                                   ((archend = strchr(arch + 1, '/'))
+                                       == NULL) ? 0 :
+                                   strncmp(arch, "amd64/",
+                                       archend - arch) ? 2 : 1;
+                               if (archprio < archpriouse) {
+                                       archpriouse = archprio;
+                                       priouse = prio;
+                                       iuse = i;
+                                       continue;
+                               }
+                               if (archprio > archpriouse)
+                                       continue;
+                       }
+                       if (prio >= priouse)
+                               continue;
+                       priouse = prio;
+                       iuse = i;
+               }
+               resp_show(req, r[iuse].file);
+       }

 
 

-       resp_index(req);
+       resp_end_html();

 }
 
 static void
 }
 
 static void

-catman(const struct req *req, const char *file)
+resp_catman(const struct req *req, const char *file)

 {
        FILE            *f;
 {
        FILE            *f;

-       size_t           len;
-       int              i;

        char            *p;
        char            *p;

+       size_t           sz;
+       ssize_t          len;
+       int              i;

        int              italic, bold;
 
        int              italic, bold;
 

-       if (NULL == (f = fopen(file, "r"))) {
-               resp_error_badrequest(
-                   "You specified an invalid manual file.");
+       if ((f = fopen(file, "r")) == NULL) {
+               puts("<p>You specified an invalid manual file.</p>");

                return;
        }
 
                return;
        }
 

-       resp_begin_html(200, NULL);
-       resp_searchform(req);
-       puts("<DIV CLASS=\"catman\">\n"
-            "<PRE>");
+       puts("<div class=\"catman\">\n"
+            "<pre>");

 
 

-       while (NULL != (p = fgetln(f, &len))) {
+       p = NULL;
+       sz = 0;
+
+       while ((len = getline(&p, &sz, f)) != -1) {

                bold = italic = 0;
                bold = italic = 0;

-               for (i = 0; i < (int)len - 1; i++) {
-                       /* 
+               for (i = 0; i < len - 1; i++) {
+                       /*

                         * This means that the catpage is out of state.
                         * Ignore it and keep going (although the
                         * catpage is bogus).
                         * This means that the catpage is out of state.
                         * Ignore it and keep going (although the
                         * catpage is bogus).


@@ -567,22 +689,22 @@ catman(const struct req *req, const char *file)
 
                        if ('\b' != p[i + 1]) {
                                if (italic)
 
                        if ('\b' != p[i + 1]) {
                                if (italic)

-                                       printf("</I>");
+                                       printf("</i>");

                                if (bold)
                                if (bold)

-                                       printf("</B>");
+                                       printf("</b>");

                                italic = bold = 0;
                                html_putchar(p[i]);
                                continue;
                                italic = bold = 0;
                                html_putchar(p[i]);
                                continue;

-                       } else if (i + 2 >= (int)len)
+                       } else if (i + 2 >= len)

                                continue;
 
                        /* Italic mode. */
 
                        if ('_' == p[i]) {
                                if (bold)
                                continue;
 
                        /* Italic mode. */
 
                        if ('_' == p[i]) {
                                if (bold)

-                                       printf("</B>");
+                                       printf("</b>");

                                if ( ! italic)
                                if ( ! italic)

-                                       printf("<I>");
+                                       printf("<i>");

                                bold = 0;
                                italic = 1;
                                i += 2;
                                bold = 0;
                                italic = 1;
                                i += 2;


@@ -590,7 +712,7 @@ catman(const struct req *req, const char *file)
                                continue;
                        }
 
                                continue;
                        }
 

-                       /* 
+                       /*

                         * Handle funny behaviour troff-isms.
                         * These grok'd from the original man2html.c.
                         */
                         * Handle funny behaviour troff-isms.
                         * These grok'd from the original man2html.c.
                         */


@@ -604,9 +726,9 @@ catman(const struct req *req, const char *file)
                                        ('*' == p[i] && '|' == p[i + 2]) ||
                                        ('|' == p[i] && '*' == p[i + 2]))  {
                                if (italic)
                                        ('*' == p[i] && '|' == p[i + 2]) ||
                                        ('|' == p[i] && '*' == p[i + 2]))  {
                                if (italic)

-                                       printf("</I>");
+                                       printf("</i>");

                                if (bold)
                                if (bold)

-                                       printf("</B>");
+                                       printf("</b>");

                                italic = bold = 0;
                                putchar('*');
                                i += 2;
                                italic = bold = 0;
                                putchar('*');
                                i += 2;


@@ -618,9 +740,9 @@ catman(const struct req *req, const char *file)
                                        ('+' == p[i] && '|' == p[i + 1]) ||
                                        ('|' == p[i] && '+' == p[i + 1]))  {
                                if (italic)
                                        ('+' == p[i] && '|' == p[i + 1]) ||
                                        ('|' == p[i] && '+' == p[i + 1]))  {
                                if (italic)

-                                       printf("</I>");
+                                       printf("</i>");

                                if (bold)
                                if (bold)

-                                       printf("</B>");
+                                       printf("</b>");

                                italic = bold = 0;
                                putchar('+');
                                i += 2;
                                italic = bold = 0;
                                putchar('+');
                                i += 2;


@@ -628,111 +750,124 @@ catman(const struct req *req, const char *file)
                        }
 
                        /* Bold mode. */
                        }
 
                        /* Bold mode. */

-                       
+

                        if (italic)
                        if (italic)

-                               printf("</I>");
+                               printf("</i>");

                        if ( ! bold)
                        if ( ! bold)

-                               printf("<B>");
+                               printf("<b>");

                        bold = 1;
                        italic = 0;
                        i += 2;
                        html_putchar(p[i]);
                }
 
                        bold = 1;
                        italic = 0;
                        i += 2;
                        html_putchar(p[i]);
                }
 

-               /* 
+               /*

                 * Clean up the last character.
                 * Clean up the last character.

-                * We can get to a newline; don't print that. 
+                * We can get to a newline; don't print that.

                 */
 
                if (italic)
                 */
 
                if (italic)

-                       printf("</I>");
+                       printf("</i>");

                if (bold)
                if (bold)

-                       printf("</B>");
+                       printf("</b>");

 
 

-               if (i == (int)len - 1 && '\n' != p[i])
+               if (i == len - 1 && p[i] != '\n')

                        html_putchar(p[i]);
 
                putchar('\n');
        }
                        html_putchar(p[i]);
 
                putchar('\n');
        }

+       free(p);

 
 

-       puts("</PRE>\n"
-            "</DIV>\n"
-            "</BODY>\n"
-            "</HTML>");
+       puts("</pre>\n"
+            "</div>");

 
        fclose(f);
 }
 
 static void
 
        fclose(f);
 }
 
 static void

-format(const struct req *req, const char *file)
+resp_format(const struct req *req, const char *file)

 {
 {

+       struct manoutput conf;

        struct mparse   *mp;
        struct mparse   *mp;

-       int              fd;
-       struct mdoc     *mdoc;
-       struct man      *man;
+       struct roff_man *man;

        void            *vp;
        void            *vp;

-       enum mandoclevel rc;
-       char             opts[PATH_MAX + 128];
+       int              fd;
+       int              usepath;

 
        if (-1 == (fd = open(file, O_RDONLY, 0))) {
 
        if (-1 == (fd = open(file, O_RDONLY, 0))) {

-               resp_error_badrequest(
-                   "You specified an invalid manual file.");
+               puts("<p>You specified an invalid manual file.</p>");

                return;
        }
 
                return;
        }
 

-       mp = mparse_alloc(MPARSE_SO, MANDOCLEVEL_FATAL, NULL,
-           req->q.manpath);
-       rc = mparse_readfd(mp, fd, file);
+       mchars_alloc();
+       mp = mparse_alloc(MPARSE_SO, MANDOCLEVEL_BADARG, NULL, req->q.manpath);
+       mparse_readfd(mp, fd, file);

        close(fd);
 
        close(fd);
 

-       if (rc >= MANDOCLEVEL_FATAL) {
-               fprintf(stderr, "fatal mandoc error: %s/%s\n",
-                   req->q.manpath, file);
-               resp_error_internal();
-               return;
-       }
-
-       snprintf(opts, sizeof(opts),
-           "fragment,man=%s/search?sec=%%S&expr=Nm~^%%N$",
-           scriptname);
+       memset(&conf, 0, sizeof(conf));
+       conf.fragment = 1;
+       usepath = strcmp(req->q.manpath, req->p[0]);
+       mandoc_asprintf(&conf.man, "/%s%s%%N.%%S",
+           usepath ? req->q.manpath : "", usepath ? "/" : "");

 
 

-       mparse_result(mp, &mdoc, &man, NULL);
-       if (NULL == man && NULL == mdoc) {
-               fprintf(stderr, "fatal mandoc error: %s/%s\n",
-                   req->q.manpath, file);
-               resp_error_internal();
+       mparse_result(mp, &man, NULL);
+       if (man == NULL) {
+               warnx("fatal mandoc error: %s/%s", req->q.manpath, file);
+               pg_error_internal();

                mparse_free(mp);
                mparse_free(mp);

+               mchars_free();

                return;
        }
 
                return;
        }
 

-       resp_begin_html(200, NULL);
-       resp_searchform(req);
-
-       vp = html_alloc(opts);
+       vp = html_alloc(&conf);

 
 

-       if (NULL != mdoc)
-               html_mdoc(vp, mdoc);
-       else
+       if (man->macroset == MACROSET_MDOC) {
+               mdoc_validate(man);
+               html_mdoc(vp, man);
+       } else {
+               man_validate(man);

                html_man(vp, man);
                html_man(vp, man);

-
-       puts("</BODY>\n"
-            "</HTML>");
+       }

 
        html_free(vp);
        mparse_free(mp);
 
        html_free(vp);
        mparse_free(mp);

+       mchars_free();
+       free(conf.man);
+}
+
+static void
+resp_show(const struct req *req, const char *file)
+{
+
+       if ('.' == file[0] && '/' == file[1])
+               file += 2;
+
+       if ('c' == *file)
+               resp_catman(req, file);
+       else
+               resp_format(req, file);

 }
 
 static void
 }
 
 static void

-pg_show(const struct req *req, char *path)
+pg_show(struct req *req, const char *fullpath)

 {
 {

-       char            *sub;
+       char            *manpath;
+       const char      *file;

 
 

-       if (NULL == path || NULL == (sub = strchr(path, '/'))) {
-               resp_error_badrequest(
+       if ((file = strchr(fullpath, '/')) == NULL) {
+               pg_error_badrequest(

                    "You did not specify a page to show.");
                return;
                    "You did not specify a page to show.");
                return;

-       } 
-       *sub++ = '\0';
+       }
+       manpath = mandoc_strndup(fullpath, file - fullpath);
+       file++;
+
+       if ( ! validate_manpath(req, manpath)) {
+               pg_error_badrequest(
+                   "You specified an invalid manpath.");
+               free(manpath);
+               return;
+       }

 
        /*
         * Begin by chdir()ing into the manpath.
 
        /*
         * Begin by chdir()ing into the manpath.


@@ -740,28 +875,36 @@ pg_show(const struct req *req, char *path)
         * relative to the manpath root.
         */
 
         * relative to the manpath root.
         */
 

-       if (-1 == chdir(path)) {
-               resp_error_badrequest(
-                   "You specified an invalid manpath.");
+       if (chdir(manpath) == -1) {
+               warn("chdir %s", manpath);
+               pg_error_internal();
+               free(manpath);

                return;
        }
                return;
        }

+       free(manpath);

 
 

-       if ('c' == *sub)
-               catman(req, sub);
-       else
-               format(req, sub);
+       if ( ! validate_filename(file)) {
+               pg_error_badrequest(
+                   "You specified an invalid manual file.");
+               return;
+       }
+
+       resp_begin_html(200, NULL);
+       resp_searchform(req, FOCUS_NONE);
+       resp_show(req, file);
+       resp_end_html();

 }
 
 static void
 }
 
 static void

-pg_search(const struct req *req, char *path)
+pg_search(const struct req *req)

 {
        struct mansearch          search;
        struct manpaths           paths;
        struct manpage           *res;
 {
        struct mansearch          search;
        struct manpaths           paths;
        struct manpage           *res;

-       char                    **cp;
-       const char               *ep, *start;
+       char                    **argv;
+       char                     *query, *rp, *wp;

        size_t                    ressz;
        size_t                    ressz;

-       int                       i, sz;
+       int                       argc;

 
        /*
         * Begin by chdir()ing into the root of the manpath.
 
        /*
         * Begin by chdir()ing into the root of the manpath.


@@ -769,62 +912,62 @@ pg_search(const struct req *req, char *path)
         * relative to the manpath root.
         */
 
         * relative to the manpath root.
         */
 

-       if (-1 == (chdir(req->q.manpath))) {
-               resp_error_badrequest(
-                   "You specified an invalid manpath.");
+       if (chdir(req->q.manpath) == -1) {
+               warn("chdir %s", req->q.manpath);
+               pg_error_internal();

                return;
        }
 
        search.arch = req->q.arch;
        search.sec = req->q.sec;
                return;
        }
 
        search.arch = req->q.arch;
        search.sec = req->q.sec;

-       search.deftype = TYPE_Nm | TYPE_Nd;
-       search.flags = 0;
+       search.outkey = "Nd";
+       search.argmode = req->q.equal ? ARG_NAME : ARG_EXPR;
+       search.firstmatch = 1;

 
        paths.sz = 1;
        paths.paths = mandoc_malloc(sizeof(char *));
        paths.paths[0] = mandoc_strdup(".");
 
        /*
 
        paths.sz = 1;
        paths.paths = mandoc_malloc(sizeof(char *));
        paths.paths[0] = mandoc_strdup(".");
 
        /*

-        * Poor man's tokenisation: just break apart by spaces.
-        * Yes, this is half-ass.  But it works for now.
+        * Break apart at spaces with backslash-escaping.

         */
 
         */
 

-       ep = req->q.expr;
-       while (ep && isspace((unsigned char)*ep))
-               ep++;
+       argc = 0;
+       argv = NULL;
+       rp = query = mandoc_strdup(req->q.query);
+       for (;;) {
+               while (isspace((unsigned char)*rp))
+                       rp++;
+               if (*rp == '\0')
+                       break;
+               argv = mandoc_reallocarray(argv, argc + 1, sizeof(char *));
+               argv[argc++] = wp = rp;
+               for (;;) {
+                       if (isspace((unsigned char)*rp)) {
+                               *wp = '\0';
+                               rp++;
+                               break;
+                       }
+                       if (rp[0] == '\\' && rp[1] != '\0')
+                               rp++;
+                       if (wp != rp)
+                               *wp = *rp;
+                       if (*rp == '\0')
+                               break;
+                       wp++;
+                       rp++;
+               }
+       }

 
 

-       sz = 0;
-       cp = NULL;
-       while (ep && '\0' != *ep) {
-               cp = mandoc_reallocarray(cp, sz + 1, sizeof(char *));
-               start = ep;
-               while ('\0' != *ep && ! isspace((unsigned char)*ep))
-                       ep++;
-               cp[sz] = mandoc_malloc((ep - start) + 1);
-               memcpy(cp[sz], start, ep - start);
-               cp[sz++][ep - start] = '\0';
-               while (isspace((unsigned char)*ep))
-                       ep++;
-       }
-
-       if (0 == mansearch(&search, &paths, sz, cp, "Nd", &res, &ressz))
-               resp_noresult(req, "You entered an invalid query.");
+       if (0 == mansearch(&search, &paths, argc, argv, &res, &ressz))
+               pg_noresult(req, "You entered an invalid query.");

        else if (0 == ressz)
        else if (0 == ressz)

-               resp_noresult(req, "No results found.");
+               pg_noresult(req, "No results found.");

        else
        else

-               resp_search(req, res, ressz);
-
-       for (i = 0; i < sz; i++)
-               free(cp[i]);
-       free(cp);
-
-       for (i = 0; i < (int)ressz; i++) {
-               free(res[i].file);
-               free(res[i].names);
-               free(res[i].output);
-       }
-       free(res);
+               pg_searchres(req, res, ressz);

 
 

+       free(query);
+       mansearch_free(res, ressz);

        free(paths.paths[0]);
        free(paths.paths);
 }
        free(paths.paths[0]);
        free(paths.paths);
 }


@@ -832,124 +975,212 @@ pg_search(const struct req *req, char *path)
 int
 main(void)
 {
 int
 main(void)
 {

-       int              i;

        struct req       req;
        struct req       req;

-       char            *querystring, *path, *subpath;
-
-       /* Scan our run-time environment. */
-
-       if (NULL == (mandir = getenv("MAN_DIR")))
-               mandir = "/man";
-
-       if (NULL == (scriptname = getenv("SCRIPT_NAME")))
-               scriptname = "";
+       struct itimerval itimer;
+       const char      *path;
+       const char      *querystring;
+       int              i;

 
 

-       if (NULL == (cssdir = getenv("CSS_DIR")))
-               cssdir = "";
+       /* Poor man's ReDoS mitigation. */

 
 

-       if (NULL == (httphost = getenv("HTTP_HOST")))
-               httphost = "localhost";
+       itimer.it_value.tv_sec = 2;
+       itimer.it_value.tv_usec = 0;
+       itimer.it_interval.tv_sec = 2;
+       itimer.it_interval.tv_usec = 0;
+       if (setitimer(ITIMER_VIRTUAL, &itimer, NULL) == -1) {
+               warn("setitimer");
+               pg_error_internal();
+               return EXIT_FAILURE;
+       }

 
        /*
 
        /*

-        * First we change directory into the mandir so that
+        * First we change directory into the MAN_DIR so that

         * subsequent scanning for manpath directories is rooted
         * relative to the same position.
         */
 
         * subsequent scanning for manpath directories is rooted
         * relative to the same position.
         */
 

-       if (-1 == chdir(mandir)) {
-               fprintf(stderr, "MAN_DIR: %s: %s\n",
-                   mandir, strerror(errno));
-               resp_error_internal();
-               return(EXIT_FAILURE);
-       } 
+       if (chdir(MAN_DIR) == -1) {
+               warn("MAN_DIR: %s", MAN_DIR);
+               pg_error_internal();
+               return EXIT_FAILURE;
+       }

 
        memset(&req, 0, sizeof(struct req));
 
        memset(&req, 0, sizeof(struct req));

-       pathgen(&req);
-
-       /* Next parse out the query string. */
-
-       if (NULL != (querystring = getenv("QUERY_STRING")))
-               http_parse(&req, querystring);
-
-       /*
-        * Now juggle paths to extract information.
-        * We want to extract our filetype (the file suffix), the
-        * initial path component, then the trailing component(s).
-        * Start with leading subpath component. 
-        */
-
-       subpath = path = NULL;
-       req.page = PAGE__MAX;
+       req.q.equal = 1;
+       parse_manpath_conf(&req);

 
 

-       if (NULL == (path = getenv("PATH_INFO")) || '\0' == *path)
-               req.page = PAGE_INDEX;
+       /* Parse the path info and the query string. */

 
 

-       if (NULL != path && '/' == *path && '\0' == *++path)
-               req.page = PAGE_INDEX;
+       if ((path = getenv("PATH_INFO")) == NULL)
+               path = "";
+       else if (*path == '/')
+               path++;

 
 

-       /* Resolve subpath component. */
+       if (*path != '\0') {
+               parse_path_info(&req, path);
+               if (req.q.manpath == NULL || access(path, F_OK) == -1)
+                       path = "";
+       } else if ((querystring = getenv("QUERY_STRING")) != NULL)
+               parse_query_string(&req, querystring);

 
 

-       if (NULL != path && NULL != (subpath = strchr(path, '/')))
-               *subpath++ = '\0';
+       /* Validate parsed data and add defaults. */

 
 

-       /* Map path into one we recognise. */
+       if (req.q.manpath == NULL)
+               req.q.manpath = mandoc_strdup(req.p[0]);
+       else if ( ! validate_manpath(&req, req.q.manpath)) {
+               pg_error_badrequest(
+                   "You specified an invalid manpath.");
+               return EXIT_FAILURE;
+       }

 
 

-       if (NULL != path && '\0' != *path)
-               for (i = 0; i < (int)PAGE__MAX; i++) 
-                       if (0 == strcmp(pages[i], path)) {
-                               req.page = (enum page)i;
-                               break;
-                       }
+       if ( ! (NULL == req.q.arch || validate_urifrag(req.q.arch))) {
+               pg_error_badrequest(
+                   "You specified an invalid architecture.");
+               return EXIT_FAILURE;
+       }

 
 

-       /* Route pages. */
+       /* Dispatch to the three different pages. */

 
 

-       switch (req.page) {
-       case (PAGE_INDEX):
-               pg_index(&req, subpath);
-               break;
-       case (PAGE_SEARCH):
-               pg_search(&req, subpath);
-               break;
-       case (PAGE_SHOW):
-               pg_show(&req, subpath);
-               break;
-       default:
-               resp_error_notfound(path);
-               break;
-       }
+       if ('\0' != *path)
+               pg_show(&req, path);
+       else if (NULL != req.q.query)
+               pg_search(&req);
+       else
+               pg_index(&req);

 
 

+       free(req.q.manpath);
+       free(req.q.arch);
+       free(req.q.sec);
+       free(req.q.query);

        for (i = 0; i < (int)req.psz; i++)
                free(req.p[i]);
        free(req.p);
        for (i = 0; i < (int)req.psz; i++)
                free(req.p[i]);
        free(req.p);

-       return(EXIT_SUCCESS);
+       return EXIT_SUCCESS;

 }
 
 }
 

-static int
-cmp(const void *p1, const void *p2)
+/*
+ * If PATH_INFO is not a file name, translate it to a query.
+ */
+static void
+parse_path_info(struct req *req, const char *path)

 {
 {

+       char    *dir[4];
+       int      i;
+
+       req->isquery = 0;
+       req->q.equal = 1;
+       req->q.manpath = mandoc_strdup(path);
+       req->q.arch = NULL;
+
+       /* Mandatory manual page name. */
+       if ((req->q.query = strrchr(req->q.manpath, '/')) == NULL) {
+               req->q.query = req->q.manpath;
+               req->q.manpath = NULL;
+       } else
+               *req->q.query++ = '\0';
+
+       /* Optional trailing section. */
+       if ((req->q.sec = strrchr(req->q.query, '.')) != NULL) {
+               if(isdigit((unsigned char)req->q.sec[1])) {
+                       *req->q.sec++ = '\0';
+                       req->q.sec = mandoc_strdup(req->q.sec);
+               } else
+                       req->q.sec = NULL;
+       }
+
+       /* Handle the case of name[.section] only. */
+       if (req->q.manpath == NULL)
+               return;
+       req->q.query = mandoc_strdup(req->q.query);
+
+       /* Split directory components. */
+       dir[i = 0] = req->q.manpath;
+       while ((dir[i + 1] = strchr(dir[i], '/')) != NULL) {
+               if (++i == 3) {
+                       pg_error_badrequest(
+                           "You specified too many directory components.");
+                       exit(EXIT_FAILURE);
+               }
+               *dir[i]++ = '\0';
+       }
+
+       /* Optional manpath. */
+       if ((i = validate_manpath(req, req->q.manpath)) == 0)
+               req->q.manpath = NULL;
+       else if (dir[1] == NULL)
+               return;
+
+       /* Optional section. */
+       if (strncmp(dir[i], "man", 3) == 0) {
+               free(req->q.sec);
+               req->q.sec = mandoc_strdup(dir[i++] + 3);
+       }
+       if (dir[i] == NULL) {
+               if (req->q.manpath == NULL)
+                       free(dir[0]);
+               return;
+       }
+       if (dir[i + 1] != NULL) {
+               pg_error_badrequest(
+                   "You specified an invalid directory component.");
+               exit(EXIT_FAILURE);
+       }

 
 

-       return(strcasecmp(((const struct manpage *)p1)->names,
-           ((const struct manpage *)p2)->names));
+       /* Optional architecture. */
+       if (i) {
+               req->q.arch = mandoc_strdup(dir[i]);
+               if (req->q.manpath == NULL)
+                       free(dir[0]);
+       } else
+               req->q.arch = dir[0];

 }
 
 /*
  * Scan for indexable paths.
  */
 static void
 }
 
 /*
  * Scan for indexable paths.
  */
 static void

-pathgen(struct req *req)
+parse_manpath_conf(struct req *req)

 {
        FILE    *fp;
        char    *dp;
        size_t   dpsz;
 {
        FILE    *fp;
        char    *dp;
        size_t   dpsz;

+       ssize_t  len;

 
 

-       if (NULL == (fp = fopen("manpath.conf", "r")))
-               return;
+       if ((fp = fopen("manpath.conf", "r")) == NULL) {
+               warn("%s/manpath.conf", MAN_DIR);
+               pg_error_internal();
+               exit(EXIT_FAILURE);
+       }

 
 

-       while (NULL != (dp = fgetln(fp, &dpsz))) {
-               if ('\n' == dp[dpsz - 1])
-                       dpsz--;
+       dp = NULL;
+       dpsz = 0;
+
+       while ((len = getline(&dp, &dpsz, fp)) != -1) {
+               if (dp[len - 1] == '\n')
+                       dp[--len] = '\0';

                req->p = mandoc_realloc(req->p,
                    (req->psz + 1) * sizeof(char *));
                req->p = mandoc_realloc(req->p,
                    (req->psz + 1) * sizeof(char *));

-               req->p[req->psz++] = mandoc_strndup(dp, dpsz);
+               if ( ! validate_urifrag(dp)) {
+                       warnx("%s/manpath.conf contains "
+                           "unsafe path \"%s\"", MAN_DIR, dp);
+                       pg_error_internal();
+                       exit(EXIT_FAILURE);
+               }
+               if (strchr(dp, '/') != NULL) {
+                       warnx("%s/manpath.conf contains "
+                           "path with slash \"%s\"", MAN_DIR, dp);
+                       pg_error_internal();
+                       exit(EXIT_FAILURE);
+               }
+               req->p[req->psz++] = dp;
+               dp = NULL;
+               dpsz = 0;
+       }
+       free(dp);
+
+       if (req->p == NULL) {
+               warnx("%s/manpath.conf is empty", MAN_DIR);
+               pg_error_internal();
+               exit(EXIT_FAILURE);

        }
 }
        }
 }