We already supported (outer) user-defined strings containing references

[mandoc.git] / roff.c

diff --git a/roff.c b/roff.c
index ca8ab7bb6d8e04ea137d20651ba32bfc95a6d5b5..2adafc18585b5cbcf623690d47cadde85869d853 100644 (file)
--- a/roff.c
+++ b/roff.c
@@ -1,4 +1,4 @@
-/*     $Id: roff.c,v 1.191 2014/01/06 23:46:07 schwarze Exp $ */
+/*     $Id: roff.c,v 1.205 2014/04/07 21:00:08 schwarze Exp $ */

 /*
  * Copyright (c) 2010, 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2010-2014 Ingo Schwarze <schwarze@openbsd.org>
 /*
  * Copyright (c) 2010, 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2010-2014 Ingo Schwarze <schwarze@openbsd.org>


@@ -26,6 +26,7 @@
 #include <string.h>
 
 #include "mandoc.h"
 #include <string.h>
 
 #include "mandoc.h"

+#include "mandoc_aux.h"

 #include "libroff.h"
 #include "libmandoc.h"
 
 #include "libroff.h"
 #include "libmandoc.h"
 


@@ -40,7 +41,9 @@ enum  rofft {
        ROFF_am,
        ROFF_ami,
        ROFF_am1,
        ROFF_am,
        ROFF_ami,
        ROFF_am1,

+       ROFF_as,

        ROFF_cc,
        ROFF_cc,

+       ROFF_ce,

        ROFF_de,
        ROFF_dei,
        ROFF_de1,
        ROFF_de,
        ROFF_dei,
        ROFF_de1,


@@ -59,6 +62,7 @@ enum  rofft {
        ROFF_ns,
        ROFF_ps,
        ROFF_rm,
        ROFF_ns,
        ROFF_ps,
        ROFF_rm,

+       ROFF_rr,

        ROFF_so,
        ROFF_ta,
        ROFF_tr,
        ROFF_so,
        ROFF_ta,
        ROFF_tr,


@@ -70,16 +74,10 @@ enum        rofft {
        ROFF_EQ,
        ROFF_EN,
        ROFF_cblock,
        ROFF_EQ,
        ROFF_EN,
        ROFF_cblock,

-       ROFF_ccond,

        ROFF_USERDEF,
        ROFF_MAX
 };
 
        ROFF_USERDEF,
        ROFF_MAX
 };
 

-enum   roffrule {
-       ROFFRULE_DENY,
-       ROFFRULE_ALLOW
-};
-

 /*
  * An incredibly-simple string buffer.
  */
 /*
  * An incredibly-simple string buffer.
  */


@@ -107,11 +105,10 @@ struct    roffreg {
 };
 
 struct roff {
 };
 
 struct roff {

-       enum mparset     parsetype; /* requested parse type */

        struct mparse   *parse; /* parse point */
        struct mparse   *parse; /* parse point */

-       int              quick; /* skip standard macro deletion */
+       int              options; /* parse options */

        struct roffnode *last; /* leaf of stack */
        struct roffnode *last; /* leaf of stack */

-       enum roffrule    rstack[RSTACK_MAX]; /* stack of !`ie' rules */
+       int              rstack[RSTACK_MAX]; /* stack of !`ie' rules */

        char             control; /* control character */
        int              rstackpos; /* position in rstack */
        struct roffreg  *regtab; /* number registers */
        char             control; /* control character */
        int              rstackpos; /* position in rstack */
        struct roffreg  *regtab; /* number registers */


@@ -135,7 +132,7 @@ struct      roffnode {
        char            *name; /* node name, e.g. macro name */
        char            *end; /* end-rules: custom token */
        int              endspan; /* end-rules: next-line or infty */
        char            *name; /* node name, e.g. macro name */
        char            *end; /* end-rules: custom token */
        int              endspan; /* end-rules: next-line or infty */

-       enum roffrule    rule; /* current evaluation rule */
+       int              rule; /* current evaluation rule */

 };
 
 #define        ROFF_ARGS        struct roff *r, /* parse ctx */ \
 };
 
 #define        ROFF_ARGS        struct roff *r, /* parse ctx */ \


@@ -178,12 +175,15 @@ static    enum rofferr     roff_block_text(ROFF_ARGS);
 static enum rofferr     roff_block_sub(ROFF_ARGS);
 static enum rofferr     roff_cblock(ROFF_ARGS);
 static enum rofferr     roff_cc(ROFF_ARGS);
 static enum rofferr     roff_block_sub(ROFF_ARGS);
 static enum rofferr     roff_cblock(ROFF_ARGS);
 static enum rofferr     roff_cc(ROFF_ARGS);

-static enum rofferr     roff_ccond(ROFF_ARGS);
+static void             roff_ccond(struct roff *, int, int);

 static enum rofferr     roff_cond(ROFF_ARGS);
 static enum rofferr     roff_cond_text(ROFF_ARGS);
 static enum rofferr     roff_cond_sub(ROFF_ARGS);
 static enum rofferr     roff_ds(ROFF_ARGS);
 static enum rofferr     roff_cond(ROFF_ARGS);
 static enum rofferr     roff_cond_text(ROFF_ARGS);
 static enum rofferr     roff_cond_sub(ROFF_ARGS);
 static enum rofferr     roff_ds(ROFF_ARGS);

-static enum roffrule    roff_evalcond(const char *, int *);
+static int              roff_evalcond(const char *, int *);
+static int              roff_evalnum(const char *, int *, int *, int);
+static int              roff_evalpar(const char *, int *, int *);
+static int              roff_evalstrcond(const char *, int *);

 static void             roff_free1(struct roff *);
 static void             roff_freereg(struct roffreg *);
 static void             roff_freestr(struct roffkv *);
 static void             roff_free1(struct roff *);
 static void             roff_freereg(struct roffreg *);
 static void             roff_freestr(struct roffkv *);


@@ -192,6 +192,7 @@ static      int              roff_getnum(const char *, int *, int *);
 static int              roff_getop(const char *, int *, char *);
 static int              roff_getregn(const struct roff *,
                                const char *, size_t);
 static int              roff_getop(const char *, int *, char *);
 static int              roff_getregn(const struct roff *,
                                const char *, size_t);

+static int              roff_getregro(const char *name);

 static const char      *roff_getstrn(const struct roff *, 
                                const char *, size_t);
 static enum rofferr     roff_it(ROFF_ARGS);
 static const char      *roff_getstrn(const struct roff *, 
                                const char *, size_t);
 static enum rofferr     roff_it(ROFF_ARGS);


@@ -204,6 +205,7 @@ static      enum rofferr     roff_parsetext(char **, size_t *, int, int *);
 static enum rofferr     roff_res(struct roff *, 
                                char **, size_t *, int, int);
 static enum rofferr     roff_rm(ROFF_ARGS);
 static enum rofferr     roff_res(struct roff *, 
                                char **, size_t *, int, int);
 static enum rofferr     roff_rm(ROFF_ARGS);

+static enum rofferr     roff_rr(ROFF_ARGS);

 static void             roff_setstr(struct roff *,
                                const char *, const char *, int);
 static void             roff_setstrn(struct roffkv **, const char *, 
 static void             roff_setstr(struct roff *,
                                const char *, const char *, int);
 static void             roff_setstrn(struct roffkv **, const char *, 


@@ -232,7 +234,9 @@ static      struct roffmac   roffs[ROFF_MAX] = {
        { "am", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "ami", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "am1", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "am", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "ami", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "am1", roff_block, roff_block_text, roff_block_sub, 0, NULL },

+       { "as", roff_ds, NULL, NULL, 0, NULL },

        { "cc", roff_cc, NULL, NULL, 0, NULL },
        { "cc", roff_cc, NULL, NULL, 0, NULL },

+       { "ce", roff_line_ignore, NULL, NULL, 0, NULL },

        { "de", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "dei", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "de1", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "de", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "dei", roff_block, roff_block_text, roff_block_sub, 0, NULL },
        { "de1", roff_block, roff_block_text, roff_block_sub, 0, NULL },


@@ -251,6 +255,7 @@ static      struct roffmac   roffs[ROFF_MAX] = {
        { "ns", roff_line_ignore, NULL, NULL, 0, NULL },
        { "ps", roff_line_ignore, NULL, NULL, 0, NULL },
        { "rm", roff_rm, NULL, NULL, 0, NULL },
        { "ns", roff_line_ignore, NULL, NULL, 0, NULL },
        { "ps", roff_line_ignore, NULL, NULL, 0, NULL },
        { "rm", roff_rm, NULL, NULL, 0, NULL },

+       { "rr", roff_rr, NULL, NULL, 0, NULL },

        { "so", roff_so, NULL, NULL, 0, NULL },
        { "ta", roff_line_ignore, NULL, NULL, 0, NULL },
        { "tr", roff_tr, NULL, NULL, 0, NULL },
        { "so", roff_so, NULL, NULL, 0, NULL },
        { "ta", roff_line_ignore, NULL, NULL, 0, NULL },
        { "tr", roff_tr, NULL, NULL, 0, NULL },


@@ -262,38 +267,39 @@ static    struct roffmac   roffs[ROFF_MAX] = {
        { "EQ", roff_EQ, NULL, NULL, 0, NULL },
        { "EN", roff_EN, NULL, NULL, 0, NULL },
        { ".", roff_cblock, NULL, NULL, 0, NULL },
        { "EQ", roff_EQ, NULL, NULL, 0, NULL },
        { "EN", roff_EN, NULL, NULL, 0, NULL },
        { ".", roff_cblock, NULL, NULL, 0, NULL },

-       { "\\}", roff_ccond, NULL, NULL, 0, NULL },

        { NULL, roff_userdef, NULL, NULL, 0, NULL },
 };
 
        { NULL, roff_userdef, NULL, NULL, 0, NULL },
 };
 

+/* not currently implemented: Ds em Eq LP Me PP pp Or Rd Sf SH */

 const  char *const __mdoc_reserved[] = {
        "Ac", "Ad", "An", "Ao", "Ap", "Aq", "Ar", "At",
        "Bc", "Bd", "Bf", "Bk", "Bl", "Bo", "Bq",
        "Brc", "Bro", "Brq", "Bsx", "Bt", "Bx",
        "Cd", "Cm", "Db", "Dc", "Dd", "Dl", "Do", "Dq",
 const  char *const __mdoc_reserved[] = {
        "Ac", "Ad", "An", "Ao", "Ap", "Aq", "Ar", "At",
        "Bc", "Bd", "Bf", "Bk", "Bl", "Bo", "Bq",
        "Brc", "Bro", "Brq", "Bsx", "Bt", "Bx",
        "Cd", "Cm", "Db", "Dc", "Dd", "Dl", "Do", "Dq",

-       "Ds", "Dt", "Dv", "Dx", "D1",
-       "Ec", "Ed", "Ef", "Ek", "El", "Em", "em",
-       "En", "Eo", "Eq", "Er", "Es", "Ev", "Ex",
+       "Dt", "Dv", "Dx", "D1",
+       "Ec", "Ed", "Ef", "Ek", "El", "Em",
+       "En", "Eo", "Er", "Es", "Ev", "Ex",

        "Fa", "Fc", "Fd", "Fl", "Fn", "Fo", "Fr", "Ft", "Fx",
        "Fa", "Fc", "Fd", "Fl", "Fn", "Fo", "Fr", "Ft", "Fx",

-       "Hf", "Ic", "In", "It", "Lb", "Li", "Lk", "Lp", "LP",
-       "Me", "Ms", "Mt", "Nd", "Nm", "No", "Ns", "Nx",
+       "Hf", "Ic", "In", "It", "Lb", "Li", "Lk", "Lp",
+       "Ms", "Mt", "Nd", "Nm", "No", "Ns", "Nx",

        "Oc", "Oo", "Op", "Os", "Ot", "Ox",
        "Oc", "Oo", "Op", "Os", "Ot", "Ox",

-       "Pa", "Pc", "Pf", "Po", "Pp", "PP", "pp", "Pq",
-       "Qc", "Ql", "Qo", "Qq", "Or", "Rd", "Re", "Rs", "Rv",
-       "Sc", "Sf", "Sh", "SH", "Sm", "So", "Sq",
+       "Pa", "Pc", "Pf", "Po", "Pp", "Pq",
+       "Qc", "Ql", "Qo", "Qq", "Re", "Rs", "Rv",
+       "Sc", "Sh", "Sm", "So", "Sq",

        "Ss", "St", "Sx", "Sy",
        "Ta", "Tn", "Ud", "Ux", "Va", "Vt", "Xc", "Xo", "Xr",
        "Ss", "St", "Sx", "Sy",
        "Ta", "Tn", "Ud", "Ux", "Va", "Vt", "Xc", "Xo", "Xr",

-       "%A", "%B", "%D", "%I", "%J", "%N", "%O",
+       "%A", "%B", "%C", "%D", "%I", "%J", "%N", "%O",

        "%P", "%Q", "%R", "%T", "%U", "%V",
        NULL
 };
 
        "%P", "%Q", "%R", "%T", "%U", "%V",
        NULL
 };
 

+/* not currently implemented: BT DE DS ME MT PT SY TQ YS */

 const  char *const __man_reserved[] = {
 const  char *const __man_reserved[] = {

-       "AT", "B", "BI", "BR", "BT", "DE", "DS", "DT",
-       "EE", "EN", "EQ", "EX", "HF", "HP", "I", "IB", "IP", "IR",
-       "LP", "ME", "MT", "OP", "P", "PD", "PP", "PT",
-       "R", "RB", "RE", "RI", "RS", "SB", "SH", "SM", "SS", "SY",
-       "TE", "TH", "TP", "TQ", "TS", "T&", "UC", "UE", "UR", "YS",
+       "AT", "B", "BI", "BR", "DT",
+       "EE", "EN", "EQ", "EX", "HP", "I", "IB", "IP", "IR",
+       "LP", "OP", "P", "PD", "PP",
+       "R", "RB", "RE", "RI", "RS", "SB", "SH", "SM", "SS",
+       "TE", "TH", "TP", "TS", "T&", "UC", "UE", "UR",

        NULL
 };
 
        NULL
 };
 


@@ -398,7 +404,7 @@ roffnode_push(struct roff *r, enum rofft tok, const char *name,
        p->parent = r->last;
        p->line = line;
        p->col = col;
        p->parent = r->last;
        p->line = line;
        p->col = col;

-       p->rule = p->parent ? p->parent->rule : ROFFRULE_DENY;
+       p->rule = p->parent ? p->parent->rule : 0;

 
        r->last = p;
 }
 
        r->last = p;
 }


@@ -464,14 +470,13 @@ roff_free(struct roff *r)
 
 
 struct roff *
 
 
 struct roff *

-roff_alloc(enum mparset type, struct mparse *parse, int quick)
+roff_alloc(struct mparse *parse, int options)

 {
        struct roff     *r;
 
        r = mandoc_calloc(1, sizeof(struct roff));
 {
        struct roff     *r;
 
        r = mandoc_calloc(1, sizeof(struct roff));

-       r->parsetype = type;

        r->parse = parse;
        r->parse = parse;

-       r->quick = quick;
+       r->options = options;

        r->rstackpos = -1;
        
        roffhash_init();
        r->rstackpos = -1;
        
        roffhash_init();


@@ -488,32 +493,44 @@ static enum rofferr
 roff_res(struct roff *r, char **bufp, size_t *szp, int ln, int pos)
 {
        char             ubuf[12]; /* buffer to print the number */
 roff_res(struct roff *r, char **bufp, size_t *szp, int ln, int pos)
 {
        char             ubuf[12]; /* buffer to print the number */

+       const char      *start; /* start of the string to process */

        const char      *stesc; /* start of an escape sequence ('\\') */
        const char      *stnam; /* start of the name, after "[(*" */
        const char      *cp;    /* end of the name, e.g. before ']' */
        const char      *res;   /* the string to be substituted */
        char            *nbuf;  /* new buffer to copy bufp to */
        const char      *stesc; /* start of an escape sequence ('\\') */
        const char      *stnam; /* start of the name, after "[(*" */
        const char      *cp;    /* end of the name, e.g. before ']' */
        const char      *res;   /* the string to be substituted */
        char            *nbuf;  /* new buffer to copy bufp to */

-       size_t           nsz;   /* size of the new buffer */

        size_t           maxl;  /* expected length of the escape name */
        size_t           naml;  /* actual length of the escape name */
        size_t           maxl;  /* expected length of the escape name */
        size_t           naml;  /* actual length of the escape name */

+       size_t           ressz; /* size of the replacement string */

        int              expand_count;  /* to avoid infinite loops */
 
        expand_count = 0;
        int              expand_count;  /* to avoid infinite loops */
 
        expand_count = 0;

+       start = *bufp + pos;
+       stesc = strchr(start, '\0') - 1;
+       while (stesc-- > start) {

 
 

-again:
-       cp = *bufp + pos;
-       while (NULL != (cp = strchr(cp, '\\'))) {
-               stesc = cp++;
+               /* Search backwards for the next backslash. */
+
+               if ('\\' != *stesc)
+                       continue;
+
+               /* If it is escaped, skip it. */
+
+               for (cp = stesc - 1; cp >= start; cp--)
+                       if ('\\' != *cp)
+                               break;
+
+               if (0 == (stesc - cp) % 2) {
+                       stesc = cp;
+                       continue;
+               }

 
                /*
 
                /*

-                * The second character must be an asterisk or an n.
-                * If it isn't, skip it anyway:  It is escaped,
-                * so it can't start another escape sequence.
+                * Everything except user-defined strings and number
+                * registers is only checked, not expanded.

                 */
 
                 */
 

-               if ('\0' == *cp)
-                       return(ROFF_CONT);
-
+               cp = stesc + 1;

                switch (*cp) {
                case ('*'):
                        res = NULL;
                switch (*cp) {
                case ('*'):
                        res = NULL;


@@ -522,15 +539,17 @@ again:
                        res = ubuf;
                        break;
                default:
                        res = ubuf;
                        break;
                default:

-                       if (ESCAPE_ERROR != mandoc_escape(&cp, NULL, NULL))
-                               continue;
-                       mandoc_msg
-                               (MANDOCERR_BADESCAPE, r->parse, 
-                                ln, (int)(stesc - *bufp), NULL);
-                       return(ROFF_CONT);
+                       if (ESCAPE_ERROR == mandoc_escape(&cp, NULL, NULL))
+                               mandoc_msg(MANDOCERR_BADESCAPE, r->parse,
+                                   ln, (int)(stesc - *bufp), NULL);
+                       continue;

                }
 
                }
 

-               cp++;
+               if (EXPAND_LIMIT < ++expand_count) {
+                       mandoc_msg(MANDOCERR_ROFFLOOP, r->parse,
+                           ln, (int)(stesc - *bufp), NULL);
+                       return(ROFF_IGN);
+               }

 
                /*
                 * The third character decides the length
 
                /*
                 * The third character decides the length


@@ -538,9 +557,9 @@ again:
                 * Save a pointer to the name.
                 */
 
                 * Save a pointer to the name.
                 */
 

-               switch (*cp) {
+               switch (*++cp) {

                case ('\0'):
                case ('\0'):

-                       return(ROFF_CONT);
+                       continue;

                case ('('):
                        cp++;
                        maxl = 2;
                case ('('):
                        cp++;
                        maxl = 2;


@@ -563,7 +582,7 @@ again:
                                        (MANDOCERR_BADESCAPE, 
                                         r->parse, ln, 
                                         (int)(stesc - *bufp), NULL);
                                        (MANDOCERR_BADESCAPE, 
                                         r->parse, ln, 
                                         (int)(stesc - *bufp), NULL);

-                               return(ROFF_CONT);
+                               continue;

                        }
                        if (0 == maxl && ']' == *cp)
                                break;
                        }
                        if (0 == maxl && ']' == *cp)
                                break;


@@ -586,29 +605,23 @@ again:
                                 ln, (int)(stesc - *bufp), NULL);
                        res = "";
                }
                                 ln, (int)(stesc - *bufp), NULL);
                        res = "";
                }

+               ressz = strlen(res);

 
                /* Replace the escape sequence by the string. */
 
 
                /* Replace the escape sequence by the string. */
 

-               pos = stesc - *bufp;
-
-               nsz = *szp + strlen(res) + 1;
-               nbuf = mandoc_malloc(nsz);
+               *szp += ressz + 1;
+               nbuf = mandoc_malloc(*szp);

 
                strlcpy(nbuf, *bufp, (size_t)(stesc - *bufp + 1));
 
                strlcpy(nbuf, *bufp, (size_t)(stesc - *bufp + 1));

-               strlcat(nbuf, res, nsz);
-               strlcat(nbuf, cp + (maxl ? 0 : 1), nsz);
+               strlcat(nbuf, res, *szp);
+               strlcat(nbuf, cp + (maxl ? 0 : 1), *szp);

 
 

-               free(*bufp);
+               /* Prepare for the next replacement. */

 
 

+               start = nbuf + pos;
+               stesc = nbuf + (stesc - *bufp) + ressz;
+               free(*bufp);

                *bufp = nbuf;
                *bufp = nbuf;

-               *szp = nsz;
-
-               if (EXPAND_LIMIT >= ++expand_count)
-                       goto again;
-
-               /* Just leave the string unexpanded. */
-               mandoc_msg(MANDOCERR_ROFFLOOP, r->parse, ln, pos, NULL);
-               return(ROFF_IGN);

        }
        return(ROFF_CONT);
 }
        }
        return(ROFF_CONT);
 }


@@ -656,11 +669,7 @@ roff_parsetext(char **bufp, size_t *szp, int pos, int *offs)
 
        /* Spring the input line trap. */
        if (1 == roffit_lines) {
 
        /* Spring the input line trap. */
        if (1 == roffit_lines) {

-               isz = asprintf(&p, "%s\n.%s", *bufp, roffit_macro);
-               if (-1 == isz) {
-                       perror(NULL);
-                       exit((int)MANDOCLEVEL_SYSERR);
-               }
+               isz = mandoc_asprintf(&p, "%s\n.%s", *bufp, roffit_macro);

                free(*bufp);
                *bufp = p;
                *szp = isz + 1;
                free(*bufp);
                *bufp = p;
                *szp = isz + 1;


@@ -785,14 +794,10 @@ roff_parse(struct roff *r, const char *buf, int *pos)
                        '\t' == buf[*pos] || ' ' == buf[*pos])
                return(ROFF_MAX);
 
                        '\t' == buf[*pos] || ' ' == buf[*pos])
                return(ROFF_MAX);
 

-       /*
-        * We stop the macro parse at an escape, tab, space, or nil.
-        * However, `\}' is also a valid macro, so make sure we don't
-        * clobber it by seeing the `\' as the end of token.
-        */
+       /* We stop the macro parse at an escape, tab, space, or nil. */

 
        mac = buf + *pos;
 
        mac = buf + *pos;

-       maclen = strcspn(mac + 1, " \\\t\0") + 1;
+       maclen = strcspn(mac, " \\\t\0");

 
        t = (r->current_string = roff_getstrn(r, mac, maclen))
            ? ROFF_USERDEF : roffhash_find(mac, maclen);
 
        t = (r->current_string = roff_getstrn(r, mac, maclen))
            ? ROFF_USERDEF : roffhash_find(mac, maclen);


@@ -861,14 +866,13 @@ roffnode_cleanscope(struct roff *r)
 }
 
 
 }
 
 

-/* ARGSUSED */
-static enum rofferr
-roff_ccond(ROFF_ARGS)
+static void
+roff_ccond(struct roff *r, int ln, int ppos)

 {
 
        if (NULL == r->last) {
                mandoc_msg(MANDOCERR_NOSCOPE, r->parse, ln, ppos, NULL);
 {
 
        if (NULL == r->last) {
                mandoc_msg(MANDOCERR_NOSCOPE, r->parse, ln, ppos, NULL);

-               return(ROFF_IGN);
+               return;

        }
 
        switch (r->last->tok) {
        }
 
        switch (r->last->tok) {


@@ -880,20 +884,17 @@ roff_ccond(ROFF_ARGS)
                break;
        default:
                mandoc_msg(MANDOCERR_NOSCOPE, r->parse, ln, ppos, NULL);
                break;
        default:
                mandoc_msg(MANDOCERR_NOSCOPE, r->parse, ln, ppos, NULL);

-               return(ROFF_IGN);
+               return;

        }
 
        if (r->last->endspan > -1) {
                mandoc_msg(MANDOCERR_NOSCOPE, r->parse, ln, ppos, NULL);
        }
 
        if (r->last->endspan > -1) {
                mandoc_msg(MANDOCERR_NOSCOPE, r->parse, ln, ppos, NULL);

-               return(ROFF_IGN);
+               return;

        }
 
        }
 

-       if ((*bufp)[pos])
-               mandoc_msg(MANDOCERR_ARGSLOST, r->parse, ln, pos, NULL);
-

        roffnode_pop(r);
        roffnode_cleanscope(r);
        roffnode_pop(r);
        roffnode_cleanscope(r);

-       return(ROFF_IGN);
+       return;

 }
 
 
 }
 
 


@@ -938,7 +939,7 @@ roff_block(ROFF_ARGS)
        /*
         * At the beginning of a `de' macro, clear the existing string
         * with the same name, if there is one.  New content will be
        /*
         * At the beginning of a `de' macro, clear the existing string
         * with the same name, if there is one.  New content will be

-        * added from roff_block_text() in multiline mode.
+        * appended from roff_block_text() in multiline mode.

         */
 
        if (ROFF_de == tok)
         */
 
        if (ROFF_de == tok)


@@ -1028,7 +1029,7 @@ roff_block_sub(ROFF_ARGS)
         */
        if (ROFF_cblock != t) {
                if (ROFF_de == tok)
         */
        if (ROFF_cblock != t) {
                if (ROFF_de == tok)

-                       roff_setstr(r, r->last->name, *bufp + ppos, 1);
+                       roff_setstr(r, r->last->name, *bufp + ppos, 2);

                return(ROFF_IGN);
        }
 
                return(ROFF_IGN);
        }
 


@@ -1044,7 +1045,7 @@ roff_block_text(ROFF_ARGS)
 {
 
        if (ROFF_de == tok)
 {
 
        if (ROFF_de == tok)

-               roff_setstr(r, r->last->name, *bufp + pos, 1);
+               roff_setstr(r, r->last->name, *bufp + pos, 2);

 
        return(ROFF_IGN);
 }
 
        return(ROFF_IGN);
 }


@@ -1055,8 +1056,8 @@ static enum rofferr
 roff_cond_sub(ROFF_ARGS)
 {
        enum rofft       t;
 roff_cond_sub(ROFF_ARGS)
 {
        enum rofft       t;

-       enum roffrule    rr;

        char            *ep;
        char            *ep;

+       int              rr;

 
        rr = r->last->rule;
        roffnode_cleanscope(r);
 
        rr = r->last->rule;
        roffnode_cleanscope(r);


@@ -1068,37 +1069,31 @@ roff_cond_sub(ROFF_ARGS)
         */
 
        if ((ROFF_MAX != t) &&
         */
 
        if ((ROFF_MAX != t) &&

-           (ROFF_ccond == t || ROFFRULE_ALLOW == rr ||
-            ROFFMAC_STRUCT & roffs[t].flags)) {
+           (rr || ROFFMAC_STRUCT & roffs[t].flags)) {

                assert(roffs[t].proc);
                return((*roffs[t].proc)(r, t, bufp, szp,
                                        ln, ppos, pos, offs));
        }
 
                assert(roffs[t].proc);
                return((*roffs[t].proc)(r, t, bufp, szp,
                                        ln, ppos, pos, offs));
        }
 

-       /* Always check for the closing delimiter `\}'. */
-
-       ep = &(*bufp)[pos];
-       while (NULL != (ep = strchr(ep, '\\'))) {
-               if ('}' != *(++ep))
-                       continue;
+       /*
+        * If `\}' occurs on a macro line without a preceding macro,
+        * drop the line completely.
+        */

 
 

-               /*
-                * If we're at the end of line, then just chop
-                * off the \} and resize the buffer.
-                * If we aren't, then convert it to spaces.
-                */
+       ep = *bufp + pos;
+       if ('\\' == ep[0] && '}' == ep[1])
+               rr = 0;

 
 

-               if ('\0' == *(ep + 1)) {
-                       *--ep = '\0';
-                       *szp -= 2;
-               } else
-                       *(ep - 1) = *ep = ' ';
+       /* Always check for the closing delimiter `\}'. */

 
 

-               roff_ccond(r, ROFF_ccond, bufp, szp, 
-                               ln, pos, pos + 2, offs);
-               break;
+       while (NULL != (ep = strchr(ep, '\\'))) {
+               if ('}' == *(++ep)) {
+                       *ep = '&';
+                       roff_ccond(r, ln, ep - *bufp - 1);
+               }
+               ++ep;

        }
        }

-       return(ROFFRULE_DENY == rr ? ROFF_IGN : ROFF_CONT);
+       return(rr ? ROFF_CONT : ROFF_IGN);

 }
 
 /* ARGSUSED */
 }
 
 /* ARGSUSED */


@@ -1106,23 +1101,28 @@ static enum rofferr
 roff_cond_text(ROFF_ARGS)
 {
        char            *ep;
 roff_cond_text(ROFF_ARGS)
 {
        char            *ep;

-       enum roffrule    rr;
+       int              rr;

 
        rr = r->last->rule;
        roffnode_cleanscope(r);
 
 
        rr = r->last->rule;
        roffnode_cleanscope(r);
 

-       ep = &(*bufp)[pos];
-       for ( ; NULL != (ep = strchr(ep, '\\')); ep++) {
-               ep++;
-               if ('}' != *ep)
-                       continue;
-               *ep = '&';
-               roff_ccond(r, ROFF_ccond, bufp, szp, 
-                               ln, pos, pos + 2, offs);
+       ep = *bufp + pos;
+       while (NULL != (ep = strchr(ep, '\\'))) {
+               if ('}' == *(++ep)) {
+                       *ep = '&';
+                       roff_ccond(r, ln, ep - *bufp - 1);
+               }
+               ++ep;

        }
        }

-       return(ROFFRULE_DENY == rr ? ROFF_IGN : ROFF_CONT);
+       return(rr ? ROFF_CONT : ROFF_IGN);

 }
 
 }
 

+/*
+ * Parse a single signed integer number.  Stop at the first non-digit.
+ * If there is at least one digit, return success and advance the
+ * parse point, else return failure and let the parse point unchanged.
+ * Ignore overflows, treat them just like the C language.
+ */

 static int
 roff_getnum(const char *v, int *pos, int *res)
 {
 static int
 roff_getnum(const char *v, int *pos, int *res)
 {


@@ -1134,7 +1134,7 @@ roff_getnum(const char *v, int *pos, int *res)
                p++;
 
        for (*res = 0; isdigit((unsigned char)v[p]); p++)
                p++;
 
        for (*res = 0; isdigit((unsigned char)v[p]); p++)

-               *res += 10 * *res + v[p] - '0';
+               *res = 10 * *res + v[p] - '0';

        if (p == *pos + n)
                return 0;
 
        if (p == *pos + n)
                return 0;
 


@@ -1145,92 +1145,89 @@ roff_getnum(const char *v, int *pos, int *res)
        return 1;
 }
 
        return 1;
 }
 

+/*
+ * Evaluate a string comparison condition.
+ * The first character is the delimiter.
+ * Succeed if the string up to its second occurrence
+ * matches the string up to its third occurence.
+ * Advance the cursor after the third occurrence
+ * or lacking that, to the end of the line.
+ */

 static int
 static int

-roff_getop(const char *v, int *pos, char *res)
+roff_evalstrcond(const char *v, int *pos)

 {
 {

-       int e;
+       const char      *s1, *s2, *s3;
+       int              match;

 
 

-       *res = v[*pos];
-       e = v[*pos + 1] == '=';
+       match = 0;
+       s1 = v + *pos;          /* initial delimiter */
+       s2 = s1 + 1;            /* for scanning the first string */
+       s3 = strchr(s2, *s1);   /* for scanning the second string */

 
 

-       switch (*res) {
-       case '=':
-               break;
-       case '>':
-               if (e)
-                       *res = 'g';
-               break;
-       case '<':
-               if (e)
-                       *res = 'l';
-               break;
-       default:
-               return(0);
-       }
+       if (NULL == s3)         /* found no middle delimiter */
+               goto out;

 
 

-       *pos += 1 + e;
+       while ('\0' != *++s3) {
+               if (*s2 != *s3) {  /* mismatch */
+                       s3 = strchr(s3, *s1);
+                       break;
+               }
+               if (*s3 == *s1) {  /* found the final delimiter */
+                       match = 1;
+                       break;
+               }
+               s2++;
+       }

 
 

-       return(*res);
+out:
+       if (NULL == s3)
+               s3 = strchr(s2, '\0');
+       else
+               s3++;
+       *pos = s3 - v;
+       return(match);

 }
 
 }
 

-static enum roffrule
+/*
+ * Evaluate an optionally negated single character, numerical,
+ * or string condition.
+ */
+static int

 roff_evalcond(const char *v, int *pos)
 {
 roff_evalcond(const char *v, int *pos)
 {

-       int      not, lh, rh;
-       char     op;
+       int      wanttrue, number;
+
+       if ('!' == v[*pos]) {
+               wanttrue = 0;
+               (*pos)++;
+       } else
+               wanttrue = 1;

 
        switch (v[*pos]) {
        case ('n'):
 
        switch (v[*pos]) {
        case ('n'):

+               /* FALLTHROUGH */
+       case ('o'):

                (*pos)++;
                (*pos)++;

-               return(ROFFRULE_ALLOW);
+               return(wanttrue);
+       case ('c'):
+               /* FALLTHROUGH */
+       case ('d'):
+               /* FALLTHROUGH */

        case ('e'):
                /* FALLTHROUGH */
        case ('e'):
                /* FALLTHROUGH */

-       case ('o'):
+       case ('r'):

                /* FALLTHROUGH */
        case ('t'):
                (*pos)++;
                /* FALLTHROUGH */
        case ('t'):
                (*pos)++;

-               return(ROFFRULE_DENY);
-       case ('!'):
-               (*pos)++;
-               not = 1;
-               break;
+               return(!wanttrue);

        default:
        default:

-               not = 0;

                break;
        }
 
                break;
        }
 

-       if (!roff_getnum(v, pos, &lh))
-               return ROFFRULE_DENY;
-       if (!roff_getop(v, pos, &op)) {
-               if (lh < 0)
-                       lh = 0;
-               goto out;
-       }
-       if (!roff_getnum(v, pos, &rh))
-               return ROFFRULE_DENY;
-       switch (op) {
-       case 'g':
-               lh = lh >= rh;
-               break;
-       case 'l':
-               lh = lh <= rh;
-               break;
-       case '=':
-               lh = lh == rh;
-               break;
-       case '>':
-               lh = lh > rh;
-               break;
-       case '<':
-               lh = lh < rh;
-               break;
-       default:
-               return ROFFRULE_DENY;
-       }
-out:
-       if (not)
-               lh = !lh;
-       return lh ? ROFFRULE_ALLOW : ROFFRULE_DENY;
+       if (roff_evalnum(v, pos, &number, 0))
+               return((number > 0) == wanttrue);
+       else
+               return(roff_evalstrcond(v, pos) == wanttrue);

 }
 
 /* ARGSUSED */
 }
 
 /* ARGSUSED */


@@ -1257,8 +1254,7 @@ roff_cond(ROFF_ARGS)
         */
 
        r->last->rule = ROFF_el == tok ?
         */
 
        r->last->rule = ROFF_el == tok ?

-               (r->rstackpos < 0 ? 
-                ROFFRULE_DENY : r->rstack[r->rstackpos--]) :
+               (r->rstackpos < 0 ? 0 : r->rstack[r->rstackpos--]) :

                roff_evalcond(*bufp, &pos);
 
        /*
                roff_evalcond(*bufp, &pos);
 
        /*


@@ -1272,15 +1268,13 @@ roff_cond(ROFF_ARGS)
                                r->parse, ln, ppos, NULL);
                        return(ROFF_ERR);
                }
                                r->parse, ln, ppos, NULL);
                        return(ROFF_ERR);
                }

-               r->rstack[++r->rstackpos] = 
-                       ROFFRULE_DENY == r->last->rule ?
-                       ROFFRULE_ALLOW : ROFFRULE_DENY;
+               r->rstack[++r->rstackpos] = !r->last->rule;

        }
 
        /* If the parent has false as its rule, then so do we. */
 
        }
 
        /* If the parent has false as its rule, then so do we. */
 

-       if (r->last->parent && ROFFRULE_DENY == r->last->parent->rule)
-               r->last->rule = ROFFRULE_DENY;
+       if (r->last->parent && !r->last->parent->rule)
+               r->last->rule = 0;

 
        /*
         * Determine scope.
 
        /*
         * Determine scope.


@@ -1347,10 +1341,198 @@ roff_ds(ROFF_ARGS)
                string++;
 
        /* The rest is the value. */
                string++;
 
        /* The rest is the value. */

-       roff_setstr(r, name, string, 0);
+       roff_setstr(r, name, string, ROFF_as == tok);

        return(ROFF_IGN);
 }
 
        return(ROFF_IGN);
 }
 

+/*
+ * Parse a single operator, one or two characters long.
+ * If the operator is recognized, return success and advance the
+ * parse point, else return failure and let the parse point unchanged.
+ */
+static int
+roff_getop(const char *v, int *pos, char *res)
+{
+
+       *res = v[*pos];
+
+       switch (*res) {
+       case ('+'):
+               /* FALLTHROUGH */
+       case ('-'):
+               /* FALLTHROUGH */
+       case ('*'):
+               /* FALLTHROUGH */
+       case ('/'):
+               /* FALLTHROUGH */
+       case ('%'):
+               /* FALLTHROUGH */
+       case ('&'):
+               /* FALLTHROUGH */
+       case (':'):
+               break;
+       case '<':
+               switch (v[*pos + 1]) {
+               case ('='):
+                       *res = 'l';
+                       (*pos)++;
+                       break;
+               case ('>'):
+                       *res = '!';
+                       (*pos)++;
+                       break;
+               case ('?'):
+                       *res = 'i';
+                       (*pos)++;
+                       break;
+               default:
+                       break;
+               }
+               break;
+       case '>':
+               switch (v[*pos + 1]) {
+               case ('='):
+                       *res = 'g';
+                       (*pos)++;
+                       break;
+               case ('?'):
+                       *res = 'a';
+                       (*pos)++;
+                       break;
+               default:
+                       break;
+               }
+               break;
+       case '=':
+               if ('=' == v[*pos + 1])
+                       (*pos)++;
+               break;
+       default:
+               return(0);
+       }
+       (*pos)++;
+
+       return(*res);
+}
+
+/*
+ * Evaluate either a parenthesized numeric expression
+ * or a single signed integer number.
+ */
+static int
+roff_evalpar(const char *v, int *pos, int *res)
+{
+
+       if ('(' != v[*pos])
+               return(roff_getnum(v, pos, res));
+
+       (*pos)++;
+       if ( ! roff_evalnum(v, pos, res, 1))
+               return(0);
+
+       /* If the trailing parenthesis is missing, ignore the error. */
+       if (')' == v[*pos])
+               (*pos)++;
+
+       return(1);
+}
+
+/*
+ * Evaluate a complete numeric expression.
+ * Proceed left to right, there is no concept of precedence.
+ */
+static int
+roff_evalnum(const char *v, int *pos, int *res, int skipwhite)
+{
+       int              mypos, operand2;
+       char             operator;
+
+       if (NULL == pos) {
+               mypos = 0;
+               pos = &mypos;
+       }
+
+       if (skipwhite)
+               while (isspace((unsigned char)v[*pos]))
+                       (*pos)++;
+
+       if ( ! roff_evalpar(v, pos, res))
+               return(0);
+
+       while (1) {
+               if (skipwhite)
+                       while (isspace((unsigned char)v[*pos]))
+                               (*pos)++;
+
+               if ( ! roff_getop(v, pos, &operator))
+                       break;
+
+               if (skipwhite)
+                       while (isspace((unsigned char)v[*pos]))
+                               (*pos)++;
+
+               if ( ! roff_evalpar(v, pos, &operand2))
+                       return(0);
+
+               if (skipwhite)
+                       while (isspace((unsigned char)v[*pos]))
+                               (*pos)++;
+
+               switch (operator) {
+               case ('+'):
+                       *res += operand2;
+                       break;
+               case ('-'):
+                       *res -= operand2;
+                       break;
+               case ('*'):
+                       *res *= operand2;
+                       break;
+               case ('/'):
+                       *res /= operand2;
+                       break;
+               case ('%'):
+                       *res %= operand2;
+                       break;
+               case ('<'):
+                       *res = *res < operand2;
+                       break;
+               case ('>'):
+                       *res = *res > operand2;
+                       break;
+               case ('l'):
+                       *res = *res <= operand2;
+                       break;
+               case ('g'):
+                       *res = *res >= operand2;
+                       break;
+               case ('='):
+                       *res = *res == operand2;
+                       break;
+               case ('!'):
+                       *res = *res != operand2;
+                       break;
+               case ('&'):
+                       *res = *res && operand2;
+                       break;
+               case (':'):
+                       *res = *res || operand2;
+                       break;
+               case ('i'):
+                       if (operand2 < *res)
+                               *res = operand2;
+                       break;
+               case ('a'):
+                       if (operand2 > *res)
+                               *res = operand2;
+                       break;
+               default:
+                       abort();
+               }
+       }
+       return(1);
+}
+

 void
 roff_setreg(struct roff *r, const char *name, int val, char sign)
 {
 void
 roff_setreg(struct roff *r, const char *name, int val, char sign)
 {


@@ -1380,10 +1562,45 @@ roff_setreg(struct roff *r, const char *name, int val, char sign)
                reg->val = val;
 }
 
                reg->val = val;
 }
 

+/*
+ * Handle some predefined read-only number registers.
+ * For now, return -1 if the requested register is not predefined;
+ * in case a predefined read-only register having the value -1
+ * were to turn up, another special value would have to be chosen.
+ */
+static int
+roff_getregro(const char *name)
+{
+
+       switch (*name) {
+       case ('A'):  /* ASCII approximation mode is always off. */
+               return(0);
+       case ('g'):  /* Groff compatibility mode is always on. */
+               return(1);
+       case ('H'):  /* Fixed horizontal resolution. */
+               return (24);
+       case ('j'):  /* Always adjust left margin only. */
+               return(0);
+       case ('T'):  /* Some output device is always defined. */
+               return(1);
+       case ('V'):  /* Fixed vertical resolution. */
+               return (40);
+       default:
+               return (-1);
+       }
+}
+

 int
 roff_getreg(const struct roff *r, const char *name)
 {
        struct roffreg  *reg;
 int
 roff_getreg(const struct roff *r, const char *name)
 {
        struct roffreg  *reg;

+       int              val;
+
+       if ('.' == name[0] && '\0' != name[1] && '\0' == name[2]) {
+               val = roff_getregro(name + 1);
+               if (-1 != val)
+                       return (val);
+       }

 
        for (reg = r->regtab; reg; reg = reg->next)
                if (0 == strcmp(name, reg->key.p))
 
        for (reg = r->regtab; reg; reg = reg->next)
                if (0 == strcmp(name, reg->key.p))


@@ -1396,6 +1613,13 @@ static int
 roff_getregn(const struct roff *r, const char *name, size_t len)
 {
        struct roffreg  *reg;
 roff_getregn(const struct roff *r, const char *name, size_t len)
 {
        struct roffreg  *reg;

+       int              val;
+
+       if ('.' == name[0] && 2 == len) {
+               val = roff_getregro(name + 1);
+               if (-1 != val)
+                       return (val);
+       }

 
        for (reg = r->regtab; reg; reg = reg->next)
                if (len == reg->key.sz &&
 
        for (reg = r->regtab; reg; reg = reg->next)
                if (len == reg->key.sz &&


@@ -1418,13 +1642,11 @@ roff_freereg(struct roffreg *reg)
        }
 }
 
        }
 }
 

-/* ARGSUSED */

 static enum rofferr
 roff_nr(ROFF_ARGS)
 {
        const char      *key;
        char            *val;
 static enum rofferr
 roff_nr(ROFF_ARGS)
 {
        const char      *key;
        char            *val;

-       size_t           sz;

        int              iv;
        char             sign;
 
        int              iv;
        char             sign;
 


@@ -1435,11 +1657,34 @@ roff_nr(ROFF_ARGS)
        if ('+' == sign || '-' == sign)
                val++;
 
        if ('+' == sign || '-' == sign)
                val++;
 

-       sz = strspn(val, "0123456789");
-       iv = sz ? mandoc_strntoi(val, sz, 10) : 0;
+       if (roff_evalnum(val, NULL, &iv, 0))
+               roff_setreg(r, key, iv, sign);
+
+       return(ROFF_IGN);
+}
+
+static enum rofferr
+roff_rr(ROFF_ARGS)
+{
+       struct roffreg  *reg, **prev;
+       const char      *name;
+       char            *cp;

 
 

-       roff_setreg(r, key, iv, sign);
+       cp = *bufp + pos;
+       name = roff_getname(r, &cp, ln, pos);

 
 

+       prev = &r->regtab;
+       while (1) {
+               reg = *prev;
+               if (NULL == reg || !strcmp(name, reg->key.p))
+                       break;
+               prev = &reg->next;
+       }
+       if (NULL != reg) {
+               *prev = reg->next;
+               free(reg->key.p);
+               free(reg);
+       }

        return(ROFF_IGN);
 }
 
        return(ROFF_IGN);
 }
 


@@ -1490,7 +1735,7 @@ roff_Dd(ROFF_ARGS)
 {
        const char *const       *cp;
 
 {
        const char *const       *cp;
 

-       if (0 == r->quick && MPARSE_MDOC != r->parsetype)
+       if (0 == ((MPARSE_MDOC | MPARSE_QUICK) & r->options))

                for (cp = __mdoc_reserved; *cp; cp++)
                        roff_setstr(r, *cp, NULL, 0);
 
                for (cp = __mdoc_reserved; *cp; cp++)
                        roff_setstr(r, *cp, NULL, 0);
 


@@ -1503,7 +1748,7 @@ roff_TH(ROFF_ARGS)
 {
        const char *const       *cp;
 
 {
        const char *const       *cp;
 

-       if (0 == r->quick && MPARSE_MDOC != r->parsetype)
+       if (0 == (MPARSE_QUICK & r->options))

                for (cp = __man_reserved; *cp; cp++)
                        roff_setstr(r, *cp, NULL, 0);
 
                for (cp = __man_reserved; *cp; cp++)
                        roff_setstr(r, *cp, NULL, 0);
 


@@ -1805,22 +2050,23 @@ roff_getname(struct roff *r, char **cpp, int ln, int pos)
 
 /*
  * Store *string into the user-defined string called *name.
 
 /*
  * Store *string into the user-defined string called *name.

- * In multiline mode, append to an existing entry and append '\n';
- * else replace the existing entry, if there is one.

  * To clear an existing entry, call with (*r, *name, NULL, 0).
  * To clear an existing entry, call with (*r, *name, NULL, 0).

+ * append == 0: replace mode
+ * append == 1: single-line append mode
+ * append == 2: multiline append mode, append '\n' after each call

  */
 static void
 roff_setstr(struct roff *r, const char *name, const char *string,
  */
 static void
 roff_setstr(struct roff *r, const char *name, const char *string,

-       int multiline)
+       int append)

 {
 
        roff_setstrn(&r->strtab, name, strlen(name), string,
 {
 
        roff_setstrn(&r->strtab, name, strlen(name), string,

-                       string ? strlen(string) : 0, multiline);
+                       string ? strlen(string) : 0, append);

 }
 
 static void
 roff_setstrn(struct roffkv **r, const char *name, size_t namesz,
 }
 
 static void
 roff_setstrn(struct roffkv **r, const char *name, size_t namesz,

-               const char *string, size_t stringsz, int multiline)
+               const char *string, size_t stringsz, int append)

 {
        struct roffkv   *n;
        char            *c;
 {
        struct roffkv   *n;
        char            *c;


@@ -1842,8 +2088,7 @@ roff_setstrn(struct roffkv **r, const char *name, size_t namesz,
                n->val.sz = 0;
                n->next = *r;
                *r = n;
                n->val.sz = 0;
                n->next = *r;
                *r = n;

-       } else if (0 == multiline) {
-               /* In multiline mode, append; else replace. */
+       } else if (0 == append) {

                free(n->val.p);
                n->val.p = NULL;
                n->val.sz = 0;
                free(n->val.p);
                n->val.p = NULL;
                n->val.sz = 0;


@@ -1856,7 +2101,7 @@ roff_setstrn(struct roffkv **r, const char *name, size_t namesz,
         * One additional byte for the '\n' in multiline mode,
         * and one for the terminating '\0'.
         */
         * One additional byte for the '\n' in multiline mode,
         * and one for the terminating '\0'.
         */

-       newch = stringsz + (multiline ? 2u : 1u);
+       newch = stringsz + (1 < append ? 2u : 1u);

 
        if (NULL == n->val.p) {
                n->val.p = mandoc_malloc(newch);
 
        if (NULL == n->val.p) {
                n->val.p = mandoc_malloc(newch);


@@ -1883,7 +2128,7 @@ roff_setstrn(struct roffkv **r, const char *name, size_t namesz,
        }
 
        /* Append terminating bytes. */
        }
 
        /* Append terminating bytes. */

-       if (multiline)
+       if (1 < append)

                *c++ = '\n';
 
        *c = '\0';
                *c++ = '\n';
 
        *c = '\0';