From ab189900401da15dee3e20b86bd32d1cdb7e37ac Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Sun, 29 Jun 2014 21:20:31 +0000 Subject: [PATCH] Bugfix in roff_setstrn(): Do not call strcmp() on an array of char that might not be NUL-terminated. --- roff.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/roff.c b/roff.c index 46ed2d7c..30e92309 100644 --- a/roff.c +++ b/roff.c @@ -1,4 +1,4 @@ -/* $Id: roff.c,v 1.210 2014/06/25 00:20:19 schwarze Exp $ */ +/* $Id: roff.c,v 1.211 2014/06/29 21:20:31 schwarze Exp $ */ /* * Copyright (c) 2010, 2011, 2012 Kristaps Dzonsons * Copyright (c) 2010-2014 Ingo Schwarze @@ -2068,7 +2068,8 @@ roff_setstrn(struct roffkv **r, const char *name, size_t namesz, /* Search for an existing string with the same name. */ n = *r; - while (n && strcmp(name, n->key.p)) + while (n && (namesz != n->key.sz || + strncmp(n->key.p, name, namesz))) n = n->next; if (NULL == n) { -- 2.47.1