diff options
| author |   Ingo Schwarze <schwarze@openbsd.org> | 2014-01-05 03:25:51 +0000 |
|---|---|---|
| committer | Ingo Schwarze <schwarze@openbsd.org> | 2014-01-05 03:25:51 +0000 |
| commit | 42b944defba9613b4887c77042d426c2b784fac3 (patch) | |
| tree | 1c908cbebf1f501fbafc87cbcfffc161ed7ee680 | |
| parent | bdcc37124aeee4069ccfb383b235e3f0efebdd5f (diff) | |
| download | mandoc-42b944defba9613b4887c77042d426c2b784fac3.tar.gz mandoc-42b944defba9613b4887c77042d426c2b784fac3.tar.zst mandoc-42b944defba9613b4887c77042d426c2b784fac3.zip | |
Remove the obsolete sec and arch columns from the mpages table.
They were confusing because a manpage can have MLINKS in different
sections and architectures.
| -rw-r--r-- | mandocdb.c | 12 | ||||
| -rw-r--r-- | mansearch.c | 8 |
2 files changed, 8 insertions, 12 deletions
@@ -1,4 +1,4 @@ -/* $Id: mandocdb.c,v 1.98 2014/01/05 03:06:43 schwarze Exp $ */ +/* $Id: mandocdb.c,v 1.99 2014/01/05 03:25:51 schwarze Exp $ */ /* * Copyright (c) 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2011, 2012, 2013, 2014 Ingo Schwarze <schwarze@openbsd.org> @@ -1819,13 +1819,11 @@ dbindex(const struct mpage *mpage, struct mchars *mc) i = 1; /* - * XXX The following three lines are obsolete + * XXX The following line is obsolete * and only kept for backward compatibility * until apropos(1) and friends have caught up. */ SQL_BIND_TEXT(stmts[STMT_INSERT_PAGE], i, mpage->mlinks->file); - SQL_BIND_TEXT(stmts[STMT_INSERT_PAGE], i, mpage->mlinks->dsec); - SQL_BIND_TEXT(stmts[STMT_INSERT_PAGE], i, mpage->mlinks->arch); SQL_BIND_TEXT(stmts[STMT_INSERT_PAGE], i, desc); SQL_BIND_INT(stmts[STMT_INSERT_PAGE], i, FORM_SRC == mpage->form); SQL_STEP(stmts[STMT_INSERT_PAGE]); @@ -1963,14 +1961,12 @@ dbopen(int real) } /* - * XXX The first three columns in table mpages are obsolete + * XXX The first column in table mpages is obsolete * and only kept for backward compatibility * until apropos(1) and friends have caught up. */ sql = "CREATE TABLE \"mpages\" (\n" " \"file\" TEXT NOT NULL,\n" - " \"sec\" TEXT NOT NULL,\n" - " \"arch\" TEXT NOT NULL,\n" " \"desc\" TEXT NOT NULL,\n" " \"form\" INTEGER NOT NULL,\n" " \"id\" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL\n" @@ -2007,7 +2003,7 @@ prepare_statements: sql = "DELETE FROM mpages where file=?"; sqlite3_prepare_v2(db, sql, -1, &stmts[STMT_DELETE_PAGE], NULL); sql = "INSERT INTO mpages " - "(file,sec,arch,desc,form) VALUES (?,?,?,?,?)"; + "(file,desc,form) VALUES (?,?,?)"; sqlite3_prepare_v2(db, sql, -1, &stmts[STMT_INSERT_PAGE], NULL); sql = "INSERT INTO mlinks " "(file,sec,arch,name,pageid) VALUES (?,?,?,?,?)"; diff --git a/mansearch.c b/mansearch.c index f4903c1e..3787f454 100644 --- a/mansearch.c +++ b/mansearch.c @@ -1,4 +1,4 @@ -/* $Id: mansearch.c,v 1.15 2014/01/05 03:06:43 schwarze Exp $ */ +/* $Id: mansearch.c,v 1.16 2014/01/05 03:25:51 schwarze Exp $ */ /* * Copyright (c) 2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2013, 2014 Ingo Schwarze <schwarze@openbsd.org> @@ -279,7 +279,7 @@ mansearch(const struct mansearch *search, * distribution of buckets in the table. */ while (SQLITE_ROW == (c = sqlite3_step(s))) { - id = sqlite3_column_int64(s, 5); + id = sqlite3_column_int64(s, 3); idx = ohash_lookup_memory (&htab, (char *)&id, sizeof(uint64_t), (uint32_t)id); @@ -292,8 +292,8 @@ mansearch(const struct mansearch *search, mp->file = mandoc_strdup ((char *)sqlite3_column_text(s, 0)); mp->desc = mandoc_strdup - ((char *)sqlite3_column_text(s, 3)); - mp->form = sqlite3_column_int(s, 4); + ((char *)sqlite3_column_text(s, 1)); + mp->form = sqlite3_column_int(s, 2); ohash_insert(&htab, idx, mp); } |