diff options
| author |   Ingo Schwarze <schwarze@openbsd.org> | 2015-02-06 01:07:22 +0000 |
|---|---|---|
| committer | Ingo Schwarze <schwarze@openbsd.org> | 2015-02-06 01:07:22 +0000 |
| commit | e1808a26399ba483775f0653731559b644cc6f0f (patch) | |
| tree | 9aba4cd57641891357436652945f5089d623dcbe | |
| parent | 068bdebaf39570b6a01506886f67b47bbb8e6fd2 (diff) | |
| download | mandoc-e1808a26399ba483775f0653731559b644cc6f0f.tar.gz mandoc-e1808a26399ba483775f0653731559b644cc6f0f.tar.zst mandoc-e1808a26399ba483775f0653731559b644cc6f0f.zip | |
better handle .In .Sh .Ss .St .Xr without arguments
| -rw-r--r-- | mdoc_macro.c | 13 | ||||
| -rw-r--r-- | mdoc_validate.c | 14 |
2 files changed, 15 insertions, 12 deletions
diff --git a/mdoc_macro.c b/mdoc_macro.c index b9abaf5d..8bc79919 100644 --- a/mdoc_macro.c +++ b/mdoc_macro.c @@ -1,4 +1,4 @@ -/* $Id: mdoc_macro.c,v 1.176 2015/02/05 01:46:56 schwarze Exp $ */ +/* $Id: mdoc_macro.c,v 1.177 2015/02/06 01:07:22 schwarze Exp $ */ /* * Copyright (c) 2008-2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2010, 2012-2015 Ingo Schwarze <schwarze@openbsd.org> @@ -904,6 +904,12 @@ blk_full(MACRO_PROT_ARGS) nl = MDOC_NEWLINE & mdoc->flags; + if (buf[*pos] == '\0' && (tok == MDOC_Sh || tok == MDOC_Ss)) { + mandoc_msg(MANDOCERR_MACRO_EMPTY, mdoc->parse, + line, ppos, mdoc_macronames[tok]); + return; + } + if ( ! (mdoc_macros[tok].flags & MDOC_EXPLICIT)) { /* Here, tok is one of Sh Ss Nm Nd It. */ @@ -1367,6 +1373,11 @@ in_line_argn(MACRO_PROT_ARGS) } if (j == 0) { + if (tok == MDOC_In || tok == MDOC_St || tok == MDOC_Xr) { + mandoc_msg(MANDOCERR_MACRO_EMPTY, mdoc->parse, + line, ppos, mdoc_macronames[tok]); + return; + } mdoc_elem_alloc(mdoc, line, ppos, tok, arg); if (ac == ARGS_PUNCT && tok == MDOC_Pf) append_delims(mdoc, line, pos, buf); diff --git a/mdoc_validate.c b/mdoc_validate.c index c600fa3e..a433367c 100644 --- a/mdoc_validate.c +++ b/mdoc_validate.c @@ -1,4 +1,4 @@ -/* $Id: mdoc_validate.c,v 1.271 2015/02/05 01:46:56 schwarze Exp $ */ +/* $Id: mdoc_validate.c,v 1.272 2015/02/06 01:07:22 schwarze Exp $ */ /* * Copyright (c) 2008-2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2010-2015 Ingo Schwarze <schwarze@openbsd.org> @@ -156,7 +156,7 @@ static const struct valids mdoc_valids[MDOC_MAX] = { { NULL, post_fn }, /* Fn */ { NULL, NULL }, /* Ft */ { NULL, NULL }, /* Ic */ - { NULL, ewarn_eq1 }, /* In */ + { NULL, NULL }, /* In */ { NULL, post_defaults }, /* Li */ { NULL, post_nd }, /* Nd */ { NULL, post_nm }, /* Nm */ @@ -167,7 +167,7 @@ static const struct valids mdoc_valids[MDOC_MAX] = { { NULL, post_st }, /* St */ { NULL, NULL }, /* Va */ { NULL, post_vt }, /* Vt */ - { NULL, ewarn_ge1 }, /* Xr */ + { NULL, NULL }, /* Xr */ { NULL, ewarn_ge1 }, /* %A */ { NULL, post_hyphtext }, /* %B */ /* FIXME: can be used outside Rs/Re. */ { NULL, ewarn_ge1 }, /* %D */ @@ -1640,13 +1640,6 @@ post_st(POST_ARGS) n = mdoc->last; nch = n->child; - if (NULL == nch) { - mandoc_msg(MANDOCERR_MACRO_EMPTY, mdoc->parse, - n->line, n->pos, mdoc_macronames[n->tok]); - mdoc_node_delete(mdoc, n); - return; - } - assert(MDOC_TEXT == nch->type); if (NULL == (p = mdoc_a2st(nch->string))) { @@ -2076,7 +2069,6 @@ post_ignpar(POST_ARGS) { struct mdoc_node *np; - check_count(mdoc, MDOC_HEAD, CHECK_GT, 0); post_hyph(mdoc); if (MDOC_BODY != mdoc->last->type) |