diff options
author | Ingo Schwarze <schwarze@openbsd.org> | 2014-04-23 16:34:50 +0000 |
---|---|---|
committer | Ingo Schwarze <schwarze@openbsd.org> | 2014-04-23 16:34:50 +0000 |
commit | 83a9b4af97fd1c631d24b734b275982561069bda (patch) | |
tree | 62524c50ab6459c93a7fbe177e10232012a1de4c /mandocdb.c | |
parent | e1bb09be17d41880b391cdcbe9d968f8964928ff (diff) | |
download | mandoc-83a9b4af97fd1c631d24b734b275982561069bda.tar.gz mandoc-83a9b4af97fd1c631d24b734b275982561069bda.tar.zst mandoc-83a9b4af97fd1c631d24b734b275982561069bda.zip |
improve SQL style: avoid "SELECT *", be explicit in what columns we want;
suggested by espie@.
Diffstat (limited to 'mandocdb.c')
-rw-r--r-- | mandocdb.c | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -1,4 +1,4 @@ -/* $Id: mandocdb.c,v 1.141 2014/04/20 16:46:04 schwarze Exp $ */ +/* $Id: mandocdb.c,v 1.142 2014/04/23 16:34:50 schwarze Exp $ */ /* * Copyright (c) 2011, 2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2011, 2012, 2013, 2014 Ingo Schwarze <schwarze@openbsd.org> @@ -1287,7 +1287,8 @@ names_check(void) "AND mlinks.name == names.name" ")" ") JOIN (" - "SELECT * FROM mlinks GROUP BY pageid" + "SELECT sec, arch, name, pageid FROM mlinks " + "GROUP BY pageid" ") USING (pageid);", -1, &stmt, NULL); |