diff options
author | Ingo Schwarze <schwarze@openbsd.org> | 2017-06-29 15:22:17 +0000 |
---|---|---|
committer | Ingo Schwarze <schwarze@openbsd.org> | 2017-06-29 15:22:17 +0000 |
commit | 294cf32a27d430922b8f008f10b766ddce477cf6 (patch) | |
tree | 5d2f44c87d164c034525970057e994f303f21f89 /mdoc_validate.c | |
parent | 7ce799ea42df955972ae7d0c05eeb330a9864345 (diff) | |
download | mandoc-294cf32a27d430922b8f008f10b766ddce477cf6.tar.gz mandoc-294cf32a27d430922b8f008f10b766ddce477cf6.tar.zst mandoc-294cf32a27d430922b8f008f10b766ddce477cf6.zip |
warn about some non-portable idioms in .Bl -column;
triggered by a question from Yuri Pankov (illumos)
Diffstat (limited to 'mdoc_validate.c')
-rw-r--r-- | mdoc_validate.c | 25 |
1 files changed, 20 insertions, 5 deletions
diff --git a/mdoc_validate.c b/mdoc_validate.c index a7d91ec0..73493155 100644 --- a/mdoc_validate.c +++ b/mdoc_validate.c @@ -1,4 +1,4 @@ -/* $Id: mdoc_validate.c,v 1.344 2017/06/27 12:18:00 schwarze Exp $ */ +/* $Id: mdoc_validate.c,v 1.345 2017/06/29 15:22:17 schwarze Exp $ */ /* * Copyright (c) 2008-2012 Kristaps Dzonsons <kristaps@bsd.lv> * Copyright (c) 2010-2017 Ingo Schwarze <schwarze@openbsd.org> @@ -1460,15 +1460,30 @@ post_it(POST_ARGS) assert(nit->head->child == NULL); - i = 0; - for (nch = nit->child; nch != NULL; nch = nch->next) - if (nch->type == ROFFT_BODY) - i++; + if (nit->head->next->child == NULL && + nit->head->next->next == NULL) { + mandoc_msg(MANDOCERR_MACRO_EMPTY, mdoc->parse, + nit->line, nit->pos, "It"); + roff_node_delete(mdoc, nit); + break; + } + i = 0; + for (nch = nit->child; nch != NULL; nch = nch->next) { + if (nch->type != ROFFT_BODY) + continue; + if (i++ && nch->flags & NODE_LINE) + mandoc_msg(MANDOCERR_TA_LINE, mdoc->parse, + nch->line, nch->pos, "Ta"); + } if (i < cols || i > cols + 1) mandoc_vmsg(MANDOCERR_BL_COL, mdoc->parse, nit->line, nit->pos, "%d columns, %d cells", cols, i); + else if (nit->head->next->child != NULL && + nit->head->next->child->line > nit->line) + mandoc_msg(MANDOCERR_IT_NOARG, mdoc->parse, + nit->line, nit->pos, "Bl -column It"); break; default: abort(); |