Implement tbl(7) lines in -T html output,

as far as they are on the edges of table cells
rather than going through the middle of cells:

* the box, doublebox, and allbox options;
* the | and || layout modifiers;
* and the _ and = data lines;
- but not yet _ and = in individual layout and data cells.

Missing feature reported by Pali dot Rohar at gmail dot com.

1 files changed, 124 insertions, 68 deletions

diff --git a/tbl_html.c b/tbl_html.c
index de521834..56fdcfb0 100644
--- a/tbl_html.c
+++ b/tbl_html.c
@@ -1,4 +1,4 @@
-/*	$Id: tbl_html.c,v 1.28 2018/11/26 01:51:46 schwarze Exp $ */
+/*	$Id: tbl_html.c,v 1.29 2018/11/26 21:06:02 schwarze Exp $ */
 /*
  * Copyright (c) 2011 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2014, 2015, 2017, 2018 Ingo Schwarze <schwarze@openbsd.org>
@@ -86,7 +86,15 @@ html_tblopen(struct html *h, const struct tbl_span *sp)
 		tblcalc(&h->tbl, sp, 0, 0);
 	}
 	assert(NULL == h->tblt);
-	h->tblt = print_otag(h, TAG_TABLE, "c", "tbl");
+	h->tblt = print_otag(h, TAG_TABLE, "c?ss", "tbl",
+	    "border",
+		sp->opts->opts & TBL_OPT_ALLBOX ? "1" : NULL,
+	    "border-style",
+		sp->opts->opts & TBL_OPT_DBOX ? "double" :
+		sp->opts->opts & TBL_OPT_BOX ? "solid" : NULL,
+	    "border-top-style",
+		sp->pos == TBL_SPAN_DHORIZ ? "double" :
+		sp->pos == TBL_SPAN_HORIZ ? "solid" : NULL);
 }
 
 void
@@ -102,89 +110,137 @@ void
 print_tbl(struct html *h, const struct tbl_span *sp)
 {
 	const struct tbl_dat	*dp;
+	const struct tbl_cell	*cp;
+	const struct tbl_span	*psp;
 	struct tag		*tt;
 	const char		*hspans, *vspans, *halign, *valign;
+	const char		*bborder, *lborder, *rborder;
 	char			 hbuf[4], vbuf[4];
-
-	/* Inhibit printing of spaces: we do padding ourselves. */
+	int			 i;
 
 	if (h->tblt == NULL)
 		html_tblopen(h, sp);
 
-	assert(h->tblt);
+	/*
+	 * Horizontal lines spanning the whole table
+	 * are handled by previous or following table rows.
+	 */
+
+	if (sp->pos != TBL_SPAN_DATA)
+		return;
+
+	/* Inhibit printing of spaces: we do padding ourselves. */
 
 	h->flags |= HTML_NONOSPACE;
 	h->flags |= HTML_NOSPACE;
 
-	tt = print_otag(h, TAG_TR, "");
+	/* Draw a vertical line left of this row? */
 
-	switch (sp->pos) {
-	case TBL_SPAN_HORIZ:
-	case TBL_SPAN_DHORIZ:
-		print_otag(h, TAG_TD, "?", "colspan", "0");
+	switch (sp->layout->vert) {
+	case 2:
+		lborder = "double";
+		break;
+	case 1:
+		lborder = "solid";
 		break;
 	default:
-		for (dp = sp->first; dp != NULL; dp = dp->next) {
-			print_stagq(h, tt);
-
-			/*
-			 * Do not generate <td> elements for continuations
-			 * of spanned cells.  Larger <td> elements covering
-			 * this space were already generated earlier.
-			 */
-
-			if (dp->layout->pos == TBL_CELL_SPAN ||
-			    dp->layout->pos == TBL_CELL_DOWN ||
-			    (dp->string != NULL &&
-			     strcmp(dp->string, "\\^") == 0))
-				continue;
-
-			/* Determine the attribute values. */
-
-			if (dp->hspans > 0) {
-				(void)snprintf(hbuf, sizeof(hbuf),
-				    "%d", dp->hspans + 1);
-				hspans = hbuf;
-			} else
-				hspans = NULL;
-			if (dp->vspans > 0) {
-				(void)snprintf(vbuf, sizeof(vbuf),
-				    "%d", dp->vspans + 1);
-				vspans = vbuf;
-			} else
-				vspans = NULL;
-
-			switch (dp->layout->pos) {
-			case TBL_CELL_CENTRE:
-				halign = "center";
-				break;
-			case TBL_CELL_RIGHT:
-			case TBL_CELL_NUMBER:
-				halign = "right";
-				break;
-			default:
-				halign = NULL;
-				break;
-			}
-			if (dp->layout->flags & TBL_CELL_TALIGN)
-				valign = "top";
-			else if (dp->layout->flags & TBL_CELL_BALIGN)
-				valign = "bottom";
-			else
-				valign = NULL;
-
-			/* Print the element and the attributes. */
-
-			print_otag(h, TAG_TD, "??ss",
-			    "colspan", hspans, "rowspan", vspans,
-			    "vertical-align", valign,
-			    "text-align", halign);
-			if (dp->string != NULL)
-				print_text(h, dp->string);
-		}
+		lborder = NULL;
 		break;
 	}
 
+	/* Draw a horizontal line below this row? */
+
+	bborder = NULL;
+	if ((psp = sp->next) != NULL) {
+		switch (psp->pos) {
+		case TBL_SPAN_DHORIZ:
+			bborder = "double";
+			break;
+		case TBL_SPAN_HORIZ:
+			bborder = "solid";
+			break;
+		default:
+			break;
+		}
+	}
+
+	tt = print_otag(h, TAG_TR, "ss",
+	    "border-left-style", lborder,
+	    "border-bottom-style", bborder);
+
+	for (dp = sp->first; dp != NULL; dp = dp->next) {
+		print_stagq(h, tt);
+
+		/*
+		 * Do not generate <td> elements for continuations
+		 * of spanned cells.  Larger <td> elements covering
+		 * this space were already generated earlier.
+		 */
+
+		cp = dp->layout;
+		if (cp->pos == TBL_CELL_SPAN || cp->pos == TBL_CELL_DOWN ||
+		    (dp->string != NULL && strcmp(dp->string, "\\^") == 0))
+			continue;
+
+		/* Determine the attribute values. */
+
+		if (dp->hspans > 0) {
+			(void)snprintf(hbuf, sizeof(hbuf),
+			    "%d", dp->hspans + 1);
+			hspans = hbuf;
+		} else
+			hspans = NULL;
+		if (dp->vspans > 0) {
+			(void)snprintf(vbuf, sizeof(vbuf),
+			    "%d", dp->vspans + 1);
+			vspans = vbuf;
+		} else
+			vspans = NULL;
+
+		switch (cp->pos) {
+		case TBL_CELL_CENTRE:
+			halign = "center";
+			break;
+		case TBL_CELL_RIGHT:
+		case TBL_CELL_NUMBER:
+			halign = "right";
+			break;
+		default:
+			halign = NULL;
+			break;
+		}
+		if (cp->flags & TBL_CELL_TALIGN)
+			valign = "top";
+		else if (cp->flags & TBL_CELL_BALIGN)
+			valign = "bottom";
+		else
+			valign = NULL;
+
+		for (i = dp->hspans; i > 0; i--)
+			cp = cp->next;
+		switch (cp->vert) {
+		case 2:
+			rborder = "double";
+			break;
+		case 1:
+			rborder = "solid";
+			break;
+		default:
+			rborder = NULL;
+			break;
+		}
+
+		/* Print the element and the attributes. */
+
+		print_otag(h, TAG_TD, "??sss",
+		    "colspan", hspans, "rowspan", vspans,
+		    "vertical-align", valign,
+		    "text-align", halign,
+		    "border-right-style", rborder);
+		if (dp->string != NULL)
+			print_text(h, dp->string);
+	}
+
 	print_tagq(h, tt);
 
 	h->flags &= ~HTML_NONOSPACE;