From 6de28b8b9ab60066105f904c47554cc5d6fb60b8 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Thu, 21 Nov 2013 01:53:48 +0000 Subject: My audit of mandoc revealed one missing (unsigned char) cast in a tolower() argument containing arbitrary char data. Thanks to deraadt@ for triggering the audit. --- mandocdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mandocdb.c b/mandocdb.c index c56a2b36..a7491caf 100644 --- a/mandocdb.c +++ b/mandocdb.c @@ -1,4 +1,4 @@ -/* $Id: mandocdb.c,v 1.49.2.9 2013/10/10 23:43:04 schwarze Exp $ */ +/* $Id: mandocdb.c,v 1.49.2.10 2013/11/21 01:53:48 schwarze Exp $ */ /* * Copyright (c) 2011, 2012 Kristaps Dzonsons * Copyright (c) 2011, 2012 Ingo Schwarze @@ -736,7 +736,7 @@ index_merge(const struct of *of, struct mparse *mp, } buf_appendb(buf, ")", 2); for (p = buf->cp; '\0' != *p; p++) - *p = tolower(*p); + *p = tolower((unsigned char)*p); key.data = buf->cp; key.size = buf->len; val.data = NULL; -- cgit v1.2.3-56-ge451