From a01d965c76db9cf227d69d8316586f39cd940ab1 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Wed, 7 Feb 2018 20:04:57 +0000 Subject: Fix the mandoc_strndup() utility function. All existing callers seem safe so far, but implementing it with an unchecked memcpy(3) is just wrong and quite dangerous. --- mandoc_aux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mandoc_aux.c b/mandoc_aux.c index db593e44..5d595ce0 100644 --- a/mandoc_aux.c +++ b/mandoc_aux.c @@ -1,4 +1,4 @@ -/* $Id: mandoc_aux.c,v 1.10 2017/06/12 19:05:47 schwarze Exp $ */ +/* $Id: mandoc_aux.c,v 1.11 2018/02/07 20:04:57 schwarze Exp $ */ /* * Copyright (c) 2009, 2011 Kristaps Dzonsons * Copyright (c) 2014, 2015, 2017 Ingo Schwarze @@ -111,8 +111,8 @@ mandoc_strndup(const char *ptr, size_t sz) { char *p; - p = mandoc_malloc(sz + 1); - memcpy(p, ptr, sz); - p[(int)sz] = '\0'; + p = strndup(ptr, sz); + if (p == NULL) + err((int)MANDOCLEVEL_SYSERR, NULL); return p; } -- cgit v1.2.3-56-ge451