From cf057940852b80c08275bb28dab9c2f9b01fdc63 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Sat, 9 Aug 2014 14:24:53 +0000 Subject: mmap(2) requires MAP_PRIVATE ^ MAP_SHARED for flags; found by kristaps@ on Mac OS X --- TODO | 6 +++++- mansearch.c | 5 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index 387bd6ad..a41df298 100644 --- a/TODO +++ b/TODO @@ -1,6 +1,6 @@ ************************************************************************ * Official mandoc TODO. -* $Id: TODO,v 1.175 2014/08/08 20:04:36 schwarze Exp $ +* $Id: TODO,v 1.176 2014/08/09 14:24:53 schwarze Exp $ ************************************************************************ ************************************************************************ @@ -399,6 +399,10 @@ * performance issues ************************************************************************ +- Why are we using MAP_SHARED, not MAP_PRIVATE for mmap(2)? + How does SQLITE_CONFIG_PAGECACHE actually work? Document it! + from kristaps@ Sat, 09 Aug 2014 13:51:36 +0200 + Several areas can be cleaned up to make mandoc even faster. These are - improve hashing mechanism for macros (quite important: performance) diff --git a/mansearch.c b/mansearch.c index 6e6961b9..e1226b1c 100644 --- a/mansearch.c +++ b/mansearch.c @@ -1,4 +1,4 @@ -/* $Id: mansearch.c,v 1.41 2014/08/05 14:43:10 schwarze Exp $ */ +/* $Id: mansearch.c,v 1.42 2014/08/09 14:24:53 schwarze Exp $ */ /* * Copyright (c) 2012 Kristaps Dzonsons * Copyright (c) 2013, 2014 Ingo Schwarze @@ -123,7 +123,8 @@ mansearch_setup(int start) } pagecache = mmap(NULL, PC_PAGESIZE * PC_NUMPAGES, - PROT_READ | PROT_WRITE, MAP_ANON, -1, 0); + PROT_READ | PROT_WRITE, + MAP_SHARED | MAP_ANON, -1, 0); if (MAP_FAILED == pagecache) { perror("mmap"); -- cgit v1.2.3-56-ge451