From 520a0876835a9bf8d8392782bf02058e7a984702 Mon Sep 17 00:00:00 2001
From: Ingo Schwarze <schwarze@openbsd.org>
Date: Fri, 3 May 2019 18:39:34 +0000
Subject: avoid duplicate "bad argument" error message, also shortening the
 code

---
 main.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

(limited to 'main.c')

diff --git a/main.c b/main.c
index bfe918b8..8e8ca894 100644
--- a/main.c
+++ b/main.c
@@ -1,4 +1,4 @@
-/*	$Id: main.c,v 1.326 2019/05/03 17:31:15 schwarze Exp $ */
+/*	$Id: main.c,v 1.327 2019/05/03 18:39:34 schwarze Exp $ */
 /*
  * Copyright (c) 2008-2012 Kristaps Dzonsons <kristaps@bsd.lv>
  * Copyright (c) 2010-2012, 2014-2019 Ingo Schwarze <schwarze@openbsd.org>
@@ -300,12 +300,9 @@ main(int argc, char *argv[])
 			search.outkey = oarg;
 		else {
 			while (oarg != NULL) {
-				thisarg = oarg;
 				if (manconf_output(&conf.output,
-				    strsep(&oarg, ","), 0) == 0)
-					continue;
-				warnx("-O %s: Bad argument", thisarg);
-				return (int)MANDOCLEVEL_BADARG;
+				    strsep(&oarg, ","), 0) == -1)
+					return (int)MANDOCLEVEL_BADARG;
 			}
 		}
 	}
-- 
cgit v1.2.3-56-ge451