From a1567e8417f169edf6c71532dc11bfa763ac444b Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Fri, 20 Aug 2010 01:02:07 +0000 Subject: Implement a simple, consistent user interface for error handling. We now have sufficient practical experience to know what we want, so this is intended to be final: - provide -Wlevel (warning, error or fatal) to select what you care about - provide -Wstop to stop after parsing a file with warnings you care about - provide consistent exit status codes for those warnings you care about - fully document what warnings, errors and fatal errors mean - remove all other cruft from the user interface, less is more: - remove all -f knobs along with the whole -f option - remove the old -Werror because calling warnings "fatal" is silly - always finish parsing each file, unless fatal errors prevent that This commit also includes a couple of related simplifications behind the scenes regarding error handling. Feedback and OK kristaps@; Joerg Sonnenberger (NetBSD) and Sascha Wildner (DragonFly BSD) agree with the general direction. --- man_validate.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'man_validate.c') diff --git a/man_validate.c b/man_validate.c index b6883ff8..e5b1d65e 100644 --- a/man_validate.c +++ b/man_validate.c @@ -1,4 +1,4 @@ -/* $Id: man_validate.c,v 1.48 2010/07/31 23:52:58 schwarze Exp $ */ +/* $Id: man_validate.c,v 1.49 2010/08/20 01:02:07 schwarze Exp $ */ /* * Copyright (c) 2008, 2009, 2010 Kristaps Dzonsons * @@ -233,12 +233,8 @@ check_text(CHKARGS) if (c) { p += c - 1; pos += c - 1; - continue; - } - - c = man_pmsg(m, n->line, pos, MANDOCERR_BADESCAPE); - if ( ! (MAN_IGN_ESCAPE & m->pflags) && ! c) - return(c); + } else + man_pmsg(m, n->line, pos, MANDOCERR_BADESCAPE); } return(1); -- cgit v1.2.3-56-ge451