From a90a19d8ea1fd9c75174c833a56f4c68dae450c4 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Fri, 21 Dec 2018 17:15:18 +0000 Subject: Rename mandoc_getarg() to roff_getarg() and pass it the roff parser struct as an argument such that after copy-in, it can call roff_expand() once again, which used to be called roff_res() before this. This fixes a subtle low-level roff(7) parsing bug reported by Fabio Scotoni in the 4.4BSD-Lite2 mdoc.samples(7) manual page, because that page used an escaped escape sequence in a macro argument. To expand escaped escape sequences in quoted mdoc(7) arguments, too, stop bypassing the call to roff_getarg() in mdoc_argv.c, function args() for this case. This does not solve the case of escaped escape sequences in quoted .Bl -column phrases yet. Because roff_expand() can make the string longer, roff_getarg() can no longer operate in-place but needs to malloc(3) the returned string. In the high-level parsers, free(3) that string after processing it. --- regress/man/RS/REarg.out_ascii | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'regress/man/RS/REarg.out_ascii') diff --git a/regress/man/RS/REarg.out_ascii b/regress/man/RS/REarg.out_ascii index 747e037b..45326a88 100644 --- a/regress/man/RS/REarg.out_ascii +++ b/regress/man/RS/REarg.out_ascii @@ -20,4 +20,4 @@ DDEESSCCRRIIPPTTIIOONN -OpenBSD January 24, 2015 RS-REARG(1) +OpenBSD December 21, 2018 RS-REARG(1) -- cgit v1.2.3-56-ge451