From 3c72c09b0b46063f51691bedeabc69413194fb61 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Wed, 6 Feb 2019 21:11:43 +0000 Subject: Let roff_getname() end the roff identifier at a tab character and audit all its callers whether termination is handled correctly. Resulting improvements: * An escape or tab ending the macro name in a macro invocation is discarded, and argument processing is started after it. * An escape or tab ending a name in ".if d" and ".if r" is preserved. * An escape ending a name in ".ds" causes the whole request to be ignored. * A tab ending a name in ".ds" becomes part of the string. * An escape or tab ending a name in ".rm" causes the rest of the line to be ignored. * An escape or tab ending the first name in ".als", ".rn", or ".nr" causes the whole request to be ignored. Kurt Jaeger made me aware of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235456#c0 and in that bug report, comment 0 item (3) is a special case of this class of issues. Yes, the "mh" manual pages are no doubt among the worst on the planet. --- regress/roff/cond/string.out_ascii | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'regress/roff/cond/string.out_ascii') diff --git a/regress/roff/cond/string.out_ascii b/regress/roff/cond/string.out_ascii index b5075d21..b01e072a 100644 --- a/regress/roff/cond/string.out_ascii +++ b/regress/roff/cond/string.out_ascii @@ -17,6 +17,10 @@ DDEESSCCRRIIPPTTIIOONN standard macro is defined + identifier and tab: mystr is defined + escape sequence after identifier: -mystr is defined -OpenBSD June 14, 2017 STRING(1) + + +OpenBSD February 6, 2019 STRING(1) -- cgit v1.2.3-56-ge451