From 3c72c09b0b46063f51691bedeabc69413194fb61 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Wed, 6 Feb 2019 21:11:43 +0000 Subject: Let roff_getname() end the roff identifier at a tab character and audit all its callers whether termination is handled correctly. Resulting improvements: * An escape or tab ending the macro name in a macro invocation is discarded, and argument processing is started after it. * An escape or tab ending a name in ".if d" and ".if r" is preserved. * An escape ending a name in ".ds" causes the whole request to be ignored. * A tab ending a name in ".ds" becomes part of the string. * An escape or tab ending a name in ".rm" causes the rest of the line to be ignored. * An escape or tab ending the first name in ".als", ".rn", or ".nr" causes the whole request to be ignored. Kurt Jaeger made me aware of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235456#c0 and in that bug report, comment 0 item (3) is a special case of this class of issues. Yes, the "mh" manual pages are no doubt among the worst on the planet. --- regress/roff/de/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'regress/roff/de/Makefile') diff --git a/regress/roff/de/Makefile b/regress/roff/de/Makefile index 0d024a23..0d4d203f 100644 --- a/regress/roff/de/Makefile +++ b/regress/roff/de/Makefile @@ -1,9 +1,10 @@ -# $OpenBSD: Makefile,v 1.9 2015/02/03 19:37:25 schwarze Exp $ +# $OpenBSD: Makefile,v 1.12 2019/02/06 20:54:28 schwarze Exp $ -REGRESS_TARGETS = append cond escname factorial indir infinite startde TH Dd +REGRESS_TARGETS = append cond escname factorial indir infinite startde tab +REGRESS_TARGETS += TH Dd LINT_TARGETS = escname indir infinite -# groff-1.22.3 defect: +# groff-1.22.4 defect: # infinite recursion aborts output completely SKIP_GROFF = infinite -- cgit v1.2.3-56-ge451