]> git.cameronkatri.com Git - pw-darwin.git/blobdiff - pw/pw_user.c
Revert r277652
[pw-darwin.git] / pw / pw_user.c
index b59789c9f576148cee89b84d8ff3757abf551abb..483148af4909d2c6170b9024b353d72595d22200 100644 (file)
@@ -42,6 +42,9 @@ static const char rcsid[] =
 #include <sys/resource.h>
 #include <unistd.h>
 #include <login_cap.h>
+#include <pwd.h>
+#include <grp.h>
+#include <libutil.h>
 #include "pw.h"
 #include "bitmap.h"
 
@@ -197,7 +200,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        strlcpy(dbuf, cnf->home, sizeof(dbuf));
                        p = dbuf;
                        if (stat(dbuf, &st) == -1) {
-                               while ((p = strchr(++p, '/')) != NULL) {
+                               while ((p = strchr(p + 1, '/')) != NULL) {
                                        *p = '\0';
                                        if (stat(dbuf, &st) == -1) {
                                                if (mkdir(dbuf, _DEF_DIRMODE) == -1)
@@ -292,7 +295,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        if (mode == M_PRINT && getarg(args, 'a')) {
                int             pretty = getarg(args, 'P') != NULL;
                int             v7 = getarg(args, '7') != NULL;
-
                SETPWENT();
                while ((pwd = GETPWENT()) != NULL)
                        print_user(pwd, pretty, v7);
@@ -315,10 +317,13 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                 */
                if (mode != M_ADD && pwd == NULL
                    && strspn(a_name->val, "0123456789") == strlen(a_name->val)
-                   && atoi(a_name->val) > 0) { /* Assume uid */
+                   && *a_name->val) {
                        (a_uid = a_name)->ch = 'u';
                        a_name = NULL;
                }
+       } else {
+               if (strspn(a_uid->val, "0123456789") != strlen(a_uid->val))
+                       errx(EX_USAGE, "-u expects a number");
        }
 
        /*
@@ -378,6 +383,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        char            file[MAXPATHLEN];
                        char            home[MAXPATHLEN];
                        uid_t           uid = pwd->pw_uid;
+                       struct group    *gr;
+                       char            grname[LOGNAMESIZE];
 
                        if (strcmp(pwd->pw_name, "root") == 0)
                                errx(EX_DATAERR, "cannot remove user 'root'");
@@ -392,7 +399,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                /*
                                 * Remove crontabs
                                 */
-                               sprintf(file, "/var/cron/tabs/%s", pwd->pw_name);
+                               snprintf(file, sizeof(file), "/var/cron/tabs/%s", pwd->pw_name);
                                if (access(file, F_OK) == 0) {
                                        sprintf(file, "crontab -u %s -r", pwd->pw_name);
                                        system(file);
@@ -404,6 +411,11 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                         */
                        sprintf(file, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
                        strlcpy(home, pwd->pw_dir, sizeof(home));
+                       gr = GETGRGID(pwd->pw_gid);
+                       if (gr != NULL)
+                               strlcpy(grname, gr->gr_name, LOGNAMESIZE);
+                       else
+                               grname[0] = '\0';
 
                        rc = delpwent(pwd);
                        if (rc == -1)
@@ -422,7 +434,27 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                /* non-fatal */
                        }
 
-                       editgroups(a_name->val, NULL);
+                       grp = GETGRNAM(a_name->val);
+                       if (grp != NULL &&
+                           (grp->gr_mem == NULL || *grp->gr_mem == NULL) &&
+                           strcmp(a_name->val, grname) == 0)
+                               delgrent(GETGRNAM(a_name->val));
+                       SETGRENT();
+                       while ((grp = GETGRENT()) != NULL) {
+                               int i, j;
+                               char group[MAXLOGNAME];
+                               if (grp->gr_mem != NULL) {
+                                       for (i = 0; grp->gr_mem[i] != NULL; i++) {
+                                               if (!strcmp(grp->gr_mem[i], a_name->val)) {
+                                                       for (j = i; grp->gr_mem[j] != NULL; j++)
+                                                               grp->gr_mem[j] = grp->gr_mem[j+1];
+                                                       strlcpy(group, grp->gr_name, MAXLOGNAME);
+                                                       chggrent(group, grp);
+                                               }
+                                       }
+                               }
+                       }
+                       ENDGRENT();
 
                        pw_log(cnf, mode, W_USER, "%s(%ld) account removed", a_name->val, (long) uid);
 
@@ -494,8 +526,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
-                               if (now == expire)
-                                       errx(EX_DATAERR, "invalid password change date `%s'", arg->val);
                                if (pwd->pw_change != expire) {
                                        pwd->pw_change = expire;
                                        edited = 1;
@@ -514,8 +544,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
-                               if (now == expire)
-                                       errx(EX_DATAERR, "invalid account expiry date `%s'", arg->val);
                                if (pwd->pw_expire != expire) {
                                        pwd->pw_expire = expire;
                                        edited = 1;
@@ -558,7 +586,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
 
                        lc = login_getpwclass(pwd);
                        if (lc == NULL ||
-                           login_setcryptfmt(lc, "md5", NULL) == NULL)
+                           login_setcryptfmt(lc, "sha512", NULL) == NULL)
                                warn("setting crypt(3) format");
                        login_close(lc);
                        pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
@@ -590,7 +618,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                pwd->pw_dir = pw_homepolicy(cnf, args, pwd->pw_name);
                pwd->pw_shell = pw_shellpolicy(cnf, args, NULL);
                lc = login_getpwclass(pwd);
-               if (lc == NULL || login_setcryptfmt(lc, "md5", NULL) == NULL)
+               if (lc == NULL || login_setcryptfmt(lc, "sha512", NULL) == NULL)
                        warn("setting crypt(3) format");
                login_close(lc);
                pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
@@ -665,7 +693,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        } else {
                                lc = login_getpwclass(pwd);
                                if (lc == NULL ||
-                                   login_setcryptfmt(lc, "md5", NULL) == NULL)
+                                   login_setcryptfmt(lc, "sha512", NULL) == NULL)
                                        warn("setting crypt(3) format");
                                login_close(lc);
                                pwd->pw_passwd = pw_pwcrypt(line);
@@ -725,8 +753,42 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * Ok, user is created or changed - now edit group file
         */
 
-       if (mode == M_ADD || getarg(args, 'G') != NULL)
-               editgroups(pwd->pw_name, cnf->groups);
+       if (mode == M_ADD || getarg(args, 'G') != NULL) {
+               int i, j;
+               /* First remove the user from all group */
+               SETGRENT();
+               while ((grp = GETGRENT()) != NULL) {
+                       char group[MAXLOGNAME];
+                       if (grp->gr_mem == NULL)
+                               continue;
+                       for (i = 0; grp->gr_mem[i] != NULL; i++) {
+                               if (strcmp(grp->gr_mem[i] , pwd->pw_name) != 0)
+                                       continue;
+                               for (j = i; grp->gr_mem[j] != NULL ; j++)
+                                       grp->gr_mem[j] = grp->gr_mem[j+1];
+                               strlcpy(group, grp->gr_name, MAXLOGNAME);
+                               chggrent(group, grp);
+                       }
+               }
+               ENDGRENT();
+
+               /* now add to group where needed */
+               for (i = 0; cnf->groups[i] != NULL; i++) {
+                       grp = GETGRNAM(cnf->groups[i]);
+                       grp = gr_add(grp, pwd->pw_name);
+                       /*
+                        * grp can only be NULL in 2 cases:
+                        * - the new member is already a member
+                        * - a problem with memory occurs
+                        * in both cases we want to skip now.
+                        */
+                       if (grp == NULL)
+                               continue;
+                       chggrent(cnf->groups[i], grp);
+                       free(grp);
+               }
+       }
+
 
        /* go get a current version of pwd */
        pwd = GETPWNAM(a_name->val);
@@ -877,7 +939,8 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                                errx(EX_NOUSER, "group `%s' is not defined", a_gid->val);
                }
                gid = grp->gr_gid;
-       } else if ((grp = GETGRNAM(nam)) != NULL && grp->gr_mem[0] == NULL) {
+       } else if ((grp = GETGRNAM(nam)) != NULL &&
+           (grp->gr_mem == NULL || grp->gr_mem[0] == NULL)) {
                gid = grp->gr_gid;  /* Already created? Use it anyway... */
        } else {
                struct cargs    grpargs;
@@ -1090,10 +1153,14 @@ static int
 print_user(struct passwd * pwd, int pretty, int v7)
 {
        if (!pretty) {
-               char            buf[_UC_MAXLINE];
+               char            *buf;
 
-               fmtpwentry(buf, pwd, v7 ? PWF_PASSWD : PWF_STANDARD);
-               fputs(buf, stdout);
+               if (!v7)
+                       pwd->pw_passwd = (pwd->pw_passwd == NULL) ? "" : "*";
+
+               buf = v7 ? pw_make_v7(pwd) : pw_make(pwd);
+               printf("%s\n", buf);
+               free(buf);
        } else {
                int             j;
                char           *p;
@@ -1147,14 +1214,16 @@ print_user(struct passwd * pwd, int pretty, int v7)
                while ((grp=GETGRENT()) != NULL)
                {
                        int     i = 0;
-                       while (grp->gr_mem[i] != NULL)
-                       {
-                               if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
+                       if (grp->gr_mem != NULL) {
+                               while (grp->gr_mem[i] != NULL)
                                {
-                                       printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
-                                       break;
+                                       if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
+                                       {
+                                               printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
+                                               break;
+                                       }
+                                       ++i;
                                }
-                               ++i;
                        }
                }
                ENDGRENT();