]> git.cameronkatri.com Git - pw-darwin.git/blobdiff - pw/pw_user.c
Revert r277652
[pw-darwin.git] / pw / pw_user.c
index 7da16f8773a0e240933864d78bee4e6176df60b9..483148af4909d2c6170b9024b353d72595d22200 100644 (file)
@@ -41,19 +41,14 @@ static const char rcsid[] =
 #include <sys/time.h>
 #include <sys/resource.h>
 #include <unistd.h>
-#include <utmp.h>
 #include <login_cap.h>
-#if defined(USE_MD5RAND)
-#include <md5.h>
-#endif
+#include <pwd.h>
+#include <grp.h>
+#include <libutil.h>
 #include "pw.h"
 #include "bitmap.h"
 
-#if (MAXLOGNAME-1) > UT_NAMESIZE
-#define LOGNAMESIZE UT_NAMESIZE
-#else
 #define LOGNAMESIZE (MAXLOGNAME-1)
-#endif
 
 static         char locked_str[] = "*LOCKED*";
 
@@ -115,7 +110,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        struct stat     st;
        char            line[_PASSWORD_LEN+1];
        FILE           *fp;
-       mode_t dmode;
        char *dmode_c;
        void *set = NULL;
 
@@ -164,9 +158,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                if ((set = setmode(dmode_c)) == NULL)
                        errx(EX_DATAERR, "invalid directory creation mode '%s'",
                            dmode_c);
-               dmode = getmode(set, S_IRWXU | S_IRWXG | S_IRWXO);
+               cnf->homemode = getmode(set, _DEF_DIRMODE);
                free(set);
-               cnf->homemode = dmode;
        }
 
        /*
@@ -194,7 +187,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        if (strchr(cnf->home+1, '/') == NULL) {
                                strcpy(dbuf, "/usr");
                                strncat(dbuf, cnf->home, MAXPATHLEN-5);
-                               if (mkdir(dbuf, cnf->homemode) != -1 || errno == EEXIST) {
+                               if (mkdir(dbuf, _DEF_DIRMODE) != -1 || errno == EEXIST) {
                                        chown(dbuf, 0, 0);
                                        /*
                                         * Skip first "/" and create symlink:
@@ -207,10 +200,10 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        strlcpy(dbuf, cnf->home, sizeof(dbuf));
                        p = dbuf;
                        if (stat(dbuf, &st) == -1) {
-                               while ((p = strchr(++p, '/')) != NULL) {
+                               while ((p = strchr(p + 1, '/')) != NULL) {
                                        *p = '\0';
                                        if (stat(dbuf, &st) == -1) {
-                                               if (mkdir(dbuf, cnf->homemode) == -1)
+                                               if (mkdir(dbuf, _DEF_DIRMODE) == -1)
                                                        goto direrr;
                                                chown(dbuf, 0, 0);
                                        } else if (!S_ISDIR(st.st_mode))
@@ -219,7 +212,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                }
                        }
                        if (stat(dbuf, &st) == -1) {
-                               if (mkdir(dbuf, cnf->homemode) == -1) {
+                               if (mkdir(dbuf, _DEF_DIRMODE) == -1) {
                                direrr: err(EX_OSFILE, "mkdir '%s'", dbuf);
                                }
                                chown(dbuf, 0, 0);
@@ -302,7 +295,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
        if (mode == M_PRINT && getarg(args, 'a')) {
                int             pretty = getarg(args, 'P') != NULL;
                int             v7 = getarg(args, '7') != NULL;
-
                SETPWENT();
                while ((pwd = GETPWENT()) != NULL)
                        print_user(pwd, pretty, v7);
@@ -325,10 +317,13 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                 */
                if (mode != M_ADD && pwd == NULL
                    && strspn(a_name->val, "0123456789") == strlen(a_name->val)
-                   && atoi(a_name->val) > 0) { /* Assume uid */
+                   && *a_name->val) {
                        (a_uid = a_name)->ch = 'u';
                        a_name = NULL;
                }
+       } else {
+               if (strspn(a_uid->val, "0123456789") != strlen(a_uid->val))
+                       errx(EX_USAGE, "-u expects a number");
        }
 
        /*
@@ -388,6 +383,8 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        char            file[MAXPATHLEN];
                        char            home[MAXPATHLEN];
                        uid_t           uid = pwd->pw_uid;
+                       struct group    *gr;
+                       char            grname[LOGNAMESIZE];
 
                        if (strcmp(pwd->pw_name, "root") == 0)
                                errx(EX_DATAERR, "cannot remove user 'root'");
@@ -402,7 +399,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                /*
                                 * Remove crontabs
                                 */
-                               sprintf(file, "/var/cron/tabs/%s", pwd->pw_name);
+                               snprintf(file, sizeof(file), "/var/cron/tabs/%s", pwd->pw_name);
                                if (access(file, F_OK) == 0) {
                                        sprintf(file, "crontab -u %s -r", pwd->pw_name);
                                        system(file);
@@ -414,6 +411,11 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                         */
                        sprintf(file, "%s/%s", _PATH_MAILDIR, pwd->pw_name);
                        strlcpy(home, pwd->pw_dir, sizeof(home));
+                       gr = GETGRGID(pwd->pw_gid);
+                       if (gr != NULL)
+                               strlcpy(grname, gr->gr_name, LOGNAMESIZE);
+                       else
+                               grname[0] = '\0';
 
                        rc = delpwent(pwd);
                        if (rc == -1)
@@ -432,7 +434,27 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                /* non-fatal */
                        }
 
-                       editgroups(a_name->val, NULL);
+                       grp = GETGRNAM(a_name->val);
+                       if (grp != NULL &&
+                           (grp->gr_mem == NULL || *grp->gr_mem == NULL) &&
+                           strcmp(a_name->val, grname) == 0)
+                               delgrent(GETGRNAM(a_name->val));
+                       SETGRENT();
+                       while ((grp = GETGRENT()) != NULL) {
+                               int i, j;
+                               char group[MAXLOGNAME];
+                               if (grp->gr_mem != NULL) {
+                                       for (i = 0; grp->gr_mem[i] != NULL; i++) {
+                                               if (!strcmp(grp->gr_mem[i], a_name->val)) {
+                                                       for (j = i; grp->gr_mem[j] != NULL; j++)
+                                                               grp->gr_mem[j] = grp->gr_mem[j+1];
+                                                       strlcpy(group, grp->gr_name, MAXLOGNAME);
+                                                       chggrent(group, grp);
+                                               }
+                                       }
+                               }
+                       }
+                       ENDGRENT();
 
                        pw_log(cnf, mode, W_USER, "%s(%ld) account removed", a_name->val, (long) uid);
 
@@ -504,8 +526,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
-                               if (now == expire)
-                                       errx(EX_DATAERR, "invalid password change date `%s'", arg->val);
                                if (pwd->pw_change != expire) {
                                        pwd->pw_change = expire;
                                        edited = 1;
@@ -524,8 +544,6 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                                time_t          now = time(NULL);
                                time_t          expire = parse_date(now, arg->val);
 
-                               if (now == expire)
-                                       errx(EX_DATAERR, "invalid account expiry date `%s'", arg->val);
                                if (pwd->pw_expire != expire) {
                                        pwd->pw_expire = expire;
                                        edited = 1;
@@ -568,7 +586,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
 
                        lc = login_getpwclass(pwd);
                        if (lc == NULL ||
-                           login_setcryptfmt(lc, "md5", NULL) == NULL)
+                           login_setcryptfmt(lc, "sha512", NULL) == NULL)
                                warn("setting crypt(3) format");
                        login_close(lc);
                        pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
@@ -600,7 +618,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                pwd->pw_dir = pw_homepolicy(cnf, args, pwd->pw_name);
                pwd->pw_shell = pw_shellpolicy(cnf, args, NULL);
                lc = login_getpwclass(pwd);
-               if (lc == NULL || login_setcryptfmt(lc, "md5", NULL) == NULL)
+               if (lc == NULL || login_setcryptfmt(lc, "sha512", NULL) == NULL)
                        warn("setting crypt(3) format");
                login_close(lc);
                pwd->pw_passwd = pw_password(cnf, args, pwd->pw_name);
@@ -675,7 +693,7 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
                        } else {
                                lc = login_getpwclass(pwd);
                                if (lc == NULL ||
-                                   login_setcryptfmt(lc, "md5", NULL) == NULL)
+                                   login_setcryptfmt(lc, "sha512", NULL) == NULL)
                                        warn("setting crypt(3) format");
                                login_close(lc);
                                pwd->pw_passwd = pw_pwcrypt(line);
@@ -735,8 +753,42 @@ pw_user(struct userconf * cnf, int mode, struct cargs * args)
         * Ok, user is created or changed - now edit group file
         */
 
-       if (mode == M_ADD || getarg(args, 'G') != NULL)
-               editgroups(pwd->pw_name, cnf->groups);
+       if (mode == M_ADD || getarg(args, 'G') != NULL) {
+               int i, j;
+               /* First remove the user from all group */
+               SETGRENT();
+               while ((grp = GETGRENT()) != NULL) {
+                       char group[MAXLOGNAME];
+                       if (grp->gr_mem == NULL)
+                               continue;
+                       for (i = 0; grp->gr_mem[i] != NULL; i++) {
+                               if (strcmp(grp->gr_mem[i] , pwd->pw_name) != 0)
+                                       continue;
+                               for (j = i; grp->gr_mem[j] != NULL ; j++)
+                                       grp->gr_mem[j] = grp->gr_mem[j+1];
+                               strlcpy(group, grp->gr_name, MAXLOGNAME);
+                               chggrent(group, grp);
+                       }
+               }
+               ENDGRENT();
+
+               /* now add to group where needed */
+               for (i = 0; cnf->groups[i] != NULL; i++) {
+                       grp = GETGRNAM(cnf->groups[i]);
+                       grp = gr_add(grp, pwd->pw_name);
+                       /*
+                        * grp can only be NULL in 2 cases:
+                        * - the new member is already a member
+                        * - a problem with memory occurs
+                        * in both cases we want to skip now.
+                        */
+                       if (grp == NULL)
+                               continue;
+                       chggrent(cnf->groups[i], grp);
+                       free(grp);
+               }
+       }
+
 
        /* go get a current version of pwd */
        pwd = GETPWNAM(a_name->val);
@@ -887,7 +939,8 @@ pw_gidpolicy(struct userconf * cnf, struct cargs * args, char *nam, gid_t prefer
                                errx(EX_NOUSER, "group `%s' is not defined", a_gid->val);
                }
                gid = grp->gr_gid;
-       } else if ((grp = GETGRNAM(nam)) != NULL && grp->gr_mem[0] == NULL) {
+       } else if ((grp = GETGRNAM(nam)) != NULL &&
+           (grp->gr_mem == NULL || grp->gr_mem[0] == NULL)) {
                gid = grp->gr_gid;  /* Already created? Use it anyway... */
        } else {
                struct cargs    grpargs;
@@ -1038,6 +1091,7 @@ pw_pwcrypt(char *password)
 {
        int             i;
        char            salt[SALTSIZE + 1];
+       char            *cryptpw;
 
        static char     buf[256];
 
@@ -1045,74 +1099,27 @@ pw_pwcrypt(char *password)
         * Calculate a salt value
         */
        for (i = 0; i < SALTSIZE; i++)
-               salt[i] = chars[arc4random() % (sizeof(chars) - 1)];
+               salt[i] = chars[arc4random_uniform(sizeof(chars) - 1)];
        salt[SALTSIZE] = '\0';
 
-       return strcpy(buf, crypt(password, salt));
-}
-
-#if defined(USE_MD5RAND)
-u_char *
-pw_getrand(u_char *buf, int len)       /* cryptographically secure rng */
-{
-       int i;
-       for (i=0;i<len;i+=16) {
-               u_char ubuf[16];
-
-               MD5_CTX md5_ctx;
-               struct timeval tv, tvo;
-               struct rusage ru;
-               int n=0;
-               int t;
-
-               MD5Init (&md5_ctx);
-               t=getpid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               t=getppid();
-               MD5Update (&md5_ctx, (u_char*)&t, sizeof t);
-               gettimeofday (&tvo, NULL);
-               do {
-                       getrusage (RUSAGE_SELF, &ru);
-                       MD5Update (&md5_ctx, (u_char*)&ru, sizeof ru);
-                       gettimeofday (&tv, NULL);
-                       MD5Update (&md5_ctx, (u_char*)&tv, sizeof tv);
-               } while (n++<20 || tv.tv_usec-tvo.tv_usec<100*1000);
-               MD5Final (ubuf, &md5_ctx);
-               memcpy(buf+i, ubuf, MIN(16, len-i));
-       }
-       return buf;
+       cryptpw = crypt(password, salt);
+       if (cryptpw == NULL)
+               errx(EX_CONFIG, "crypt(3) failure");
+       return strcpy(buf, cryptpw);
 }
 
-#else  /* Portable version */
-
-static u_char *
-pw_getrand(u_char *buf, int len)
-{
-       int i;
-
-       for (i = 0; i < len; i++) {
-               unsigned long val = arc4random();
-               /* Use all bits in the random value */
-               buf[i]=(u_char)((val >> 24) ^ (val >> 16) ^ (val >> 8) ^ val);
-       }
-       return buf;
-}
-
-#endif
 
 static char    *
 pw_password(struct userconf * cnf, struct cargs * args, char const * user)
 {
        int             i, l;
        char            pwbuf[32];
-       u_char          rndbuf[sizeof pwbuf];
 
        switch (cnf->default_password) {
        case -1:                /* Random password */
                l = (arc4random() % 8 + 8);     /* 8 - 16 chars */
-               pw_getrand(rndbuf, l);
                for (i = 0; i < l; i++)
-                       pwbuf[i] = chars[rndbuf[i] % (sizeof(chars)-1)];
+                       pwbuf[i] = chars[arc4random_uniform(sizeof(chars)-1)];
                pwbuf[i] = '\0';
 
                /*
@@ -1146,10 +1153,14 @@ static int
 print_user(struct passwd * pwd, int pretty, int v7)
 {
        if (!pretty) {
-               char            buf[_UC_MAXLINE];
+               char            *buf;
+
+               if (!v7)
+                       pwd->pw_passwd = (pwd->pw_passwd == NULL) ? "" : "*";
 
-               fmtpwentry(buf, pwd, v7 ? PWF_PASSWD : PWF_STANDARD);
-               fputs(buf, stdout);
+               buf = v7 ? pw_make_v7(pwd) : pw_make(pwd);
+               printf("%s\n", buf);
+               free(buf);
        } else {
                int             j;
                char           *p;
@@ -1203,14 +1214,16 @@ print_user(struct passwd * pwd, int pretty, int v7)
                while ((grp=GETGRENT()) != NULL)
                {
                        int     i = 0;
-                       while (grp->gr_mem[i] != NULL)
-                       {
-                               if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
+                       if (grp->gr_mem != NULL) {
+                               while (grp->gr_mem[i] != NULL)
                                {
-                                       printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
-                                       break;
+                                       if (strcmp(grp->gr_mem[i], pwd->pw_name)==0)
+                                       {
+                                               printf(j++ == 0 ? "    Groups: %s" : ",%s", grp->gr_name);
+                                               break;
+                                       }
+                                       ++i;
                                }
-                               ++i;
                        }
                }
                ENDGRENT();
@@ -1268,7 +1281,7 @@ pw_checkname(u_char *name, int gecos)
        if (reject) {
                snprintf(showch, sizeof(showch), (*ch >= ' ' && *ch < 127)
                    ? "`%c'" : "0x%02x", *ch);
-               errx(EX_DATAERR, "invalid character %s at position %d in %s",
+               errx(EX_DATAERR, "invalid character %s at position %td in %s",
                    showch, (ch - name), showtype);
        }
        if (!gecos && (ch - name) > LOGNAMESIZE)