Avoid overflowing the file buffer

[pw-darwin.git] / libutil / gr_util.c

diff --git a/libutil/gr_util.c b/libutil/gr_util.c
index 8d0490be7057072829e3b5cc9e5af2fe70c960d2..be343954f403d5e1c6af17ed5b6decc94f309162 100644 (file)
--- a/libutil/gr_util.c
+++ b/libutil/gr_util.c
@@ -318,14 +318,10 @@ gr_copy(int ffd, int tfd, const struct group *gr, struct group *old_gr)
 int
 gr_mkdb(void)
 {
-       int ret;
-
-       ret = rename(tempname, group_file);
-
-       if (ret == 0)
-               chmod(group_file, 0644);
+       if (chmod(tempname, 0644) != 0)
+               return (-1);
 
-       return (ret);
+       return (rename(tempname, group_file));
 }
 
 /*